--------
On Dec. 9, 2017, 9:32 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193499
---
@ReviewBot retry
- John Sirois
On Dec. 9, 2017, 9:32 a.m
-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193430
---
On Dec. 9, 2017, 9:32 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193420
---
@ReviewBot retry
- John Sirois
On Dec. 9, 2017, 9:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193374
---
@ReviewBot retry
- John Sirois
On Dec. 9, 2017, 9:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193356
---
@ReviewBot retry
- John Sirois
On Dec. 9, 2017, 9:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193354
---
@ReviewBot retry
- John Sirois
On Dec. 9, 2017, 9:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193351
---
@ReviewBot retry
- John Sirois
On Dec. 9, 2017, 9:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193344
---
- John Sirois
On Dec. 9, 2017, 9:32 a.m., John Sirois wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193343
---
- John Sirois
On Dec. 9, 2017, 9:32 a.m., John Sirois wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193341
---
@ReviewBot retry
- John Sirois
On Dec. 9, 2017, 9:32 a.m
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193328
-------
On Dec. 9, 2017, 9:32 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail.
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193330
---
- John Sirois
On Dec. 8, 2017, 10:16 p.m., John Sirois wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193326
---
- John Sirois
On Dec. 8, 2017, 10:16 p.m., John Sirois wrote
/thermos/core/test_process.py
6cb9176e14eccbe7ed10501199a34e5e67d6fe44
Diff: https://reviews.apache.org/r/64290/diff/3/
Testing (updated)
---
```
$ ./build-support/jenkins/build.sh
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193323
---
@ReviewBot retry
- John Sirois
On Dec. 8, 2017, 8:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193321
---
@ReviewBot retry
- John Sirois
On Dec. 8, 2017, 8:47 p.m
on-2.7.12/pykerberos-1.1.14.tar.gz')
> > is not translateable by ChainedTranslator(WheelTranslator, EggTranslator,
> > SourceTranslator)
> >
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry
:17:40 00:00 [complete]
FAILURE
```
Filed this issue against pants:
https://github.com/pantsbuild/pants/issues/5153
Thanks,
John Sirois
/pants/pull/5168
This will be available with the Pants 1.4.0.dev23 release this Friday.
- John Sirois
On Dec. 4, 2017, 8:23 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
2d64521cf9/api.src.main.thrift.org.apache.aurora.gen._api/current:api.src.main.thrift.org.apache.aurora.gen._api)
00:17:40 00:00 [complete]
FAILURE
```
Filed this issue against pants:
https://github.com/pantsbuild/pants/issues/5153
Thanks,
John Sirois
]
> >FAILURE
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
@ReviewBot retry
- John
---
This is an automatically ge
> On Sept. 26, 2017, 5:53 p.m., Bill Farner wrote:
> > ```
> > /bin/sh: cmake: command not found
> > ```
> >
> > But now i need to install cmake, so i'm not sure this pays off.
>
> Bill Farner wrote:
> (this = the switch to cmake)
>
> Stephan Erb wrote:
> Bison on MacOs is 10 years
I have been looking into this a bit, but still haven't figured it out.
>
> It seems like pants changed when it tries to resolve dependencies. The
> `mesos.executor` only used to be pulled in when building the executor binary.
> In newer version, pants will check for the
n._api/current:api.src.main.thrift.org.apache.aurora.gen._api)
00:17:40 00:00 [complete]
FAILURE
```
Filed this issue against pants:
https://github.com/pantsbuild/pants/issues/5153
Thanks,
John Sirois
.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63750/#review191018
---
On Nov. 14, 2017, 4:51 p.m., se choi wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62835/#review187965
---
Ship it!
Ship It!
- John Sirois
On Oct. 13, 2017, 8:36 a.m
t seal it in by using a flag. Not to mention the new
default is probably what they really want.
- John Sirois
On Oct. 8, 2017, 12:20 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62652/#review187381
---
Ship it!
Ship It!
- John Sirois
On Oct. 8, 2017, 11:29 a.m
Monday 10/2, but I'm happy
with a quick skim!
- John Sirois
On Sept. 29, 2017, 8:07 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62716/#review186789
---
Ship it!
Ship It!
- John Sirois
On Sept. 30, 2017, 11:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62608/#review186371
---
Ship it!
Ship It!
- John Sirois
On Sept. 26, 2017, 7:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58612/#review172665
---
Ship it!
Ship It!
- John Sirois
On April 21, 2017, 5:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56577/#review166045
---
Ship it!
A tardy LGTM and thanks.
- John Sirois
On Feb. 14
reviews the last
change.
- John Sirois
On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162703
---
@ReviewBot retry
- John Sirois
On Jan. 23, 2017, 1:21 p.m
it_memory(0x0007a8e8, 298319872, 0) failed; error='Cannot
allocate memory' (errno=12)
```
I'll spin one more retry and then submit this if green.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162700
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162697
---
@ReviewBot retry
- John Sirois
On Jan. 23, 2017, 1:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162691
---
@ReviewBot retry
- John Sirois
On Jan. 23, 2017, 1:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162688
---
Ship it!
Ship It!
- John Sirois
On Jan. 23, 2017, 1:21 p.m
which looked scary in isolation - and this all
looks good to me.
- John Sirois
On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
.sourceforge.pmd.lang.java.rule.logging.InvalidSlf4jMessageFormatRule.expectedArguments(InvalidSlf4jMessageFormatRule.java:171)
at
net.sourceforge.pmd.lang.java.rule.logging.InvalidSlf4jMessageFormatRule.visit(InvalidSlf4jMessageFormatRule.java:88)
...
```
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55646/#review161975
---
@ReviewBot retry
- John Sirois
On Jan. 17, 2017, 2:30 p.m
js (Javascript):
```
Thanks,
John Sirois
find a compatible thrift.
Thanks,
John Sirois
ot;java (Java2)" and
observed the script forcing a clean recompile of 0.9.1 with a subsequent
failure to find a compatible thrift.
Thanks,
John Sirois
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55510/#review161622
---
Ship it!
Ship It!
- John Sirois
On Jan. 13, 2017, 4:25 p.m
/prepare_binary.sh
e3b46aa1f36ed3eecc9bb7794073d18dd950eb1c
Diff: https://reviews.apache.org/r/54567/diff/
Testing
---
Reproduced the current master CI failure before this change on my linux machine.
Fixed with this change.
Thanks,
John Sirois
> On Dec. 8, 2016, 8:29 p.m., John Sirois wrote:
> > build-support/thrift/prepare_binary.sh, line 29
> > <https://reviews.apache.org/r/54550/diff/3/?file=1580209#file1580209line29>
> >
> > aha - popd on linux echos the dirstack - presumably it does not do
> On Dec. 8, 2016, 8:29 p.m., John Sirois wrote:
> > build-support/thrift/prepare_binary.sh, line 29
> > <https://reviews.apache.org/r/54550/diff/3/?file=1580209#file1580209line29>
> >
> > aha - popd on linux echos the dirstack - presumably it does not do
tps://reviews.apache.org/r/54550/#comment229419>
aha - popd on linux echos the dirstack - presumably it does not do this on
osx... so needs a re-direct. Ditto pushd. And AuroraBot really does need to go
green.
- John Sirois
On Dec. 8, 2016, 7:30 p.m., Joshua Cohen
> On Dec. 8, 2016, 7:37 p.m., Aurora ReviewBot wrote:
> > Master (f5749ce) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > You are using pip version 8.1.2, however version 9.0.1 is available.
> > You should consider upgrading via the 'pip install --upgrade pip' command.
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54550/#review158626
---
Ship it!
Ship It!
- John Sirois
On Dec. 8, 2016, 7:15 p.m
Diff: https://reviews.apache.org/r/54520/diff/
Testing
---
Now with files listed and python tests run:
```
./pants filemap src/test/python/::
./build-support/jenkins/build.sh
```
Thanks,
John Sirois
> On Dec. 7, 2016, 9:41 p.m., John Sirois wrote:
> > NB: When AuroraBot goes green I'll submit this TBR and file a follow-up
> > issue in Aurora and a corresponding one in pants if needed, to restore the
> > BUILD file changes for default targets and defa
a follow-up issue
in Aurora and a corresponding one in pants if needed, to restore the BUILD file
changes for default targets and default globs.
- John Sirois
On Dec. 7, 2016, 9:39 p.m., John Sirois wrote:
>
> ---
> This is an auto
:
```
./pants filemap src/test/python/::
./build-support/jenkins/build.sh
```
Thanks,
John Sirois
and there have
been a significant number of insignificant automated changes to BUILD targets
(pants no longer requires a `name` for the default target, nor
`globs('*.')` for targets that own all the standard sources in
a directory.
- John Sirois
On Dec. 6, 2016, 5:30 p.m., John Sirois wrote
that includes the thrift
> > lib and this prepare binary? Then we can put the dep in one place.
>
> John Sirois wrote:
> I can, but this requires a custom pants plugin (housed as a loose python
> sourcefile in the repo) to expose, say, an `aurora_py_thrift_lib` target.
> Your com
./build-support/python/make-pycharm-virtualenv
```
Thanks,
John Sirois
that includes the thrift
> > lib and this prepare binary? Then we can put the dep in one place.
>
> John Sirois wrote:
> I can, but this requires a custom pants plugin (housed as a loose python
> sourcefile in the repo) to expose, say, an `aurora_py_thrift_lib` target.
> Your com
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53794/#review155999
---
Ship it!
Ship It!
- John Sirois
On Nov. 15, 2016, 2:22 p.m
apache/thermos/common/exceptional.py (line 42)
<https://reviews.apache.org/r/53519/#comment224953>
Did you contemplate and reject setting `sys.excepthook` to a custom handler
early in main as an alternative?
- John Sirois
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52665/#review154670
---
Ship it!
Ship It!
- John Sirois
On Oct. 29, 2016, 4:05 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53102/#review153730
---
Ship it!
Ship It!
- John Sirois
On Oct. 22, 2016, 11:46 a.m
> On Oct. 23, 2016, 12:12 p.m., John Sirois wrote:
> > Sorry for the delay submitting this, e2e didn't actually pass and I futzed
> > with this for a while.
> > At the end of the day I needed to re-introduce
> > `examples/vagrant/mesos_config/etc_mesos-slave/ex
-
examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout
PRE-CREATION
Diff: https://reviews.apache.org/r/53131/diff/
Testing
---
This is what allowed me to get a green e2e in
https://reviews.apache.org/r/52915/.
Thanks,
John Sirois
to add that.
- John Sirois
On Oct. 15, 2016, 4:42 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52921/#review152893
---
Ship it!
Ship It!
- John Sirois
On Oct. 16, 2016, 5:04 p.m
--
>
> (Updated Oct. 16, 2016, 5:04 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> I saw THRIFT-3868 and thought we could apply the same micro-optimization
> a
://github.com/pantsbuild/pants/issues/3956
- John Sirois
On Oct. 15, 2016, 4:42 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52790/#review152349
---
Ship it!
Ship It!
- John Sirois
On Oct. 12, 2016, 11:28 a.m
> On Oct. 12, 2016, 4:41 a.m., John Sirois wrote:
> > Your testing done says this is enough on the aurora-packaging side, but on
> > the [aurora
> > side](https://github.com/apache/aurora/blob/master/build.gradle#L24) the
> > installed plugin probably also ne
/aurora/blob/master/build.gradle#L586) is
configured in the new regime (maybe the same).
- John Sirois
On Oct. 12, 2016, 4:13 a.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52739/#review152141
---
Ship it!
Ship It!
- John Sirois
On Oct. 11, 2016, 9:11 a.m
> On Oct. 10, 2016, 5:31 p.m., John Sirois wrote:
> > I'll submit this tomorrow afternoon if I hear nothing from Zameer by then.
>
> Zameer Manji wrote:
> Sorry for the late shipit, I reviewed this previously and forgot to press
> the button.
No worries - th
by then.
- John Sirois
On Oct. 7, 2016, 10:34 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Oct. 9, 2016, 6:49 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java,
> > line 142
> > <https://reviews.apache.org/r/52665/diff/1/?file=1528674#file1528674line142>
> >
> > This was in
Zameer likely have better
ideas.
- John Sirois
On Oct. 9, 2016, 2:43 a.m., Jing Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
. The error bars for
the off-heap are generally larger than the values themselves! I imagine jmh is
simply not the right tool for testing off-heap.
I too though am interested in real-world feedback.
- John Sirois
On Oct. 9, 2016, 4:35 p.m., Stephan Erb wrote
test src/{main,test}/python:: -- -v
./build-support/release/make-python-sdists
vagrant ssh --command 'aurorabuild admin_client client executor observer'
```
Thanks,
John Sirois
> On Oct. 6, 2016, 1:10 p.m., John Sirois wrote:
> > I added myself as a reviewer since I'm running Vagrant 1.8.6. I'll have
> > time to confirm your issue and fix later today and have some feedback for
> > you by tomorrow latest.
I can confirm both the failure to auto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/#review151714
---
Ship it!
Ship It!
- John Sirois
On Oct. 6, 2016, 12:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52610/#review151707
---
Ship it!
Ship It!
- John Sirois
On Oct. 6, 2016, 12:14 p.m
. I'll have time
to confirm your issue and fix later today and have some feedback for you by
tomorrow latest.
- John Sirois
On Oct. 6, 2016, 12:14 p.m., Andrew Jorgensen wrote:
>
> ---
> This is an automatically generated e-mail.
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52479/#review151205
---
On Oct. 4, 2016, 10:55 p.m., Santhosh Kumar Shanmugham wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
ache.org/r/52594/diff/
Testing
---
Locally green:
```
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
0dc817633a0f37
Diff: https://reviews.apache.org/r/52594/diff/
Testing
---
Locally green:
```
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/reports/tests/index.html
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or
> > --debug option to get more log output.
> >
> > BUILD FAILED
> >
the 'Twitter' reference here?
Removed.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151626
-------
On Oct
.apache.org/r/52591/#review151625
---
On Oct. 6, 2016, 9:30 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> htt
> >
> > BUILD FAILED
> >
> > Total time: 9 mins 5.824 secs
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
Aha - this failure only happens under gradle 3.x... dig
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151624
---
@ReviewBot retry
- John Sirois
On Oct. 5, 2016, 9:29 p.m
ache.org/r/52594/diff/
Testing
---
Locally green:
```
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
> On Oct. 5, 2016, 5:32 p.m., John Sirois wrote:
> > presumably a near-zero jitter would help as well:
> > https://github.com/apache/aurora/blob/783baaefb9a814ca01fad78181fe3df3de5b34af/src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java#L40
Umm, nmm, pure s
:
https://github.com/apache/aurora/blob/783baaefb9a814ca01fad78181fe3df3de5b34af/src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java#L40
- John Sirois
On Oct. 5, 2016, 5:23 p.m., Stephan Erb wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52579/#review151586
---
Ship it!
Ship It!
- John Sirois
On Oct. 5, 2016, 4:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52577/#review151576
---
Ship it!
Ship It!
- John Sirois
On Oct. 5, 2016, 4:14 p.m
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52428/#review151061
---
On Sept. 30, 2016, 12:17 p.m., John Sir
1 - 100 of 620 matches
Mail list logo
