Re: Review Request 67696: Enable SLA-aware updates

2018-07-10 Thread Reza Motamedi
tps://reviews.apache.org/r/67696/#comment288743> `Default: False`? docs/reference/configuration.md Lines 386 (patched) <https://reviews.apache.org/r/67696/#comment288744> s/the update/the updater - Reza Motamedi On July 10, 2018, 2:22 a.m., Jor

Re: Review Request 67706: Fix style of TaskConfigSummary.

2018-06-22 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67706/#review205254 --- Ship it! Ship It! - Reza Motamedi On June 22, 2018, 8:17

Re: Review Request 66980: aurora update info command should print out update metadata

2018-05-07 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66980/#review202558 --- Ship it! Ship It! - Reza Motamedi On May 7, 2018, 5:07 a.m

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-03 Thread Reza Motamedi
8> s/of the host/of the hosts - Reza Motamedi On May 1, 2018, 9:19 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 66623: Fix the json endpoints in thermos

2018-04-16 Thread Reza Motamedi
[{"order": ["hello"]}]}, "name": "hello", "task_id": "www-data-prod-hello-0-00e58d09-a67f-4a46-94a0-15bcad26a098", "processes": {"failed": [], "running": ["hello"], "killed": [], "success": [], "waiting": []}, "state_timestamp": 1523728477, "state": "ACTIVE", "resource_consumption": {"status": "sleeping", "disk": 10141696, "ram": 3731456, "system": 0.35, "vms": 22994944, "threads": 2, "user": 0.24, "rss": 3731456, "cpu": 0.0, "nice": 0}, "user": "www-data", "launch_timestamp": 1523728477, "ports": {}}}% ? curl http://192.168.33.7:1338/j/process/www-data-prod-hello-0-00e58d09-a67f-4a46-94a0-15bcad26a098/hello/0 {"state": "RUNNING", "process_name": "hello", "used": {"status": "sleeping", "ram": 3735552, "system": 0.34, "vms": 22990848, "threads": 2, "user": 0.24, "rss": 3735552, "cpu": 0.0, "nice": 0}, "start_time": 1523728477.867429, "process_run": 0}% ? curl http://192.168.33.7:1338/j/processes\?task_id\=www-data-prod-hello-0-00e58d09-a67f-4a46-94a0-15bcad26a098 {"www-data-prod-hello-0-00e58d09-a67f-4a46-94a0-15bcad26a098": {"hello": {"state": "RUNNING", "process_name": "hello", "used": {"status": "sleeping", "ram": 3735552, "system": 0.35, "vms": 22994944, "threads": 2, "user": 0.25, "rss": 3735552, "cpu": 0.000561512750167, "nice": 0}, "start_time": 1523728477.867429, "process_run": 0}}}% ``` Thanks, Reza Motamedi

Review Request 66623: Fix the json endpoints in thermos

2018-04-16 Thread Reza Motamedi
7f-4a46-94a0-15bcad26a098", "processes": {"failed": [], "running": ["hello"], "killed": [], "success": [], "waiting": []}, "state_timestamp": 1523728477, "state": "ACTIVE", "resource_consumption": {"status": "sleeping", "disk": 10141696, "ram": 3731456, "system": 0.35, "vms": 22994944, "threads": 2, "user": 0.24, "rss": 3731456, "cpu": 0.0, "nice": 0}, "user": "www-data", "launch_timestamp": 1523728477, "ports": {}}}% ? curl http://192.168.33.7:1338/j/process/www-data-prod-hello-0-00e58d09-a67f-4a46-94a0-15bcad26a098/hello/0 {"state": "RUNNING", "process_name": "hello", "used": {"status": "sleeping", "ram": 3735552, "system": 0.34, "vms": 22990848, "threads": 2, "user": 0.24, "rss": 3735552, "cpu": 0.0, "nice": 0}, "start_time": 1523728477.867429, "process_run": 0}% ? curl http://192.168.33.7:1338/j/processes\?task_id\=www-data-prod-hello-0-00e58d09-a67f-4a46-94a0-15bcad26a098 {"www-data-prod-hello-0-00e58d09-a67f-4a46-94a0-15bcad26a098": {"hello": {"state": "RUNNING", "process_name": "hello", "used": {"status": "sleeping", "ram": 3735552, "system": 0.35, "vms": 22994944, "threads": 2, "user": 0.25, "rss": 3735552, "cpu": 0.000561512750167, "nice": 0}, "start_time": 1523728477.867429, "process_run": 0}}}% ``` Thanks, Reza Motamedi

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

2018-04-11 Thread Reza Motamedi
? - Reza Motamedi On April 11, 2018, 10:13 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 66103: Introduce mesos disk collector

2018-03-23 Thread Reza Motamedi
2018 observer.observer_cpu 1.3 Thu Mar 22 04:36:50 UTC 2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:00 UTC 2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:10 UTC 2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:20 UTC 2018 observer.observer_cpu 1.8 ``` Thanks, Reza Motamedi

Re: Review Request 66103: Introduce mesos disk collector

2018-03-22 Thread Reza Motamedi
r_cpu 1.3 Thu Mar 22 04:36:50 UTC 2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:00 UTC 2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:10 UTC 2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:20 UTC 2018 observer.observer_cpu 1.8 ``` Thanks, Reza Motamedi

Re: Review Request 66103: Introduce mesos disk collector

2018-03-22 Thread Reza Motamedi
2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:20 UTC 2018 observer.observer_cpu 1.8 ``` Thanks, Reza Motamedi

Re: Review Request 66103: Introduce mesos disk collector

2018-03-22 Thread Reza Motamedi
? I will include them here as well. - Reza --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199812 ------- On M

Re: Review Request 66103: Introduce mesos disk collector

2018-03-22 Thread Reza Motamedi
(patched) <https://reviews.apache.org/r/66103/#comment280297> I have built observer with this patch a couple of times on Jenkins boxes as well. Are you referring to `requests-kerberos` and `requests-mock`? I will include them here as well. - Reza Motamedi On March 22, 2018, 9:

Re: Review Request 66103: Introduce mesos disk collector

2018-03-22 Thread Reza Motamedi
Thu Mar 22 04:36:50 UTC 2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:00 UTC 2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:10 UTC 2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:20 UTC 2018 observer.observer_cpu 1.8 ``` Thanks, Reza Motamedi

Re: Review Request 66103: Introduce mesos disk collector

2018-03-22 Thread Reza Motamedi
2018 observer.observer_cpu 1.3 Thu Mar 22 04:36:50 UTC 2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:00 UTC 2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:10 UTC 2018 observer.observer_cpu 1.2 Thu Mar 22 04:37:20 UTC 2018 observer.observer_cpu 1.8 ``` Thanks, Reza Motamedi

Re: Review Request 66103: Introduce mesos disk collector

2018-03-21 Thread Reza Motamedi
u 1.8 ``` Thanks, Reza Motamedi

Re: Review Request 66103: Introduce mesos disk collector

2018-03-21 Thread Reza Motamedi
with nested folders and noticed reduction in CPU utilization of the Observer process, by at least 60%. (1.5 CPU cores to 0.4 CPU cores) Thanks, Reza Motamedi

Re: Review Request 66103: Introduce mesos disk collector

2018-03-21 Thread Reza Motamedi
ector` arg to make this incompatibility clear. - Reza --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199680 ---

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-21 Thread Reza Motamedi
> On March 21, 2018, 5:36 p.m., Reza Motamedi wrote: > > Ship It! Can you explain a bit more about the exeperiement settings? - Reza --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-21 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199678 --- Ship it! Ship It! - Reza Motamedi On March 20, 2018, 10:41

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

2018-03-20 Thread Reza Motamedi
Lines 324 (patched) <https://reviews.apache.org/r/66154/#comment279913> Nit. check the `data` as well. The default config has data. - Reza Motamedi On March 19, 2018, 11:33 p.m., Renan DelValle wrote: > > ---

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-20 Thread Reza Motamedi
atched) <https://reviews.apache.org/r/66139/#comment279866> Curious if this generator pattern is really useful. Don't we just consume everything it generates? - Reza Motamedi On March 19, 2018, 11:22 p.m., Stephan Erb wrote: > > ---

Re: Review Request 66103: Introduce mesos disk collector

2018-03-20 Thread Reza Motamedi
asure imporoved performance I created jobs with nested folders and noticed reduction in CPU utilization of the Observer process, by at least 60%. (1.5 CPU cores to 0.4 CPU cores) Thanks, Reza Motamedi

Re: Review Request 66103: Introduce mesos disk collector

2018-03-19 Thread Reza Motamedi
der` to address this. - Reza --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199448 --- On March 20, 2018, 5:37 a.m., Reza

Re: Review Request 66103: Introduce mesos disk collector

2018-03-19 Thread Reza Motamedi
ething worong with the setup. - Reza --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199486 --- On March 20, 2018, 5:37 a.m., Reza Motamedi wrote: > > ---

Re: Review Request 66103: Introduce mesos disk collector

2018-03-19 Thread Reza Motamedi
erver process, by at least 60%. (1.5 CPU cores to 0.4 CPU cores) Thanks, Reza Motamedi

Re: Review Request 66136: Switch Thermos to lazy log formatting

2018-03-19 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66136/#review199491 --- Ship it! Ship It! - Reza Motamedi On March 19, 2018, 2:55

Review Request 66103: Introduce mesos disk collector

2018-03-19 Thread Reza Motamedi
built and deployed in our test enviroment. In order to measure imporoved performance I created jobs with nested folders and noticed reduction in CPU utilization of the Observer process, by at least 60%. (1.5 CPU cores to 0.4 CPU cores) Thanks, Reza Motamedi

Re: Review Request 65735: Add GPUs to the resources.

2018-02-21 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65735/#review197963 --- Ship it! Ship It! - Reza Motamedi On Feb. 21, 2018, 4:31

Re: Review Request 65494: Add task page to Scheduler UI

2018-02-05 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65494/#review196818 --- Ship it! Ship It! - Reza Motamedi On Feb. 3, 2018, 12:27

Re: Review Request 65501: Show cron job preview when no active tasks.

2018-02-05 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65501/#review196817 --- Ship it! Ship It! - Reza Motamedi On Feb. 3, 2018, 6:39 a.m

Re: Review Request 65477: Fix UI table layout issue on Config Summaries

2018-02-02 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65477/#review196715 --- Ship it! Ship It! - Reza Motamedi On Feb. 2, 2018, 7:52 a.m

Re: Review Request 64625: Add a storage recovery tool

2017-12-15 Thread Reza Motamedi
to add something to doc re how to use this. Although the test clearly shows that. - Reza Motamedi On Dec. 14, 2017, 10:05 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 63746: Add a workaround for test_du_diskcollector failing on macOS

2017-11-13 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63746/#review190854 --- Ship it! Ship It! - Reza Motamedi On Nov. 12, 2017, 8:14

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-11-09 Thread Reza Motamedi
s fails for me consistently using: > > ./build-support/jenkins/build.sh > > Is anyone else able to reproduce my failure? > > > - David > > On October 31st, 2017, 8:15 p.m. UTC, Reza Motamedi wrote: > Review request for Aurora, David McLaughlin, Joshua Cohen, and Kai Hua

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-11-07 Thread Reza Motamedi
- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63436/#review190402 > --- > > > On Oct. 31, 2017, 8:15 p.m., Reza Motamedi wrote: &g

Re: Review Request 63648: Don't show host data when task is Throttled.

2017-11-07 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63648/#review190380 --- Ship it! Ship It! - Reza Motamedi On Nov. 7, 2017, 10:18

Re: Review Request 63337: Polling updates page if in progress in UI

2017-10-31 Thread Reza Motamedi
/aurora on git:ui-update-polling ? [14:10:00] ? ./gradlew ui:lint BUILD SUCCESSFUL in 5s 4 actionable tasks: 4 up-to-date # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:ui-update-polling ? [14:10:13] ? ./gradlew ui:test BUILD SUCCESSFUL in 0s 2 actionable tasks: 2 up-to-date Thanks, Reza

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-10-31 Thread Reza Motamedi
t_11.44.56_AM.png Thanks, Reza Motamedi

Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-10-30 Thread Reza Motamedi
31/64d47905-b058-4ef5-9d19-fa3311a47f9d__Screen_Shot_2017-10-30_at_6.36.18_PM.png Thanks, Reza Motamedi

Re: Review Request 63406: Condense whitespace of navigation and breadcrumb, reduce impact of quota widget

2017-10-30 Thread Reza Motamedi
-page.scss Lines 26 (patched) <https://reviews.apache.org/r/63406/#comment266789> What is aligned center? I did not notice this in the screenshot. - Reza Motamedi On Oct. 30, 2017, 3:32 p.m., David McLaughlin wrote: > > ---

Re: Review Request 63375: Add resource units to config summary

2017-10-27 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63375/#review189483 --- Ship it! Ship It! - Reza Motamedi On Oct. 27, 2017, 7:58

Re: Review Request 63374: Revert to old Job Page tab names and add counts

2017-10-27 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63374/#review189472 --- Ship it! Ship It! - Reza Motamedi On Oct. 27, 2017, 7:48

Re: Review Request 63373: Reduce white-space on role and env pages

2017-10-27 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63373/#review189471 --- Ship it! Ship It! - Reza Motamedi On Oct. 27, 2017, 7:35

Re: Review Request 63337: Polling updates page if in progress in UI

2017-10-27 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63337/#review189465 --- @ReviewBot retry - Reza Motamedi On Oct. 27, 2017, 5:01 p.m

Re: Review Request 63364: Revert role searching in UI to old behavior

2017-10-27 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63364/#review189442 --- Ship it! Ship It! - Reza Motamedi On Oct. 27, 2017, 4:42

Re: Review Request 63337: Polling updates page if in progress in UI

2017-10-27 Thread Reza Motamedi
ateMachine-test.js Test Suites: 30 passed, 30 total Tests: 134 passed, 134 total Snapshots: 0 total Time:6.118s Ran all test suites matching /src\/|plugin\//i. BUILD SUCCESSFUL in 9s 2 actionable tasks: 1 executed, 1 up-to-date ``` Thanks, Reza Motamedi

Re: Review Request 63337: Polling updates page if in progress in UI

2017-10-26 Thread Reza Motamedi
an all test suites matching /src\/|plugin\//i. BUILD SUCCESSFUL in 9s 2 actionable tasks: 1 executed, 1 up-to-date ``` Thanks, Reza Motamedi

Review Request 63337: Polling updates page if in progress in UI

2017-10-26 Thread Reza Motamedi
s Test Suites: 30 passed, 30 total Tests: 134 passed, 134 total Snapshots: 0 total Time:6.118s Ran all test suites matching /src\/|plugin\//i. BUILD SUCCESSFUL in 9s 2 actionable tasks: 1 executed, 1 up-to-date ``` Thanks, Reza Motamedi

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-25 Thread Reza Motamedi
atically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review189250 --- On Oct. 25, 2017, 10:26 p.m., Reza Motamedi wrote: > > --- > This is an automaticall

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-25 Thread Reza Motamedi
t-test.js PASS src/main/js/test-utils/__tests__/Builder-test.js Test Suites: 30 passed, 30 total Tests: 134 passed, 134 total Snapshots: 0 total Time:6.883s Ran all test suites matching /src\/|plugin\//i. BUILD SUCCESSFUL in 9s 2 actionable tasks: 1 executed, 1 up-to-date `

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-25 Thread Reza Motamedi
/__tests__/Builder-test.js Test Suites: 30 passed, 30 total Tests: 134 passed, 134 total Snapshots: 0 total Time:6.883s Ran all test suites matching /src\/|plugin\//i. BUILD SUCCESSFUL in 9s 2 actionable tasks: 1 executed, 1 up-to-date ``` Thanks, Reza Motamedi

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-25 Thread Reza Motamedi
reply, visit: https://reviews.apache.org/r/63221/#review189110 --- On Oct. 24, 2017, 12:09 a.m., Reza Motamedi wrote: > > --- > This is an automatically

Re: Review Request 63281: Clean up TaskList component layout.

2017-10-25 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63281/#review189228 --- Ship it! Ship It! - Reza Motamedi On Oct. 24, 2017, 11:32

Re: Review Request 63262: Add a package.json file in the plugin directory to allow custom dependencies

2017-10-25 Thread Reza Motamedi
> On Oct. 25, 2017, 6:08 p.m., Reza Motamedi wrote: > > Ship It! Works like a charm! Thanks. - Reza --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63262/#rev

Re: Review Request 63262: Add a package.json file in the plugin directory to allow custom dependencies

2017-10-25 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63262/#review189222 --- Ship it! Ship It! - Reza Motamedi On Oct. 24, 2017, 9:46

Re: Review Request 63261: Do not reserve agents for updates when constraints change.

2017-10-24 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63261/#review189092 --- Ship it! Ship It! - Reza Motamedi On Oct. 24, 2017, 9:19

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Reza Motamedi
-test.js 2395e2e1018d19604a76eddee15f58565f988e3a Diff: https://reviews.apache.org/r/63221/diff/3/ Changes: https://reviews.apache.org/r/63221/diff/2-3/ Testing --- Checked in my vagrant and now it works. ``` ? ./gradlew ui:lint ? ./gradlew ui:test ``` Thanks, Reza Motamedi

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Reza Motamedi
2395e2e1018d19604a76eddee15f58565f988e3a Diff: https://reviews.apache.org/r/63221/diff/2/ Changes: https://reviews.apache.org/r/63221/diff/1-2/ Testing --- Checked in my vagrant and now it works. ``` ? ./gradlew ui:lint ? ./gradlew ui:test ``` Thanks, Reza Motamedi

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Reza Motamedi
here and in constructor? Done! - Reza --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review188979 --- On Oct. 23, 2017, 6:01 p.m., Reza Motamedi wrote: > > -

Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Reza Motamedi
ui:lint ? ./gradlew ui:test ``` Thanks, Reza Motamedi

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-23 Thread Reza Motamedi
/OffersModule.java Lines 109 (patched) <https://reviews.apache.org/r/63199/#comment265900> Would it be easy to find the "correct" value here? The correct value seems to be correlated to a lot of things. How sensitive is the stablity of clusters to this value? - Reza Motamedi On Oct. 21

Re: Review Request 63197: Fix back button issue on Jobs page

2017-10-23 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63197/#review188949 --- Ship it! Ship It! - Reza Motamedi On Oct. 21, 2017, 1:34

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-19 Thread Reza Motamedi
-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png Neighbor list spanning over the entire page. https://reviews.apache.org/media/uploaded/files/2017/10/19/38b2d466-991a-4b71-aed7-8b0bada9e678__Screen_Shot_2017-10-19_at_3.48.08_PM.png Thanks, Reza Motamedi

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-19 Thread Reza Motamedi
-8668-b6ef36f52009__Screen_Shot_2017-10-19_at_3.48.08_PM.png Neighbor list spanning over the entire page. https://reviews.apache.org/media/uploaded/files/2017/10/19/38b2d466-991a-4b71-aed7-8b0bada9e678__Screen_Shot_2017-10-19_at_3.48.08_PM.png Thanks, Reza Motamedi

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-19 Thread Reza Motamedi
ch! thanks :) - Reza --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188371 --- On Oct. 19, 2017, 10:37 p.m., Rez

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-19 Thread Reza Motamedi
ail. To reply, visit: https://reviews.apache.org/r/63062/#review188376 --- On Oct. 19, 2017, 10:37 p.m., Reza Motamedi wrote: > > --- > This is an automatically genera

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-19 Thread Reza Motamedi
/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png Thanks, Reza Motamedi

Re: Review Request 63079: Center pagination links when not a table.

2017-10-17 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63079/#review188338 --- Ship it! Ship It! - Reza Motamedi On Oct. 17, 2017, 5:14

Re: Review Request 63081: Format constraints on Task Config Summary

2017-10-17 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63081/#review188337 --- Ship it! Ship It! - Reza Motamedi On Oct. 17, 2017, 5:21

Re: Review Request 63078: Hide pagination links on Role and Job lists when only one page

2017-10-17 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63078/#review188336 --- Ship it! Ship It! - Reza Motamedi On Oct. 17, 2017, 5:06

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-16 Thread Reza Motamedi
y don't know. I will check around some more. - Reza ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188254 --

Re: Review Request 63062: Expose list of neighbors in the instance page

2017-10-16 Thread Reza Motamedi
Screen Shot 2017-10-16 at 6.27.44 PM.png https://reviews.apache.org/media/uploaded/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png Thanks, Reza Motamedi

Re: Review Request 63062: Adding test for neighbor panel in UI

2017-10-16 Thread Reza Motamedi
/files/2017/10/17/7fa71abf-f83e-412f-b554-dc880ccdb25c__Screen_Shot_2017-10-16_at_6.27.44_PM.png Thanks, Reza Motamedi

Review Request 63062: Adding test for neighbor panel in UI

2017-10-16 Thread Reza Motamedi
Thanks, Reza Motamedi

Re: Review Request 62958: Add URL handling for tab switching on Job page

2017-10-16 Thread Reza Motamedi
ional flexibility of url parsing is not needed. - Reza Motamedi On Oct. 13, 2017, 12:10 a.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 63038: Protect against null value in RoleQuota

2017-10-16 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63038/#review188166 --- Ship it! Ship It! - Reza Motamedi On Oct. 16, 2017, 5:52

Re: Review Request 62720: Implement Instance pages in React

2017-10-04 Thread Reza Motamedi
g/r/62720/#comment264039> For my education, does this set `ACTIVE_STATES`, `Thrift`, ... up for you to later assign values to them? Like what comes in "test-setup.js"? - Reza Motamedi On Oct. 4, 2017, 5:43 a.m., David

Re: Review Request 62601: Remove the rewriteConfigs thrift method

2017-09-29 Thread Reza Motamedi
/apache/aurora/blob/243d6fa14fb46eec79de6b1f7f55a4c1937ee8f5/src/test/python/apache/aurora/api_util.py#L70-L71 - Reza Motamedi On Sept. 27, 2017, 12:20 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 62623: Use a simpler command line argument system

2017-09-29 Thread Reza Motamedi
604 (patched) <https://reviews.apache.org/r/62623/#comment263451> positive - Reza Motamedi On Sept. 28, 2017, 4:22 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 62626: Added additional stop() to prevent errors in run() to stop shutdown in SchedulerMain

2017-09-28 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62626/#review186618 --- Ship it! Ship It! - Reza Motamedi On Sept. 27, 2017, 8:25

Re: Review Request 62451: Implement Role and Environment pages in Preact.

2017-09-27 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62451/#review186513 --- Ship it! I just picked up a little bit of js. LGTM. - Reza

Re: Review Request 62626: Added additional stop() to prevent errors in run() to stop shutdown in SchedulerMain

2017-09-27 Thread Reza Motamedi
/SchedulerLifecycleTest.java Line 109 (original), 109 (patched) <https://reviews.apache.org/r/62626/#comment263029> Is just testing shutdown of the leader? Should we have separate tests the followers then? - Reza Motamedi On Sept. 27, 2017, 8:25 p.m., Jordan Ly

Re: Review Request 62604: Use a more efficient query for instance ID collision detection

2017-09-26 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62604/#review186361 --- Ship it! Ship It! - Reza Motamedi On Sept. 27, 2017, 12:25

Re: Review Request 62451: Implement Role and Environment pages in Preact.

2017-09-25 Thread Reza Motamedi
tps://reviews.apache.org/r/62451/#comment262648> That would be nice, but a pie with only two colors sounds overkill. I like it the way it is. - Reza Motamedi On Sept. 21, 2017, 11:17 p.m., David McLaughlin wrote: > > ---

Re: Review Request 61016: lock psutil's oneshot

2017-07-22 Thread Reza Motamedi
nice=0, status='sleeping', threads=1), 36350: ProcessSample(rate=0.0, user=0.0, system=0.03, rss=41906176, vms=1601019904, nice=0, status='sleeping', threads=20)}] ``` These inconsistencies disappear after removing oneshot. Thanks, Reza Motamedi

Re: Review Request 61016: lock psutil's oneshot

2017-07-21 Thread Reza Motamedi
nice=0, status='sleeping', threads=1), 36350: ProcessSample(rate=0.0, user=0.0, system=0.03, rss=41906176, vms=1601019904, nice=0, status='sleeping', threads=20)}] ``` These inconsistencies disappear after removing oneshot. Thanks, Reza Motamedi

Review Request 61016: lock psutil's oneshot

2017-07-21 Thread Reza Motamedi
7;, threads=1), 36350: ProcessSample(rate=0.0, user=0.0, system=0.03, rss=41906176, vms=1601019904, nice=0, status='sleeping', threads=20)}] ``` These inconsistencies disappear after removing oneshot. Thanks, Reza Motamedi

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-18 Thread Reza Motamedi
sStatus/process_status/ Done. - Reza --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review180798 --- On July 1

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-18 Thread Reza Motamedi
1.07.41 PM.png https://reviews.apache.org/media/uploaded/files/2017/06/22/5962c018-27d3-4463-a277-f6ad48b7f2d7__with_the_patch_--_Screen_Shot_2017-06-22_at_1.07.41_PM.png Thanks, Reza Motamedi

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-17 Thread Reza Motamedi
-22_at_1.11.12_PM.png with the patch -- Screen Shot 2017-06-22 at 1.07.41 PM.png https://reviews.apache.org/media/uploaded/files/2017/06/22/5962c018-27d3-4463-a277-f6ad48b7f2d7__with_the_patch_--_Screen_Shot_2017-06-22_at_1.07.41_PM.png Thanks, Reza Motamedi

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-17 Thread Reza Motamedi
ps://reviews.apache.org/r/60376/diff/3/?file=1766461#file1766461line115> > > > > Assert disk_usage. done. - Reza --- This is an automatically generated e-mail. To reply, visit: https://reviews.apa

Re: Review Request 60714: aurora job restart request should be idempotent and retryable

2017-07-13 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60714/#review180444 --- Ship it! LGTM. - Reza Motamedi On July 7, 2017, 11:52 p.m

Re: Review Request 60748: Prototype using cgroups for monitoring Thermos Process resource consumption (CPU and memory)

2017-07-11 Thread Reza Motamedi
roach, and then I will add additional tests. Thanks, Reza Motamedi

Re: Review Request 60748: Prototype using cgroups for monitoring Thermos Process resource consumption (CPU and memory)

2017-07-10 Thread Reza Motamedi
cpu and memory isolation. Current tests pass. I first want to see how the community feels generally about this approach, and then I will add additional tests. Thanks, Reza Motamedi

Re: Review Request 60748: Prototype using cgroups for monitoring Thermos Process resource consumption (CPU and memory)

2017-07-10 Thread Reza Motamedi
urrent tests pass. I first want to see how the community feels generally about this approach, and then I will add additional tests. Thanks, Reza Motamedi

Re: Review Request 60748: Prototype using cgroups for monitoring Thermos Process resource consumption (CPU and memory)

2017-07-10 Thread Reza Motamedi
nity feels generally about this approach, and then I will add additional tests. Thanks, Reza Motamedi

Re: Review Request 60748: Prototype using cgroups for monitoring Thermos Process resource consumption (CPU and memory)

2017-07-10 Thread Reza Motamedi
e. Note that I had to enable Mesos's cpu and memory isolation. Currently, I enabled debugging in the Observer as well, in case someone wants to check the patch in practice. Current tests pass. I first want to see how the community feels generally about this approach, and then I will add additio

Review Request 60748: Protyping the start of thermos processes in a cgroup containers

2017-07-10 Thread Reza Motamedi
tice. Current tests pass. I first want to see how the community feels generally about this approach, and then I will add additional tests. Thanks, Reza Motamedi

Re: Review Request 60376: Observer task page to load consumption info from history

2017-06-29 Thread Reza Motamedi
-- Screen Shot 2017-06-22 at 1.07.41 PM.png https://reviews.apache.org/media/uploaded/files/2017/06/22/5962c018-27d3-4463-a277-f6ad48b7f2d7__with_the_patch_--_Screen_Shot_2017-06-22_at_1.07.41_PM.png Thanks, Reza Motamedi

Re: Review Request 60376: Observer task page to load consumption info from history

2017-06-28 Thread Reza Motamedi
e/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.3.0.dev3/bin/python: > > No such file or directory > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" @ReviewBot retry - Reza

  1   2   >