1985f89ffc9142877bc168c93a7efd19b6bcd4aa
Diff: https://reviews.apache.org/r/55684/diff/
Testing (updated)
---
I have verifed that the new e2e fail with the code on master but succeed with
this patch.
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Stephan Erb
://reviews.apache.org/r/55684/diff/
Testing
---
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Stephan Erb
visit:
https://reviews.apache.org/r/55071/#review161986
-------
On Dec. 28, 2016, 12:28 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically genera
"port":8081}},"status":"ALIVE"}
When running with `-serverset_endpoint_name=https`:
[zk: 127.0.0.1:2181(CONNECTED) 0] get /aurora/scheduler/member_19
{"serviceEndpoint":{"host":"aurora.local","port":8081},"additionalEndpoints":{"https":{"host":"aurora.local","port":8081}},"status":"ALIVE"}
Thanks,
Stephan Erb
debug.
Diffs
-
src/main/python/apache/thermos/monitoring/process_collector_psutil.py
4a1b159637ae18113aa7f4d10a0864be0fd1e920
Diff: https://reviews.apache.org/r/55578/diff/
Testing
---
./pants test.pytest src/{main,test}/python:: -- -v
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55536/#review161667
---
Ship it!
Ship It!
- Stephan Erb
On Jan. 14, 2017, 7:19 p.m
---
Before:
713c53c6ace65683bbb6f6e72881442cc4f7a243
/home/xxx/zzz/yyy/aurora-packaging/artifacts/aurora-debian-jessie/dist/aurora-tools_0.16.0-snapshot_amd64.deb
After:
713c53c6ace65683bbb6f6e72881442cc4f7a243 aurora-tools_0.16.0-snapshot_amd64.deb
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55357/#review161598
---
@ReviewBot retry
- Stephan Erb
On Jan. 11, 2017, 5:48 p.m
test/deb/ubuntu-trusty/provision.sh b9807ef63f73e985adaae6583023c4f5e762c6aa
test/rpm/centos-7/provision.sh 7bef270de5a3a046b6b068286db39997db64af2f
Diff: https://reviews.apache.org/r/55507/diff/
Testing
---
Thanks,
Stephan Erb
test/deb/ubuntu-trusty/provision.sh b9807ef63f73e985adaae6583023c4f5e762c6aa
test/rpm/centos-7/provision.sh 7bef270de5a3a046b6b068286db39997db64af2f
Diff: https://reviews.apache.org/r/55507/diff/
Testing
---
Thanks,
Stephan Erb
r will do the rest if
needed.
- Stephan Erb
On Jan. 11, 2017, 10:41 p.m., Joshua Cohen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On Jan. 5, 2017, 12:54 a.m., Karthik Anantha Padmanabhan wrote:
> > I was going to wrap this up - but how do people feel about making the all
> > endpoints "idempotent" by the following method ? Inlcude an
> > "idempotency-token" along as part of the HTTP header. This token is locally
> > ca
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55243/#review161132
---
Ship it!
Ship It!
- Stephan Erb
On Jan. 6, 2017, 2:17 a.m
/preemptor/PreemptorModule.java (lines
64 - 65)
<https://reviews.apache.org/r/55357/#comment232367>
We only have a reservation once we have found a match. How about calling
this 'searched' rather than 'processed'?
- Stephan Erb
On Jan. 9, 2017, 10:40 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55347/#review161126
---
Ship it!
Ship It!
- Stephan Erb
On Jan. 10, 2017, 7 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55357/#review161119
---
@ReviewBot retry
- Stephan Erb
On Jan. 9, 2017, 10:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55347/#review161116
---
@ReviewBot retry
- Stephan Erb
On Jan. 10, 2017, 7 p.m
With that amount of mocking the test is both hard to understand and brittle
to changes of the production code.
Have you considered extending this
https://github.com/apache/aurora/blob/master/examples/vagrant/upstart/aurora-scheduler.conf#L43
list instead?
- Stephan Erb
On Jan. 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55217/#review160815
---
Ship it!
Ship It!
- Stephan Erb
On Jan. 5, 2017, 7:59 p.m
ubuntu-xenial/README.md (line 26)
<https://reviews.apache.org/r/52437/#comment231672>
`ubuntu-xenial`
- Stephan Erb
On Jan. 4, 2017, 2:43 p.m., Renan DelValle wrote:
>
> ---
> This is an automatically generated e-
/scheduler/reconciliation/TaskTimeoutTest.java
(line 130)
<https://reviews.apache.org/r/55179/#comment231646>
Given the motivation of the patch, we should probably check that we did not
try to acquire the storage lock.
- Stephan Erb
On Jan. 4, 2017, 6:16 p.m., Mehrdad Nurolahzade
. This patch is
now duplicating `specs/debian` for `ubuntu-xenial`. Is there anything
particular that makes this necessary?
- Stephan Erb
On Jan. 4, 2017, 2:43 p.m., Renan DelValle wrote:
>
> ---
> This is an automatically generat
.
- Stephan Erb
On Dec. 29, 2016, 7:45 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55058/#review160239
---
Ship it!
Ship It!
- Stephan Erb
On Dez. 28, 2016, 7:25
> On Dec. 27, 2016, 11:50 p.m., Joshua Cohen wrote:
> > Overall this looks good to me. I think some work would be required to
> > productionize it (e.g. make it optional to start). Obviously want to vet
> > this in a test cluster and we would need some doc changes to go with this
> > and RELEA
. However,
off-heap storage could still be beneficial for production workloads.
- Stephan Erb
On Oct. 11, 2016, 8:17 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://review
://reviews.apache.org/r/55071/diff/
Testing
---
./gradlew jmh
-Pbenchmarks='TaskStoreBenchmarks.DBFetchTasksBenchmark|UpdateStoreBenchmarks.*'
./gradlew -Pq build
Thanks,
Stephan Erb
once and not more often?
- Stephan Erb
On Dec. 27, 2016, 11:53 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55056/#review160198
---
Ship it!
Ship It!
- Stephan Erb
On Dec. 27, 2016, 10:36 p.m
ferent types?
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java
(lines 64 - 75)
<https://reviews.apache.org/r/54883/#comment231225>
For debugging it will be helpful to differentiate those metrics for
operations and snapshot log. As it stands the metric will
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55019/#review160158
---
Ship it!
Ship It!
- Stephan Erb
On Dec. 24, 2016, 1:52 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55027/#review160154
---
Ship it!
Ship It!
- Stephan Erb
On Dec. 24, 2016, 6:21 p.m
> On Dec. 22, 2016, 10:04 a.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java,
> > line 87
> > <https://reviews.apache.org/r/54967/diff/1/?file=1591015#file1591015line87>
> >
> > I have just n
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54995/#review160150
---
Ship it!
Ship It!
- Stephan Erb
On Dec. 22, 2016, 9:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55020/#review160149
---
Ship it!
Ship It!
- Stephan Erb
On Dec. 23, 2016, 11:46 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54992/#review160057
---
Ship it!
Ship It!
- Stephan Erb
On Dec. 22, 2016, 8:48 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54990/#review160005
---
Ship it!
Ship It!
- Stephan Erb
On Dez. 22, 2016, 8:27
exact exception.
- Stephan Erb
On Dec. 22, 2016, 1:06 a.m., Karthik Anantha Padmanabhan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
/JobUpdateHistoryPruner.java
(line 87)
<https://reviews.apache.org/r/54967/#comment230996>
I have just noticed this is holding the storage lock. Would it make sense
to export the timing here as well? (like in https://reviews.apache.org/r/54959/)
- Stephan Erb
On Dec. 22, 2016, 8:37 a.m., M
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54967/#review159935
---
Ship it!
Ship It!
- Stephan Erb
On Dec. 22, 2016, 8:37 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54959/#review159934
---
Ship it!
Ship It!
- Stephan Erb
On Dec. 22, 2016, 7:49 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54847/#review159622
---
Ship it!
Ship It!
- Stephan Erb
On Dec. 19, 2016, 12:51 a.m
}/python:: -- -v
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos 1.0
and Mesos 1.1)
Thanks,
Stephan Erb
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos 1.0
and Mesos 1.1)
Thanks,
Stephan Erb
mean 1.1.0 right?
Fixed
- Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review158370
---
On D
Vagrant box and re-run the e2e tests.
Everything passed.
- Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review158359
-----------
---------
On Dec. 18, 2016, 1:05 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -
/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos 1.0
and Mesos 1.1)
Thanks,
Stephan Erb
> On Dec. 16, 2016, 2:13 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java,
> > lines 69-72
> > <https://reviews.apache.org/r/54774/diff/6/?file=1586548#file1586548line69>
> >
> > I feel like we sh
ose by default.
- Stephan Erb
On Dec. 15, 2016, 9:04 p.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
todos if the
necessary code change itself is rather small. Do you expect there is a certain
risk here?
- Stephan Erb
On Dec. 15, 2016, 8:57 a.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
>
> (Updated Dec. 12, 2016, 2:32 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Mehrdad Nurolahzade, Stephan Erb,
> and Zameer Manji.
>
>
> Bugs: AURORA-1838
> https://issues.apache.org/jira/browse/AURORA-1838
>
>
> Reposi
states in the RELEASE-NOTES.md.
- Stephan Erb
On Dec. 12, 2016, 2:32 a.m., Jing Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
metrics docs
https://github.com/apache/aurora/blob/master/docs/features/sla-metrics.md
- Stephan Erb
On Dec. 7, 2016, 6:50 p.m., Joshua Cohen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
.
- Stephan Erb
On Dec. 2, 2016, 4:19 a.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53836/#review158401
---
Ship it!
Ship It!
- Stephan Erb
On Dec. 7, 2016, 1:30 a.m
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54428/#review158172
---
Ship it!
Ship It!
- Stephan Erb
On Dec. 6, 2016, 5:22 p.m
---
>
> (Updated Dez. 2, 2016, 12:13 vorm.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Stephan Erb.
>
>
> Bugs: AURORA-1831
> https://issues.apache.org/jira/browse/AURORA-1831
>
>
> Repository: aurora
>
>
> Descripti
reply, visit:
https://reviews.apache.org/r/54255/#review157610
-----------
On Dez. 1, 2016, 5:34 nachm., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-m
7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
Diff: https://reviews.apache.org/r/54255/diff/
Testing
---
./gradlew -Pq build
./pants test.pytest src/{main,test}/python:: -- -v
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54250/#review157580
---
Ship it!
Ship It!
- Stephan Erb
On Dez. 1, 2016, 11:48 vorm
: https://reviews.apache.org/r/54185/diff/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
Thanks,
Stephan Erb
s.apache.org/r/53519/diff/
Testing
---
./pants test.pytest src/{main,test}/python:: -- -v
aurorabuild observer
Thanks,
Stephan Erb
nalThread`?
* Where do we put that code so that we can use it in client, executor and
observer?
Diffs (updated)
-
src/main/python/apache/aurora/tools/thermos_observer.py
0a07df7bed902be2b73d2ca3308a02a1e34760d6
Diff: https://reviews.apache.org/r/53519/diff/
Testing
---
./pants test.pytest src/{main,test}/python:: -- -v
aurorabuild observer
Thanks,
Stephan Erb
reviews.apache.org/r/54011/#comment227038>
Same as above, `void` benchmarks are an anti-pattern.
- Stephan Erb
On Nov. 23, 2016, 3:47 a.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
about the delay. Looks like we forgot about that review.
- Stephan Erb
On Nov. 3, 2016, 11:46 p.m., Pradyumna Kaushik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
orrect?
- Stephan Erb
On Nov. 23, 2016, 3:47 a.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On Nov. 19, 2016, 11:12 a.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java,
> > line 204
> > <https://reviews.apache.org/r/53923/diff/1/?file=1567382#file1567382line204>
> >
> > Use `SUPPORTED_RESO
> On Nov. 19, 2016, 11:12 a.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java,
> > line 204
> > <https://reviews.apache.org/r/53923/diff/1/?file=1567382#file1567382line204>
> >
> > Use `SUPPORTED_RESO
/apache/aurora/scheduler/storage/db/AttributeMapper.xml
91c76ca0f469c5b94b1ab290b40ddf43e44ee0c9
Diff: https://reviews.apache.org/r/53918/diff/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53918/#review156522
-----------
On Nov. 19, 2016, 10:36 a.m., Stephan Erb wrote:
>
> -
.org/r/53933/#review156431
---
On Nov. 20, 2016, 7:50 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
2a92a5ac2ac533465436e35019380de14086ad74
Diff: https://reviews.apache.org/r/53933/diff/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
30bb814148b271cc9dfeebe016e8f8f92c2e3e41
Diff: https://reviews.apache.org/r/53928/diff/
Testing
---
./gradlew -Pq build
./gradlew jmh -Pbenchmarks='SchedulingBenchmarks.PreemptorSlotSearchBenchmark'
Thanks,
Stephan Erb
/scheduler/resources/ResourceManager.java (line
204)
<https://reviews.apache.org/r/53923/#comment226614>
Use `SUPPORTED_RESOURCE` here as well.
- Stephan Erb
On Nov. 19, 2016, 4:21 a.m., Renan DelValle wrote:
>
> ---
/AttributeAggregate.java
f04149e99ad9940e15ddabb6b98238495bb9d32a
src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml
91c76ca0f469c5b94b1ab290b40ddf43e44ee0c9
Diff: https://reviews.apache.org/r/53918/diff/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
/AttributeMapper.xml
91c76ca0f469c5b94b1ab290b40ddf43e44ee0c9
Diff: https://reviews.apache.org/r/53918/diff/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
-Pbenchmarks='SchedulingBenchmarks.FillClusterBenchmark'
Thanks,
Stephan Erb
://reviews.apache.org/r/53829/diff/
Testing
---
Thanks,
Stephan Erb
1b56500260fc6539facf0ae3a25db02cc72b82db
Diff: https://reviews.apache.org/r/53829/diff/
Testing
---
Thanks,
Stephan Erb
: https://reviews.apache.org/r/53829/diff/
Testing
---
Thanks,
Stephan Erb
ent226275>
This could be merged with the job update sentence highlighted above, once
it is extracted.
- Stephan Erb
On Nov. 16, 2016, 10:38 p.m., Santhosh Kumar Shanmugham wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53796/#review156040
---
Ship it!
Ship It!
- Stephan Erb
On Nov. 15, 2016, 11:09 p.m
4425&version=12335828
Diffs
-
build.gradle bbd5e3aea33817e41c9cf2878df99ba6fe44ffec
Diff: https://reviews.apache.org/r/53794/diff/
Testing
---
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Stephan Erb
/python/apache/aurora/client/cli/jobs.py (line 238)
<https://reviews.apache.org/r/53114/#comment225779>
As this method is only called by the class itself, it should be be called
`_render_config_pretty`.
- Stephan Erb
On Nov. 11, 2016, 10:34 a.m., Jing Chen
apache.org/r/53590/
> ---
>
> (Updated Nov. 9, 2016, 9:29 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1225
> https://issues.apache.org/jira/browse/AURORA-1225
>
>
> Repository: aurora
>
>
> Descr
ply, visit:
> https://reviews.apache.org/r/53590/
> ---
>
> (Updated Nov. 9, 2016, 9:29 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1225
> https://issues.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53620/#review155499
---
Ship it!
Ship It!
- Stephan Erb
On Nov. 9, 2016, 9:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51993/#review155373
---
@ReviewBot retry
- Stephan Erb
On Nov. 3, 2016, 11:46 p.m
> On Nov. 4, 2016, 3:22 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, lines 291-337
> > <https://reviews.apache.org/r/53114/diff/2/?file=1544805#file1544805line291>
> >
> > Having a manual json assembly here is brittle. Whe
onal.py PRE-CREATION
src/main/python/apache/thermos/observer/task_observer.py
1485de8faef52716f11b82a3556064de26c67427
Diff: https://reviews.apache.org/r/53519/diff/
Testing
---
./pants test.pytest src/{main,test}/python:: -- -v
aurorabuild observer
Thanks,
Stephan Erb
> On Nov. 4, 2016, 5:03 p.m., Stephan Erb wrote:
> > LGTM in general. I may not be around for the rest of the day and the
> > weekend, so I mark thas 'Ship it, then fix it'.
Ahh, "Fix it, then Ship it!" :-)
- Stephan
---
t;Assert
that Thermos does not lose track of double forking processes. On task teardown
the daemonized process should receive a signal to shut down cleanly."
- Stephan Erb
On Nov. 4, 2016, 12:48 a.m., Zameer Manji wrote:
>
> -
and AssignedTask. I fell
like the AssignedTask is the one we really care about from the perspective of
Aurora.
But I don't want to start a bikeshedding discussion, so the decision is up to
you :)
- Stephan Erb
On Nov. 4, 2016, 1:52 a.m., Zameer Manji
d-json devcluster/www-data/prod/hello
hello_world.json
```
- Stephan Erb
On Oct. 25, 2016, 4:14 a.m., Jing Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53452/#review154900
---
@ReviewBot retry
- Stephan Erb
On Nov. 4, 2016, 1:52 a.m
committers. I
will therefore proceeed and merge it.
- Stephan Erb
On Oct. 14, 2016, 5:03 p.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
401 - 500 of 1038 matches
Mail list logo
