Re: Review Request 51664: Document the Mesos containerizer

line has no effect as we are already using Java 8. - Stephan Erb On Sept. 6, 2016, 9:18 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Review Request 51664: Document the Mesos containerizer

, Stephan Erb

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147781 --- Ship it! Ship It! - Stephan Erb On Sept. 5, 2016, 8:56

Re: Review Request 51595: Add Dynamic Reservations design docs

Khutornenko. Repository: aurora Description (updated) --- Dynamic Reservations design docs Diffs - docs/development/design-documents.md 50aeafbc5f96a8c443c90269730cd8b4c4bfd6d7 Diff: https://reviews.apache.org/r/51595/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 51595: Add Dynamic Reservations design docs

://reviews.apache.org/r/51595/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 51595: Add Job Store and Dynamic Reservations design docs

https://reviews.apache.org/r/51595/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

(line 76) <https://reviews.apache.org/r/51580/#comment214950> Please update the documentation to cover the new SLA metric https://github.com/apache/aurora/blob/master/docs/features/sla-metrics.md - Stephan Erb On Sept. 1, 2016, 10:19 p.m., Kai Huang

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

> On Sept. 1, 2016, 9:53 p.m., Zameer Manji wrote: > > Can you set the depends on field of this review to be `51536`? So we know > > that this patch is blocked on that review landing first? Is it really blocked? Nothing would be wrong or broken if we submit this right away. - Stephan -

Re: Review Request 51602: Extend the resource isolation and oversubscription documentation

enane effort for us. - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51602/#review147686 --- On Sept. 2, 20

Re: Review Request 51615: Upgrade to latest CherryPy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51615/#review147696 --- Ship it! Ship It! - Stephan Erb On Sept. 2, 2016, 10:55

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

. Unfortuantely, given the problem at hand, I don't have a much better idea either. - Stephan Erb On Sept. 2, 2016, 4:11 p.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Review Request 51602: Extend the resource isolation and oversubscription documentation

59da8231a3e25e64b4be8c30a44c1043188aff2c docs/operations/configuration.md 350ea77e30ce445ba9e37ea95a9e4f593dbbe402 Diff: https://reviews.apache.org/r/51602/diff/ Testing --- Rendered version available at https://github.com/StephanErb/aurora/tree/isolation-docs Thanks, Stephan Erb

Review Request 51595: Add Job Store and Dynamic Reservations design docs

Description --- Add Job Store and Dynamic Reservations design docs Diffs - docs/development/design-documents.md 50aeafbc5f96a8c443c90269730cd8b4c4bfd6d7 Diff: https://reviews.apache.org/r/51595/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

> On Sept. 1, 2016, 12:17 a.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 239 > > <https://reviews.apache.org/r/51564/diff/3/?file=1489394#file1489394line239> > > > > This changes seems to come with a severe securit

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

-1 from my end. - Stephan Erb On Aug. 31, 2016, 10:56 p.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Aug. 30, 2016, 11:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java, > > line 143 > > > > > > We should add a constant to api.thrift for `health` and use it

Re: Review Request 51513: Add support for ETags in the Aurora API.

> On Aug. 30, 2016, 9:37 a.m., Stephan Erb wrote: > > Were you able to test this on a cluster with concurrent modifications? > > Right now, I am not confident this is working as most ouf our thrift > > responses contain unordered sequences. I would therefore suspe

Review Request 51535: Fix a Python unittest that is not asserting anything

tempered with. ./pants test.pytest src/test/python/apache/aurora/admin:: Thanks, Stephan Erb

Review Request 51531: Minor improvements to the custom executor docs

, Stephan Erb

Re: Review Request 51499: Update 3dparty Python dependencies

ceptions.UnicodeEncodeError'>) > > > > Exception message: 'latin-1' codec can't encode characters in position > > 51-55: ordinal not in range(256) > > > > > > > > > > I will refresh this build result if you post a review c

Re: Review Request 51499: Update 3dparty Python dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51499/#review147273 --- @ReviewBot retry - Stephan Erb On Aug. 30, 2016, 9:40 a.m

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

notes :-) - Stephan Erb On Aug. 28, 2016, 5:58 a.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 51499: Update 3dparty Python dependencies

Diff: https://reviews.apache.org/r/51499/diff/ Testing --- ./pants test.pytest src/{main,test}/python:: -- -v ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Stephan Erb

Re: Review Request 51513: Add support for ETags in the Aurora API.

to get some speedups for the Aurora UI as well? - Stephan Erb On Aug. 30, 2016, 3:12 a.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

efault value to the 'New/Updates' section. - Stephan Erb On Aug. 30, 2016, 1:37 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 51499: Update 3dparty Python dependencies

u post a review containing > > "@ReviewBot retry" > > John Sirois wrote: > OK - I was hoping to get more detail in the AuroraBot jenkins job > console, but this is it. I'll dig a bit. Could it be the new requests version combined with non optimal isolation? - Stephan

Re: Review Request 51499: Update 3dparty Python dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51499/#review147222 --- @ReviewBot retry - Stephan Erb On Aug. 29, 2016, 9:11 p.m

Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51502/#review147211 --- Ship it! Ship It! - Stephan Erb On Aug. 29, 2016, 10:28 p.m

Re: Review Request 51499: Update 3dparty Python dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51499/#review147191 --- @ReviewBot retry - Stephan Erb On Aug. 29, 2016, 9:11 p.m

Re: Review Request 51500: Configure ssh for e2e tests once globally, rather than as part of a specific test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51500/#review147185 --- Ship it! Ship It! - Stephan Erb On Aug. 29, 2016, 9:10 p.m

Review Request 51499: Update 3dparty Python dependencies

{main,test}/python:: -- -v ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Stephan Erb

Re: Review Request 50819: Use update_job instead of creating new config object when modifying.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review147171 --- @ReviewBot retry - Stephan Erb On Aug. 4, 2016, 11:10 p.m

Re: Review Request 51307: Catch IOError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/#review147172 --- @ReviewBot retry - Stephan Erb On Aug. 23, 2016, 11:12 p.m

Re: Review Request 51298: A few executor fixes for filesystem isolation:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146989 --- Ship it! Ship It! - Stephan Erb On Aug. 26, 2016, 5:52 vorm

Re: Review Request 51298: A few executor fixes for filesystem isolation:

> On Aug. 25, 2016, 11:48 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/process.py, line 487 > > <https://reviews.apache.org/r/51298/diff/5/?file=1486012#file1486012line487> > > > > In the taskfs_isolated case the `cwd` will contain a pat

Re: Review Request 51298: A few executor fixes for filesystem isolation:

iner image and once on the outside. Probably does no harm. src/main/python/apache/thermos/core/process.py (line 473) <https://reviews.apache.org/r/51298/#comment213643> In the taskfs_isolated case the `cwd` will contain a path within the container image. However here, we u

Re: Review Request 51298: A few executor fixes for filesystem isolation:

> On Aug. 24, 2016, 1:21 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/process.py, line 437 > > <https://reviews.apache.org/r/51298/diff/2/?file=1482578#file1482578line437> > > > > In the `taskfs_isolated` case, `cwd` will be set to a path

Re: Review Request 51366: Unset PYTHONPATH before calling pants

e.org/r/51366/#review146685 --- On Aug. 24, 2016, 2:07 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 51366: Unset PYTHONPATH before calling pants

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51366/#review146652 --- @ReviewBot retry - Stephan Erb On Aug. 24, 2016, 2:07 p.m

Re: Review Request 51366: Unset PYTHONPATH before calling pants

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51366/#review146647 --- @ReviewBot retry - Stephan Erb On Aug. 24, 2016, 2:07 p.m

Review Request 51366: Unset PYTHONPATH before calling pants

- pants b1ca3823b5b31cceccc5b9e4cb9a7ef79305d9fd Diff: https://reviews.apache.org/r/51366/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 51298: A few executor fixes for filesystem isolation:

139 - 144) <https://reviews.apache.org/r/51298/#comment213170> Can this be changed in a meaningful way? I have always assumed that the observer UI has the hardcoded assumption that logs can be found within `sandbox/.logs`

Re: Review Request 43027: Optionally enable setuid inside Docker containers

345> To make upgrading possible, you have to keep those in for now but make them a no-op. See https://reviews.apache.org/r/43112/ - Stephan Erb On Feb. 13, 2016, 3:17 a.m., Benjamin Staffin wrote: > > --- > This is a

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51348/#review146578 --- Ship it! Ship It! - Stephan Erb On Aug. 23, 2016, 10:45 p.m

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

> On Aug. 23, 2016, 11:20 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/helper.py, lines 104-109 > > <https://reviews.apache.org/r/51348/diff/1/?file=1482585#file1482585line104> > > > > In the non-docker usecase, Thermos will by def

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

nction `this_is_really_our_pid` useless, as we will now happily kill everything. To make this safe, we have to pass in the the uid that we where supposed to setuid to (i.e the role user in the default usecase). Only if this is `None`, we may enter the block you have added here. - Stephan Erb On Aug. 23

Re: Review Request 51306: Only warn about terminated executors if their exit code is not 0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51306/#review146491 --- @ReviewBot retry - Stephan Erb On Aug. 23, 2016, 12:48 a.m

Review Request 51306: Only warn about terminated executors if their exit code is not 0.

297a-417f-8ed7-d71b4634ca36" on slave value: "b1593d6b-7a7e-458c-ab22-6a5d07b9f065-S0" with status 9` Thanks, Stephan Erb

Re: Review Request 51298: A few executor fixes for filesystem isolation:

mount point could break things. - Stephan Erb On Aug. 22, 2016, 10:25 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Review Request 51301: Use a fixed Debian mirror rather than relying on httpredir

--- Multiple executions of `./build-artifact.sh builder/deb/debian-jessie snapshot.tar.gz 0.16.0-snapshot` Thanks, Stephan Erb

Re: Review Request 51264: Reduce static method exposure for Stats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51264/#review146273 --- Ship it! Ship It! - Stephan Erb On Aug. 21, 2016, 3:28 vorm

Re: Review Request 50819: Use update_job instead of creating new config object when modifying.

easy way how to add a test for that? - Stephan Erb On Aug. 4, 2016, 11:10 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 50859: Update install docs for 0.15.0

, Stephan Erb

Re: Review Request 50685: Support TBinaryProtocol over HTTP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/#review144666 --- Ship it! Ship It! - Stephan Erb On Aug. 3, 2016, 2:10 a.m

Re: Review Request 50685: Support TBinaryProtocol over HTTP

> On Aug. 3, 2016, 3:58 a.m., Joshua Cohen wrote: > > So, on further reflection, it doesn't necessarily make sense for the > > response type to be dictated by the `Content-Type` of the request. We > > should probably use the `Accept` header instead? I don't necessarily know > > if the use case

Re: Review Request 50168: Add rollback functionality to the scheduler

168/#comment210551> That slipped into the 0.15er release notes rather than 0.16. - Stephan Erb On Aug. 2, 2016, 11:20 p.m., Igor Morozov wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

/common/sandbox.py (line 193) <https://reviews.apache.org/r/47853/#comment210548> As discussed out-of-band, `-f` will silently switch the GID and can therefore not be used. - Stephan Erb On Aug. 2, 2016, 10:55 p.m., Joshua Cohen

Review Request 50716: Use Docker host network rather than bridging.

Diffs - build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 Diff: https://reviews.apache.org/r/50716/diff/ Testing --- ./build-artifact.sh apache-aurora-0.15.0.tar.gz 0.15.0 Thanks, Stephan Erb

Re: Review Request 50685: Support TBinaryProtocol over HTTP

. We should also try clearly capture the knowledge of what content type corresponds to what protocol. You did a great job explaining this in the commit message, but I feel like it is less clear within the doc string. - Stephan Erb On Aug. 2, 2016, 3:29 a.m., Zameer Manji wrote

Re: Review Request 50669: Upgrade aurora-packaging for Mesos 1.0.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50669/#review144378 --- Ship it! Ship It! - Stephan Erb On Aug. 1, 2016, 9:28 p.m

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

that are out of scope of this particular review request) * documentation * `aurora task ssh` could probably be update to use the containerizer launch command as well. - Stephan Erb On Aug. 1, 2016, 7:22 p.m., Joshua Cohen wrote: > > --

Re: Review Request 50584: Upgrade to Mesos 1.0.0

dition, the update to Mesos 1.0 is the most prominent change in the upcoming Aurora version and should therefore be at the top (like in earlier releases). - Stephan Erb On July 28, 2016, 11:18 p.m., Joshua Cohen wrote: > > ---

Re: Review Request 50530: AURORA-1656 Document tier concept

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50530/#review143958 --- Ship it! Ship It! - Stephan Erb On Juli 28, 2016, 12:41

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

for the user-facing configuration option * rebase Joshua, would be great if you could land this patch once its done. I am gone for the week & without proper internet access. - Stephan Erb On July 20, 2016, 7:56 p.m., Mehrdad Nurolahzade w

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

> On July 20, 2016, 12:27 a.m., Stephan Erb wrote: > > RELEASE-NOTES.md, line 13 > > <https://reviews.apache.org/r/49048/diff/7/?file=1440195#file1440195line13> > > > > Maybe add here explicitly that `production` is deprecated and that > > peopl

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

n --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50052/#review142830 ------- On July 19, 2016, 4:12 a.m., Mehrdad Nurolahzade wrote: > &

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

The additional mock calls are obscuring the original test intend. A simple workaround would be to already set a `tier` in the job. `get_tier_config` would then no longer need to be called. - Stephan Erb On July 9, 2016, 1:15 a.m., Mehrdad Nurolahzade wrote: > > --

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

r the fix? - Stephan Erb On July 9, 2016, 1:15 a.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 49512: [FEEDBACK] Add thermos option to monitor whole docker storage disk usage

> On July 4, 2016, 9:55 a.m., Stephan Erb wrote: > > Have you considered querying Mesos for the disk usage of the task? That > > would be in line with our desire to also leave the isolation up to Mesos > > https://issues.apache.org/jira/browse/AURORA-1033 > > Mart

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

ally strong opinion here, especially given that the class was untested before. Feel free to ignore if you see this otherwise. - Stephan Erb On July 19, 2016, 4:12 a.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

> On July 18, 2016, 12:15 a.m., Stephan Erb wrote: > > Should we consider adopting `protobuf-java-util`'s JsonFormatter rather > > than implementing this on our own? > > > > * > > https://github.com/google/protobuf/blob/master/java/util/src/main/java/co

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

atter rather than implementing this on our own? * https://github.com/google/protobuf/blob/master/java/util/src/main/java/com/google/protobuf/util/JsonFormat.java * http://mvnrepository.com/artifact/com.google.protobuf/protobuf-java-util/3.0.0-beta-3 - Stephan Erb On July 15, 2016, 10:1

Re: Review Request 49732: Update package scripts to 0.15.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49732/#review141956 --- Ship it! Ship It! - Stephan Erb On July 7, 2016, 2:30 a.m

Re: Review Request 49512: [FEEDBACK] Add thermos option to monitor whole docker storage disk usage

> On July 4, 2016, 9:55 a.m., Stephan Erb wrote: > > Have you considered querying Mesos for the disk usage of the task? That > > would be in line with our desire to also leave the isolation up to Mesos > > https://issues.apache.org/jira/browse/AURORA-1033 > > Mart

Re: Review Request 49872: Upgrade pants to 1.1.0-rc7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49872/#review141856 --- Ship it! Ship It! - Stephan Erb On Juli 12, 2016, 2:21 vorm

Re: Review Request 49868: Update virtualenv version to 15.0.2

FAILURE > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" It looks like as if those tests are failing which are calling `./pants` from within the test code. - Stephan --

Re: Review Request 49868: Update virtualenv version to 15.0.2

https://reviews.apache.org/r/49868/diff/ Testing --- rm -rf ~/.cache/pants/ git clean -fxd ./pants test.pytest src/{main,test}/python:: Thanks, Stephan Erb

Re: Review Request 49868: Update virtualenv version to 15.0.2

pants: No such file or directory ``` I believe that the error here is that our paths are too long. There is an obscure limitation in the linux kernel that shebang lines cannot be longer than 127 characters. However, once you have a virtualenv in a deeply nested directo

Review Request 49868: Update virtualenv version to 15.0.2

03c14323e14d2a3923e080efc947107b9b8a3a16 pants a11588a02d9b471b600a5095476caa5ae8eb8161 Diff: https://reviews.apache.org/r/49868/diff/ Testing --- rm -rf ~/.cache/pants/ git clean -fxd ./pants test.pytest src/{main,test}/python:: Thanks, Stephan Erb

Re: Review Request 49732: Update package scripts to 0.15.0.

--- On July 7, 2016, 2:30 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49732/ > --- > > (Upda

Re: Review Request 49642: Updating release docs to remind about rc argument usage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49642/#review141061 --- Ship it! Ship It! - Stephan Erb On July 5, 2016, 7:09 p.m

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

x27;d really like to see us migrate to stable 1.1 before doing the next release of Aurora. - Stephan Erb On July 4, 2016, 4:52 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 49512: [FEEDBACK] Add thermos option to monitor whole docker storage disk usage

? That would be in line with our desire to also leave the isolation up to Mesos https://issues.apache.org/jira/browse/AURORA-1033 - Stephan Erb On July 1, 2016, 4:51 p.m., Martin Hrabovcin wrote: > > --- > This is an auto

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

. - Stephan Erb On July 4, 2016, 1:02 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 49577: Ensure e2e key has its own authorized_keys line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49577/#review140575 --- Ship it! Ship It! - Stephan Erb On Juli 3, 2016, 9:39 nachm

Re: Review Request 49339: Update install docs to for Aurora 0.14.0

: aurora Description (updated) --- Update install docs to for Aurora 0.14.0 Diffs - docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 Diff: https://reviews.apache.org/r/49339/diff/ Testing --- Thanks, Stephan Erb

Review Request 49527: Reduce log level of finding a valid leader

iff: https://reviews.apache.org/r/49527/diff/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb

Re: Review Request 49399: Fix Process log configuration handling.

new syntax using a `Choice` field. If you are interested, feel free to address this in a separate RB. - Stephan Erb On June 30, 2016, 1 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 49399: Fix Process log configuration handling.

> On June 30, 2016, 3:39 p.m., Stephan Erb wrote: > > docs/reference/configuration.md, line 144 > > <https://reviews.apache.org/r/49399/diff/1/?file=1433250#file1433250line144> > > > > Have you considered using `RotatePolicy()` as the default rather than &

Re: Review Request 49399: Fix Process log configuration handling.

> > (Updated June 30, 2016, 1 a.m.) > > > Review request for Aurora, George Sirois, Martin Hrabovcin, and Stephan Erb. > > > Bugs: AURORA-1724 > https://issues.apache.org/jira/browse/AURORA-1724 > > > Repository: aurora > > >

Re: Review Request 49399: Fix Process log configuration handling.

9> I feel like we can reduce the cyclomatic complexity in `_build_process_logger_args` if we assign default arugments here, rather than later in the code. - Stephan Erb On June 30, 2016, 1 a.m., John Sirois wrote: > > --

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140155 --- Ship it! Ship It! - Stephan Erb On June 30, 2016, 2:10 a.m

Review Request 49339: Update install docs to for Aurora 0.14.0

/diff/ Testing --- Thanks, Stephan Erb

Review Request 49338: Update packaging for Aurora 0.14

-7/provision.sh e42a015af40ff2c142b259cf04217b09a5e829bf Diff: https://reviews.apache.org/r/49338/diff/ Testing --- Manually run through the test instructions in `tests/$distribution' Thanks, Stephan Erb

Re: Review Request 48606: Improve consistency of the RPM and DEB default configuration

> On June 13, 2016, 12:14 a.m., Stephan Erb wrote: > > specs/rpm/SOURCES/aurora-scheduler.sysconfig, lines 33-36 > > <https://reviews.apache.org/r/48606/diff/1/?file=1416269#file1416269line33> > > > > Should we adopt the same configuration schem

Re: Review Request 48606: Improve consistency of the RPM and DEB default configuration

https://reviews.apache.org/r/48606/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 48591: Ensure we can verify release candidates in the Vagrant box

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48591/#review137571 --- @ReviewBot retry - Stephan Erb On June 12, 2016, 12:21 a.m

Re: Review Request 48606: Improve consistency of the RPM and DEB default configuration

think? - Stephan Erb On June 13, 2016, 12:08 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 48606: Improve consistency of the RPM and DEB default configuration

bb793410f1bb2bbb1231eb3ca0ad7f7d8ba14fc0 test/rpm/centos-7/README.md bb34fb6b5dad0971226b4a9adb89d69e85c633a4 Diff: https://reviews.apache.org/r/48606/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 48591: Ensure we can verify release candidates in the Vagrant box

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48591/#review137190 --- @ReviewBot retry - Stephan Erb On June 12, 2016, 12:21 a.m

<    2   3   4   5   6   7   8   9   10   11   >