---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46290/#review129375
---
Ship it!
Ship It!
- Zameer Manji
On April 15, 2016, 4:59
/storage/db/DbModule.java
743993cef43f028ff0d53d93adacb86f5ed79a5c
Diff: https://reviews.apache.org/r/46289/diff/
Testing
---
Thanks,
Zameer Manji
/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java
743993cef43f028ff0d53d93adacb86f5ed79a5c
Diff: https://reviews.apache.org/r/46289/diff/
Testing
---
Thanks,
Zameer Manji
pache.org/r/46290/#comment192671>
please check the .mock_calls[] attribute here. Otherwise a typo as as
`mock_getpwnam.asert_not_called()` will hide any test failures.
- Zameer Manji
On April 15, 2016, 4:31 p.m., Dmitriy Shir
743993cef43f028ff0d53d93adacb86f5ed79a5c
Diff: https://reviews.apache.org/r/46289/diff/
Testing
---
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46171/#review129162
---
Ship it!
Ship It!
- Zameer Manji
On April 13, 2016, 3:18
hn Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46171/
> ---
>
> (Updated April 13, 2016, 3:18 p.m.)
>
>
> Review request for Aurora, Bill Farne
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46241/#review129144
---
Ship it!
Ship It!
- Zameer Manji
On April 14, 2016, 6:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46133/#review128750
---
Ship it!
Ship It!
- Zameer Manji
On April 13, 2016, 8:09
/
Testing
---
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46111/#review128574
---
Ship it!
Ship It!
- Zameer Manji
On April 12, 2016, 2:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46064/#review128479
---
Ship it!
Ship It!
- Zameer Manji
On April 11, 2016, 5:03
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46051/#review128257
---
Ship it!
Ship It!
- Zameer Manji
On April 11, 2016, 2:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46045/#review128215
---
Ship it!
Ship It!
- Zameer Manji
On April 11, 2016, 12:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45992/#review128174
---
Ship it!
Ship It!
- Zameer Manji
On April 10, 2016, 1:57
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45936/#review127837
---
Ship it!
Ship It!
- Zameer Manji
On April 8, 2016, 11:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45902/#review127713
---
Ship it!
Ship It!
- Zameer Manji
On April 7, 2016, 4:07 p.m
/CuratorServiceGroupMonitor.java
(line 108)
<https://reviews.apache.org/r/45902/#comment191097>
Shouldn't this be fatal? To me to looks like this exception can only throw
if there is a ZK problem `data.getData()` is null, or the data is malformed
(bug in a follower).
- Zameer Manji
On April 7
at this and everything LGTM.
It took me a bit to understand the mechanics but it seems to be a robust enough
solution.
- Zameer Manji
On April 7, 2016, 10:29 a.m., Joshua Cohen wrote:
>
> ---
> This is an automatically generated e-mail. To rep
Diff: https://reviews.apache.org/r/45821/diff/
Testing
---
Saw metrics in vagrant environment.
Thanks,
Zameer Manji
---
Saw metrics in vagrant environment.
Thanks,
Zameer Manji
.
Thanks,
Zameer Manji
d be
able to tell the difference.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45821/#review127408
-------
On
java:${protobufRev}"
force "junit:junit:${junitRev}"
force "org.apache.thrift:libthrift:${thriftRev}"
force "org.hamcrest:hamcrest-core:1.3"
force "org.slf4j:slf4j-api:${slf4jRev}"
}
````
You c
in vagrant environment.
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127163
---
Ship it!
Ship It!
- Zameer Manji
On April 4, 2016, 7:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45754/#review127156
---
Ship it!
Ship It!
- Zameer Manji
On April 5, 2016, 10:40
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45694/#review126889
---
Ship it!
Ship It!
- Zameer Manji
On April 4, 2016, 11:16
work fine.
- Zameer Manji
On March 31, 2016, 3:41 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45457/
> ---
>
> (Updated March 29, 2016, 4:01 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45506/#review126447
---
Ship it!
Ship It!
- Zameer Manji
On March 31, 2016, 1:18
> On March 31, 2016, 11:11 a.m., Zameer Manji wrote:
> > The change and the tests LGTM.
> >
> > I currently have great ideas on how to ensure end to end validation. The
> > best idea that I can provide is make use of the shell checker in the e2e
> > tests.
plumb the None into the method.
- Zameer Manji
On March 31, 2016, 11:01 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/#review126015
---
Ship it!
Ship It!
- Zameer Manji
On March 29, 2016, 3:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45212/#review125674
---
Ship it!
Ship It!
- Zameer Manji
On March 23, 2016, 7:56
in `TaskStoreBenchmarks` to validate that there is
no crazy performance difference from this change? I know this change seems
innocent but I recall `` being much slower than expected.
- Zameer Manji
On March 24, 2016, 9:43 p.m., Bill Farner wrote
> I've widened the reviewer scope a bit to gather more opions here. This
> may need a dev@ thread.
>
> Stephan Erb wrote:
> It's not a real bug for the executor. For the executor we boundle the
> `mesos.native` wheel in the pex-file.
>
> Bill Farner wrote:
more than I expected, but
I think this is the better solution. I think whenever we get around to fixing
AURORA-1650 and AURORA-1651 the code should end up a lot cleaner.
- Zameer Manji
On March 24, 2016, 7:52 a.m., John Sirois wrote
of work, I will just ship this change as is.
- Zameer Manji
On March 23, 2016, 9:35 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
matically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45212/
> -------
>
> (Updated March 23, 2016, 7:56 a.m.)
>
>
> Review request for Aurora, Jake Farrell, John Sirois, Stephan Erb, Bill
> Farner, a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/#review124886
---
Ship it!
Ship It!
- Zameer Manji
On March 22, 2016, 2:04
---
Thanks,
Zameer Manji
if `default_acl` was supposed to be a
list or a single instance of `ACL`, but I confirmed that it was a list via
checking the source of Kazoo 1.3.1.
Thanks for your contribution, this should help operators who want to maintain a
secure ZK cluster for service discovery.
- Zameer Manji
On March 22, 2016, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45135/#review124832
---
Ship it!
LGTM modulo Maxim's comment.
- Zameer Manji
ed e-mail. To reply, visit:
> https://reviews.apache.org/r/45135/
> ---
>
> (Updated March 21, 2016, 5:19 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1645
> https://issues.apache.org/jira/bro
On March 18, 2016, 2:57 p.m., Kunal Thakar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45042/
> ---
>
> (Updated March 18, 2016, 2:57 p.m.)
>
>
> Review request for Aur
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44806/#review123548
---
Ship it!
Ship It!
- Zameer Manji
On March 14, 2016, 1:44
on supporting
the Mesos Universal Containerizer (see his recent design doc to dev@)
- Zameer Manji
On March 10, 2016, 4:37 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123039
---
Ship it!
Ship It!
- Zameer Manji
On March 10, 2016, 2:36
out so pardon my
> ignorance.
>
> Do you have strong concerns about this approach or just want it to be
> perfect?
>
> On Tue, Mar 8, 2016, 12:04 PM Zameer Manji <zma...@apache.org> wrote:
>
>> This is an automatically generated e-mail. To reply, visit:
>> https:
> On March 8, 2016, 11:25 a.m., Zameer Manji wrote:
> > The code for this approach looks fine to me, but I'm not sure if this
> > approach is the way to go.
> >
> > Why can't the command for the health checker include
> > '{{thermos.ports[http]}}' and
> On March 8, 2016, 11:25 a.m., Zameer Manji wrote:
> > The code for this approach looks fine to me, but I'm not sure if this
> > approach is the way to go.
> >
> > Why can't the command for the health checker include
> > '{{thermos.ports[http]}}' and
the health checker process to have access to
all of the same information that task processes have like hostname.
For example the command could be '/usr/bin/health_checker
--port-to-check={{thermos.ports[http]}}'.
- Zameer Manji
On March 8, 2016, 10:32 a.m., Dmitriy Shirchenko wrote
which is dropping the other
fields in the snapshot after we move all in memory storage to H2.
I think keeping those fields for a while will be useful because they allow
cluster operators to look at a snapshot of the cluster state and perform
analytics, etc.
- Zameer Manji
On March 7, 2016, 3:55
/ShiroAuthorizingParamInterceptor.java
3043dfacfe824551b15595a070a1a4fdb7967d3a
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java
b5b405bdff189120a0e8e2beb1159571321d5b96
Diff: https://reviews.apache.org/r/44354/diff/
Testing
---
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44368/#review121959
---
Ship it!
Ship It!
- Zameer Manji
On March 3, 2016, 3:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121941
---
@ReviewBot retry
- Zameer Manji
On March 3, 2016, 12:16 p.m
://reviews.apache.org/r/44354/diff/
Testing
---
Thanks,
Zameer Manji
://reviews.apache.org/r/44347/diff/
Testing
---
vagrant up
checked thrift was installed
Thanks,
Zameer Manji
://reviews.apache.org/r/44219/diff/
Testing
---
Thanks,
Zameer Manji
---
This completes the TODO in Tasks.java by removing the unused code.
Diffs
-
src/main/java/org/apache/aurora/scheduler/base/Tasks.java
9f625c775544d9ae4d8e5b15e1fc824ed4a876c8
Diff: https://reviews.apache.org/r/44219/diff/
Testing
---
Thanks,
Zameer Manji
/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java
dc5e2bd142676e837b390e4268148831b3669941
Diff: https://reviews.apache.org/r/44106/diff/
Testing
---
./gradlew test
Thanks,
Zameer Manji
dc5e2bd142676e837b390e4268148831b3669941
Diff: https://reviews.apache.org/r/44106/diff/
Testing
---
./gradlew test
Thanks,
Zameer Manji
3d37187429deddc74eceb73dfb849ae60d58b206
Diff: https://reviews.apache.org/r/43866/diff/
Testing
---
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43784/#review119975
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 19, 2016, 1:12 p.m
----------
On Feb. 16, 2016, 7:42 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43643/
> ---
± 21422.498 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 5 thrpt5
70160.553 ± 20418.670 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10 thrpt5
29834.284 ± 10440.180 ops/s
Thanks,
Zameer Manji
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 5 thrpt5
70160.553 ± 20418.670 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10 thrpt5
29834.284 ± 10440.180 ops/s
Thanks,
Zameer Manji
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 5 thrpt5
70160.553 ± 20418.670 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10 thrpt5
29834.284 ± 10440.180 ops/s
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43486/#review118903
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 11, 2016, 8:54 a.m
inplace copy.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43457/#review118774
---
On Feb. 10, 2016, 4:35 p.m., Za
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10 thrpt5 2.143 ±
1.234 ops/s
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43503/#review118963
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 11, 2016, 3:03 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43457/#review118784
---
@ReviewBot retry
- Zameer Manji
On Feb. 10, 2016, 4:35 p.m
h John.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43457/#review118775
---
On Feb. 10, 2016, 4:15 p.m.,
> > - I'd hope construction would beat setters, but - if not - be _very close_.
> > If this latter bit was significant, my faith in the jvm is duly shaken.
>
> Zameer Manji wrote:
> Switching to Pair and populating via constructor:
>
> Benchmark
isit:
https://reviews.apache.org/r/43457/#review118790
-------
On Feb. 10, 2016, 4:35 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generate
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 1 thrpt5 51.531 ±
7.236 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 5 thrpt5 7.370 ±
1.320 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10 thrpt5 2.143 ±
1.234 ops/s
Thanks,
Zameer
--------
On Feb. 10, 2016, 4:35 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43457/
> -
7fbdcbf50fca7e974e56ed27a91ec682c6c8c3c2
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java
3ce78e355368acb539cd374638be665535bbfd4a
Diff: https://reviews.apache.org/r/43397/diff/
Testing
---
./gradlew build -Pq
e2e tests
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43342/#review118315
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 8, 2016, 2:51 p.m
eviews.apache.org/r/43237/#review118058
---
On Feb. 5, 2016, 10:57 a.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To re
± 28.108 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10 thrpt5 38.883
± 14.443 ops/s
Thanks,
Zameer Manji
± 28.108 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10 thrpt5 38.883
± 14.443 ops/s
Thanks,
Zameer Manji
38.883
± 14.443 ops/s
Thanks,
Zameer Manji
/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10 thrpt5 38.883
± 14.443 ops/s
Thanks,
Zameer Manji
statsProvider.untracked() here.
What's the reason for that?
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43150/#review117687
-------
O
build -Pq
Checked the metrics in vagrant
Thanks,
Zameer Manji
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43150/#review117683
---
On Feb. 3, 2016, 2:23 p.m., Zameer Manji wrote:
>
> --
7674b8af6d18b39153ecdf02015f0970e035e874
src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java
3ab95c615b01f3201e3b87089119abf01d71dbb7
Diff: https://reviews.apache.org/r/43150/diff/
Testing
---
./gradlew build -Pq
Checked the metrics in vagrant
Thanks,
Zameer Manji
---
./gadlew test
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43098/#review117447
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 2, 2016, 9:37 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117488
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 2, 2016, 1:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117520
---
This is on master now.
- Zameer Manji
On Feb. 2, 2016, 3:24
/thermos_executor_main.py (line 62)
<https://reviews.apache.org/r/43112/#comment178698>
Please reference `AURORA-1606` here.
- Zameer Manji
On Feb. 2, 2016, 2:13 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117519
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 2, 2016, 3:24 p.m
/admin.py (line 72)
<https://reviews.apache.org/r/42964/#comment178411>
I think you can just do `options.bypass_leader_redirect` because there is a
default.
- Zameer Manji
On Feb. 1, 2016, 12:05 p.m., Joshua Cohen
e we don't handle a lock timeout.
Done.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42985/#review117049
---------
/DbModule.java
a0344f7f6bf2b468820a2279a36bd6c945d760c0
Diff: https://reviews.apache.org/r/42985/diff/
Testing
---
Thanks,
Zameer Manji
---
Bump virtualenv version for in repo tools.
Diffs
-
build-support/virtualenv 334653bb02e18325a4fc65cc0a0f27d92e82b5c7
Diff: https://reviews.apache.org/r/43066/diff/
Testing
---
git clean -fdx
./rbt
Thanks,
Zameer Manji
401 - 500 of 731 matches
Mail list logo
