Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

536/#comment215530> I'd change this to "- Allow `watch_secs` to be set to 0". - Zameer Manji On Sept. 7, 2016, 3:06 p.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 51667: Remove HttpServletRequestParams

/HttpServletRequestParamsTest.java f1479bfea90bd78cd07d451fc62ca2b4d341d654 Diff: https://reviews.apache.org/r/51667/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

`0c90c862a14c3a5efe0fdf0f30ee41c01b96b434`. - Zameer Manji On Sept. 5, 2016, 11:56 a.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147899 --- Ship it! Ship It! - Zameer Manji On Sept. 5, 2016, 11:56

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Sept. 1, 2016, 12:51 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 467 > > <https://reviews.apache.org/r/51536/diff/3/?file=1489406#file1489406line467> > > > > This is not sufficent to determine if healthcheckin

Re: Review Request 51595: Add Job Store and Dynamic Reservations design docs

shouldn't link to it until someone works on it. - Zameer Manji On Sept. 2, 2016, 2:14 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 51602: Extend the resource isolation and oversubscription documentation

Mesos docs or just the latest version we support at time of writing? - Zameer Manji On Sept. 2, 2016, 7:55 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

we know that this patch is blocked on that review landing first? - Zameer Manji On Sept. 1, 2016, 12:37 p.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

enabling of this feature be a property of the Job or Update? - Zameer Manji On Aug. 31, 2016, 3:08 p.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

> On Aug. 31, 2016, 2:47 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 795-796 > > <https://reviews.apache.org/r/51384/diff/4/?file=1487500#file1487500line795> > > > > +100 > > > > I don't

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

- 796) <https://reviews.apache.org/r/51384/#comment214669> +100 I don't think a client could fetch the entire JobUpdate to get the metadata it attached to the request. - Zameer Manji On Aug. 27, 2016, 8:58 p.m., Santhosh Kumar Shanm

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

> On Aug. 29, 2016, 9:57 a.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 795-796 > > > > > > How about moving this into `JobUpdateSummary` instead? As it stands > > now

Re: Review Request 51469: Remove static Stats method `exportSize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51469/#review147493 --- Bumping for Josh. - Zameer Manji On Aug. 26, 2016, 3:11 p.m

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147490 --- Ship it! Ship It! - Zameer Manji On Aug. 31, 2016, 1:56 p.m

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51536/ > ------- > > (Updated Aug. 30, 2016, 1:52 p.m.) > > > Review

Re: Review Request 51513: Add support for ETags in the Aurora API.

ct that we > > get a different hash each time, even though the content itself has not > > changed. > > > > Considering it is working in some cases, do we have to do something to get > > some speedups for the Aurora UI as well? > > Zameer Manji wrote: > C

Re: Review Request 51513: Add support for ETags in the Aurora API.

ct that we > > get a different hash each time, even though the content itself has not > > changed. > > > > Considering it is working in some cases, do we have to do something to get > > some speedups for the Aurora UI as well? > > Zameer Manji wrote: > C

Re: Review Request 51513: Add support for ETags in the Aurora API.

large enough that > > sending them on the wire and processing them on the client side is causing > > a perf problem)? > > > > At the very least, perhaps we should only buffer the response if the > > `If-None-Match` header is set? > > Zameer Manji wrot

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

> On Aug. 30, 2016, 10:56 a.m., Zameer Manji wrote: > > LGTM modulo updating the docs about restarting all instances at the same > > time. > > > > Could you also file a ticket to track the removal of the `zk_use_curator` > > flag in 0.17? I did not see on

Re: Review Request 51499: Update 3dparty Python dependencies

cates nothing that conerns me. Just saying that if the executor/observer behavious abnormally after this change, it's likely because of that. - Zameer Manji On Aug. 30, 2016, 12:40 a.m., Stephan Erb wrote: > > --- > This

Re: Review Request 51513: Add support for ETags in the Aurora API.

-------- On Aug. 29, 2016, 6:12 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51513/ > ---

Re: Review Request 51513: Add support for ETags in the Aurora API.

a big concern, I could wrap the outputstream of the response and have that compute the hash as bytes are given. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51513/#review147255 -

Re: Review Request 51531: Minor improvements to the custom executor docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51531/#review147324 --- Ship it! Ship It! - Zameer Manji On Aug. 30, 2016, 10:45

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

instances at the same time. Could you also file a ticket to track the removal of the `zk_use_curator` flag in 0.17? I did not see one on JIRA. - Zameer Manji On Aug. 29, 2016, 4:37 p.m., John Sirois wrote: > > --- > This is an auto

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

> > (Updated Aug. 29, 2016, 4:37 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > >

Re: Review Request 51513: Add support for ETags in the Aurora API.

well. I'm willing to add e2e tests and other changes to validate this works via curl if required. Feel free to comment on the idea in the associated ticket. - Zameer Manji On Aug. 29, 2016, 6:12 p.m., Zameer Manji wrote: > > ---

Review Request 51513: Add support for ETags in the Aurora API.

/ApiIT.java 0a3ff05586c87e0ab2cc20470e99b5dd609f7039 Diff: https://reviews.apache.org/r/51513/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51469: Remove static Stats method `exportSize`.

> On Aug. 29, 2016, 9:33 a.m., Maxim Khutornenko wrote: > > Not against this change but rather curious what your thoughts are wrt the > > larger picture here. Are you intending to get rid of all static helps in > > `Stats` in favor of the `StatsProvider`? > > Zamee

Re: Review Request 51469: Remove static Stats method `exportSize`.

r/51469/#review147138 --- On Aug. 26, 2016, 3:11 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

that merits it's own discussion. I believe we configured pants to style checking already. It shouldn't be necessary to do this here. - Zameer Manji On Aug. 27, 2016, 3:33 p.m., Santhosh Kumar Shanmugham wrote: > > --- > T

Re: Review Request 51469: Remove static Stats method `exportSize`.

://reviews.apache.org/r/51469/diff/ Testing --- Thanks, Zameer Manji

Review Request 51469: Remote static stats method `exportSize`.

6d4934b6b6de5273687041174315c4e3d151ac11 src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java e7534c4325afa29b580d890cffdc26bdec7ef938 Diff: https://reviews.apache.org/r/51469/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51366: Unset PYTHONPATH before calling pants

pants project: https://github.com/pantsbuild/setup Have you considered submitting this change upstream instead? - Zameer Manji On Aug. 24, 2016, 5:07 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

lly generated e-mail. To reply, visit: https://reviews.apache.org/r/51348/#review146574 ------- On Aug. 23, 2016, 1:45 p.m., Zameer Manji wrote: > > --- >

Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

/helper.py dda40ed71bf8d26255cdb76eae29a5978a120d41 src/test/python/apache/thermos/core/test_helper.py 35397abd3ec769788f166088e5455c28bb120459 Diff: https://reviews.apache.org/r/51348/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51306: Only warn about terminated executors if their exit code is not 0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51306/#review146452 --- Ship it! Ship It! - Zameer Manji On Aug. 22, 2016, 3:48 p.m

Review Request 51264: Reduce static method exposure for Stats.

bb0af69a89e8f8905e7fd01183d0ac7fe2a49db2 Diff: https://reviews.apache.org/r/51264/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 51045: Remove unnecessary guice container parameters.

"value": 3.0 }, "type": "SCALAR" } ], "slave_id": { "value": "d7716da3-790d-4297-877b-93f724e91335-S0" }, "url": {

Review Request 51045: Remove unnecessary guice container parameters.

/aurora/scheduler/http/api/ApiModule.java e46820952fb6028911bca924169ceade6a134bfc Diff: https://reviews.apache.org/r/51045/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50168: Add rollback functionality to the scheduler

the code before I had a chance. - Zameer Manji On Aug. 11, 2016, 11:07 a.m., Igor Morozov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 50937: Bump jetty dependency to the latest release.

iff: https://reviews.apache.org/r/50937/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50931: Remove unnecessary guice container parameters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50931/#review145258 --- @ReviewBot retry - Zameer Manji On Aug. 9, 2016, 12:53 p.m

Review Request 50931: Remove unnecessary guice container parameters.

etty(9.3.6.v20151106) Thanks, Zameer Manji

Re: Review Request 50685: Support TBinaryProtocol over HTTP

//github.com/apache/aurora/commit/581262ccfb3191083b42e40588dbb5471d52e3c4 - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/#review144797 --- On Aug.

Re: Review Request 50826: Populate the source field of ExecutorInfo.

/MesosTaskFactoryImplTest.java 7484e8b159eb65634f7bd8f0aae61b2e1227e662 Diff: https://reviews.apache.org/r/50826/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50826: Populate the source field of ExecutorInfo.

: https://reviews.apache.org/r/50826/diff/ Testing --- Thanks, Zameer Manji

Review Request 50826: Populate the source field of ExecutorInfo.

/aurora/scheduler/mesos/MesosTaskFactory.java 34134430063b2d24a4e20d3f91ab899604edaf89 Diff: https://reviews.apache.org/r/50826/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50685: Support TBinaryProtocol over HTTP

7dbe48b433262a5b9f7b369d69a0d41e2472b054 src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 31f5cb3bed48eef60c3b2becb2ed285e93f2bd5a Diff: https://reviews.apache.org/r/50685/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50685: Support TBinaryProtocol over HTTP

ecessarily know > > if the use case exists to send json yet want to receive binary, but it's > > more idiomatic HTTP to support that possibility. > > Stephan Erb wrote: > +1 for the accept header > > Zameer Manji wrote: > I tried and wasn't able to ma

Re: Review Request 50685: Support TBinaryProtocol over HTTP

-------- On Aug. 2, 2016, 5:10 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50685/ > -

Re: Review Request 50685: Support TBinaryProtocol over HTTP

/TContentAwareServletTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50685/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50685: Support TBinaryProtocol over HTTP

/TContentAwareServletTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50685/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50685: Support TBinaryProtocol over HTTP

-CREATION Diff: https://reviews.apache.org/r/50685/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50685: Support TBinaryProtocol over HTTP

e.org/r/50685/#review144485 --- On Aug. 1, 2016, 6:29 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 50685: Support TBinaryProtocol over HTTP

.apache.org/r/50685/#review144439 --- On Aug. 1, 2016, 6:29 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 50685: Support TBinaryProtocol over HTTP

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/#review144450 --- On Aug. 1, 2016, 6:29 p.m., Zameer Manji wrote: > > --- > This is an automatically generate

Re: Review Request 50685: Support TBinaryProtocol over HTTP

/ApiModule.java (line 11) <https://reviews.apache.org/r/50685/#comment210451> Reviwers: please note that this is a little light on tests because I want to ensure the approach is acceptable first. - Zameer Manji On Aug. 1, 2016, 6:29 p.m., Zameer Manji

Review Request 50685: Support TBinaryProtocol over HTTP

/apache/aurora/scheduler/http/api/TContentAwareServletTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50685/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 50168: Add rollback functionality to the scheduler

the changes here and include a brief statement in `RELEASE-NOTES.md`. - Zameer Manji On July 28, 2016, 12:06 p.m., Igor Morozov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Review Request 50478: Improve `executorLost` error message.

, Zameer Manji

Re: Review Request 50168: Add rollback functionality to the scheduler

s://reviews.apache.org/r/50168/ > --- > > (Updated July 20, 2016, 8:37 p.m.) > > > Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Bill Farner, and > Zameer Manji. > > > Bugs: AURORA-1721 >

Re: Review Request 50168: Add rollback functionality to the scheduler

ure that we can only rollback updates in the `ROLLING_FORWARD` and the `ROLLED_FORWARD` state when there is no other update in progress. - Zameer Manji On July 20, 2016, 8:37 p.m., Igor Morozov wrote: > > --- > This is an autom

Re: Review Request 47076: Changing ResourceMapper interface arg type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47076/#review132091 --- Ship it! Ship It! - Zameer Manji On May 6, 2016, 11:10 a.m

Re: Review Request 46948: Adding mesos resource converter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46948/#review131735 --- Ship it! Ship It! - Zameer Manji On May 3, 2016, 2:11 p.m

Re: Review Request 46810: Generalizing port resource management.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46810/#review131155 --- Ship it! Ship It! - Zameer Manji On April 29, 2016, 9:43

Re: Review Request 46716: ResourceAggregate schema changes for resource refactoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46716/#review130812 --- Ship it! Ship It! - Zameer Manji On April 26, 2016, 5:31

Re: Review Request 46587: Deprecating --restart-threshold option in 'aurora job restart'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46587/#review130510 --- Ship it! Ship It! - Zameer Manji On April 22, 2016, 2:54

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130506 --- Ship it! Ship It! - Zameer Manji On April 22, 2016, 5:16

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/#review130468 --- Ship it! Ship It! - Zameer Manji On April 22, 2016, 5:38

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

-- > > (Updated April 22, 2016, 5:38 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-945 > https://issues.apache.org/jira/browse/AURORA-945 > > > Repository: aurora > >

Re: Review Request 46459: Schema changes for resource management refactoring

org/r/46459/#comment193835> Perhaps to reduce duplication we could use `ResourceType..getAuroraName()` here instead of hard coding in CPUS, RAM_MB, etc? - Zameer Manji On April 22, 2016, 9:45 a.m., Maxim Khutornenko wrote: > > ---

Re: Review Request 46361: deleting --setuid-health-checks and switching to --nosetuid-health-checks flag to to control whether the executor runs health checks as the job role's user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46361/#review129600 --- Ship it! Ship It! - Zameer Manji On April 18, 2016, 7:31

Re: Review Request 46346: Add @Timed annotations to cron stores.

org/r/46346/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 46346: Add @Timed annotations to cron stores.

ng the metrics. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46346/#review129438 --- On April 18, 2016, 2:0

Review Request 46346: Add @Timed annotations to cron stores.

.java 6a9c73e8e6dd92e9e6361baa0e02ccaf89fce5d7 src/main/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStore.java 365494c0bfca7b633c57bf97762473df458ef1aa Diff: https://reviews.apache.org/r/46346/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 46291: Moving db migration into LogStorage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46291/#review129390 --- Ship it! Ship It! - Zameer Manji On April 18, 2016, 10:29

Re: Review Request 46286: Plumb Curator discovery as an option.

? - Zameer Manji On April 16, 2016, 9:10 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46290/#review129375 --- Ship it! Ship It! - Zameer Manji On April 15, 2016, 4:59

Re: Review Request 46289: Make MyBatis connection pool size configurable.

/storage/db/DbModule.java 743993cef43f028ff0d53d93adacb86f5ed79a5c Diff: https://reviews.apache.org/r/46289/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 46289: Make MyBatis connection pool size configurable.

/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 743993cef43f028ff0d53d93adacb86f5ed79a5c Diff: https://reviews.apache.org/r/46289/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

pache.org/r/46290/#comment192671> please check the .mock_calls[] attribute here. Otherwise a typo as as `mock_getpwnam.asert_not_called()` will hide any test failures. - Zameer Manji On April 15, 2016, 4:31 p.m., Dmitriy Shir

Review Request 46289: Make MyBatis connection pool size configurable.

743993cef43f028ff0d53d93adacb86f5ed79a5c Diff: https://reviews.apache.org/r/46289/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 46167: Replace org.apache.aurora.common.base.Closure with java.util.function.Consumer

/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0256c06ee0794bf50bccaa283c5086da7642f3f6 Diff: https://reviews.apache.org/r/46167/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 46171: Centralize ZooKeeper configuration in discovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46171/#review129162 --- Ship it! Ship It! - Zameer Manji On April 13, 2016, 3:18

Re: Review Request 46171: Centralize ZooKeeper configuration in discovery.

hn Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46171/ > --- > > (Updated April 13, 2016, 3:18 p.m.) > > > Review request for Aurora, Bill Farne

Re: Review Request 46241: Upgrade to Mesos 0.27.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46241/#review129144 --- Ship it! Ship It! - Zameer Manji On April 14, 2016, 6:01

Re: Review Request 46133: Simplify `Credentials`; kill `ZooKeeperClient` dep.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46133/#review128750 --- Ship it! Ship It! - Zameer Manji On April 13, 2016, 8:09

Review Request 46167: Replace org.apache.aurora.common.base.Closure with java.util.function.Consumer

/ Testing --- Thanks, Zameer Manji

Re: Review Request 46111: Introduce a Curator-based `SingletonService`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46111/#review128574 --- Ship it! Ship It! - Zameer Manji On April 12, 2016, 2:21

Re: Review Request 46064: Removing ResourceVector enum in favor of ResourceType

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46064/#review128479 --- Ship it! Ship It! - Zameer Manji On April 11, 2016, 5:03

Re: Review Request 46069: Add a test for invalid member nodes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46069/#review128472 --- Ship it! Ship It! - Zameer Manji On April 11, 2016, 9:44

Re: Review Request 46057: Renaming ResourceType.getName()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46057/#review128279 --- Ship it! Ship It! - Zameer Manji On April 11, 2016, 3:56

Re: Review Request 46051: Moving resource-related classes into a new package

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46051/#review128257 --- Ship it! Ship It! - Zameer Manji On April 11, 2016, 2:23

Re: Review Request 46045: Removing unused quota_check.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46045/#review128215 --- Ship it! Ship It! - Zameer Manji On April 11, 2016, 12:19

Re: Review Request 45992: Make `ServerSet.JSON_CODEC` robust to errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45992/#review128174 --- Ship it! Ship It! - Zameer Manji On April 10, 2016, 1:57

Re: Review Request 45939: Remove support for positional command line arguments,

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45939/#review127844 --- Ship it! Ship It! - Zameer Manji On April 8, 2016, 12:01

Re: Review Request 45936: Remove support for reading command line argument values from files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45936/#review127837 --- Ship it! Ship It! - Zameer Manji On April 8, 2016, 11:32

Re: Review Request 45935: Remove support for canonical command line arg names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45935/#review127830 --- Ship it! Ship It! - Zameer Manji On April 8, 2016, 11:16

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review127713 --- Ship it! Ship It! - Zameer Manji On April 7, 2016, 4:07 p.m

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

> On April 7, 2016, 5:42 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java, > > line 108 > > <https://reviews.apache.org/r/45902/diff/2/?file=1331375#file1331375line108> > > > > Shouldn&#x

<    1   2   3   4   5   6   7   8   9   10   >