to reflect this.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39670/#review104295
---
On Oct. 27, 2015, 9:
to use the
built in pants checkstyle?
- Zameer Manji
On Oct. 29, 2015, 3:05 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39691/#review104186
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 27, 2015, 10:44 a.m
To reply, visit:
https://reviews.apache.org/r/39670/#review104115
-------
On Oct. 26, 2015, 4:16 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39629/#review104235
---
@ReviewBot retry
- Zameer Manji
On Oct. 27, 2015, 4:38 p.m
Thanks,
Zameer Manji
this with benchmark information.
Thanks,
Zameer Manji
Thanks,
Zameer Manji
build -Pq
Thanks,
Zameer Manji
/aurora/scheduler/SchedulerServicesModule.java
7b110b9698440b7e09b777afe430944845530eee
Diff: https://reviews.apache.org/r/39631/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
://reviews.apache.org/r/39631/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
d7d649dc8aaacd98772183fa1429ef8fc84fa20a
src/main/python/apache/aurora/tools/thermos_observer.py
82de0a14b3de2bf3d1b7282fe7dc9fc185d7
Diff: https://reviews.apache.org/r/39629/diff/
Testing
---
e2e tests passed
Thanks,
Zameer Manji
---
Explicitly declare FindBugs version and effort level.
Diffs
-
build.gradle 6c7644ecad6e726cfaa82b6aabc005d8a3b243d3
Diff: https://reviews.apache.org/r/39630/diff/
Testing
---
./gradlew clean build -Pq
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39572/#review103688
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 22, 2015, 4:42 p.m
this is the way to go so long as we
also start the deprecation process.
- Zameer Manji
On Oct. 22, 2015, 2:35 p.m., Kevin Sweeney wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38904/#review101143
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 30, 2015, 12:46 p.m
: https://reviews.apache.org/r/38841/diff/
Testing
---
./gradlew clean test
Thanks,
Zameer Manji
://reviews.apache.org/r/38841/diff/
Testing
---
./gradlew clean test
Thanks,
Zameer Manji
,
Zameer Manji
(line 164)
<https://reviews.apache.org/r/38385/#comment156821>
higher or equal priority.
- Zameer Manji
On Sept. 21, 2015, 2:41 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
(line 355)
<https://reviews.apache.org/r/38390/#comment156819>
What happens if a job with a tier of revocable is sent to a scheduler where
it isn't configured? I think that should be added here.
- Zameer Manji
On Sept. 21, 2015, 2:41 p.m., Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38280/#review99429
---
This is now on master. Thanks for the contribution!
- Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38280/#review99428
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 17, 2015, 12:26 p.m
pty ImmutableMap and get rid of the Optional.
`fetchProperties()` can load the properties and transform it into a Map by
using Guava's `fromProperties` method:
http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/collect/Maps.html#fromProperties%28java.util.Proper
> On Sept. 16, 2015, 2:54 p.m., Zameer Manji wrote:
> > I'm proposing some changes in this review which I think will greatly
> > simplify the code.
>
> Maxim Khutornenko wrote:
> I agree there are ways to improve this functionality but given this is
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38326/#review99252
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 11, 2015, 4:31 p.m
ge.java
> d76596c7422786e58b5a8aa79f324911cfd29b25
> >
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java
> 50838de8708d78fc0bd7ee672b7c7ba02dfcd505
> >
> src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java
> cc9c066556385c073962903691c037b0c07cc94c
> >
>
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
> 6e032a6cef86e5f408bfc0d853a52c7f898d0db8
> >
> > Diff: https://reviews.apache.org/r/38280/diff/
> >
> >
> > Testing
> > ---
> >
> > `./gradlew build -Pq`
> >
> >
> > Thanks,
> >
> > Joe Smith
> >
> >
>
> --
> Zameer Manji
>
>
tomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38326/#review98708
---
On Sept. 11, 2015, 4:31 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apa
and into
org.apache.aurora.scheduler.http.endpoints?
- Zameer Manji
On Sept. 13, 2015, 11:06 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38302/#review98648
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 11, 2015, 8:46 a.m
/thermos_executor_main.py (line 43)
<https://reviews.apache.org/r/38260/#comment154898>
I think this should go to stderr like logging and other diagnostic
information. You can do this by adding the `file` parameter to print and
passing in `sys.stderr`.
- Zameer Manji
On Sept. 10, 2015, 9:30 a.m.
pache/aurora/common/util/BuildInfo.java (line 85)
<https://reviews.apache.org/r/38280/#comment155018>
This should return Optional since it is possible for the
build.info to not be available.
- Zameer Manji
On Sept. 10, 20
review this LGTM.
- Zameer Manji
On Sept. 8, 2015, 4:21 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
387e379a9c84d663f2af23e4760754a023219860
commons/src/test/java/org/apache/aurora/common/collections/BoundedQueueTest.java
d6e3c211542e14406785ff200076f77ac1dc4823
Diff: https://reviews.apache.org/r/38202/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
think you need to `prodDedicatedConsumption` to the set of hashed fields.
- Zameer Manji
On Sept. 2, 2015, 5:46 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
-Type header via vagrant.
Thanks,
Zameer Manji
ream` to signal that it is opaque data that should
not be handled by the browser.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38111/#review97691
---
On Sept. 3, 2015, 3:15 p.m., Zameer Manji wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38106/#review97673
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 3, 2015, 12:14 p.m
is is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -------
>
> (Updated Sept. 2, 2015, 9:45 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38018/#review97340
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 1, 2015, 2:27 p.m
/src/test/java/org/apache/aurora/common/base/ClosuresTest.java
574ab4018e6d7c25e2de18d714d586c23b6a96bd
Diff: https://reviews.apache.org/r/38039/diff/
Testing
---
./gradlew build
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37987/#review97233
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 31, 2015, 8:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97187
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 31, 2015, 3:53 p.m
-Pq
Thanks,
Zameer Manji
it.
- Zameer Manji
On Aug. 27, 2015, 11:16 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37874
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37872/#review96889
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 27, 2015, 9:46 p.m
/testing/mockito/MockitoTest.java
would you mind changing build.gradle and removing the dependency on mockito and
objenesis dependency?
- Zameer Manji
On Aug. 27, 2015, 9:46 p.m., Bill Farner wrote:
---
This is an automatically generated
Farner and Zameer Manji.
Bugs: AURORA-1437
https://issues.apache.org/jira/browse/AURORA-1437
Repository: aurora
Description
---
The external config file is optional for now as tiers are not fully defined
yet.
Diffs
-
examples/vagrant/upstart/aurora-scheduler
that are not expected. I
would expect the scheduler to reject such files because they are malformed.
- Zameer Manji
On Aug. 26, 2015, 6:07 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Aug. 27, 2015, 10:54 a.m., Zameer Manji wrote:
src/test/java/org/apache/aurora/scheduler/TierManagerTest.java, line 26
https://reviews.apache.org/r/37825/diff/1/?file=102#file102line26
Please add a test for the config for having keys that are not expected.
I would
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37807/
---
Review request for Aurora and Bill Farner.
Bugs: AURORA-1442
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37807/
---
(Updated Aug. 26, 2015, 12:26 p.m.)
Review request for Aurora and Bill Farner.
a.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37807/
---
(Updated Aug. 26, 2015, 11:54 a.m.)
Review
add support
for that?
- Zameer Manji
On Aug. 26, 2015, 10:05 a.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37776/#review96566
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 25, 2015, 4:05 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37761/#review96377
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 25, 2015, 8:01 a.m
to non-prod behavior. This change fixes the oversight and delivers
on naming expectations. Nothing else in the tutorial has to change.
Zameer Manji wrote:
I don't mind this change, but it does feel out of place in the diff.
Bill Farner wrote:
Doesn't this mean, though, that quota needs
e-mail. To reply, visit:
https://reviews.apache.org/r/37719/
---
(Updated Aug. 24, 2015, 10:32 a.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1414
https://issues.apache.org/jira/browse/AURORA
the ticket id
here.
src/main/python/apache/aurora/client/config.py (line 60)
https://reviews.apache.org/r/37719/#comment151522
Please create a ticket for this task. You could also repurpose
https://issues.apache.org/jira/browse/AURORA-319
- Zameer Manji
On Aug. 24, 2015, 10:32 a.m., Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666/
---
(Updated Aug. 24, 2015, 4:54 p.m.)
Review request for Aurora, Jake Farrell,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666/
---
(Updated Aug. 24, 2015, 5:03 p.m.)
Review request for Aurora, Jake Farrell,
On Aug. 21, 2015, 11:04 a.m., Maxim Khutornenko wrote:
It would be great to preserve all commit history with this import. Any
chance you could follow the sapling split procedure? It's a bit involved
but pretty well documented here: https://github.com/jsirois/sapling
Zameer Manji
---
On Aug. 20, 2015, 6:04 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666/
---
(Updated Aug. 21, 2015, 11:02 a.m.)
Review request for Aurora, Jake Farrell,
., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666/
---
(Updated Aug. 21, 2015, 11:02 a.m.)
Review request
in build.gradle.
- Zameer Manji
On Aug. 20, 2015, 6:04 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37666/
---
Review request for Aurora, Jake Farrell, Kevin Sweeney, Maxim Khutornenko, and
reviewbot.
- Zameer Manji
On Aug. 19, 2015, 4:49 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37624
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37593/#review95899
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 18, 2015, 3:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37447/#review95334
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 13, 2015, 2:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37455/#review95361
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 13, 2015, 4:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37366/#review95342
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 13, 2015, 2:46 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37206/#review94560
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 6, 2015, 9:12 p.m
)
https://reviews.apache.org/r/37137/#comment148852
My lack of angular knowledge is showing: where is the 'inProgress'
expression defined?
- Zameer Manji
On Aug. 5, 2015, 1:28 p.m., Joshua Cohen wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37137/#review94308
---
Ship it!
Ship It!
- Zameer Manji
On Aug. 5, 2015, 1:28 p.m
On Aug. 5, 2015, 1:49 p.m., Zameer Manji wrote:
src/main/resources/scheduler/assets/css/app.css, line 436
https://reviews.apache.org/r/37137/diff/2/?file=1032840#file1032840line436
If we are going to add the -webkit prefix then I think we should do the
same for -moz. Otherwise I
/TaskScheduler.java (line
101)
https://reviews.apache.org/r/37001/#comment148359
nit: Was it needed to flip the BiCache type here? If not, it would be nice
not to do it to minimize the diff.
- Zameer Manji
On July 31, 2015, 4:03 p.m., Maxim Khutornenko wrote
this review by linking to a ticket (bugs field) and
adding myself (zmanji) under the People field?
- Zameer Manji
On July 22, 2015, 11:06 a.m., Zane Silver wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36697/#review92654
---
Ship it!
Ship It!
- Zameer Manji
On July 22, 2015, 11:29 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36709/#review92661
---
Ship it!
Nice find.
- Zameer Manji
On July 22, 2015, 3:13 p.m
.
- Zameer Manji
On July 22, 2015, 11:29 a.m., Zane Silver wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36697/
---
(Updated July
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36511/#review91788
---
Ship it!
Ship It!
- Zameer Manji
On July 15, 2015, 10:50 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36478/#review91653
---
Ship it!
Ship It!
- Zameer Manji
On July 14, 2015, 10:27 a.m
On July 13, 2015, 3:04 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java, line
14
https://reviews.apache.org/r/36407/diff/1/?file=1008771#file1008771line14
Why not move this class to org.apache.aurora.util? Nothing about
On July 13, 2015, 3:04 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/shims/TaskConstraintShim.java,
line 40
https://reviews.apache.org/r/36407/diff/1/?file=1008765#file1008765line40
Some db view classes provide methods to convert to the immutable
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36407/#review91559
---
Ship it!
Ship It!
- Zameer Manji
On July 10, 2015, 3:47 p.m
to db views.
- Zameer Manji
On July 10, 2015, 3:47 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36407
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36362/#review91148
---
Ship it!
Please complete your commit message.
- Zameer Manji
Why not a lambda here?
src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java
(line 630)
https://reviews.apache.org/r/36357/#comment144409
Why not a lambda here?
- Zameer Manji
On July 9, 2015, 10:59 a.m., Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36357/#review91138
---
Ship it!
Ship It!
- Zameer Manji
On July 9, 2015, 11:22 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36364/#review91157
---
Ship it!
Ship It!
- Zameer Manji
On July 9, 2015, noon, Bill
On July 9, 2015, 11:05 a.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 115
https://reviews.apache.org/r/36357/diff/1/?file=1003739#file1003739line115
Once H2 becomes the default/only in memory storage, are we going to
revisit
On July 9, 2015, 12:47 p.m., Stephan Erb wrote:
I have just looked into the debian packages and noticed that these are
quite different (different resulting packages, different dependencies,
different config such as cluster.json). Shoudn't we aim to make the
packages more similar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36367/#review91181
---
Ship it!
Ship It!
- Zameer Manji
On July 9, 2015, 1:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36370/#review91186
---
Ship it!
Ship It!
- Zameer Manji
On July 9, 2015, 1:29 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36319/#review90932
---
Ship it!
Ship It!
- Zameer Manji
On July 8, 2015, 10:46 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36320/#review90938
---
Ship it!
Ship It!
- Zameer Manji
On July 8, 2015, 10:57 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36329/#review91039
---
Ship it!
Ship It!
- Zameer Manji
On July 8, 2015, 1:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35928/#review90073
---
Ship it!
Ship It!
- Zameer Manji
On July 1, 2015, 10:30 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review89961
---
Ship it!
LGTM.
- Zameer Manji
On June 30, 2015, 12:36 p.m
601 - 700 of 731 matches
Mail list logo
