Re: Review Request 35498: Compute SLA stats for non-prod jobs

> On June 25, 2015, 7:59 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 138-139 > > > > > > Add getters for these fields and access them below via the get

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated July 1, 2015, 7:09 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review89956 --- Ship it! Master (616ef10) is green with this patch. ./build-suppo

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 30, 2015, 9:51 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35498: Compute SLA stats for non-prod jobs

> On June 25, 2015, 5:59 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 138-139 > > > > > > Add getters for these fields and access them below via the get

Re: Review Request 35498: Compute SLA stats for non-prod jobs

> On June 25, 2015, 7:59 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 138-139 > > > > > > Add getters for these fields and access them below via the get

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review89548 --- Ship it! Master (2ef6a05) is green with this patch. ./build-suppo

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 26, 2015, 9 p.m.) Review request for Aurora, Kevin Sweeney and Ma

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review89536 --- This patch does not apply cleanly on master (2ef6a05), do you need t

Re: Review Request 35498: Compute SLA stats for non-prod jobs

> On June 25, 2015, 10:59 a.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 138-139 > > > > > > Add getters for these fields and access them below via the ge

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 26, 2015, 7:45 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35498: Compute SLA stats for non-prod jobs

> On June 25, 2015, 7:59 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 138-139 > > > > > > Add getters for these fields and access them below via the get

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review89394 --- Ship it! src/main/java/org/apache/aurora/scheduler/sla/MetricCalcu

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review89244 --- Ship it! Master (4b8c34c) is green with this patch. ./build-suppo

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 24, 2015, 9:09 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 24, 2015, 9:08 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 23, 2015, 11:13 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88946 --- Ship it! Master (2df2db9) is green with this patch. ./build-suppo

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88802 --- Ship it! Thanks! src/main/java/org/apache/aurora/scheduler/sla/Sl

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88699 --- Ship it! Master (d240926) is green with this patch. ./build-suppo

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 21, 2015, 4:39 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 21, 2015, 4:34 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35498: Compute SLA stats for non-prod jobs

> On June 19, 2015, 8:12 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java, line 65 > > > > > > Since it backs enum, you may want to add something like: > > > > ".

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88562 --- Ship it! Master (589d901) is green with this patch. ./build-suppo

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88552 --- Loogs great overall! Just a few nits/suggestions. src/main/java/or

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 19, 2015, 5:23 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88261 --- src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java (li

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88044 --- Ship it! Master (b09adc6) is green with this patch. ./build-suppo

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 16, 2015, 11:07 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88042 --- src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java (line

Review Request 35498: Compute SLA stats for non-prod jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aur