Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/#review89016 --- Ship it! Master (2df2db9) is green with this patch. ./build-suppo

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/ --- (Updated June 23, 2015, 6 p.m.) Review request for Aurora and Bill Farner. Ch

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Maxim Khutornenko
> On June 23, 2015, 5:49 p.m., Bill Farner wrote: > > docs/storage-config.md, line 103 > > > > > > Consider a significantly higher number as the advice to make it clear, > > e.g. 365days. Done. > On June 23, 2015,

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/#review89007 --- Ship it! LGTM so long as end-to-end tests come up green. docs/sto

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/#review88983 --- Ship it! Master (2df2db9) is green with this patch. ./build-suppo

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/ --- (Updated June 23, 2015, 2:24 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Maxim Khutornenko
> On June 23, 2015, 2:19 a.m., Zameer Manji wrote: > > src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java, line 69 > > > > > > We can remove this test now that the gc executor is gone. Seems like a val

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/#review88901 --- src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/#review88899 --- Master (2df2db9) is red with this patch. ./build-support/jenkins/b

Review Request 35760: Removing GcExecutorLauncher code.

2015-06-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1334 https://issues