Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/#review89407 --- Ship it! Ship It! - Zameer Manji On June 25, 2015, 11:32 a.m., K

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/#review89406 --- Ship it! Master (d28bd4f) is green with this patch. ./build-suppo

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/#review89405 --- Ship it! Ship It! - Bill Farner On June 25, 2015, 6:32 p.m., Kev

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/ --- (Updated June 25, 2015, 11:32 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/ --- (Updated June 25, 2015, 11:12 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-25 Thread Kevin Sweeney
> On June 24, 2015, 3:15 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/util/GuavaCollectors.java, line 36 > > > > > > I think this collector needs to be given the unordered characteristic > > because it

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-24 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/#review89257 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInt

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/#review89255 --- Ship it! Master (d28bd4f) is green with this patch. ./build-suppo

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/ --- (Updated June 24, 2015, 2:52 p.m.) Review request for Aurora, Bill Farner and Z

Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora D