Re: Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954/#review89965 --- Ship it! One nit, but i don't feel strongly about it.

Re: Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954/#review89743 --- src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java

Re: Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954/#review89807 --- Ship it!

Re: Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954/#review89802 --- Ship it! Master (a1af1f6) is green with this patch.

Re: Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954/#review89793 --- Master (a1af1f6) is red with this patch.

Re: Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-29 Thread Zameer Manji
On June 29, 2015, 8:35 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, lines 81-82 https://reviews.apache.org/r/35954/diff/1/?file=993700#file993700line81 I understand what you are trying to do here but we usually don't go that

Re: Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954/ --- (Updated June 29, 2015, 5:06 p.m.) Review request for Aurora, Joe Smith, Maxim

Re: Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954/#review89836 --- Ship it! Master (a1af1f6) is green with this patch.

Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954/ --- Review request for Aurora, Joe Smith, Maxim Khutornenko, and Bill Farner.