Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Maxim Khutornenko
> On Jan. 22, 2016, 7:42 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java, > > line 132 > > > > > > s/consider removing/Remove/, +

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/ --- (Updated Jan. 22, 2016, 9:13 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Maxim Khutornenko
> On Jan. 22, 2016, 7:44 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 444 > > > > > > Nearly forgot - in this branch, you should log and

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115930 --- Fix it, then Ship it!

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Maxim Khutornenko
> On Jan. 22, 2016, 9:19 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 441 > > > > > > Following up from earlier comment - `active()` scoping

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Bill Farner
> On Jan. 22, 2016, 1:19 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 441 > > > > > > Following up from earlier comment - `active()` scoping

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/ --- (Updated Jan. 22, 2016, 9:36 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115939 --- This patch does not apply cleanly against master (2da1700), do

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/ --- (Updated Jan. 22, 2016, 9:43 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115940 --- Ship it!

Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1583

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115910 ---

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115903 --- Ship it! Ship It! - Zameer Manji On Jan. 22, 2016, 10:47 a.m.,

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115905 --- Master (66a4d5f) is red with this patch.

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Maxim Khutornenko
> On Jan. 22, 2016, 9:48 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 439 > > > > > > DRY? I actually meant to only do the

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

2016-01-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115946 --- Ship it! Master (4b3d7bc) is green with this patch.