Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Repository: auro

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/#review131007 --- Master (450d881) is green with this patch. ./build-support/jenki

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/#review131025 --- Is there ever a case where we wouldn't want to show the tier? I.e.

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/#review131026 --- Ship it! Ship It! - Joshua Cohen On April 28, 2016, 11:09 p.

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/#review131028 --- src/main/resources/scheduler/assets/js/controllers.js (line 139)

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Amol Deshmukh
> On April 28, 2016, 6:20 p.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/ --- (Updated April 28, 2016, 7:54 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/#review131042 --- Master (450d881) is green with this patch. ./build-support/jenki

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Joshua Cohen
> On April 29, 2016, 1:20 a.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Bill Farner
> On April 28, 2016, 6:20 p.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-29 Thread Amol Deshmukh
> On April 28, 2016, 6:20 p.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-29 Thread Maxim Khutornenko
> On April 29, 2016, 1:20 a.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-29 Thread Bill Farner
> On April 28, 2016, 6:20 p.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-29 Thread Amol Deshmukh
> On April 28, 2016, 6:20 p.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-05-20 Thread Stephan Erb
> On April 29, 2016, 3:20 a.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-05-23 Thread Maxim Khutornenko
> On April 29, 2016, 1:20 a.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most