Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-04-25 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review172990 --- I see three catgories of timeouts here: (a) Aurora scheduler cann

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-27 Thread Santhosh Kumar Shanmugham
> On March 27, 2017, 3:22 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/client/api/scheduler_client.py > > Line 324 (original), 324 (patched) > > > > > > Could you please elaborate why TransportException

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review170233 --- src/main/python/apache/aurora/client/api/scheduler_client.py Line

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-27 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review170227 --- Ship it! src/main/python/apache/aurora/admin/admin.py Line 242

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review170047 --- Ship it! Master (c32f14c) is green with this patch. ./build-s

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-24 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/ --- (Updated March 24, 2017, 6:30 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review169977 --- Master (c32f14c) is red with this patch. ./build-support/jenkins

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/ --- (Updated March 24, 2017, 4:38 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
> On March 23, 2017, 4:52 p.m., David McLaughlin wrote: > > src/main/python/apache/aurora/admin/admin.py > > Lines 244 (patched) > > > > > > Where is options.no_retry defined? duh ! Bad push my bad. - Karthik --

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review169894 --- src/main/python/apache/aurora/admin/admin.py Lines 244 (patched)

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review169889 --- Ship it! Master (33acb89) is green with this patch. ./build-s

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/ --- (Updated March 23, 2017, 4:23 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review169847 --- Master (33acb89) is red with this patch. ./build-support/jenkins

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/ --- (Updated March 23, 2017, 8:23 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/ --- (Updated March 23, 2017, 8:23 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-03-23 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/ --- (Updated March 23, 2017, 8:22 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-01-10 Thread Stephan Erb
> On Jan. 5, 2017, 12:54 a.m., Karthik Anantha Padmanabhan wrote: > > I was going to wrap this up - but how do people feel about making the all > > endpoints "idempotent" by the following method ? Inlcude an > > "idempotency-token" along as part of the HTTP header. This token is locally > > ca

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-01-05 Thread Karthik Anantha Padmanabhan
> On Jan. 4, 2017, 11:54 p.m., Karthik Anantha Padmanabhan wrote: > > I was going to wrap this up - but how do people feel about making the all > > endpoints "idempotent" by the following method ? Inlcude an > > "idempotency-token" along as part of the HTTP header. This token is locally > > ca

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-01-05 Thread Santhosh Kumar Shanmugham
> On Jan. 4, 2017, 3:54 p.m., Karthik Anantha Padmanabhan wrote: > > I was going to wrap this up - but how do people feel about making the all > > endpoints "idempotent" by the following method ? Inlcude an > > "idempotency-token" along as part of the HTTP header. This token is locally > > cac

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2017-01-04 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review160546 --- I was going to wrap this up - but how do people feel about making

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2016-12-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review159952 --- This change is imporant enough to be mentioned in the release note

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2016-12-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review159911 --- Is it even worth making this a controllable option? I think it's a

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2016-12-21 Thread Karthik Anantha Padmanabhan
> On Dec. 22, 2016, 12:54 a.m., Karthik Anantha Padmanabhan wrote: > > src/main/python/apache/aurora/admin/aurora_admin.py, line 55 > > > > > > In the current implementation we retry only when a `TimeoutError` is >

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2016-12-21 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review159896 --- src/main/python/apache/aurora/admin/aurora_admin.py (line 55)

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2016-12-21 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review159891 --- src/main/python/apache/aurora/admin/aurora_admin.py (line 51)

Re: Review Request 54957: Add option to not retry api calls to the scheduler.

2016-12-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/#review159890 --- Ship it! Master (38b9311) is green with this patch. ./build-s

Review Request 54957: Add option to not retry api calls to the scheduler.

2016-12-21 Thread Karthik Anantha Padmanabhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54957/ --- Review request for Aurora. Repository: aurora Description --- This diff