Re: Review Request 54967: AURORA-1856 Expose stats on deleted job updates in JobUpdateHistoryPruner

2017-01-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54967/#review161315 --- Ship it! Ship It! - Joshua Cohen On Dec. 22, 2016, 7:37

Re: Review Request 54967: AURORA-1856 Expose stats on deleted job updates in JobUpdateHistoryPruner

2017-01-08 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54967/#review160831 --- Ship it! Ship It! - Reza Motamedi On Dec. 22, 2016, 7:37

Re: Review Request 54967: AURORA-1856 Expose stats on deleted job updates in JobUpdateHistoryPruner

2017-01-08 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54967/#review160828 --- Ship it! lgtm! - Kai Huang On Dec. 22, 2016, 7:37 a.m.,

Re: Review Request 54967: AURORA-1856 Expose stats on deleted job updates in JobUpdateHistoryPruner

2016-12-27 Thread Stephan Erb
> On Dec. 22, 2016, 10:04 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java, > > line 87 > > > > > > I have just noticed this is holding the storage lock.

Re: Review Request 54967: AURORA-1856 Expose stats on deleted job updates in JobUpdateHistoryPruner

2016-12-22 Thread Mehrdad Nurolahzade
> On Dec. 22, 2016, 1:04 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java, > > line 87 > > > > > > I have just noticed this is holding the storage lock.

Re: Review Request 54967: AURORA-1856 Expose stats on deleted job updates in JobUpdateHistoryPruner

2016-12-22 Thread Mehrdad Nurolahzade
> On Dec. 22, 2016, 1:04 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java, > > line 87 > > > > > > I have just noticed this is holding the storage lock.

Re: Review Request 54967: AURORA-1856 Expose stats on deleted job updates in JobUpdateHistoryPruner

2016-12-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54967/#review159936 ---

Re: Review Request 54967: AURORA-1856 Expose stats on deleted job updates in JobUpdateHistoryPruner

2016-12-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54967/#review159935 --- Ship it! Ship It! - Stephan Erb On Dec. 22, 2016, 8:37

Review Request 54967: AURORA-1856 Expose stats on deleted job updates in JobUpdateHistoryPruner

2016-12-21 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54967/ --- Review request for Aurora, David McLaughlin and Joshua Cohen. Bugs: