Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166788 --- Ship it! Master (98eb99a) is green with this patch.

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/ --- (Updated Feb. 24, 2017, 11:59 p.m.) Review request for Aurora, Mehrdad

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/ --- (Updated Feb. 24, 2017, 11:50 p.m.) Review request for Aurora, Mehrdad

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

> On Feb. 24, 2017, 3:18 p.m., David McLaughlin wrote: > > Do we have PMC members/committers who are comfortable with accepting major > > feature changes in this manner? This feature proposal has been around for a > > while, and the last time we left it, we were waiting on more iterations on

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166779 --- Master (98eb99a) is red with this patch.

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

> On Feb. 24, 2017, 9:21 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/base/JobKeys.java, line 114 > > > > > > I don't think you need the `components.size() == 4` here. Vanished. Done. >

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166759 --- The overall concept here LGTM. To me this seems to be the right

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166455 --- Ship it! Master (98eb99a) is green with this patch.

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166450 --- @ReviewBot retry - Dmitriy Shirchenko On Feb. 22, 2017, 10:35

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166435 --- Master (98eb99a) is red with this patch.

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166434 --- @ReviewBot retry - Dmitriy Shirchenko On Feb. 22, 2017, 10:35

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166432 --- This patch does not apply cleanly against RB#56690 (98eb99a), do

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review165783 --- This patch does not apply cleanly against RB#56690 (9ea8979), do

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/ --- (Updated Feb. 16, 2017, 12:01 a.m.) Review request for Aurora, Mehrdad

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/ --- (Updated Feb. 15, 2017, 9:09 a.m.) Review request for Aurora, Mehrdad

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review165621 --- Master (9ea8979) is red with this patch.

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/ --- (Updated Feb. 15, 2017, 1:48 a.m.) Review request for Aurora, Mehrdad

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review165607 --- This patch does not apply cleanly against master (0e9c086), do

Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/ --- Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.