Re: Review Request 18484: Count on task timeouts and task pruning to be idempotent, simplifying handling code.

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18484/#review35983 --- Ping? Suman — waiting on a review from you. - Bill Farner On Feb

Re: Review Request 18562: Simplfiy TOC and anchors in remaining docs, among other niceties.

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18562/#review35984 --- Ping? - Bill Farner On Feb. 27, 2014, 4:06 a.m., Bill Farner wrot

Re: Review Request 18562: Simplfiy TOC and anchors in remaining docs, among other niceties.

2014-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18562/#review35985 --- Ship it! I would delegate this to Tom. LGTM AFAICT. - Maxim Khutor

Re: Review Request 18658: GZIP HTTP thrift API responses

2014-03-03 Thread Kevin Sweeney
> On March 1, 2014, 9:23 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java, line 40 > > > > > > I can't think of a good reason to not apply this to /, can you? If so, > >

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review35988 --- src/main/java/org/apache/aurora/scheduler/base/Query.java

Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-03-03 Thread Bill Farner
> On Feb. 26, 2014, 7:30 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line > > 335 > > > > > > How about extracting a private transactionManager field initi

Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/ --- (Updated March 3, 2014, 6:29 p.m.) Review request for Aurora, Kevin Sweeney and

Review Request 18704: Remove LogStream.close, which was a no-op everywhere.

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18704/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description -

Re: Review Request 18704: Remove LogStream.close, which was a no-op everywhere.

2014-03-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18704/#review36010 --- Ship it! Ship It! - Kevin Sweeney On March 3, 2014, 11:05 a.m.,

Re: Review Request 18562: Simplfiy TOC and anchors in remaining docs, among other niceties.

2014-03-03 Thread Tom Galloway
Ship it! Tom On Mon, Mar 3, 2014 at 9:52 AM, Maxim Khutornenko wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18562/ > > Ship it! > > I would delegate this to Tom. LGTM AFAICT. > > > - Maxim Khutornenko > > On February 27th, 2014, 4:06 a.

Re: Review Request 17303: Added getJobSummary API

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/#review36023 --- Looking pretty good now, found a handful of places where comments fr

Re: Review Request 18658: GZIP HTTP thrift API responses

2014-03-03 Thread Bill Farner
> On March 1, 2014, 5:23 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java, line 40 > > > > > > I can't think of a good reason to not apply this to /, can you? If so, > >

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Bill Farner
> On March 3, 2014, 6:06 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/base/Query.java, line 387 > > > > > > To continue this conversation, I don't quite feel merging job > > (role/env/n

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Bill Farner
> On March 1, 2014, 1:32 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/base/JobKeys.java, line 178 > > > > > > "from" is currently intended to unambiguously give a single IJobKey > > ins

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Maxim Khutornenko
> On March 1, 2014, 1:32 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/base/JobKeys.java, line 178 > > > > > > "from" is currently intended to unambiguously give a single IJobKey > > ins

Re: Review Request 18562: Simplfiy TOC and anchors in remaining docs, among other niceties.

2014-03-03 Thread Tom Galloway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18562/#review36038 --- Ship it! Ship It! - Tom Galloway On Feb. 27, 2014, 4:06 a.m., Bi

Re: Review Request 18580: Upgrade mesos to 0.17.0

2014-03-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/#review36050 --- Ship it! Ship It! - Brian Wickman On Feb. 28, 2014, 11:21 p.m.,

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 3, 2014, 11:26 p.m.) Review request for Aurora, Kevin Sweeney an

Review Request 18713: Initiate a teardown of scheduler lifecycle upon application exit.

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18713/ --- Review request for Aurora, Suman Karumuri and Maxim Khutornenko. Repository: au

Review Request 18714: Disable log and initiate shutdown upon log storage failures.

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18714/ --- Review request for Aurora, Kevin Sweeney and Suman Karumuri. Bugs: AURORA-221

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36054 --- src/main/java/org/apache/aurora/scheduler/base/JobKeys.java

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Maxim Khutornenko
> On March 4, 2014, 12:02 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/Query.java, line 78 > > > > > > Iterables.getOnlyELement is a bit of a land mine. An unsuspecting > > caller can hi

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Bill Farner
> On March 4, 2014, 12:02 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/Query.java, line 78 > > > > > > Iterables.getOnlyELement is a bit of a land mine. An unsuspecting > > caller can hi

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Bill Farner
> On March 4, 2014, 12:02 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/Query.java, line 78 > > > > > > Iterables.getOnlyELement is a bit of a land mine. An unsuspecting > > caller can hi

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 4, 2014, 1:03 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36072 --- src/main/java/org/apache/aurora/scheduler/base/JobKeys.java

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36073 --- Ship it! Ship It! - Bill Farner On March 4, 2014, 1:03 a.m., Max

Review Request 18720: Refactored admin client commands to take advantage of new TaskQuery fields.

2014-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18720/ --- Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-239

Re: Review Request 18713: Initiate a teardown of scheduler lifecycle upon application exit.

2014-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18713/#review36077 --- src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java <

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-03-03 Thread Joe Smith
> On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/admin/mesos_maintenance.py, line 73 > > > > > > Inclined to revert this - better to explicitly call out a dependency on > > system t

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-03-03 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334/ --- (Updated March 3, 2014, 6:50 p.m.) Review request for Aurora, Kevin Sweeney, Ma