Re: Review Request 23835: Refactoring SchedulerCore (forceTaskState)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23835/#review48471 --- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/Schedule

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48327 --- Ship it! src/main/java/org/apache/aurora/scheduler/http/api/ApiBet

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23834/ --- (Updated July 23, 2014, 2:36 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

> On July 23, 2014, 2:29 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 779 > > > > > > @Nullable Done. - Maxim -

Review Request 23835: Refactoring SchedulerCore (forceTaskState)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23835/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-94 h

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23834/#review48467 --- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/Schedule

Review Request 23834: Refactoring SchedulerCore (restartShards)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23834/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-94 h

Re: Review Request 23832: Fix constraint violation caused by slave ID change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23832/#review48464 --- Ship it! Ship It! - Maxim Khutornenko On July 23, 2014, 1:25 a.m

Review Request 23832: Fix constraint violation caused by slave ID change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23832/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-596 https://i

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review48459 --- Ship it! Ship It! - Brian Wickman On July 21, 2014, 9:09 p.m., M

Re: Review Request 23471: add support for Mesos masters running with --no-root_submissions, see AURORA-311

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/ --- (Updated July 22, 2014, 4:28 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 23471: add support for Mesos masters running with --no-root_submissions, see AURORA-311

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/ --- (Updated July 22, 2014, 4:28 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 23471: add support for Mesos masters running with --no-root_submissions, see AURORA-311

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/#review48453 --- Ship it! Ship It! - Kevin Sweeney On July 17, 2014, 11:11 a.m.,

Re: Review Request 23718: AURORA-594: RC1 files missing Apache license headers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23718/#review48452 --- Ship it! Ship It! - Kevin Sweeney On July 20, 2014, 1:07 p.m., J

Re: Review Request 23776: Add --stacktrace to gradle build command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23776/#review48451 --- Ship it! Ship It! - Kevin Sweeney On July 21, 2014, 3:27 p.m., B

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48450 --- Ship it! src/main/java/org/apache/aurora/scheduler/http/api/ApiBet

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48449 --- Ship it! lgtm. - David McLaughlin On July 21, 2014, 4:59 p.m.,

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/#review48448 --- Ship it! Ship It! - Kevin Sweeney On July 1, 2014, 6:33 p.m., Bi

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

> On July 22, 2014, 10:52 p.m., David McLaughlin wrote: > > Overall I think this is great. For my own curiosity - any reason why you've > > used gson over the simple JSON protocol that comes with Thrift? > > Bill Farner wrote: > TSimpleJSONProtocol is one-way, so it doesn't solve consumptio

Re: Review Request 23316: Documentation for task health checking and graceful shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23316/#review48446 --- Ship it! Ship It! - Kevin Sweeney On July 7, 2014, 11:34 a.m., B

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

> On July 22, 2014, 10:52 p.m., David McLaughlin wrote: > > Overall I think this is great. For my own curiosity - any reason why you've > > used gson over the simple JSON protocol that comes with Thrift? TSimpleJSONProtocol is one-way, so it doesn't solve consumption of parameters. I original

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48442 --- Overall I think this is great. For my own curiosity - any reason why

Review Request 23827: Filtering out unknown hosts when starting maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23827/ --- Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-443 https://is

Re: Review Request 23244: Fixing return value in _check_sla.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/#review48427 --- Ship it! Ship It! src/main/python/apache/aurora/admin/host_mainte

Re: Review Request 23244: Fixing return value in _check_sla.

> On July 22, 2014, 8:07 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/admin/host_maintenance.py, line 131 > > > > > > Oh, I see. So why not just do "if host_groups and len(host_groups) > 1"? > > The

Re: Review Request 23244: Fixing return value in _check_sla.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/ --- (Updated July 22, 2014, 8:40 p.m.) Review request for Aurora, Joe Smith and Mar

Re: Review Request 23244: Fixing return value in _check_sla.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/#review48418 --- src/main/python/apache/aurora/admin/host_maintenance.py

Re: Review Request 23244: Fixing return value in _check_sla.

> On July 22, 2014, 7:59 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/admin/host_maintenance.py, line 131 > > > > > > What is this initialization doing? I don't see what it changes - it's > > reassi

Re: Review Request 23244: Fixing return value in _check_sla.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/#review48415 --- src/main/python/apache/aurora/admin/host_maintenance.py

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/#review48414 --- Ship it! Ship It! - Kevin Sweeney On July 21, 2014, 4:23 p.m., M

Re: Review Request 23823: Upgrade jersey version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23823/#review48413 --- Ship it! Ship It! - Maxim Khutornenko On July 22, 2014, 7:42 p.m

Review Request 23823: Upgrade jersey version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23823/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti

Re: Review Request 23782: Revert "Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23782/#review48408 --- Ship it! Ship It! - Kevin Sweeney On July 21, 2014, 5:29 p.m., B

Re: Review Request 23779: Fix filter spec for leader redirect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23779/#review48407 --- Ship it! Thanks for setting up this test infrastructure - Kevin Sw

Re: Review Request 23817: Do not rely upon pytest capsys since command line parameters alter outcome.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23817/#review48381 --- Ship it! Ship It! - Kevin Sweeney On July 22, 2014, 9:27 a.m., B

Re: Review Request 23244: Fixing return value in _check_sla.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/ --- (Updated July 22, 2014, 4:41 p.m.) Review request for Aurora, Joe Smith and Mar

Re: Review Request 23817: Do not rely upon pytest capsys since command line parameters alter outcome.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23817/#review48371 --- Ship it! Ship It! - Bill Farner On July 22, 2014, 4:27 p.m., Bri

Review Request 23817: Do not rely upon pytest capsys since command line parameters alter outcome.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23817/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-595

Re: Review Request 23455: Add a lightweight version of command hooks for clientv1 commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23455/ --- (Updated July 22, 2014, 10:49 a.m.) Review request for Aurora, Joe Smith and Ke

Re: Review Request 23455: Add a lightweight version of command hooks for clientv1 commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23455/#review48362 --- src/main/python/apache/aurora/client/commands/core.py