. SUCCESS
src.test.python.apache.aurora.client.cli.quota
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
tps://reviews.apache.org/r/21273/#comment77289>
Same thing the bindings parameters always do. The bindings are a dictionary
of Pystachio bindings that get applied to the config.
- Mark Chu-Carroll
On May 13, 2014, 2:09 p.m., Mark Chu-Carroll
/http/ui/js/controllers.js
<https://reviews.apache.org/r/21523/#comment77304>
Why?
- Mark Chu-Carroll
On May 15, 2014, 9:30 p.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/#review43264
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 15, 2014, 9:30 p.m
h the updated doc.)
Diffs (updated)
-
docs/clientv2.md PRE-CREATION
Diff: https://reviews.apache.org/r/18979/diff/
Testing
---
n/a
Thanks,
Mark Chu-Carroll
. (Includes two new tests, that ensure
that calling the new APIs causes the right internal cron methods to be called.)
Thanks,
Mark Chu-Carroll
w. Did you not
notice those, or is there a particular kind of test that you're looking for?
- Mark Chu-Carroll
On May 19, 2014, 11:25 a.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically genera
> On May 19, 2014, 5:11 p.m., Mark Chu-Carroll wrote:
> > src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java,
> > line 147
> > <https://reviews.apache.org/r/21383/diff/3/?file=584300#file584300line147>
> >
> > Just to be clear: the
ernal cron methods to be called.)
Thanks,
Mark Chu-Carroll
cquiring a lock"
src/main/python/apache/aurora/client/api/updater.py
<https://reviews.apache.org/r/21440/#comment77724>
"using a" better than "with the"
src/main/python/apache/aurora/client/api/updater.py
<https://reviews.apache.org/r/21440/#comment7772
calling the new APIs causes the right internal cron methods to be called.)
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21740/#review43566
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 20, 2014, 8:21 p.m
tps://reviews.apache.org/r/21740/#comment77806>
This TODO should be removed - run is working now.
- Mark Chu-Carroll
On May 20, 2014, 8:21 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
/scheduler_client.py
<https://reviews.apache.org/r/21739/#comment77808>
Not necessary, but you could just use a patch in the test, instead of
changing this.
- Mark Chu-Carroll
On May 20, 2014, 7:57 p.m., Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21662/#review43568
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 19, 2014, 5:24 p.m
tps://reviews.apache.org/r/21597/#comment77810>
Why are these split into multiple methods? The only place where
"check_and_log_locked" is used is right here.
- Mark Chu-Carroll
On May 19, 2014, 1:58 p.m., Maxim Khutornenko wrote:
>
>
ct, I know that I got some style errors earlier on in this
change. Did something change?
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21383/#review43575
------------
calling the new APIs causes the right internal cron methods to be called.)
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21597/#review43634
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 21, 2014, 12:05 p.m
src.test.python.apache.aurora.client.config
. SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21812/#review43715
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 22, 2014, 10:31 a.m
-
>
> (Updated May 22, 2014, 5:58 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim
> Khutornenko.
>
>
> Bugs: AURORA-461
> https://issues.apache.org/jira/browse/AURORA-461
>
>
> Repository: aurora
>
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21848/#review43828
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 23, 2014, 2:14 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43972
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 23, 2014, 3:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/#review43982
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 22, 2014, 9:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review43983
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 22, 2014, 9:12 p.m
-mail. To reply, visit:
> https://reviews.apache.org/r/21830/
> ---
>
> (Updated May 27, 2014, 1:39 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim
> Khutornenko.
>
>
> Bugs: AURORA-461
> https://issues.apache.org/jira/browse/AUR
mining instances: [0]
log(info): Killing instances: [0]
log(info): Instances killed
log(info): Adding instances: [0]
log(info): Instances added
log(info): Watching instances: [0]
{noformat}
Thanks,
Mark Chu-Carroll
urora'
log(info): Updating job: http_example
log(info): Starting job update.
log(info): Examining instances: [0]
log(info): Killing instances: [0]
log(info): Instances killed
log(info): Adding instances: [0]
log(info): Instances added
log(info): Watching instances: [0]
{noformat}
Thanks,
Mark Chu-Carroll
tyle for Python on apache? I didn't think so. But why would
a logging import not be OK?
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21980/#review44144
--
> On May 28, 2014, 2:49 p.m., David McLaughlin wrote:
> > I don't have all the context, but it seems unusual to me to add a log level
> > for this use case. Can you explain a little why this is needed?
>
> Mark Chu-Carroll wrote:
> Sure. We're tryi
ng to get to this, but never
had time.
src/main/python/apache/aurora/config/__init__.py
<https://reviews.apache.org/r/21943/#comment78548>
I don't think this check is necessary: you've got a jobkey - pystachio will
reject it if they're not bound.
- Mark Chu-Carro
workflow
more complicated, and I'm not clear on what benefits it produces in exchange.
- Mark Chu-Carroll
On May 29, 2014, 12:43 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
Mark Chu-Carroll
. SUCCESS
Thanks,
Mark Chu-Carroll
/test_update.py
a2abc5eb0f11f9bc563f4504c93fcf5b7520d141
src/test/python/apache/aurora/client/cli/util.py
dac4928111200136a9987c9622087e8cdca7f2d2
Diff: https://reviews.apache.org/r/22023/diff/
Testing
---
Ran all client unit tests, plus v2 version of e2e.
Thanks,
Mark Chu-Carroll
Instances added
log(info): Watching instances: [0]
{noformat}
Thanks,
Mark Chu-Carroll
nks,
Mark Chu-Carroll
Ran all client unit tests, plus v2 version of e2e.
Thanks,
Mark Chu-Carroll
> On May 29, 2014, 7:58 a.m., Mark Chu-Carroll wrote:
> > Why?
> >
> > Right now, I do a lot of debugging of the client using vagrant. My typical
> > workflow is:
> > - Make the change in my git workspace.
> > - Commit it to a branch.
> > - vagran
> On May 29, 2014, 7:58 a.m., Mark Chu-Carroll wrote:
> > Why?
> >
> > Right now, I do a lot of debugging of the client using vagrant. My typical
> > workflow is:
> > - Make the change in my git workspace.
> > - Commit it to a branch.
> > - vagran
://reviews.apache.org/r/22082/diff/
Testing
---
All client unit tests run and passed.
Thanks,
Mark Chu-Carroll
> On May 29, 2014, 7:58 a.m., Mark Chu-Carroll wrote:
> > Why?
> >
> > Right now, I do a lot of debugging of the client using vagrant. My typical
> > workflow is:
> > - Make the change in my git workspace.
> > - Commit it to a branch.
> > - vagran
> On May 29, 2014, 7:58 a.m., Mark Chu-Carroll wrote:
> > Why?
> >
> > Right now, I do a lot of debugging of the client using vagrant. My typical
> > workflow is:
> > - Make the change in my git workspace.
> > - Commit it to a branch.
> > - vagran
/apache/aurora/client/binding_helper.py
47448e061c4afd85b88ee3f106f49884e2369e8a
Diff: https://reviews.apache.org/r/22082/diff/
Testing
---
All client unit tests run and passed.
Thanks,
Mark Chu-Carroll
x27;s worth being complete here.
- Mark Chu-Carroll
On May 29, 2014, 3:30 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
;t done it, so
I have no idea what's involved.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/#review44289
---
On May 29
ION
Diff: https://reviews.apache.org/r/22032/diff/
Testing
---
n/a
Thanks,
Mark Chu-Carroll
ION
Diff: https://reviews.apache.org/r/22032/diff/
Testing
---
n/a
Thanks,
Mark Chu-Carroll
got an identical "print_results" function in utils. Why?
src/main/python/apache/aurora/client/commands/maintenance.py
<https://reviews.apache.org/r/22167/#comment79151>
I don't understand this replacement: why did you get rid of the post-drain
stuff?
- Mark Chu-Carro
https://reviews.apache.org/r/22023/diff/
Testing
---
Ran all client unit tests, plus v2 version of e2e.
Thanks,
Mark Chu-Carroll
4b3e1499c7447792288f4b480cbd756c8e19a831
src/test/sh/org/apache/aurora/e2e/http_example.py
04f7fa5c9bf36a36b395d870db02b97f8e5b6c66
Diff: https://reviews.apache.org/r/22233/diff/
Testing
---
Added check to unit tests; all client tests pass.
Thanks,
Mark Chu-Carroll
check to unit tests; all client tests pass.
Thanks,
Mark Chu-Carroll
src/test/sh/org/apache/aurora/e2e/http_example.py
04f7fa5c9bf36a36b395d870db02b97f8e5b6c66
Diff: https://reviews.apache.org/r/22243/diff/
Testing
---
Thanks,
Mark Chu-Carroll
it's even harder to refactor as you suggest - this does a conditional
return. To abstract this out, we'd need to switch to an exception throw, which
would be more complex and less clear.
- Mark Chu-Carroll
On June
ra Client v1 ==
Supported commands are: cancel_update, create, diff, get_quota, inspect, kill,
list_jobs, open, restart, run, ssh, start_cron, status, update, version
Run './dist/aurora2.pex help _command_' for help on a specific command
Thanks,
Mark Chu-Carroll
/python/apache/aurora/client/cli/test_api_from_cli.py PRE-CREATION
Diff: https://reviews.apache.org/r/22274/diff/
Testing
---
Added new unit tests, ran all tests successfully.
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22281/#review44896
---
Ship it!
Ship It!
- Mark Chu-Carroll
On June 5, 2014, 7 p.m
t/cli/util.py
dac4928111200136a9987c9622087e8cdca7f2d2
Diff: https://reviews.apache.org/r/22023/diff/
Testing
---
Ran all client unit tests, plus v2 version of e2e.
Thanks,
Mark Chu-Carroll
://reviews.apache.org/r/22307/diff/
Testing
---
Ran tests with gradlew.
Thanks,
Mark Chu-Carroll
dac4928111200136a9987c9622087e8cdca7f2d2
Diff: https://reviews.apache.org/r/22023/diff/
Testing
---
Ran all client unit tests, plus v2 version of e2e.
Thanks,
Mark Chu-Carroll
070718caaf912374f00fa89fdb9266ab95b3c483
Diff: https://reviews.apache.org/r/22023/diff/
Testing
---
Ran all client unit tests, plus v2 version of e2e.
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22334/#review44986
---
Ship it!
Ship It!
- Mark Chu-Carroll
On June 6, 2014, 7:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22280/#review45108
---
Ship it!
Approach looks good to me.
- Mark Chu-Carroll
On June
tps://reviews.apache.org/r/22167/#comment79777>
Are you sure you uploaded the correct diff? In your reply to the review,
you said you'd added docs here - but I still don't see any.
- Mark Chu-Carroll
On June 3, 2014, 9:46 p.m., Maxim K
s://reviews.apache.org/r/22243/diff/
Testing
---
Thanks,
Mark Chu-Carroll
view44881
---
On June 5, 2014, 10:02 a.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
a certain percentage of tasks must
have been up all the time? Time period over which a percentage of tasks must
have been up for at least some amount of time?
- Mark Chu-Carroll
On June 3, 2014, 9:46 p.m., Maxim Khutornenko wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45164
---
Ship it!
Ship It!
- Mark Chu-Carroll
On June 9, 2014, 6:08 p.m
> On June 9, 2014, 4:43 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/maintenance.py, line 72
> > <https://reviews.apache.org/r/22167/diff/3/?file=603316#file603316line72>
> >
> > This help line is unclear: what does "ti
;help noun verb' for help about a specific command
== help for Aurora Client v1 ==
Supported commands are: cancel_update, create, diff, get_quota, inspect, kill,
list_jobs, open, restart, run, ssh, start_cron, status, update, version
Run './dist/aurora2.pex help _command_' for help on a specific command
Thanks,
Mark Chu-Carroll
diff" tests
of the new functionality.
All tests pass.
Thanks,
Mark Chu-Carroll
o see it get into
today's client deploy.
- Mark Chu-Carroll
On June 3, 2014, 1:07 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
!
- Mark Chu-Carroll
On June 4, 2014, 1:09 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
iff.py PRE-CREATION
Diff: https://reviews.apache.org/r/22457/diff/
Testing
---
New unit tests of the JSON tree diff code, plus a bunch of new "job diff" tests
of the new functionality.
All tests pass.
Thanks,
Mark Chu-Carroll
g the right thing, we can
move it to api.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22457/#review45382
-----------
On June 11, 2014, 11 a.m., Mark Chu-Carroll wrote:
>
> ---
ran all client tests.
Thanks,
Mark Chu-Carroll
c21159c4af3fa3b21b271d94a1b0edbed49a76c8
src/test/python/apache/aurora/client/cli/test_task_run.py
167f4906c2d752ca188b83bf0e775bf6ad527073
Diff: https://reviews.apache.org/r/22233/diff/
Testing
---
Added check to unit tests; all client tests pass.
Thanks,
Mark Chu-Carroll
ve to root, to a local path (./work/code/foo) relative to
"/u/users/markcc" is rebasing.
- Mark Chu-Carroll
On June 11, 2014, 11 a.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generat
rg/r/22457/diff/
Testing
---
New unit tests of the JSON tree diff code, plus a bunch of new "job diff" tests
of the new functionality.
All tests pass.
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22457/#review45749
---
ping?
- Mark Chu-Carroll
On June 13, 2014, 4:22 p.m., Mark Chu
or 1, depending
on whether or not they found differences.
- Mark Chu-Carroll
On June 13, 2014, 4:22 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22662/#review45861
---
Ship it!
Ship It!
- Mark Chu-Carroll
On June 16, 2014, 7:09 p.m
But we know that these json trees are thrift; I'm exploiting the way that
thrift serializes as lists and dicts to build the diff. And thrift doesn't
allow "." in field names.
- Mark
---
This is an auto
roblem; but for people
who rely on the current diff
behavior, I'd rather not change that.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22457/#review45835
-----------
New unit tests of the JSON tree diff code, plus a bunch of new "job diff" tests
of the new functionality.
All tests pass.
Thanks,
Mark Chu-Carroll
> > Without sorting, the diff will only work 99% of the time. This has been
> > demonstrated in a few real-life job updates.
>
> Mark Chu-Carroll wrote:
> This isn't a new thing in this updated diff system - this is the current
> behavior.
>
>
> > Without sorting, the diff will only work 99% of the time. This has been
> > demonstrated in a few real-life job updates.
>
> Mark Chu-Carroll wrote:
> This isn't a new thing in this updated diff system - this is the current
> behavior.
>
>
> > Without sorting, the diff will only work 99% of the time. This has been
> > demonstrated in a few real-life job updates.
>
> Mark Chu-Carroll wrote:
> This isn't a new thing in this updated diff system - this is the current
> behavior.
>
>
> > Without sorting, the diff will only work 99% of the time. This has been
> > demonstrated in a few real-life job updates.
>
> Mark Chu-Carroll wrote:
> This isn't a new thing in this updated diff system - this is the current
> behavior.
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22747/#review46309
---
Ship it!
Ship It!
- Mark Chu-Carroll
On June 20, 2014, 2:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22746/#review46310
---
Ship it!
Ship It!
- Mark Chu-Carroll
On June 18, 2014, 2:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22701/#review46311
---
Ship it!
Ship It!
- Mark Chu-Carroll
On June 17, 2014, 7:25 p.m
src/test/python/apache/aurora/client/cli/test_plugins.py
ce85318727dcaf22a696d05f99c49b5e953bd3ca
Diff: https://reviews.apache.org/r/22839/diff/
Testing
---
- Added new test.
- Ran all unit tests.
- Did manual command-line testing.
Thanks,
Mark Chu-Carroll
//reviews.apache.org/r/22839/#review46325
-------
On June 20, 2014, 4:47 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail. To
> On June 20, 2014, 5:30 p.m., Brian Wickman wrote:
> > not a big fan of globals here. can you instead annotate the context with
> > the exception and in post-dispatch have the plugin print it out if
> > --reveal-errors is set?
>
> Mark Chu-Carroll wrote:
>
> On June 20, 2014, 5:30 p.m., Brian Wickman wrote:
> > not a big fan of globals here. can you instead annotate the context with
> > the exception and in post-dispatch have the plugin print it out if
> > --reveal-errors is set?
>
> Mark Chu-Carroll wrote:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22486/#review46463
---
Ship it!
Ship It!
- Mark Chu-Carroll
On June 11, 2014, 8:07 p.m
unit tests.
- Did manual command-line testing.
Thanks,
Mark Chu-Carroll
> > Without sorting, the diff will only work 99% of the time. This has been
> > demonstrated in a few real-life job updates.
>
> Mark Chu-Carroll wrote:
> This isn't a new thing in this updated diff system - this is the current
> behavior.
>
>
301 - 400 of 569 matches
Mail list logo
