<https://reviews.apache.org/r/28617/#comment107722>
staticallyBannedOffers is only filled but never cleared. Looks like we will
be leaking memory.
- Stephan Erb
On Dec. 8, 2014, 10:57 p.m., Maxim Khutornenko wrote:
>
> ---
/LocalServiceRegistryWithOverrides.java
<https://reviews.apache.org/r/29464/#comment109798>
To be consistent with mesos, how about calling this one "--hostname"?
- Stephan Erb
On Dec. 29, 2014, 8:23 p.m., Steve Niemitz wrote:
>
> ---
tps://reviews.apache.org/r/29464/#comment109948>
It seems that you can simplify your code significantly if you just read the
'slaveHost' attribute form the 'AssignedTask' instance passed into your method.
(I am not an Aurora committer so I be wrong here.)
> On Dec. 31, 2014, 12:51 a.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/common/announcer.py, line 82
> > <https://reviews.apache.org/r/29464/diff/3/?file=804038#file804038line82>
> >
> > It seems that you can simplify your code signif
ent109952>
How about injecting the hostname value into the constuctor of
DefaultThermosTaskRunnerProvider when you create it? This would allow you to
get rid of the remaining setter functions.
- Stephan Erb
On Dec. 31, 2014, 12:23 a.m., Steve N
/requirements.txt). Is it safe to update just one of them?
- Stephan Erb
On Jan. 30, 2015, 10:07 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Jan. 30, 2015, 10:55 p.m., Stephan Erb wrote:
> > What about the other references to 0.20.1? (e.g.,
> > 3rdparty/python/requirements.txt). Is it safe to update just one of them?
>
> Kevin Sweeney wrote:
> +1, please refer to previous mesos upgrade patches
hin an overload of the `getWeaklyConsistentOffers` method.
- Stephan Erb
On Feb. 11, 2015, 9:38 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
your change however, no
task would be considered running until this worst case time window has passed.
A potential solution would be to change the meaning of `initial_interval_secs`
to always send health checks but to ignore any errors.
- Stephan Erb
On Feb. 18, 2015, 4:32 a.m., Moses Nakamura
Diff: https://reviews.apache.org/r/31350/diff/
Testing
---
./pants test.pytest --no-fast src/test/python/apache/aurora/common::
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/#review73806
---
@ReviewBot retry
- Stephan Erb
On Feb. 24, 2015, 11:57 a.m
/python/apache/aurora/common/test_clusters.py
1bd696e9cd28d87d0cac68b33ab043407d796b61
Diff: https://reviews.apache.org/r/31350/diff/
Testing
---
./pants test.pytest --no-fast src/test/python/apache/aurora/common::
Thanks,
Stephan Erb
> On Feb. 24, 2015, 7:01 a.m., Joshua Cohen wrote:
> >
>
> Steve Niemitz wrote:
> I'm not a big fan of how the parsing works here either. I was thinking
> about this last night, I think I have a better plan here. Lemme know what
> you think.
>
> I already want to add volume supp
/MesosTaskFactory.java
<https://reviews.apache.org/r/31338/#comment120230>
This code will also work for a default Mesos container on a slave with the
`filesystem/shared` isolator.
Is it worth to generalize here and make mounting work for docker and
non-docker containers?
- Stephan Erb
On F
/diff/
Testing
---
./pants test.pytest --no-fast src/test/python/apache/aurora/common::
Thanks,
Stephan Erb
ur.
- Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/#review73867
---
On Feb. 24, 2015, 10:52 p.m., St
c4b7fefca30313b281808478bf23158a9b7fbf85
src/test/python/apache/aurora/common/test_clusters.py
1bd696e9cd28d87d0cac68b33ab043407d796b61
Diff: https://reviews.apache.org/r/31350/diff/
Testing
---
./pants test.pytest --no-fast src/test/python/apache/aurora/common::
Thanks,
Stephan Erb
tps://reviews.apache.org/r/31491/#comment120932>
You have secured all `self._state` accesses with a check that the latter is
defined, all except this one.
- Stephan Erb
On Feb. 26, 2015, 9 p.m., Brian Wickman wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31491/#review74367
---
Ship it!
Ship It!
- Stephan Erb
On Feb. 26, 2015, 9 p.m., Brian
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350/#review75203
---
On Feb. 24, 2015, 11:12 p.m., Stephan Erb wrote:
>
> ---
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java
<https://reviews.apache.org/r/31739/#comment122217>
Is this the same single threaded scheduler used for ordinary scheduling?
(Otherwise I would expect races)
- Stephan Erb
On March 4, 2015, 8:30 p.m., Maxim
422d5a9a42310979752eb7282658316c2b772419
Diff: https://reviews.apache.org/r/32181/diff/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
31aa2bbaab3d97875493ad75c4d2c7c82ac7fa58
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java
422d5a9a42310979752eb7282658316c2b772419
Diff: https://reviews.apache.org/r/32181/diff/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
Collect` and performing it
directly in `willUse`?
- Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32181/#review76841
------------
loglevel for insufficient GC resources to fine
Diffs
-
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java
31aa2bbaab3d97875493ad75c4d2c7c82ac7fa58
Diff: https://reviews.apache.org/r/32208/diff/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32208/#review76934
---
@ReviewBot retry
- Stephan Erb
On March 18, 2015, 7:28 p.m
nt and might need to be tuned.
- Stephan Erb
On March 21, 2015, 3:22 a.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/PendingTaskProcessor.java
<https://reviews.apache.org/r/32352/#comment125254>
Slotes computed here might have overlapping victims. A simple way to
mitigate this problem could be to properly randomize the slave traversal order
in `findPreemptionSlotFor`
- Stephan Erb
On March 21, 2015, 3:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32359/#review77471
---
Ship it!
- Stephan Erb
On March 23, 2015, 7:10 p.m., Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32352/#review77474
---
Ship it!
Ship It!
- Stephan Erb
On March 21, 2015, 3:19 a.m
> On March 22, 2015, 11:04 a.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java,
> > line 107
> > <https://reviews.apache.org/r/32352/diff/1/?file=902121#file902121line107>
> >
> > Slot
31 matches
Mail list logo
