Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-27 Thread Mark Chu-Carroll
Bill: It's been 24 hours, and I'm still waiting on a clarification request. Please, can you take a minute, and answer, so that I can get this review done? -Mark On Wed, Mar 26, 2014 at 3:28 PM, Mark Chu-Carroll mchucarr...@twopensource.com wrote: This is an automatically generated

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38788 --- Ship it! Ship It! - Brian Wickman On March 26, 2014, 6:08 p.m.,

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-25 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38480 --- Ping? - Mark Chu-Carroll On March 24, 2014, 2:58 p.m., Mark

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-25 Thread Brian Wickman
On March 24, 2014, 6:57 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/options.py, lines 121-124 https://reviews.apache.org/r/19431/diff/4/?file=532893#file532893line121 all was never revealed to users, and we've decided to get rid of it. It will never

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-25 Thread Mark Chu-Carroll
Not uncaught: it gets handled exactly the way that all invalid parameters get handled - the exception gets thrown in the parser, it bubbles up, and gets caught by the framework and turned into an error: [sun-wukong incubator-aurora (instance-syntax)]$ ./dist/client.pex job kill

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38336 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-24 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- (Updated March 24, 2014, 2:58 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-24 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38338 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- (Updated March 22, 2014, 10:14 a.m.) Review request for Aurora, Bill Farner

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38162 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- (Updated March 21, 2014, 3:56 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38196 --- src/main/python/apache/aurora/client/cli/options.py

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review37930 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-20 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review37933 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-20 Thread Bill Farner
On March 20, 2014, 6:27 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 293 https://reviews.apache.org/r/19431/diff/1/?file=528673#file528673line293 The instance syntax is mandatory for commands that can operate on instances. The parser is

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review37936 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-20 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- (Updated March 20, 2014, 2:48 p.m.) Review request for Aurora, Bill Farner and

Review Request 19431: Add instance specifier syntax to clientv2

2014-03-19 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-268