Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/ --- Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim Khutorn

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43796 --- This will not pass python tests as we reference resp.message in quit

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43801 --- Ship it! Looks great; thanks for doing this so quickly! - Mark Chu

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

> On May 23, 2014, 12:07 a.m., Maxim Khutornenko wrote: > > This will not pass python tests as we reference resp.message in quite a few > > places. Doh! You're right, i published this in haste before leaving the office. I'll fix that up shortly. - Bill ---

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/ --- (Updated May 23, 2014, 7:30 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43868 --- Also passes old and new end-to-end tests. - Bill Farner On May 23

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43870 --- Ship it! Ship It! - David McLaughlin On May 23, 2014, 7:30 p.m.,

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43972 --- Ship it! Ship It! - Mark Chu-Carroll On May 23, 2014, 3:30 p.m.,

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43977 --- src/main/java/org/apache/aurora/scheduler/thrift/Util.java

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

> On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 > > > > > > Would it make sense to change it to list instead? I can imagine how the > > order may b

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/ --- (Updated May 27, 2014, 5:39 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

> On May 27, 2014, 12:36 p.m., Maxim Khutornenko wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 > > > > > > Would it make sense to change it to list instead? I can imagine how the > > order may

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

> On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, > > line 49 > > > > > > We don't inline @Inject with methods, why here? > > Bill

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

> On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 > > > > > > Would it make sense to change it to list instead? I can imagine how the > > order may b

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

> On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 > > > > > > Would it make sense to change it to list instead? I can imagine how the > > order may b

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

> On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 > > > > > > Would it make sense to change it to list instead? I can imagine how the > > order may b

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/ --- (Updated May 27, 2014, 9:57 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review44055 --- Ship it! Ship It! - Maxim Khutornenko On May 27, 2014, 9:57 p.m.

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/ --- (Updated May 27, 2014, 11 p.m.) Review request for Aurora, David McLaughlin, Ma