[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8684 ) Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners .. IMPALA-3804: Re-enable

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-06 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8783 to look at the new patch set (#4). Change subject: IMPALA-6286: Remove invalid runtime filter targets.

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-06 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8783 to look at the new patch set (#3). Change subject: IMPALA-6286: Remove invalid runtime filter targets.

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8639 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8788 Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. IMPALA-6285: Don't print stack trace on RPC errors. There is not

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-06 Thread Bikramjeet Vig (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8660 to look at the new patch set (#2). Change subject: IMPALA-5929: Remove redundant explicit casts to string

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8660 ) Change subject: IMPALA-5929: Remove redundant explicit casts to string .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 1: (6 comments) Thanks for the quick review!

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-06 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8783 to look at the new patch set (#2). Change subject: IMPALA-6286: Remove invalid runtime filter targets.

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8783 ) Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. Patch Set 1: (6 comments) still getting the hang of

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-06 Thread Kim Jin Chul (Code Review)
Hello Michael Ho, Jim Apple, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8355 to look at the new patch set (#16). Change subject: IMPALA-5754: Improve randomness of rand()/random()

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 15: The third party library is officially released

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-06 Thread Kim Jin Chul (Code Review)
Hello Michael Ho, Jim Apple, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8355 to look at the new patch set (#15). Change subject: IMPALA-5754: Improve randomness of rand()/random()

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 17: Code-Review+1 Did you want to have

[Impala-ASF-CR] IMPALA-6281: Fix use-after-free in InitAuth()

2017-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8777 ) Change subject: IMPALA-6281: Fix use-after-free in InitAuth() .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: I spoke to Gabor about this a few days ago. I agree it would

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8684 ) Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8781 ) Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation .. Patch Set 1: (10 comments) I like the

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-06 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 1: The earlier attempt

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-06 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8784 Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. IMPALA-6225: Part 2: Query profile

[Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker

2017-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8782 ) Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6286: Remove invalid runtime filter targets.

2017-12-06 Thread Alex Behm (Code Review)
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8783 Change subject: IMPALA-6286: Remove invalid runtime filter targets. .. IMPALA-6286: Remove invalid runtime filter targets. If the target

[Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker

2017-12-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8782 Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker .. IMPALA-5848: Account for TCMalloc overhead in MemTracker

[Impala-ASF-CR] IMPALA-6281: Fix use-after-free in InitAuth()

2017-12-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8777 ) Change subject: IMPALA-6281: Fix use-after-free in InitAuth() .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8781 Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation .. IMPALA-6222: Add details to error msg on

[Impala-ASF-CR] IMPALA-6270: create Impala parent pom

2017-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8753 ) Change subject: IMPALA-6270: create Impala parent pom .. Patch Set 1: Code-Review+2 (1 comment) I played around with this change locally

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8569 ) Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function. .. Patch Set 5: Before merging, I'll run the tests one more time and give

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-12-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8569 ) Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function. .. Patch Set 5: Code-Review+2 That's clearer, thanks. -- To view, visit

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-12-06 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8569 to look at the new patch set (#5). Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function.

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8569 ) Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6281: Fix use-after-free in InitAuth()

2017-12-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8777 ) Change subject: IMPALA-6281: Fix use-after-free in InitAuth() .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6272: Update external Hadoop ecosystem versions

2017-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8759 ) Change subject: IMPALA-6272: Update external Hadoop ecosystem versions .. IMPALA-6272: Update external Hadoop ecosystem

[Impala-ASF-CR] IMPALA-6272: Update external Hadoop ecosystem versions

2017-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8759 ) Change subject: IMPALA-6272: Update external Hadoop ecosystem versions .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest

2017-12-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8670 ) Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest .. IMPALA-6242: Reduce flakiness in TimerCounterTest The error threshold

[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8684 ) Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners

2017-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8684 ) Change subject: IMPALA-3804: Re-enable per-scan filtering for sequence-based scanners .. Patch Set 6: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs

2017-12-06 Thread Laszlo Gaal (Code Review)
Hello Lars Volker, Michael Brown, Jim Apple, Philip Zeyliger, Sailesh Mukil, David Knupp, Joe McDonnell, Tim Armstrong, Alex Behm, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8294 to look at the new patch set (#5). Change subject:

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest

2017-12-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 ) Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest .. Patch Set 1: Since we are measuring wall time here, I don't

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2017-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 13: Code-Review+2 carry -- To view,

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2017-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and

[Impala-ASF-CR] IMPALA-6272: Update external Hadoop ecosystem versions

2017-12-06 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8759 ) Change subject: IMPALA-6272: Update external Hadoop ecosystem versions .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 11: (10 comments) Thanks!

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-06 Thread Zoltan Borok-Nagy (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Laszlo Gaal, Gabor Kaszab, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8490 to look at the new patch set (#12). Change subject: IMPALA-2248: Make

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-06 Thread Kim Jin Chul (Code Review)
Hello Gabor Kaszab, Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8508 to look at the new patch set (#6). Change subject: IMPALA-5237: Support a quoted string in date/time format

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-06 Thread Kim Jin Chul (Code Review)
Hello Gabor Kaszab, Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8508 to look at the new patch set (#5). Change subject: IMPALA-5237: Support a quoted string in date/time format

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 2: Code-Review+1 I'm fine with this patch.

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. IMPALA-6262: Always initialize runtime profile for DataSink

[Impala-ASF-CR] IMPALA-2640: Maintain the command given by an user

2017-12-06 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#3). Change subject: IMPALA-2640: Maintain the command given by an user

[Impala-ASF-CR] IMPALA-2640: Maintain the command given by an user

2017-12-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Maintain the command given by an user .. Patch Set 2: Code-Review-1 I found that "ctrl + d" (EOF) does not