[Impala-ASF-CR] IMPALA-6477: Fix flakiness with thrift-server-test

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9247 ) Change subject: IMPALA-6477: Fix flakiness with thrift-server-test .. Patch Set 3: Verified-1 Build failed: https://jenkins.imp

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-08 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#13). Change subject: IMPALA-3193: Show table's comment on show tables

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-08 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 13: (1 comment) The timed out issue at Jenkins should be

[Impala-ASF-CR] IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9251 ) Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams .. Patch Set 1: (1 comment) Your answer re: compressi

[Impala-ASF-CR] IMPALA-6477: Fix flakiness with thrift-server-test

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9247 ) Change subject: IMPALA-6477: Fix flakiness with thrift-server-test .. Patch Set 3: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-6477: Disable rpc-mgr-kerberized-test

2018-02-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9256 Change subject: IMPALA-6477: Disable rpc-mgr-kerberized-test .. IMPALA-6477: Disable rpc-mgr-kerberized-test This test is breaking build

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9239 to look at the new patch set (#2). Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows ..

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 1: (4 comments) Thanks for the

[Impala-ASF-CR] IMPALA-5690: Upgrade thrift to 0.9.3-p3

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Upgrade thrift to 0.9.3-p3 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9168/4/be/sr

[Impala-ASF-CR] IMPALA-5690: Upgrade thrift to 0.9.3-p3

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Upgrade thrift to 0.9.3-p3 .. Patch Set 4: Thomas: could you give this a review? Sailesh: please review

[Impala-ASF-CR] IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9232 ) Change subject: IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart .. Patch Set 2: Build started: https://jenk

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6477: Fix flakiness with thrift-server-test

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9247 ) Change subject: IMPALA-6477: Fix flakiness with thrift-server-test .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-6477: Fix flakiness with thrift-server-test

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9247 ) Change subject: IMPALA-6477: Fix flakiness with thrift-server-test .. IMPALA-6477: Fix flakiness with thrift-server-test

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-08 Thread Anonymous Coward (Code Review)
xyutin...@cloudera.com has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. IMPALA-5440 Add planner tests with extreme stati

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-08 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#4). Change subject: IMPALA-5801: Clean up codegen GetType() interface ..

[Impala-ASF-CR] IMPALA-5690: Upgrade thrift to 0.9.3-p3

2018-02-08 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Upgrade thrift to 0.9.3-p3 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9168/4/be/src/co

[Impala-ASF-CR] IMPALA-5690: Upgrade thrift to 0.9.3-p3

2018-02-08 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Upgrade thrift to 0.9.3-p3 .. IMPALA-5690: Upgrade thrift to 0.9.3-p3 Dependency changes: - BE and python use

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-08 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#5). Change subject: IMPALA-5801: Clean up codegen GetType() interface ..

[Impala-ASF-CR] IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9232 ) Change subject: IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart .. IMPALA-6486: Fix INVALIDATE METAD

[Impala-ASF-CR] IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9232 ) Change subject: IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart .. Patch Set 2: Verified+1 -- To view, vis

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-6477: Disable rpc-mgr-kerberized-test

2018-02-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9256 ) Change subject: IMPALA-6477: Disable rpc-mgr-kerberized-test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6477: Disable rpc-mgr-kerberized-test

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9256 ) Change subject: IMPALA-6477: Disable rpc-mgr-kerberized-test .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-08 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 13: I don't prefer to refactor the code to avoid the redun

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2018-02-08 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 7: Hi Lars, You may be busy. It would be great if

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 13: > I don't prefer to refactor the code to avoi

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-08 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#14). Change subject: IMPALA-3193: Show table's comment on show tables

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-08 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 13: Applied the update. -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-6477: Disable rpc-mgr-kerberized-test

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9256 ) Change subject: IMPALA-6477: Disable rpc-mgr-kerberized-test .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6477: Disable rpc-mgr-kerberized-test

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9256 ) Change subject: IMPALA-6477: Disable rpc-mgr-kerberized-test .. IMPALA-6477: Disable rpc-mgr-kerberized-test This test

[Impala-ASF-CR] IMPALA-6372: Go parallel for Hive dataload

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: IMPALA-6372: Go parallel for Hive dataload .. Patch Set 7: I ran tests with this change and observed data loading go

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9238 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 2: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9238 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 2: Code-Review+2 Tests passed on CentOS 6 -- To vi

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. IMPALA-3271: organise and warn on removed startup flags Gather

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. Patch Set 5: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. Patch Set 5: Code-Review+2 Fix compile error from backslash

[Impala-ASF-CR] Remove Yarn from minicluster.

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9264 ) Change subject: Remove Yarn from minicluster. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9264/1/testdata/cluste

[Impala-ASF-CR] Remove Yarn from minicluster.

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9264 ) Change subject: Remove Yarn from minicluster. .. Patch Set 1: https://jenkins.impala.io/job/gerrit-verify-dryrun-external/78/ is runn

[Impala-ASF-CR] Remove Yarn from minicluster.

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9264 Change subject: Remove Yarn from minicluster. .. Remove Yarn from minicluster. Removes vestiges of Yarn from the minicluster. Turns o

[Impala-ASF-CR] IMPALA-6070: Expose using Docker to run tests faster.

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9085 ) Change subject: IMPALA-6070: Expose using Docker to run tests faster. .. IMPALA-6070: Expose using Docker to run tests faster. Allows r

[Impala-ASF-CR] Adding simplistic parser for Impala profile logs.

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9265 Change subject: Adding simplistic parser for Impala profile logs. .. Adding simplistic parser for Impala profile logs. It's hard to fi

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. Patch Set 3: Code-Review+2 (1 comment) htt

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. Patch Set 5: Verified-1 Build failed: https://jenkin

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9238 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 2: Verified-1 Build failed: https://jenkins.