[Impala-ASF-CR] IMPALA-6537: Add missing ODBC scalar functions

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9376 ) Change subject: IMPALA-6537: Add missing ODBC scalar functions .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6537: Add missing ODBC scalar functions

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9376 ) Change subject: IMPALA-6537: Add missing ODBC scalar functions .. IMPALA-6537: Add missing ODBC scalar functions This

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9407 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6275: Fix warn stacktrace in successful CTAS

2018-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9364 ) Change subject: IMPALA-6275: Fix warn stacktrace in successful CTAS .. Patch Set 6: Code-Review+2 -- To view, visit

Re: [Impala-ASF-CR] IMPALA-6275: Fix warn stacktrace in successful CTAS

2018-02-22 Thread Alexander Behm
GVO hit IMPALA-6532, going to retry On Thu, Feb 22, 2018 at 6:31 PM, Impala Public Jenkins (Code Review) < ger...@cloudera.org> wrote: > Impala Public Jenkins *posted comments* on this change. > > View Change > > Patch set 5:Verified -1 > > Build failed:

[Impala-ASF-CR] IMPALA-6567: ResetMetadataStmt analysis should not load tables.

2018-02-22 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9418 ) Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables. .. IMPALA-6567: ResetMetadataStmt analysis should not load

[Impala-ASF-CR] IMPALA-6567: ResetMetadataStmt analysis should not load tables.

2018-02-22 Thread Alex Behm (Code Review)
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9418 Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables. .. IMPALA-6567: ResetMetadataStmt analysis should not load

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. IMPALA-6549: Enable file handle cache by default

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9417 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 1: There were some conflicts here, so resolving

[Impala-ASF-CR](2.x) IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9417 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 1: Build started:

[Impala-ASF-CR](2.x) IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9417 Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPALA-4835: Part 3: switch I/O buffers to buffer pool This

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. IMPALA-6482: add EXEC_TIME_LIMIT_S option This is similar

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPALA-4835: Part 3: switch I/O buffers to buffer

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. IMPALA-4835: Part 2: Allocate scan range buffers

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 25: Verified+1 Verified with

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 34: Verified+1 Verified with

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. IMPALA-4835: Part 1: simplify I/O mgr mem

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 25: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9154 ) Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala .. Patch Set 7:

[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 ) Change subject: IMPALA-2990: Add a warning message during cancellation .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 ) Change subject: IMPALA-2990: Add a warning message during cancellation .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-6275: Fix warn stacktrace in successful CTAS

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9364 ) Change subject: IMPALA-6275: Fix warn stacktrace in successful CTAS .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation

2018-02-22 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9413 Change subject: IMPALA-2990: Add a warning message during cancellation .. IMPALA-2990: Add a warning message during cancellation Until

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#9). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#8). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

[Impala-ASF-CR] IMPALA-6537: Add missing ODBC scalar functions

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9376 ) Change subject: IMPALA-6537: Add missing ODBC scalar functions .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6537: Add missing ODBC scalar functions

2018-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9376 ) Change subject: IMPALA-6537: Add missing ODBC scalar functions .. Patch Set 5: Code-Review+2 Trivial fixes with expected test output and a

[Impala-ASF-CR] IMPALA-6537: Add missing ODBC scalar functions

2018-02-22 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#5) to the change originally created by Greg Rahn. ( http://gerrit.cloudera.org:8080/9376 ) Change subject: IMPALA-6537: Add missing ODBC scalar functions .. IMPALA-6537: Add missing ODBC

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9407 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Patch Set 1: Build started:

[Impala-ASF-CR](2.x) IMPALA-5152: Introduce metadata loading phase

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9408 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 1: Code-Review+1 I took a look at the conflicts and

[Impala-ASF-CR](2.x) IMPALA-5152: Introduce metadata loading phase

2018-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9408 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 1: (2 comments) Did not cherry-pick clean. I'm still running

[Impala-ASF-CR](2.x) IMPALA-5152: Introduce metadata loading phase

2018-02-22 Thread Alex Behm (Code Review)
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9408 to review the following change. Change subject: IMPALA-5152: Introduce metadata loading phase ..

[Impala-ASF-CR] IMPALA-6537: Add missing ODBC scalar functions

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9376 ) Change subject: IMPALA-6537: Add missing ODBC scalar functions .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9407 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#7). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. Patch Set 10: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9227 to look at the new patch set (#10). Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. Patch Set 9: (9 comments)

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. Patch Set 9: Code-Review+2 (9 comments)

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9368 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. IMPALA-5752: Add support for DECIMAL on Kudu

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9368 ) Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. Patch Set 9: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 3: Build started:

[Impala-ASF-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9383 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 2: Code-Review+1 > Looks good to me,

[Impala-ASF-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9383 to look at the new patch set (#2). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#6). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 3: GVO hit IMPALA-6532 -- To view, visit

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#5). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9407 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Patch Set 1: Clean cherry-pick -- To view, visit

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/9407 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Removed reviewer Todd Lipcon. -- To view, visit

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed Dan Burkert from this change. ( http://gerrit.cloudera.org:8080/9407 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Removed reviewer Dan Burkert. -- To view, visit

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9407 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Joe McDonnell (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9407 to review the following change. Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages

[Impala-ASF-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9383 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 1: Code-Review+1 Looks good to me,

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 25: Build started:

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 25: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 25: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#34). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 34: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 33: (1 comment)

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9367 ) Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX .. Patch Set 2: Code-Review+1 Did anyone else want to take a

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 33: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9154 ) Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala .. Patch Set 7: Code-Review+2

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9154 ) Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala .. Patch Set 7: Build

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9154 ) Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala .. Patch Set 6: Code-Review+2

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 33: (1 comment)

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 33: (1 comment)

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9227 to look at the new patch set (#9). Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 ) Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. Patch Set 4: Code-Review+2 Carrying +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 ) Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-22 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9370 to look at the new patch set (#4). Change subject: IMPALA-6530: Track time spent opening HDFS file handles

[Impala-ASF-CR] IMPALA-6482: add EXEC TIME LIMIT S option

2018-02-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option .. Patch Set 8: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 24: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 33: Added a fix for IMPALA-6564 -- To view,

[Impala-ASF-CR] IMPALA-4835: Part 2+3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/9302 ) Change subject: IMPALA-4835: Part 2+3: switch I/O buffers to buffer pool .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9302 To

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/9405 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9405 To

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#33). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#24). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool

[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change

2018-02-22 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 4: Code-Review+1 LGTM, after looking

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9405 Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#23). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#4). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 24: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 32: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9367 ) Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX .. Patch Set 1: (1 comment) Updated

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-22 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9367 to look at the new patch set (#2). Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 2: (2 comments)

  1   2   >