[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 1: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 1: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9527 Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. IMPALA-6609: Fix ownership of class members in KrpcDa

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 14: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. IMPALA-6347: Monitor que

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9525 Change subject: IMPALA-6389: Make '\0' delimited text files work .. IMPALA-6389: Make '\0' delimited text files work This is conflated a b

[Impala-ASF-CR] IMPALA-6610: Impala shell fetches the value of ldap password cmd incorrectly

2018-03-06 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly .. Patch Set 3: (1 comment) Thank you Fredy

[Impala-ASF-CR] IMPALA-6610: Impala shell fetches the value of ldap password cmd incorrectly

2018-03-06 Thread Donghui Xu (Code Review)
Hello Fredy Wijaya, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9506 to look at the new patch set (#3). Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly

[Impala-ASF-CR] IMPALA-6610: Impala shell fetches the value of ldap password cmd incorrectly

2018-03-06 Thread Donghui Xu (Code Review)
Hello Fredy Wijaya, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9506 to look at the new patch set (#2). Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-03-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 3: Now all DDL operatio

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-03-06 Thread Zoltan Borok-Nagy (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9090 to look at the new patch set (#4). Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata ...

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 7: I'm still seeing crashes when I

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-03-06 Thread Zoltan Borok-Nagy (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9090 to look at the new patch set (#3). Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata ...

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-03-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/919

[Impala-ASF-CR] IMPALA-6614: ClientRequestState should use HS2 TOperationState

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9501 ) Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState .. Patch Set 2: (8 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic

2018-03-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 ) Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic .. Patch Set 1: (1 comment) Just an FYI to Alex's response o

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/9195/9

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-03-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/919

[Impala-ASF-CR] IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9519 ) Change subject: IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 .. Patch Set 2: Code-Review+2 Please do some basic sanity tests o

[Impala-ASF-CR] IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9519 ) Change subject: IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 .. Patch Set 1: (2 comments) > (2 comments) > > So, thrift-

[Impala-ASF-CR] IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4

2018-03-06 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9519 to look at the new patch set (#2). Change subject: IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 .. IMPALA-

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py script to handle exit code for EE tests when no tests are collected.After this change return code will be either 0 if no tests are expecte

2018-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9494 ) Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py script to handle exit_code for EE tests when no tests are collected.After this change return_code will be either 0 if no tests are expected to

[Impala-ASF-CR] IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9519 ) Change subject: IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 .. Patch Set 1: (2 comments) So, thrift-server-test didn't need

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-03-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/919

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-03-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/919

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-03-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/91

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC This change rename

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. Patch Set 2: Verified+1 This change does not affect the builds in out GD

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 10: Code-Review+1 Carrying Vuk's +1. -- To view, visit htt

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. IMPALA-6337: Fix infinite loop in Impala shell The patch uses a workaro

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py script to handle exit code for EE tests when no tests are collected.After this change return code will be either 0 if no tests are expecte

2018-03-06 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9494 Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py script to handle exit_code for EE tests when no tests are collected.After this change return_code will be either 0 if no tests are expect

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic

2018-03-06 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 ) Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic

2018-03-06 Thread Alex Rodoni (Code Review)
Hello John Russell, Fredy Wijaya, Alan Choi, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9515 to look at the new patch set (#4). Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic ..

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 3: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 14: Build started: ht

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 14: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 3: (7 comments) The overall a

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#14). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6605: Exception hidden on complex types

2018-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9514 ) Change subject: IMPALA-6605: Exception hidden on complex types .. IMPALA-6605: Exception hidden on complex types This patch fixes the issu

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 13: Code-Review+2 (1 comment)

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm

2018-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 ) Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/95

[Impala-ASF-CR] IMPALA-6573: Create consistent response on column access failures

2018-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9509 ) Change subject: IMPALA-6573: Create consistent response on column access failures .. Patch Set 1: (4 comments) http://gerrit.cloudera.

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm

2018-03-06 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 ) Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/951

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm

2018-03-06 Thread Alex Rodoni (Code Review)
Hello John Russell, Alan Choi, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9515 to look at the new patch set (#3). Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm ..

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm

2018-03-06 Thread Alex Rodoni (Code Review)
Hello John Russell, Alan Choi, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9515 to look at the new patch set (#2). Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm ..

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm

2018-03-06 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 ) Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/95

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm

2018-03-06 Thread Alan Choi (Code Review)
Alan Choi has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 ) Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9515

[Impala-ASF-CR] IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9519 Change subject: IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 .. IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 On

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-03-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/91

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 13: Code-Review+1 I will let Lar

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 11: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. Patch Set 1: (1 comment) Thanks for the review, Sailesh. Please see PS2

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Hello Michael Ho, Philip Zeyliger, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9516 to look at the new patch set (#2). Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC ..

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 13: (2 comments) http://gerr

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#13). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9516 Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC This change renames the TES

[Impala-ASF-CR] IMPALA-6614: ClientRequestState should use HS2 TOperationState

2018-03-06 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9501 Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState .. IMPALA-6614: ClientRequestState should use HS2 TOperationSt

[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm

2018-03-06 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9515 Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm .. [DOCS] Publish Choosing the Load-Balancign Algorithm Change-Id: I7

[Impala-ASF-CR] IMPALA-6606: date trunc() misinterprets MILLENNIUM/CENTURY precision

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9508 ) Change subject: IMPALA-6606: date_trunc() misinterprets MILLENNIUM/CENTURY precision .. Patch Set 1: (4 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option

2018-03-06 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option .. Patch Set 3: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-6605: Exception hidden on complex types

2018-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9514 Change subject: IMPALA-6605: Exception hidden on complex types .. IMPALA-6605: Exception hidden on complex types This patch fixes the iss

[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option

2018-03-06 Thread Alan Choi (Code Review)
Alan Choi has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option .. Patch Set 3: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6606: date trunc() misinterprets MILLENNIUM/CENTURY precision

2018-03-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9508 ) Change subject: IMPALA-6606: date_trunc() misinterprets MILLENNIUM/CENTURY precision .. Patch Set 2: Code-Review+1 Tim, mind taking a look

[Impala-ASF-CR] IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

2018-03-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9484 ) Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL .. Patch Set 1: I am not sure how valid the results/reproducib

[Impala-ASF-CR] IMPALA-6610: Impala shell fetches the value of ldap password cmd incorrectly

2018-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly .. Patch Set 1: (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-6606: date trunc() misinterprets MILLENNIUM/CENTURY precision

2018-03-06 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9508 ) Change subject: IMPALA-6606: date_trunc() misinterprets MILLENNIUM/CENTURY precision .. Patch Set 2: (6 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6606: date trunc() misinterprets MILLENNIUM/CENTURY precision

2018-03-06 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9508 ) Change subject: IMPALA-6606: date_trunc() misinterprets MILLENNIUM/CENTURY precision .. IMPALA-6606: date_trunc() misinterprets MILLENNIUM

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 12: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 12: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-06 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Gabor Kaszab, Jim Apple, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9381 to look at the new patch set (#6). Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics ...

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-06 Thread Tim Armstrong (Code Review)
Hello Quanlong Huang, Lars Volker, Laszlo Gaal, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9274 to look at the new patch set (#5). Change subject: IMPALA-5717: Build ORC C++ lib in toolchain ...

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/9274/4/bu

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 2: (15 comments) Thanks! Few more comments:

[Impala-ASF-CR] IMPALA-6606: date trunc() misinterprets MILLENNIUM/CENTURY precision

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9508 ) Change subject: IMPALA-6606: date_trunc() misinterprets MILLENNIUM/CENTURY precision .. Patch Set 1: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6606: date trunc() misinterprets MILLENNIUM/CENTURY precision

2018-03-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9508 ) Change subject: IMPALA-6606: date_trunc() misinterprets MILLENNIUM/CENTURY precision .. Patch Set 1: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-03-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/9391 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: Sure! Thank you. -- To view, visit http

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 8: (2 comments) Once you address my comments below, pleas

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/9274/4/builda

[Impala-ASF-CR] IMPALA-6592: add test for invalid parquet codecs

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9500 ) Change subject: IMPALA-6592: add test for invalid parquet codecs .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9500/

[Impala-ASF-CR] IMPALA-6592: add test for invalid parquet codecs

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9500 ) Change subject: IMPALA-6592: add test for invalid parquet codecs .. IMPALA-6592: add test for invalid parquet codecs IMPALA-6592 revealed

[Impala-ASF-CR] IMPALA-6573: Create consistent response on column access failures

2018-03-06 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9509 Change subject: IMPALA-6573: Create consistent response on column access failures .. IMPALA-6573: Create consistent response on column acc

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 4: Just getting back to this. I know a lot of people at Cloude

[Impala-ASF-CR] IMPALA-6606: date trunc() misinterprets MILLENNIUM/CENTURY precision

2018-03-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9508 ) Change subject: IMPALA-6606: date_trunc() misinterprets MILLENNIUM/CENTURY precision .. Patch Set 1: (5 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 5: (2 comments) http://gerrit

[Impala-ASF-CR] IMPALA-6606: date trunc() misinterprets MILLENNIUM/CENTURY precision

2018-03-06 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9508 Change subject: IMPALA-6606: date_trunc() misinterprets MILLENNIUM/CENTURY precision .. IMPALA-6606: date_trunc() misinterprets MILLENNIU

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-03-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9391 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: Hey, Let me put myself in context and get

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 3: Code-Review+1 (1 comment) h

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. IMPALA-6595: fix crash in NljBuilder::Close() The bug is that

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 4: (31 comments) Thanks for taking a look, At

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#4). Change subject: IMPALA-3866 Improve error reporting for scratch write errors ..

[Impala-ASF-CR] IMPALA-6595: fix crash in NljBuilder::Close()

2018-03-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9493 ) Change subject: IMPALA-6595: fix crash in NljBuilder::Close() .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6610: Impala shell fetches the value of ldap password cmd incorrectly

2018-03-06 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9506 Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly .. IMPALA-6610: Impala shell fetches the value

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 3: Rebased with master + resolved conflicts.

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#3). Change subject: IMPALA-3866 Improve error reporting for scratch write errors ..