[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. IMPALA-6120: Add thread timers for

[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. IMPALA-6850: Print actual error message on

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

2018-04-13 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#5). Change subject: IMPALA-6522: [DOCS] Document Decimal V2

[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns

2018-04-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10070 Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. IMPALA-6464: [DOCS] COMPUTE STATS supports a list of

[Impala-ASF-CR] IMPALA-6463: [DOCS] Removed query options were deleted from docs

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10055 ) Change subject: IMPALA-6463: [DOCS] Removed query options were deleted from docs .. IMPALA-6463: [DOCS] Removed query

[Impala-ASF-CR] IMPALA-6463: [DOCS] Removed query options were deleted from docs

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10055 ) Change subject: IMPALA-6463: [DOCS] Removed query options were deleted from docs .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6372: Go parallel for Hive dataload

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: IMPALA-6372: Go parallel for Hive dataload .. Patch Set 11: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6372: Go parallel for Hive dataload

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: IMPALA-6372: Go parallel for Hive dataload .. IMPALA-6372: Go parallel for Hive dataload This changes

[Impala-ASF-CR] IMPALA-6483: [DOCS] Document the new EXEC TIME LIMIT S query option

2018-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10043 ) Change subject: IMPALA-6483: [DOCS] Document the new EXEC_TIME_LIMIT_S query option .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6463: [DOCS] Removed query options were deleted from docs

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10055 ) Change subject: IMPALA-6463: [DOCS] Removed query options were deleted from docs .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5310: [DOCS] Document TABLESAMPLE clause for COMPUTE STATS

2018-04-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded a new patch set (#3) to the change originally created by John Russell. ( http://gerrit.cloudera.org:8080/8975 ) Change subject: IMPALA-5310: [DOCS] Document TABLESAMPLE clause for COMPUTE STATS ..

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-13 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#4). Change subject: IMPALA-6847: work around high memory estimates for AC

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-13 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#3). Change subject: IMPALA-6847: work around high memory estimates for AC

[Impala-ASF-CR] Fix test query concurrency exception handling.

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10049 ) Change subject: Fix test_query_concurrency exception handling. .. Fix test_query_concurrency exception handling.

[Impala-ASF-CR] Fix test query concurrency exception handling.

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10049 ) Change subject: Fix test_query_concurrency exception handling. .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 8: > Patch Set 8: > > > Patch Set 8: > > > > can

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

2018-04-13 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#4). Change subject: IMPALA-6522: [DOCS] Document Decimal V2

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

2018-04-13 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#3). Change subject: IMPALA-6522: [DOCS] Document Decimal V2

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9993 ) Change subject: IMPALA-6723: [DOCS] Hints for CTAS .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10053 ) Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice .. Patch Set 4: Nice find! If you add something

[Impala-ASF-CR] IMPALA-6514: [DOCS] impala-shell option for load balancer and Kerberos

2018-04-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10047 ) Change subject: IMPALA-6514: [DOCS] impala-shell option for load balancer and Kerberos .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6514: [DOCS] impala-shell option for load balancer and Kerberos

2018-04-13 Thread Alex Rodoni (Code Review)
Hello Vincent Tran, Alan Choi, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10047 to look at the new patch set (#2). Change subject: IMPALA-6514: [DOCS] impala-shell option for load balancer and Kerberos

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 7: Code-Review+2 GVO failed due to flakiness

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

2018-04-13 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 ) Change subject: Allow bootstrap_system.sh to work on existing impala/ repo .. Patch Set 1: (1 comment) I think you and Fredy need

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 ) Change subject: Allow bootstrap_system.sh to work on existing impala/ repo .. Patch Set 1: http://gerrit.cloudera.org:8080/9994 -- To

[Impala-ASF-CR] [DOCS] Perf Statistics doc reorg and refactoring

2018-04-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10067 ) Change subject: [DOCS] Perf Statistics doc reorg and refactoring .. Patch Set 1: No need to review yet. I asked Alex for help with

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

2018-04-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10052 ) Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

2018-04-13 Thread Alex Rodoni (Code Review)
Hello Vincent Tran, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10052 to look at the new patch set (#2). Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-04-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10056 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. IMPALA-6747: Automate diagnostics collection. This

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10068 Change subject: Allow bootstrap_system.sh to work on existing impala/ repo .. Allow bootstrap_system.sh to work on existing impala/

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-04-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10056 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-04-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10056 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 1: Code-Review+1

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 6: Build failed:

[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10053 ) Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice .. IMPALA-6845: TestHdfsQueries causes

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10053 ) Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] [DOCS] Perf Statistics doc reorg and refactoring

2018-04-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10067 Change subject: [DOCS] Perf Statistics doc reorg and refactoring .. [DOCS] Perf Statistics doc reorg and refactoring Change-Id:

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10031 ) Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort .. IMPALA-6713: Fix request for unneeded

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10031 ) Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

2018-04-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 The entire DECIMAL doc was refactored.

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10030 ) Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10030 ) Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables .. IMPALA-6451: AuthorizationException in

[Impala-ASF-CR] WIP Decimal V2

2018-04-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has abandoned this change. ( http://gerrit.cloudera.org:8080/10065 ) Change subject: WIP Decimal V2 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/10065 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2

2018-04-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10066 Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 The entire DECIMAL doc was

[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error

2018-04-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP Decimal V2

2018-04-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10065 Change subject: WIP Decimal V2 .. WIP Decimal V2 Change-Id: I0b2292bbb80f1b6f88141a598a9fa4b0ed80fa1c --- M docs/impala_keydefs.ditamap

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 8: > Patch Set 8: > > can you repro this

[Impala-ASF-CR] IMPALA-6372: Go parallel for Hive dataload

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: IMPALA-6372: Go parallel for Hive dataload .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-6372: Go parallel for Hive dataload

2018-04-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: IMPALA-6372: Go parallel for Hive dataload .. Patch Set 11: Code-Review+2 Rebased. Carrying +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error

2018-04-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. Patch Set 3: Please re-review it again. I found a bug

[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error

2018-04-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. IMPALA-6850: Print actual error message on Sentry error The

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-13 Thread Joe McDonnell (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10044 to look at the new patch set (#2). Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 1: I'm uploading a new version that adds a comment in

[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error

2018-04-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has removed a vote on this change. Change subject: IMPALA-6850: Print actual error message on Sentry error .. Removed Code-Review+2 by Vuk Ercegovac -- To view, visit

[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error

2018-04-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has removed a vote on this change. Change subject: IMPALA-6850: Print actual error message on Sentry error .. Removed Code-Review+2 by Philip Zeyliger -- To view, visit

[Impala-ASF-CR] IMPALA-6372: Go parallel for Hive dataload

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: IMPALA-6372: Go parallel for Hive dataload .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Fix test query concurrency exception handling.

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10049 ) Change subject: Fix test_query_concurrency exception handling. .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error

2018-04-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10064 Change subject: IMPALA-6850: Print actual error message on Sentry error .. IMPALA-6850: Print actual error message on Sentry error

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 1: That seems like a good thing for use to do Fredy, but might

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 1: > Patch Set 1: > > > We also have the source code for sqlparse

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10053 ) Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 6: GVO failed due to an unrelated flaky test

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10053 ) Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-04-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10056 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 1: Thanks, Phil for the quick review. Will merge

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10031 ) Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort .. Patch Set 3: Code-Review+2 carrying forward

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10031 ) Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10031 ) Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10053 ) Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-13 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10053 to look at the new patch set (#3). Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 1: > We also have the source code for sqlparse checked into the

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

2018-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10030 ) Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

2018-04-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10030 ) Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

2018-04-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10030 ) Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

2018-04-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10030 ) Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables .. IMPALA-6451: AuthorizationException in CTAS for Kudu

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9993 ) Change subject: IMPALA-6723: [DOCS] Hints for CTAS .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-04-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 23: (3 comments)

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10056 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 1: I also used the following command to verify that

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10056 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 1: Code-Review+2 This is an unrevert. I helped review

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 1: > Patch Set 1: > > One potential problem is that I know

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 1: One potential problem is that I know some people still want

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10031 ) Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort .. Patch Set 2: Code-Review+2 (1 comment) LGTM so long

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 1: We also have the source code for sqlparse checked into the

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-04-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10056 Change subject: IMPALA-6747: Automate diagnostics collection. .. IMPALA-6747: Automate diagnostics collection. This commit adds

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

2018-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10052 ) Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-04-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 1: (7 comments) Spent only a limited amount of time on

[Impala-ASF-CR] IMPALA-6514: [DOCS] impala-shell option for load balancer and Kerberos

2018-04-13 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/10047 ) Change subject: IMPALA-6514: [DOCS] impala-shell option for load balancer and Kerberos .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

2018-04-13 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/10052 ) Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10031 ) Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort .. Patch Set 2: Code-Review+1 -- To view, visit