[Impala-ASF-CR] IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell

2018-07-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10876 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. IMPALA-6625: Skip computing

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. Patch Set 15: Verified+1 -- To view,

[Impala-ASF-CR] Update Impala to adapt to KRPC changes

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/10767 ) Change subject: Update Impala to adapt to KRPC changes .. Abandoned Not needed anymore. -- To view, visit http://gerrit.cloudera.org:8080/10767

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/10764 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Abandoned Not needed anymore. -- To view, visit

[Impala-ASF-CR] Propagate HAVE PIPE2 compile time value to files that use it

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/10761 ) Change subject: Propagate HAVE_PIPE2 compile time value to files that use it .. Abandoned Not needed anymore. -- To view, visit

[Impala-ASF-CR] KUTIL: Various fixes

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/10766 ) Change subject: KUTIL: Various fixes .. Abandoned Not needed anymore. -- To view, visit http://gerrit.cloudera.org:8080/10766 To unsubscribe,

[Impala-ASF-CR] IMPALA-5873: Check for existence of sync file range()

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/10762 ) Change subject: IMPALA-5873: Check for existence of sync_file_range() .. Abandoned Not needed anymore. -- To view, visit

[Impala-ASF-CR] GUTIL: Rename constant to Kudu's value

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/10768 ) Change subject: GUTIL: Rename constant to Kudu's value .. Abandoned Not needed anymore. -- To view, visit http://gerrit.cloudera.org:8080/10768

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-05 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10758 to look at the new patch set (#3). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-05 Thread Lars Volker (Code Review)
Hello Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10760 to look at the new patch set (#3). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build

[Impala-ASF-CR] Pick parts of recent Kudu gutil changes

2018-07-05 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10769 to look at the new patch set (#7). Change subject: Pick parts of recent Kudu gutil changes

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-05 Thread Lars Volker (Code Review)
Hello Sailesh Mukil, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10763 to look at the new patch set (#3). Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-4669: [KSECURITY] Add security library to build

2018-07-05 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10759 to look at the new patch set (#3). Change subject: IMPALA-4669: [KSECURITY] Add security library to build

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-05 Thread Lars Volker (Code Review)
Hello Sailesh Mukil, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10763 to look at the new patch set (#2). Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-05 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10758 to look at the new patch set (#2). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.

[Impala-ASF-CR] Pick parts of recent Kudu gutil changes

2018-07-05 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10769 to look at the new patch set (#6). Change subject: Pick parts of recent Kudu gutil changes

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-05 Thread Lars Volker (Code Review)
Hello Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10760 to look at the new patch set (#2). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build

[Impala-ASF-CR] Bump toolchain version, include libunwind

2018-07-05 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10755 to look at the new patch set (#2). Change subject: Bump toolchain version, include libunwind .. Bump toolchain

[Impala-ASF-CR] Add KRPC folders from kudu@dc40297046 (WIP)

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10757 ) Change subject: Add KRPC folders from kudu@dc40297046 (WIP) .. Add KRPC folders from kudu@dc40297046 (WIP) cp -a

[Impala-ASF-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-07-05 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10765 to look at the new patch set (#2). Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code

[Impala-ASF-CR] IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell

2018-07-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10876 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7251: Fix QueryMaintenance calls in Aggregators

2018-07-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10871 ) Change subject: IMPALA-7251: Fix QueryMaintenance calls in Aggregators .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test

2018-07-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10859 ) Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test .. Patch Set 1: Yeah, those should probably be merged

[Impala-ASF-CR] IMPALA-7238: Use custom timeout for create unique database

2018-07-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10862 ) Change subject: IMPALA-7238: Use custom timeout for create unique database .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6031: Distributed plan describes coordinator-only nodes as scanning

2018-07-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10873 ) Change subject: IMPALA-6031: Distributed plan describes coordinator-only nodes as scanning .. Patch Set 2: (11 comments) lgtm,

[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test

2018-07-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10859 ) Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test .. Patch Set 1: I saw you filed some bugs:

[native-toolchain-CR] IMPALA-7252. Backport rate limiting of fadvise calls for glog

2018-07-05 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10877 to review the following change. Change subject: IMPALA-7252. Backport rate limiting of fadvise calls for glog ..

[Impala-ASF-CR] IMPALA-6031: Distributed plan describes coordinator-only nodes as scanning

2018-07-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10873 ) Change subject: IMPALA-6031: Distributed plan describes coordinator-only nodes as scanning .. Patch Set 2: (7 comments) Change

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-05 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Pranay Singh, Lars Volker, Fredy Wijaya, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10744 to look at the new patch set (#10). Change subject: IMPALA-1760: Implement shutdown command

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell

2018-07-05 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10876 Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. IMPALA-6223: Gracefully handle malformed

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-07-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10810 ) Change subject: IMPALA-7095: clean up scan node profiles .. Patch Set 7: (14 comments)

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-07-05 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10810 to look at the new patch set (#8). Change subject: IMPALA-7095: clean up scan node profiles ..

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. Patch Set 15: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-07-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. Patch Set 14: Code-Review+2 Carrying over

[Impala-ASF-CR] IMPALA-6031: Distributed plan describes coordinator-only nodes as scanning

2018-07-05 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10873 Change subject: IMPALA-6031: Distributed plan describes coordinator-only nodes as scanning .. IMPALA-6031: Distributed plan

[Impala-ASF-CR] IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming

2018-07-05 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10863 ) Change subject: IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7251: Fix QueryMaintenance calls in Aggregators

2018-07-05 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10871 Change subject: IMPALA-7251: Fix QueryMaintenance calls in Aggregators .. IMPALA-7251: Fix QueryMaintenance calls in Aggregators A

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 9: (3 comments)

[Impala-ASF-CR] IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming

2018-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10863 ) Change subject: IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming

2018-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10863 ) Change subject: IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming .. IMPALA-7240: Fix missing

[Impala-ASF-CR] IMPALA-6918: Implement COMMENT ON COLUMN

2018-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10754 ) Change subject: IMPALA-6918: Implement COMMENT ON COLUMN .. IMPALA-6918: Implement COMMENT ON COLUMN This patch

[Impala-ASF-CR] IMPALA-6918: Implement COMMENT ON COLUMN

2018-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10754 ) Change subject: IMPALA-6918: Implement COMMENT ON COLUMN .. Patch Set 9: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming

2018-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10863 ) Change subject: IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming

2018-07-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10863 ) Change subject: IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming .. Patch Set 1: Code-Review+2 I'm ok with this

[Impala-ASF-CR] IMPALA-6918: Implement COMMENT ON COLUMN

2018-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10754 ) Change subject: IMPALA-6918: Implement COMMENT ON COLUMN .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6918: Implement COMMENT ON COLUMN

2018-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10754 ) Change subject: IMPALA-6918: Implement COMMENT ON COLUMN .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-7027: Mulitple varchar cast fails with distinct

2018-07-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10858 ) Change subject: IMPALA-7027: Mulitple varchar cast fails with distinct .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6918: Implement COMMENT ON COLUMN

2018-07-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10754 ) Change subject: IMPALA-6918: Implement COMMENT ON COLUMN .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6918: Implement COMMENT ON COLUMN

2018-07-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/10754 ) Change subject: IMPALA-6918: Implement COMMENT ON COLUMN .. IMPALA-6918: Implement COMMENT ON COLUMN This patch implements updating

[Impala-ASF-CR] IMPALA-6918: Implement COMMENT ON COLUMN

2018-07-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10754 ) Change subject: IMPALA-6918: Implement COMMENT ON COLUMN .. Patch Set 8: (6 comments)

[Impala-ASF-CR] IMPALA-6918: Implement COMMENT ON COLUMN

2018-07-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10754 ) Change subject: IMPALA-6918: Implement COMMENT ON COLUMN .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-05 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Lars Volker, Fredy Wijaya, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10744 to look at the new patch set (#9). Change subject: IMPALA-1760: Implement shutdown command

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 7: (2 comments)