[Impala-ASF-CR] IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext()

2018-08-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11296 ) Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() .. Patch Set 3: (5 comments) looks good to

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 10: All outstanding comments have been

[Impala-ASF-CR] IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. IMPALA-7460 part 1: require user to

[Impala-ASF-CR] IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext()

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11296 ) Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7447. Evict LocalCatalog cache entries based on size

2018-08-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11231 ) Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-22 Thread David Knupp (Code Review)
Hello Lars Volker, Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11257 to look at the new patch set (#10). Change subject: IMPALA-7399: Emit a junit xml report when

[Impala-ASF-CR] IMPALA-7447. Evict LocalCatalog cache entries based on size

2018-08-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11231 ) Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext()

2018-08-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11296 ) Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() .. Patch Set 3: Code-Review+1 Will let bikram

[Impala-ASF-CR] IMPALA-110: Support for multiple DISTINCT

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10771 ) Change subject: IMPALA-110: Support for multiple DISTINCT .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext()

2018-08-22 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11296 ) Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() .. IMPALA-7418: Return first non-ok status from

[Impala-ASF-CR] IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext()

2018-08-22 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11296 ) Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext()

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11296 ) Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-110: Support for multiple DISTINCT

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10771 ) Change subject: IMPALA-110: Support for multiple DISTINCT .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext()

2018-08-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11296 ) Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-110: Support for multiple DISTINCT

2018-08-22 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10771 ) Change subject: IMPALA-110: Support for multiple DISTINCT .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-110: Support for multiple DISTINCT

2018-08-22 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10771 to look at the new patch set (#7). Change subject: IMPALA-110: Support for multiple DISTINCT

[Impala-ASF-CR] IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext()

2018-08-22 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11296 ) Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext()

2018-08-22 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11296 ) Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() .. IMPALA-7418: Return first non-ok status from

[Impala-ASF-CR] IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext()

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11296 ) Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 9: Code-Review+1 (2 comments) Phil had good

[Impala-ASF-CR] IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext()

2018-08-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11296 ) Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext()

2018-08-22 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11296 Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() .. IMPALA-7418: Return first non-ok status

[Impala-ASF-CR] IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11279 ) Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements .. IMPALA-7344: Restrict ALTER

[Impala-ASF-CR] IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11279 ) Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7437. LRU caching of partitions in impalad

2018-08-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11208 ) Change subject: IMPALA-7437. LRU caching of partitions in impalad .. Patch Set 8: (8 comments) Just a bunch of nits I found

[Impala-ASF-CR] IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Michael Brown (Code Review)
Hello Lars Volker, Philip Zeyliger, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11264 to look at the new patch set (#5). Change subject: IMPALA-7460 part 1: require user to install Paramiko and Fabric

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6373: Allow primitive type widening on parquet tables

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11268 ) Change subject: IMPALA-6373: Allow primitive type widening on parquet tables .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-6373: Allow primitive type widening on parquet tables

2018-08-22 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11268 ) Change subject: IMPALA-6373: Allow primitive type widening on parquet tables .. Patch Set 3: (3 comments) Rebased the CR.

[Impala-ASF-CR] IMPALA-6373: Allow primitive type widening on parquet tables

2018-08-22 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11268 ) Change subject: IMPALA-6373: Allow primitive type widening on parquet tables .. IMPALA-6373: Allow primitive type widening on parquet

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 4: > Expect another non-trivial

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Michael Brown (Code Review)
Hello Lars Volker, Philip Zeyliger, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11264 to look at the new patch set (#4). Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 9: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-08-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11279 ) Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11282 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11282 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. IMPALA-7412: width_bucket() function

[Impala-ASF-CR] IMPALA-6709: Simplify tests that copy local files to tables

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 ) Change subject: IMPALA-6709: Simplify tests that copy local files to tables .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6709: Simplify tests that copy local files to tables

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11127 ) Change subject: IMPALA-6709: Simplify tests that copy local files to tables .. IMPALA-6709: Simplify tests that copy

[Impala-ASF-CR] IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11279 ) Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11279 ) Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements

2018-08-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11279 ) Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7349: Add Admission control support for automatically setting mem limit

2018-08-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 ) Change subject: IMPALA-7349: Add Admission control support for automatically setting mem_limit .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements

2018-08-22 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11279 ) Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements .. IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER

[Impala-ASF-CR] IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements

2018-08-22 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11279 ) Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 10: Verified-1 Build

[Impala-ASF-CR] IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements

2018-08-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11279 ) Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-7349: Add Admission control support for automatically setting mem limit

2018-08-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 ) Change subject: IMPALA-7349: Add Admission control support for automatically setting mem_limit .. Patch Set 7: (3 comments)

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-22 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 9: (18 comments) Did a quick

[Impala-ASF-CR] IMPALA-7457. statestore: allow filtering by key prefix

2018-08-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11253 ) Change subject: IMPALA-7457. statestore: allow filtering by key prefix .. IMPALA-7457. statestore: allow filtering by key prefix

[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11293 ) Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7447. Evict LocalCatalog cache entries based on size

2018-08-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11231 ) Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size .. IMPALA-7447. Evict LocalCatalog cache entries

[Impala-ASF-CR] IMPALA-7447. Evict LocalCatalog cache entries based on size

2018-08-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11231 ) Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size .. Patch Set 6: Code-Review+2 carrying +2 from Vuk -- To

[Impala-ASF-CR] IMPALA-7457. statestore: allow filtering by key prefix

2018-08-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11253 ) Change subject: IMPALA-7457. statestore: allow filtering by key prefix .. Patch Set 4: Code-Review+2 Carrying +2 from Vuk and Tim --

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 11: Build Failed

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-6758: Add metric for current catalog version to catalog

2018-08-22 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11293 Change subject: IMPALA-6758: Add metric for current catalog version to catalog .. IMPALA-6758: Add metric for current catalog version to

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-08-22 Thread Pranay Singh (Code Review)
Hello Andrew Sherman, Lars Volker, Zoram Thanga, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10847 to look at the new patch set (#11). Change subject: IMPALA-6271: Impala daemon should log a message when it's being

[Impala-ASF-CR] IMPALA-6373: Allow primitive type widening on parquet tables

2018-08-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11268 ) Change subject: IMPALA-6373: Allow primitive type widening on parquet tables .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11282 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 2: Yeah, I've ran it around 300 times

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11282 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11282 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 10: The test has hit

[Impala-ASF-CR] IMPALA-6709: Simplify tests that copy local files to tables

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 ) Change subject: IMPALA-6709: Simplify tests that copy local files to tables .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6709: Simplify tests that copy local files to tables

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 ) Change subject: IMPALA-6709: Simplify tests that copy local files to tables .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 9: Verified-1 Build

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-22 Thread Quanlong Huang (Code Review)
Hello Zoltan Borok-Nagy, Attila Jeges, Todd Lipcon, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10950 to look at the new patch set (#11). Change subject: IMPALA-376: add built-in functions for parsing JSON

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 10: (5 comments)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-22 Thread Quanlong Huang (Code Review)
Hello Zoltan Borok-Nagy, Attila Jeges, Todd Lipcon, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10950 to look at the new patch set (#10). Change subject: IMPALA-376: add built-in functions for parsing JSON

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 9: -Code-Review (1 comment)

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-22 Thread Csaba Ringhofer (Code Review)
Hello Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11183 to look at the new patch set (#9). Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

[Impala-ASF-CR] IMPALA-6373: Allow primitive type widening on parquet tables

2018-08-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11268 ) Change subject: IMPALA-6373: Allow primitive type widening on parquet tables .. Patch Set 2: Code-Review+1 (1 comment) lgtm!

[Impala-ASF-CR] IMPALA-7466: Improve readability of describe authorization tests

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11278 ) Change subject: IMPALA-7466: Improve readability of describe authorization tests .. IMPALA-7466: Improve readability

[Impala-ASF-CR] IMPALA-7466: Improve readability of describe authorization tests

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11278 ) Change subject: IMPALA-7466: Improve readability of describe authorization tests .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] cleanup: remove RuntimeState::exec env

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11269 ) Change subject: cleanup: remove RuntimeState::exec_env_ .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] cleanup: remove RuntimeState::exec env

2018-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11269 ) Change subject: cleanup: remove RuntimeState::exec_env_ .. cleanup: remove RuntimeState::exec_env_ Change-Id: