[Impala-ASF-CR] IMPALA-8063: Add sleep to ImpalaTestSuite::wait for state() loop

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12207 ) Change subject: IMPALA-8063: Add sleep to ImpalaTestSuite::wait_for_state() loop .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. IMPALA-6544/IMPALA-7070:

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8063: Add sleep to ImpalaTestSuite::wait for state() loop

2019-01-09 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12207 ) Change subject: IMPALA-8063: Add sleep to ImpalaTestSuite::wait_for_state() loop .. Patch Set 1: Looks good. Can you also reduce

[Impala-ASF-CR] IMPALA-8063: Add sleep to ImpalaTestSuite::wait for state() loop

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12207 ) Change subject: IMPALA-8063: Add sleep to ImpalaTestSuite::wait_for_state() loop .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8063: Add sleep to ImpalaTestSuite::wait for state() loop

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12207 ) Change subject: IMPALA-8063: Add sleep to ImpalaTestSuite::wait_for_state() loop .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-8063: Add sleep to ImpalaTestSuite::wait for state() loop

2019-01-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12207 Change subject: IMPALA-8063: Add sleep to ImpalaTestSuite::wait_for_state() loop .. IMPALA-8063: Add sleep to

[Impala-ASF-CR] IMPALA-6533: Add min-max filter for decimal types on kudu tables.

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12113 ) Change subject: IMPALA-6533: Add min-max filter for decimal types on kudu tables. .. IMPALA-6533: Add min-max filter

[Impala-ASF-CR] IMPALA-6533: Add min-max filter for decimal types on kudu tables.

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12113 ) Change subject: IMPALA-6533: Add min-max filter for decimal types on kudu tables. .. Patch Set 18: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7666: Adding an opaque client identifier to query options.

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12130 ) Change subject: IMPALA-7666: Adding an opaque client identifier to query options. .. IMPALA-7666: Adding an opaque

[Impala-ASF-CR] IMPALA-7666: Adding an opaque client identifier to query options.

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12130 ) Change subject: IMPALA-7666: Adding an opaque client identifier to query options. .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. Patch Set 5: Build Successful

[Impala-ASF-CR] WIP IMPALA-7550 Add documentation to profile counters

2019-01-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12116 ) Change subject: WIP IMPALA-7550 Add documentation to profile counters .. Patch Set 2: (7 comments) I'm in favour of going forward

[Impala-ASF-CR] IMPALA-7986,IMPALA-7987: run daemons in docker containers

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12095 ) Change subject: IMPALA-7986,IMPALA-7987: run daemons in docker containers .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2019-01-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and

[Impala-ASF-CR] IMPALA-7986,IMPALA-7987: run daemons in docker containers

2019-01-09 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12095 to look at the new patch set (#13). Change subject: IMPALA-7986,IMPALA-7987: run daemons in docker containers

[Impala-ASF-CR] IMPALA-7986,IMPALA-7987: run daemons in docker containers

2019-01-09 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12095 to look at the new patch set (#12). Change subject: IMPALA-7986,IMPALA-7987: run daemons in docker containers

[Impala-ASF-CR] IMPALA-7986,IMPALA-7987: run daemons in docker containers

2019-01-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12095 ) Change subject: IMPALA-7986,IMPALA-7987: run daemons in docker containers .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-6533: Add min-max filter for decimal types on kudu tables.

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12113 ) Change subject: IMPALA-6533: Add min-max filter for decimal types on kudu tables. .. Patch Set 18: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6533: Add min-max filter for decimal types on kudu tables.

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12113 ) Change subject: IMPALA-6533: Add min-max filter for decimal types on kudu tables. .. Patch Set 18: Build started:

[Impala-ASF-CR] IMPALA-7867 (Part 4): Collection cleanup in catalog

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12131 ) Change subject: IMPALA-7867 (Part 4): Collection cleanup in catalog .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7666: Adding an opaque client identifier to query options.

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12130 ) Change subject: IMPALA-7666: Adding an opaque client identifier to query options. .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7867 (Part 4): Collection cleanup in catalog

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12131 ) Change subject: IMPALA-7867 (Part 4): Collection cleanup in catalog .. IMPALA-7867 (Part 4): Collection cleanup in

[Impala-ASF-CR] IMPALA-7666: Adding an opaque client identifier to query options.

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12130 ) Change subject: IMPALA-7666: Adding an opaque client identifier to query options. .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-09 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 17: Finally passed the pre-commit builds after

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. IMPALA-7832: Support for IF NOT EXISTS in ALTER

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. Patch Set 2: (1

[Impala-ASF-CR] WIP IMPALA-7550 Add documentation to profile counters

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12116 ) Change subject: WIP IMPALA-7550 Add documentation to profile counters .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. IMPALA-6544/IMPALA-7070:

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. Patch Set 1: (2

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12203 Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. IMPALA-6544/IMPALA-7070:

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 16: (1 comment)

[Impala-ASF-CR] WIP IMPALA-7550 Add documentation to profile counters

2019-01-09 Thread Lars Volker (Code Review)
Hello Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12116 to look at the new patch set (#2). Change subject: WIP IMPALA-7550 Add documentation to profile counters

[Impala-ASF-CR] WIP IMPALA-7550 Add documentation to profile counters

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12116 ) Change subject: WIP IMPALA-7550 Add documentation to profile counters .. Patch Set 1: > It's hard to argue with documenting these. >

[Impala-ASF-CR] WIP IMPALA-7550 Add documentation to profile counters

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12116 ) Change subject: WIP IMPALA-7550 Add documentation to profile counters .. Patch Set 1: > (1 comment) Thanks for the feedback. I added a

[Impala-ASF-CR] WIP IMPALA-7550 Add documentation to profile counters

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12116 ) Change subject: WIP IMPALA-7550 Add documentation to profile counters .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-8060: [DOCS] A typo fix

2019-01-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12201 ) Change subject: IMPALA-8060: [DOCS] A typo fix .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8060: [DOCS] A typo fix

2019-01-09 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12201 ) Change subject: IMPALA-8060: [DOCS] A typo fix .. IMPALA-8060: [DOCS] A typo fix Change-Id:

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 17: Build Successful

[Impala-ASF-CR] IMPALA-8060: [DOCS] A typo fix

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12201 ) Change subject: IMPALA-8060: [DOCS] A typo fix .. Patch Set 1: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-8060: [DOCS] A typo fix

2019-01-09 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12201 Change subject: IMPALA-8060: [DOCS] A typo fix .. IMPALA-8060: [DOCS] A typo fix Change-Id: Ia1fc02f9676c46f95f799f5c71e2b34ed30a4899

[Impala-ASF-CR] IMPALA-8060: [DOCS] A typo fix

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12201 ) Change subject: IMPALA-8060: [DOCS] A typo fix .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs

2019-01-09 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12191 ) Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs .. IMPALA-8060: [DOCS] Restructured the admission

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-09 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-09 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11575 to look at the new patch set (#17). Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-09 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-7666: Adding an opaque client identifier to query options.

2019-01-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12130 ) Change subject: IMPALA-7666: Adding an opaque client identifier to query options. .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7666: Adding an opaque client identifier to query options.

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12130 ) Change subject: IMPALA-7666: Adding an opaque client identifier to query options. .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12177 ) Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER. .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs

2019-01-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 ) Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8061: Fix S3 ACCESS VALIDATED unbound variable

2019-01-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12193 ) Change subject: IMPALA-8061: Fix S3_ACCESS_VALIDATED unbound variable .. Patch Set 1: > Patch Set 1: > > Did something recently fail

[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 ) Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs .. Patch Set 2: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12192 ) Change subject: IMPALA-8058: Fallback for HBase key scan range estimation .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs

2019-01-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 ) Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6664: Tag log statements with fragment or query ids.

2019-01-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12129 ) Change subject: IMPALA-6664: Tag log statements with fragment or query ids. .. Patch Set 3: > Does/should this fix up the Java side

[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs

2019-01-09 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 ) Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 ) Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs .. Patch Set 2: Build Started

[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs

2019-01-09 Thread Alex Rodoni (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12191 to look at the new patch set (#2). Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-09 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 17: (1 comment) Bharath, thanks for the +2.

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 16: (2 comments)

[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.

2019-01-09 Thread Philip Zeyliger (Code Review)
Hello David Knupp, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12177 to look at the new patch set (#2). Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.

[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.

2019-01-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12177 ) Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER. .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-7666: Adding an opaque client identifier to query options.

2019-01-09 Thread Philip Zeyliger (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12130 to look at the new patch set (#4). Change subject: IMPALA-7666: Adding an opaque client identifier to query options.

[Impala-ASF-CR] IMPALA-7666: Adding an opaque client identifier to query options.

2019-01-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12130 ) Change subject: IMPALA-7666: Adding an opaque client identifier to query options. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7867 (Part 4): Collection cleanup in catalog

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12131 ) Change subject: IMPALA-7867 (Part 4): Collection cleanup in catalog .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7867 (Part 4): Collection cleanup in catalog

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12131 ) Change subject: IMPALA-7867 (Part 4): Collection cleanup in catalog .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs

2019-01-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 ) Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs .. Patch Set 1: (1 comment) LGTM except for the "CDH"s

[Impala-ASF-CR] IMPALA-6533: Add min-max filter for decimal types on kudu tables.

2019-01-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12113 ) Change subject: IMPALA-6533: Add min-max filter for decimal types on kudu tables. .. Patch Set 17: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7867 (Part 4): Collection cleanup in catalog

2019-01-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12131 ) Change subject: IMPALA-7867 (Part 4): Collection cleanup in catalog .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP: IMPALA-5843: Use page index in Parquet files to skip pages

2019-01-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: WIP: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 1: (1 comment)

[Impala-ASF-CR] WIP: IMPALA-5843: Use page index in Parquet files to skip pages

2019-01-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: WIP: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12172 ) Change subject: IMPALA-7979: Enhance decoders to support value-skipping .. Patch Set 1: (9 comments) Thanks for pulling this out, it

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

2019-01-09 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12192 ) Change subject: IMPALA-8058: Fallback for HBase key scan range estimation .. Patch Set 1: Passed pre-review tests:

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

2019-01-09 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12192 Change subject: IMPALA-8058: Fallback for HBase key scan range estimation .. IMPALA-8058: Fallback for HBase key scan range estimation

[Impala-ASF-CR] IMPALA-6742: Profiles of running queries should include execution summary.

2019-01-09 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11591 ) Change subject: IMPALA-6742: Profiles of running queries should include execution summary. .. Patch Set 6: > Change has been

[Impala-ASF-CR] IMPALA-8061: Fix S3 ACCESS VALIDATED unbound variable

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12193 ) Change subject: IMPALA-8061: Fix S3_ACCESS_VALIDATED unbound variable .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8061: Fix S3 ACCESS VALIDATED unbound variable

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12193 ) Change subject: IMPALA-8061: Fix S3_ACCESS_VALIDATED unbound variable .. Patch Set 1: Did something recently fail that makes this

[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.

2019-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 ) Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones. .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-8043: Fix BE test failures related to SystemV timezones.

2019-01-09 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12199 Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones. .. IMPALA-8043: Fix BE test failures related to SystemV

[Impala-ASF-CR] IMPALA-6664: Tag log statements with fragment or query ids.

2019-01-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12129 ) Change subject: IMPALA-6664: Tag log statements with fragment or query ids. .. Patch Set 2: (5 comments)