[Impala-ASF-CR] IMPALA-7731: Add TxRatio counter to instances and query profile

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12229 ) Change subject: IMPALA-7731: Add TxRatio counter to instances and query profile .. Patch Set 1: Build Successful https://jenk

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 23: Verified+1 -- To vie

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. IMPALA-6964: Track stats abo

[Impala-ASF-CR] IMPALA-7731: Add TxRatio counter to instances and query profile

2019-01-16 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12229 Change subject: IMPALA-7731: Add TxRatio counter to instances and query profile .. IMPALA-7731: Add TxRatio counter to instances and query

[Impala-ASF-CR] IMPALA-7731: Add TxRatio counter to instances and query profile

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12229 ) Change subject: IMPALA-7731: Add TxRatio counter to instances and query profile .. Patch Set 1: (2 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. IMPALA-7889: Write new logical types in Parquet Fil

[Impala-ASF-CR] IMPALA-8078: fix test corrupt stats explain output

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12227 ) Change subject: IMPALA-8078: fix test_corrupt_stats explain output .. Patch Set 1: Verified+1 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-8078: fix test corrupt stats explain output

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12227 ) Change subject: IMPALA-8078: fix test_corrupt_stats explain output .. IMPALA-8078: fix test_corrupt_stats explain outpu

[Impala-ASF-CR] IMPALA-8066: Build coordinator and executor containers

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12228 ) Change subject: IMPALA-8066: Build coordinator and executor containers .. Patch Set 1: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 13: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-8078: fix test corrupt stats explain output

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12227 ) Change subject: IMPALA-8078: fix test_corrupt_stats explain output .. Patch Set 1: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 23: Build started: https:

[Impala-ASF-CR] IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW

2019-01-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12217 ) Change subject: IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW .. Patch Set 2:

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12172 ) Change subject: IMPALA-7979: Enhance decoders to support value-skipping .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8066: Build coordinator and executor containers

2019-01-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12228 Change subject: IMPALA-8066: Build coordinator and executor containers .. IMPALA-8066: Build coordinator and executor containers The co

[Impala-ASF-CR] [PROTOTYPE] IMPALA-5872: Test case builder for query planner

2019-01-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: [PROTOTYPE] IMPALA-5872: Test case builder for query planner .. Patch Set 1: Thanks, Greg. That looks simpler.

[Impala-ASF-CR] IMPALA-8078: fix test corrupt stats explain output

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12227 ) Change subject: IMPALA-8078: fix test_corrupt_stats explain output .. Patch Set 1: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-8078: fix test corrupt stats explain output

2019-01-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12227 ) Change subject: IMPALA-8078: fix test_corrupt_stats explain output .. Patch Set 1: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-8078: fix test corrupt stats explain output

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12227 ) Change subject: IMPALA-8078: fix test_corrupt_stats explain output .. Patch Set 1: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 13: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 13: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12172 ) Change subject: IMPALA-7979: Enhance decoders to support value-skipping .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8078: fix test corrupt stats explain output

2019-01-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12227 Change subject: IMPALA-8078: fix test_corrupt_stats explain output .. IMPALA-8078: fix test_corrupt_stats explain output Testing: impal

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 23: Build started: https:

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 22: Build Successful htt

[Impala-ASF-CR] IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW

2019-01-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12217 ) Change subject: IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW .. Patch Set 6: Code-Re

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 23: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-16 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11575 to look at the new patch set (#22). Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader ...

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-16 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 22: Forgot to update tests/infra/t

[Impala-ASF-CR] IMPALA-8061: Fix S3 ACCESS VALIDATED unbound variable

2019-01-16 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12193 ) Change subject: IMPALA-8061: Fix S3_ACCESS_VALIDATED unbound variable .. Patch Set 1: Code-Review+1 LGTM. I still wonder how/why it work

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 21: Verified-1 Build fail

[Impala-ASF-CR] IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW

2019-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12217 ) Change subject: IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW .. Patch Set 6:

[Impala-ASF-CR] IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW

2019-01-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12217 ) Change subject: IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW .. Patch Set 6: (2 comm

[Impala-ASF-CR] IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW

2019-01-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12217 ) Change subject: IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW .. IMPALA-7679: Improve er