[Impala-ASF-CR] IMPALA-8654: Log the SQL statement in the Ranger audit log

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13590 ) Change subject: IMPALA-8654: Log the SQL statement in the Ranger audit log .. Patch Set 2: Verified-1 Build failed: https://je

[Impala-ASF-CR] IMPALA-8629: (part 2) Adjust new KuduStorageHandler package

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13541 ) Change subject: IMPALA-8629: (part 2) Adjust new KuduStorageHandler package .. Patch Set 7: Verified-1 Build failed: https://j

[Impala-ASF-CR] IMPALA-8629: (part 2) Adjust new KuduStorageHandler package

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13541 ) Change subject: IMPALA-8629: (part 2) Adjust new KuduStorageHandler package .. Patch Set 7: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-8629: (part 2) Adjust new KuduStorageHandler package

2019-06-11 Thread Grant Henke (Code Review)
Hello Thomas Marshall, Hao Hao, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13541 to look at the new patch set (#7). Change subject: IMPALA-8629: (part 2) Adjust new KuduStorageHandler package ..

[Impala-ASF-CR] IMPALA-8629: (part 2) Adjust new KuduStorageHandler package

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13541 ) Change subject: IMPALA-8629: (part 2) Adjust new KuduStorageHandler package .. Patch Set 5: Build Successful https://jenkins.

[Impala-ASF-CR] IMPALA-8629: (part 2) Adjust new KuduStorageHandler package

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13541 ) Change subject: IMPALA-8629: (part 2) Adjust new KuduStorageHandler package .. Patch Set 4: Build Successful https://jenkins.

[Impala-ASF-CR] IMPALA-8629: (part 2) Adjust new KuduStorageHandler package

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13541 ) Change subject: IMPALA-8629: (part 2) Adjust new KuduStorageHandler package .. Patch Set 6: Verified-1 Build failed: https://j

[Impala-ASF-CR] IMPALA-8629: (part 2) Adjust new KuduStorageHandler package

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13541 ) Change subject: IMPALA-8629: (part 2) Adjust new KuduStorageHandler package .. Patch Set 6: Build Failed https://jenkins.impa

[Impala-ASF-CR] IMPALA-8629: (part 2) Adjust new KuduStorageHandler package

2019-06-11 Thread Grant Henke (Code Review)
Hello Thomas Marshall, Hao Hao, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13541 to look at the new patch set (#6). Change subject: IMPALA-8629: (part 2) Adjust new KuduStorageHandler package ..

[Impala-ASF-CR] IMPALA-8629: (part 2) Adjust new KuduStorageHandler package

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13541 ) Change subject: IMPALA-8629: (part 2) Adjust new KuduStorageHandler package .. Patch Set 6: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-8629: (part 2) Adjust new KuduStorageHandler package

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13541 ) Change subject: IMPALA-8629: (part 2) Adjust new KuduStorageHandler package .. Patch Set 5: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-8629: (part 2) Adjust new KuduStorageHandler package

2019-06-11 Thread Grant Henke (Code Review)
Hello Thomas Marshall, Hao Hao, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13541 to look at the new patch set (#5). Change subject: IMPALA-8629: (part 2) Adjust new KuduStorageHandler package ..

[Impala-ASF-CR] IMPALA-8629: (part 2) Adjust new KuduStorageHandler package

2019-06-11 Thread Grant Henke (Code Review)
Hello Thomas Marshall, Hao Hao, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13541 to look at the new patch set (#4). Change subject: IMPALA-8629: (part 2) Adjust new KuduStorageHandler package ..

[Impala-ASF-CR] IMPALA-8443: Record time spent in authorization in the runtime profile

2019-06-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13353 ) Change subject: IMPALA-8443: Record time spent in authorization in the runtime profile .. Patch Set 3: > Patch Set 3: Patch Set 2 was

[Impala-ASF-CR] IMPALA-8654: Log the SQL statement in the Ranger audit log

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13590 ) Change subject: IMPALA-8654: Log the SQL statement in the Ranger audit log .. Patch Set 2: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-8654: Log the SQL statement in the Ranger audit log

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13590 ) Change subject: IMPALA-8654: Log the SQL statement in the Ranger audit log .. Patch Set 2: Build started: https://jenkins.impa

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 9: Build Successful https

[Impala-ASF-CR] IMPALA-7608: Estimate row count from file size when no stats available

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12974 ) Change subject: IMPALA-7608: Estimate row count from file size when no stats available .. Patch Set 14: Build Successful htt

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12884 ) Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell .. Patch Set 20: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12884 ) Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell .. Patch Set 19: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration t

[Impala-ASF-CR] IMPALA-7608: Estimate row count from file size when no stats available

2019-06-11 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/12974 ) Change subject: IMPALA-7608: Estimate row count from file size when no stats available .. IMPALA-7608: Estimate row count from file size

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 5: I probably won't have a chance to review this, but it look

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12884 ) Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell .. Patch Set 20: (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-06-11 Thread Tim Armstrong (Code Review)
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12884 to look at the new patch set (#20). Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell ...

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-06-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12884 ) Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell .. Patch Set 19: Rebased. Had to make some changes for IMPALA-860

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12884 ) Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell .. Patch Set 19: (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-06-11 Thread Tim Armstrong (Code Review)
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12884 to look at the new patch set (#19). Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell ...

[Impala-ASF-CR] IMPALA-8654: Log the SQL statement in the Ranger audit log

2019-06-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13590 ) Change subject: IMPALA-8654: Log the SQL statement in the Ranger audit log .. Patch Set 1: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 5: Build Failed https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-8654: Log the SQL statement in the Ranger audit log

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13590 ) Change subject: IMPALA-8654: Log the SQL statement in the Ranger audit log .. Patch Set 1: Build Failed https://jenkins.impal

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13582/2/c

[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13563 ) Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Update mustache to commit b29095

[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13563 ) Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Patch Set 2: Verified+1 -- To view, vi

[Impala-ASF-CR] IMPALA-8654: Log the SQL statement in the Ranger audit log

2019-06-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13590 Change subject: IMPALA-8654: Log the SQL statement in the Ranger audit log .. IMPALA-8654: Log the SQL statement in the Ranger audit log

[Impala-ASF-CR] IMPALA-8649: Fix confusing SHOW GRANT error messages

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13587 ) Change subject: IMPALA-8649: Fix confusing SHOW GRANT error messages .. Patch Set 3: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-8649: Fix confusing SHOW GRANT error messages

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13587 ) Change subject: IMPALA-8649: Fix confusing SHOW GRANT error messages .. Patch Set 3: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13582/2/com

[Impala-ASF-CR] IMPALA-8649: Fix confusing SHOW GRANT error messages

2019-06-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13587 ) Change subject: IMPALA-8649: Fix confusing SHOW GRANT error messages .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13582/2/c

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. IMPALA-8617: Add support for lz4 in parquet A new enum value LZ4_BLOCKED

[Impala-ASF-CR] IMPALA-7608: Estimate row count from file size when no stats available

2019-06-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12974 ) Change subject: IMPALA-7608: Estimate row count from file size when no stats available .. Patch Set 12: (3 comments) I have a few mo

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 2: (8 comments) Thanks for the review comments. Please see

[Impala-ASF-CR] IMPALA-8649: Fix confusing SHOW GRANT error messages

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13587 ) Change subject: IMPALA-8649: Fix confusing SHOW GRANT error messages .. Patch Set 2: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-8605: clean up HS2/beeswax session management

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13585 ) Change subject: IMPALA-8605: clean up HS2/beeswax session management .. IMPALA-8605: clean up HS2/beeswax session manag

[Impala-ASF-CR] IMPALA-8605: clean up HS2/beeswax session management

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13585 ) Change subject: IMPALA-8605: clean up HS2/beeswax session management .. Patch Set 2: Verified+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown

2019-06-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 ) Change subject: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown .. Patch Set 1: Code-Revi

[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13522 ) Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1) .. Patch Set 6: Verified+1 -- To view, visit ht

[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13522 ) Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1) .. IMPALA-8561: Eliminate mtime=-1 for HDFS scan

[Impala-ASF-CR] IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 ) Change subject: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown .. Patch Set 1:

[Impala-ASF-CR] IMPALA-8649: Fix confusing SHOW GRANT error messages

2019-06-11 Thread Austin Nobis (Code Review)
Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/13587 ) Change subject: IMPALA-8649: Fix confusing SHOW GRANT error messages .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-8649: Fix confusing SHOW GRANT error messages

2019-06-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13587 Change subject: IMPALA-8649: Fix confusing SHOW GRANT error messages .. IMPALA-8649: Fix confusing SHOW GRANT error messages Before this

[Impala-ASF-CR] IMPALA-8593: Prohibit write operations for bucketed tables

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13558 ) Change subject: IMPALA-8593: Prohibit write operations for bucketed tables .. Patch Set 2: Build Successful https://jenkins.i

[Impala-ASF-CR] IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown

2019-06-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13586 Change subject: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown .. IMPALA-7154 : Er

[Impala-ASF-CR] IMPALA-8436: Prohibit write/alter operations on materialized view

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13503 ) Change subject: IMPALA-8436: Prohibit write/alter operations on materialized view .. Patch Set 5: Verified+1 -- To view, vis

[Impala-ASF-CR] IMPALA-8593: Prohibit write operations for bucketed tables

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13558 ) Change subject: IMPALA-8593: Prohibit write operations for bucketed tables .. Patch Set 2: (4 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8593: Prohibit write operations for bucketed tables

2019-06-11 Thread Yongzhi Chen (Code Review)
Hello Vihang Karajgaonkar, Sudhanshu Arora, Zoltan Borok-Nagy, Todd Lipcon, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13558 to look at the new patch set (#2). Change subject: IMPALA-8593: Prohibit

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/13582/2//C

[Impala-ASF-CR] IMPALA-8633 : Insert event should not error when table does not exists

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13548 ) Change subject: IMPALA-8633 : Insert event should not error when table does not exists .. Patch Set 5: Build Successful http

[Impala-ASF-CR] IMPALA-8633 : Insert event should not error when table does not exists

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13548 ) Change subject: IMPALA-8633 : Insert event should not error when table does not exists .. Patch Set 6: Build Successful http

[Impala-ASF-CR] IMPALA-8633 : Insert event should not error when table does not exists

2019-06-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13548 ) Change subject: IMPALA-8633 : Insert event should not error when table does not exists .. Patch Set 6: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-8633 : Insert event should not error when table does not exists

2019-06-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/13548 ) Change subject: IMPALA-8633 : Insert event should not error when table does not exists .. IMPALA-8633 : Insert event should not er

[Impala-ASF-CR] IMPALA-8633 : Insert event should not error when table does not exists

2019-06-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13548 ) Change subject: IMPALA-8633 : Insert event should not error when table does not exists .. IMPALA-8633 : Insert event should not er

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-06-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12884 ) Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell .. Patch Set 18: I got back to this. It turns out that the shell

[Impala-ASF-CR] IMPALA-8593: Prohibit write operations for bucketed tables

2019-06-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13558 ) Change subject: IMPALA-8593: Prohibit write operations for bucketed tables .. Patch Set 1: (1 comment) Drive-by comment. Hope this he

[Impala-ASF-CR] IMPALA-8588: Fix revoke grant option with Ranger

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13450 ) Change subject: IMPALA-8588: Fix revoke grant option with Ranger .. Patch Set 3: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-8588: Fix revoke grant option with Ranger

2019-06-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13450 ) Change subject: IMPALA-8588: Fix revoke grant option with Ranger .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8588: Fix revoke grant option with Ranger

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13450 ) Change subject: IMPALA-8588: Fix revoke grant option with Ranger .. Patch Set 3: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-8588: Fix revoke grant option with Ranger

2019-06-11 Thread Austin Nobis (Code Review)
Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/13450 ) Change subject: IMPALA-8588: Fix revoke grant option with Ranger .. Patch Set 2: (1 comment) > Patch Set 2: > > (1 comment) http://ge

[Impala-ASF-CR] IMPALA-8612: Fix sporadic NPE when dropping an authorized table

2019-06-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 ) Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table .. Patch Set 1: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8633 : Insert event should not error when table does not exists

2019-06-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13548 ) Change subject: IMPALA-8633 : Insert event should not error when table does not exists .. Patch Set 4: (1 comment) > (1 commen

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 2: Build Successful https://jenkins.impala.io/job/ge

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-11 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13463 ) Change subject: fe: improve logging for metadata loading .. Patch Set 1: (5 comments) Patch looks good to me. left some non-blo

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13582 Change subject: IMPALA-8617: Add support for lz4 in parquet .. IMPALA-8617: Add support for lz4 in parquet A new enum value LZ4_BLOCKE

[Impala-ASF-CR] IMPALA-7608: Estimate row count from file size when no stats available

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12974 ) Change subject: IMPALA-7608: Estimate row count from file size when no stats available .. Patch Set 12: Build Successful htt

[Impala-ASF-CR] IMPALA-8605: clean up HS2/beeswax session management

2019-06-11 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13585 ) Change subject: IMPALA-8605: clean up HS2/beeswax session management .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-8605: clean up HS2/beeswax session management

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13585 ) Change subject: IMPALA-8605: clean up HS2/beeswax session management .. Patch Set 1: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13522 ) Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1) .. Patch Set 6: Build Successful https://jenkin

[Impala-ASF-CR] IMPALA-8605: clean up HS2/beeswax session management

2019-06-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13585 ) Change subject: IMPALA-8605: clean up HS2/beeswax session management .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-7467: Ported ExecQueryFInstances over to krpc

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13583 ) Change subject: IMPALA-7467: Ported ExecQueryFInstances over to krpc .. Patch Set 1: Build Successful https://jenkins.impala.

[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13563 ) Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13563 ) Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Patch Set 2: Build started: https://jen

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-06-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13522 ) Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1) .. Patch Set 6: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13522 ) Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1) .. Patch Set 6: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-7608: Estimate row count from file size when no stats available

2019-06-11 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/12974 ) Change subject: IMPALA-7608: Estimate row count from file size when no stats available .. IMPALA-7608: Estimate row count from file size

[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-11 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13522 to look at the new patch set (#6). Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1) ..

[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13522 ) Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1) .. Patch Set 4: (3 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8605: clean up HS2/beeswax session management

2019-06-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13585 Change subject: IMPALA-8605: clean up HS2/beeswax session management .. IMPALA-8605: clean up HS2/beeswax session management Session/op

[Impala-ASF-CR] IMPALA-8605: clean up HS2/beeswax session management

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13585 ) Change subject: IMPALA-8605: clean up HS2/beeswax session management .. Patch Set 2: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7467: Ported ExecQueryFInstances over to krpc

2019-06-11 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13583 Change subject: IMPALA-7467: Ported ExecQueryFInstances over to krpc .. IMPALA-7467: Ported ExecQueryFInstances over to krpc This pat

[Impala-ASF-CR] IMPALA-8593: Prohibit write operations for bucketed tables

2019-06-11 Thread Sudhanshu Arora (Code Review)
Sudhanshu Arora has posted comments on this change. ( http://gerrit.cloudera.org:8080/13558 ) Change subject: IMPALA-8593: Prohibit write operations for bucketed tables .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8436: Prohibit write/alter operations on materialized view

2019-06-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13503 ) Change subject: IMPALA-8436: Prohibit write/alter operations on materialized view .. Patch Set 5: Build started: https://jenk

[Impala-ASF-CR] IMPALA-8593: Prohibit write operations for bucketed tables

2019-06-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13558 ) Change subject: IMPALA-8593: Prohibit write operations for bucketed tables .. Patch Set 1: (5 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-8593: Prohibit write operations for bucketed tables

2019-06-11 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13558 ) Change subject: IMPALA-8593: Prohibit write operations for bucketed tables .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:808