[Impala-ASF-CR] IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases'

2019-12-12 Thread Zhou Xu (Code Review)
Zhou Xu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14846 ) Change subject: IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases' .. IMPALA-9195: Using multithreaded execution

[Impala-ASF-CR] IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases'

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14846 ) Change subject: IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases' .. Patch Set 2: Build Succes

[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.

2019-12-12 Thread Zhou Xu (Code Review)
Zhou Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14896 Change subject: IMPALA-9035: Simplify casting string to timestamp. .. IMPALA-9035: Simplify casting string to timestamp. Case 1: Simplify 'st

[Impala-ASF-CR] IMPALA-9035: Simplify casting string to timestamp.

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14896 ) Change subject: IMPALA-9035: Simplify casting string to timestamp. .. Patch Set 1: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2019-12-12 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/14080/9/

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2019-12-12 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. IMPALA-8755: Backend support for Z-ordering This change depends on gerri

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2019-12-12 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. IMPALA-8755: Backend support for Z-ordering This change depends on gerri

[Impala-ASF-CR] IMPALA-7550: Add documentation to profile counters

2019-12-12 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/14776 ) Change subject: IMPALA-7550: Add documentation to profile counters .. Patch Set 8: Code-Review+1 Thanks Jiawei, LGTM. -- To view

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 14: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 13: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-8891: concat ws() null handling is non-standard

2019-12-12 Thread jichen (Code Review)
jichen has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14885 ) Change subject: IMPALA-8891: concat_ws() null handling is non-standard .. IMPALA-8891: concat_ws() null handling is non-standard This patch fix

[Impala-ASF-CR] IMPALA-8891: concat ws() null handling is non-standard

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14885 ) Change subject: IMPALA-8891: concat_ws() null handling is non-standard .. Patch Set 5: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-9009: Core support for Ranger column masking

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14894 ) Change subject: IMPALA-9009: Core support for Ranger column masking .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9009: Core support for Ranger column masking

2019-12-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14894 ) Change subject: IMPALA-9009: Core support for Ranger column masking .. IMPALA-9009: Core support for Ranger column masking Ranger provi

[Impala-ASF-CR] IMPALA-8891: concat ws() null handling is non-standard

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14885 ) Change subject: IMPALA-8891: concat_ws() null handling is non-standard .. Patch Set 5: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-9009: Core support for Ranger column masking

2019-12-12 Thread Quanlong Huang (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14894 to look at the new patch set (#4). Change subject: IMPALA-9009: Core support for Ranger column masking ..

[Impala-ASF-CR] IMPALA-9009: Core support for Ranger column masking

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14894 ) Change subject: IMPALA-9009: Core support for Ranger column masking .. Patch Set 2: Build Failed https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-9149: part 1: Re-enabe Ranger-related FE tests

2019-12-12 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14798 ) Change subject: IMPALA-9149: part 1: Re-enabe Ranger-related FE tests .. Patch Set 7: (1 comment) Hi Kurt and Quanlong, I left some add

[Impala-ASF-CR] IMPALA-4192: Move static state from ExecNode into a PlanNode

2019-12-12 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Daniel Becker, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14764 to look at the new patch set (#11). Change subject: IMPALA-4192: Move static state from ExecNode into a PlanNode ..

[Impala-ASF-CR] IMPALA-4192: Move static state from ExecNode into a PlanNode

2019-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14764 ) Change subject: IMPALA-4192: Move static state from ExecNode into a PlanNode .. Patch Set 10: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-4192: Move static state from ExecNode into a PlanNode

2019-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14764 ) Change subject: IMPALA-4192: Move static state from ExecNode into a PlanNode .. Patch Set 10: LGTM once you fix the long lines from th

[Impala-ASF-CR] IMPALA-4192: Move static state from ExecNode into a PlanNode

2019-12-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14764 ) Change subject: IMPALA-4192: Move static state from ExecNode into a PlanNode .. Patch Set 11: (5 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-4192: Move static state from ExecNode into a PlanNode

2019-12-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14764 ) Change subject: IMPALA-4192: Move static state from ExecNode into a PlanNode .. Patch Set 11: Code-Review+2 Carrying over +2 from Tim

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. Patch Set 11: (1 comment) http:

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-12-12 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 13: > > (1 comment) > > This bug happened

[Impala-ASF-CR] IMPALA-4192: Move static state from ExecNode into a PlanNode

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14764 ) Change subject: IMPALA-4192: Move static state from ExecNode into a PlanNode .. Patch Set 11: Build Successful https://jenkin

[native-toolchain-CR] IMPALA-9237: Make package binutils building work on aarch64

2019-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14888 ) Change subject: IMPALA-9237: Make package binutils building work on aarch64 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:80

[native-toolchain-CR] IMPALA-9238: Make package libtool building work on aarch64

2019-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14889 ) Change subject: IMPALA-9238: Make package libtool building work on aarch64 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit

[native-toolchain-CR] IMPALA-9238: Make package libtool building work on aarch64

2019-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14889 ) Change subject: IMPALA-9238: Make package libtool building work on aarch64 .. Patch Set 1: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-12-12 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-12 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#12). Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. Patch Set 12: (4 comments) Updated patch.

[Impala-ASF-CR] IMPALA-9092: Add support for creating external Kudu table

2019-12-12 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/14750 ) Change subject: IMPALA-9092: Add support for creating external Kudu table .. IMPALA-9092: Add support for creating external Kudu t

[Impala-ASF-CR] IMPALA-9092: Add support for creating external Kudu table

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 ) Change subject: IMPALA-9092: Add support for creating external Kudu table .. Patch Set 10: (3 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. Patch Set 12: Build Successful h

[Impala-ASF-CR] IMPALA-9092: Add support for creating external Kudu table

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 ) Change subject: IMPALA-9092: Add support for creating external Kudu table .. Patch Set 10: Build Successful https://jenkins.i

[Impala-ASF-CR] IMPALA-9138: Classify certain errors as retryable

2019-12-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14882 ) Change subject: IMPALA-9138: Classify certain errors as retryable .. Patch Set 1: > (1 comment) Yeah, that is a good point wrt one fra

[Impala-ASF-CR] IMPALA-9138: Classify certain errors as retryable

2019-12-12 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14882 to look at the new patch set (#2). Change subject: IMPALA-9138: Classify certain errors as retryable .

[Impala-ASF-CR] IMPALA-9138: Classify certain errors as retryable

2019-12-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14882 ) Change subject: IMPALA-9138: Classify certain errors as retryable .. Patch Set 2: Updated patch addressing Thomas' comments. The most

[Impala-ASF-CR] IMPALA-9138: Classify certain errors as retryable

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14882 ) Change subject: IMPALA-9138: Classify certain errors as retryable .. Patch Set 2: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases'

2019-12-12 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14846 ) Change subject: IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases' .. Patch Set 2: (9 comments)

[native-toolchain-CR] IMPALA-9237: Make package binutils building work on aarch64

2019-12-12 Thread Anonymous Coward (Code Review)
Hello Quanlong Huang, Matthew Jacobs, Fredy Wijaya, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14888 to look at the new patch set (#2). Change subject: IMPALA-9237: Make package binutils building work on aarch64 ..

[native-toolchain-CR] IMPALA-9237: Make package binutils building work on aarch64

2019-12-12 Thread Anonymous Coward (Code Review)
huangtianhua...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14888 ) Change subject: IMPALA-9237: Make package binutils building work on aarch64 .. Patch Set 2: (1 comment) Tim Armstrong, Th

[Impala-ASF-CR] IMPALA-9092: Add support for creating external Kudu table

2019-12-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 ) Change subject: IMPALA-9092: Add support for creating external Kudu table .. Patch Set 10: Code-Review+2 (7 comments) LGTM. Thanks f

[native-toolchain-CR] IMPALA-9244 Bump up boost to work on aarch64

2019-12-12 Thread Anonymous Coward (Code Review)
huangtianhua...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14898 Change subject: IMPALA-9244 Bump up boost to work on aarch64 .. IMPALA-9244 Bump up boost to work on aarch64 Boost support

[native-toolchain-CR] IMPALA-9244 Bump up boost to work on aarch64

2019-12-12 Thread Anonymous Coward (Code Review)
huangtianhua...@gmail.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14898 ) Change subject: IMPALA-9244 Bump up boost to work on aarch64 .. IMPALA-9244 Bump up boost to work on aarch64 Boost support A

[native-toolchain-CR] IMPALA-9238: Make package libtool building work on aarch64

2019-12-12 Thread Anonymous Coward (Code Review)
huangtianhua...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14889 ) Change subject: IMPALA-9238: Make package libtool building work on aarch64 .. Patch Set 2: Tim Armstrong, Sorry, I made a

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-12-12 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 13: > (1 comment) Lock both kudu table creation and h

[Impala-ASF-CR] IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases'

2019-12-12 Thread Zhou Xu (Code Review)
Zhou Xu has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14846 ) Change subject: IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases' .. IMPALA-9195: Using multithreaded execution

[native-toolchain-CR] Make llvm for aarch64 platform.

2019-12-12 Thread Anonymous Coward (Code Review)
huangtianhua...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14900 Change subject: Make llvm for aarch64 platform. .. Make llvm for aarch64 platform. Change-Id: I4a59e8c9c847b3c7eb05584230e1

[native-toolchain-CR] IMPALA-9236 Make llvm for aarch64 platform.

2019-12-12 Thread Anonymous Coward (Code Review)
huangtianhua...@gmail.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14900 ) Change subject: IMPALA-9236 Make llvm for aarch64 platform. .. IMPALA-9236 Make llvm for aarch64 platform. Change-Id: I4a59e

[Impala-ASF-CR] IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases'

2019-12-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14846 ) Change subject: IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases' .. Patch Set 4: Build Succes