[Impala-ASF-CR] IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator .. Patch

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 ) Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator .. Patch Set 11: (5 comments)

[Impala-ASF-CR] WIP: IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16264 ) Change subject: WIP: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 ) Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-07-30 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 ) Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator .. Patch Set 11: (11 comments)

[Impala-ASF-CR] WIP: IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2020-07-30 Thread Yida Wu (Code Review)
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16264 Change subject: WIP: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. WIP: IMPALA-9867: Add Support for Spilling to S3: Milestone

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 ) Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-9983 : Pushdown limit to analytic sort operator

2020-07-30 Thread Aman Sinha (Code Review)
Hello Qifan Chen, Shant Hovsepian, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16219 to look at the new patch set (#11). Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator

[Impala-ASF-CR] IMPALA-9903: Reduce Kudu openTable calls per query

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16120 ) Change subject: IMPALA-9903: Reduce Kudu openTable calls per query .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-9903: Reduce Kudu openTable calls per query

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16120 ) Change subject: IMPALA-9903: Reduce Kudu openTable calls per query .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-9903: Reduce Kudu openTable calls per query

2020-07-30 Thread Grant Henke (Code Review)
Hello Qifan Chen, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16120 to look at the new patch set (#7). Change subject: IMPALA-9903: Reduce Kudu openTable calls per query

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-07-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16263 Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. IMPALA-10029: Strip debug symbols from

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 11: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator .. Patch

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-07-30 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#12). Change subject: IMPALA-9979: part 2: partitioned top-n

[native-toolchain-CR] IMPALA-9903: Bump Kudu version to 5ad5d3d66

2020-07-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16257 ) Change subject: IMPALA-9903: Bump Kudu version to 5ad5d3d66 .. IMPALA-9903: Bump Kudu version to 5ad5d3d66 This patch bumps

[native-toolchain-CR] IMPALA-9903: Bump Kudu version to 5ad5d3d66

2020-07-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16257 ) Change subject: IMPALA-9903: Bump Kudu version to 5ad5d3d66 .. Patch Set 1: Verified+1 This passed a build of all components on

[native-toolchain-CR] IMPALA-9903: Bump Kudu version to 5ad5d3d66

2020-07-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16257 ) Change subject: IMPALA-9903: Bump Kudu version to 5ad5d3d66 .. Patch Set 1: Code-Review+2 -- To view, visit

[native-toolchain-CR] IMPALA-9903: Bump Kudu version to 5ad5d3d66

2020-07-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16257 ) Change subject: IMPALA-9903: Bump Kudu version to 5ad5d3d66 .. Patch Set 1: This patch successfully built on Jenkins (without

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16235 ) Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions .. Patch Set 8: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16188 ) Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used .. Patch Set 5: (2 comments) > Did you run

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-30 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 11: (5 comments)

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-30 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16123 to look at the new patch set (#11). Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

[Impala-ASF-CR] IMPALA-10006: handle non-writable /opt/impala/logs

2020-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16237 ) Change subject: IMPALA-10006: handle non-writable /opt/impala/logs .. IMPALA-10006: handle non-writable /opt/impala/logs The

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-07-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 25: (1 comment)

[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.04

2020-07-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16241 ) Change subject: IMPALA-10007: Impala development environment does not support Ubuntu 20.04 .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-10006: handle non-writable /opt/impala/logs

2020-07-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16237 ) Change subject: IMPALA-10006: handle non-writable /opt/impala/logs .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10006: handle non-writable /opt/impala/logs

2020-07-30 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/16237 ) Change subject: IMPALA-10006: handle non-writable /opt/impala/logs .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 3: I think we should make some more effort to

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-07-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 3: TBH that was an educated guess based on the

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-07-30 Thread Adam Tamas (Code Review)
Adam Tamas has posted comments on this change. ( http://gerrit.cloudera.org:8080/16259 ) Change subject: IMPALA-9963: Implement ds_kll_n() function .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16235 ) Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16259 ) Change subject: IMPALA-9963: Implement ds_kll_n() function .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-30 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16235 to look at the new patch set (#8). Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-07-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16259 Change subject: IMPALA-9963: Implement ds_kll_n() function .. IMPALA-9963: Implement ds_kll_n() function This functions receives a

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16235 ) Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions .. Patch Set 7: Build Failed

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16235 ) Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-30 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16235 to look at the new patch set (#7). Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-07-30 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 3: Tim, how can you see that from the crash

[Impala-ASF-CR] WIP: IMPALA-9979: part 2: partitioned top-n

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: WIP: IMPALA-9979: part 2: partitioned top-n .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-10024: isBlackListedDb() should do a case-insensitive check

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16254 ) Change subject: IMPALA-10024: isBlackListedDb() should do a case-insensitive check .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-10024: isBlackListedDb() should do a case-insensitive check

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16254 ) Change subject: IMPALA-10024: isBlackListedDb() should do a case-insensitive check .. IMPALA-10024: isBlackListedDb()

[Impala-ASF-CR] WIP: IMPALA-9979: part 2: partitioned top-n

2020-07-30 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#11). Change subject: WIP: IMPALA-9979: part 2: partitioned top-n