[Impala-ASF-CR] IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state

2020-08-24 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16351 ) Change subject: IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state .. Patch Set 2: (1 comment) Hi Sahil, sorry that I

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 5: Verified-1 Build failed: https://jenk

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 4: Build failed: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 4: Build Successful https://jenkins.imp

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-24 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 4: (2 comments) > Patch Set 3: > > (1 comment

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-24 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Qifan Chen, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16349 to look at the new patch set (#4). Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. ...

[native-toolchain-CR] IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform

2020-08-24 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16357 Change subject: IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform .. IMPALA-10088 Fix DeadLock while run

[native-toolchain-CR] IMPALA-10089 Fix large code model issue of llvm on aarch64

2020-08-24 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16356 Change subject: IMPALA-10089 Fix large code model issue of llvm on aarch64 .. IMPALA-10089 Fix large code model issue of llvm o

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 5: Build Successful https://jenkins.imp

[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1

2020-08-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 ) Change subject: IMPALA-10103: upgrade jquery to 3.5.1 .. Patch Set 1: did you forget to add jquery-3.5.1.min.js? -- To view, visit

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 5: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16345 to look at the new patch set (#5). Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS ...

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 4: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 ) Change subject: IMPALA-10103: upgrade jquery to 3.5.1 .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-c

[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1

2020-08-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16355 Change subject: IMPALA-10103: upgrade jquery to 3.5.1 .. IMPALA-10103: upgrade jquery to 3.5.1 Testing: Manually clicked through most o

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 ) Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile .. Patch Set 6: Verified+1 -- To view, visit h

[Impala-ASF-CR] IMPALA-9382: part 1: transposed profile prototype

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15798 ) Change subject: IMPALA-9382: part 1: transposed profile prototype .. Patch Set 17: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-9382: part 1: transposed profile prototype

2020-08-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15798 ) Change subject: IMPALA-9382: part 1: transposed profile prototype .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/15

[Impala-ASF-CR] IMPALA-9382: part 1: transposed profile prototype

2020-08-24 Thread Tim Armstrong (Code Review)
Hello Kurt Deschler, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15798 to look at the new patch set (#17). Change subject: IMPALA-9382: part 1: transposed profile prototype ...

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client .. Patch Set 7:

[Impala-ASF-CR] IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator .. Patch Set 10: Ver

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/16314/8/

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-24 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 3: (1 comment) Looks good to me! http://gerrit.cl

[Impala-ASF-CR] IMPALA-10050: Fixed DCHECK error for backend in terminal state.

2020-08-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16303 ) Change subject: IMPALA-10050: Fixed DCHECK error for backend in terminal state. .. Patch Set 5: (2 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-5022: Outer join simplification

2020-08-24 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022: Outer join simplification .. Patch Set 10: (11 comments) Thanks a lot for the code change. I do have some c

[Impala-ASF-CR] IMPALA-9990: Support SET OWNER for Kudu tables

2020-08-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16273 ) Change subject: IMPALA-9990: Support SET OWNER for Kudu tables .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16273/1/

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 4: Verified-1 Build failed: https://jenk

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 8: Build Successful https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 ) Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile .. Patch Set 6: Build started: https://jenkins.

[Impala-ASF-CR] IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state

2020-08-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16351 ) Change subject: IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state .. Patch Set 1: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-24 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. IMPALA-7658: Proper codegen for HiveUdfCall Implementing codegen for Hive

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 3: (1 comment) I think this makes sense to me -

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 4: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions

2020-08-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15531 ) Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions .. Patch Set 46: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions

2020-08-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15531 ) Change subject: IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instructions .. IMPALA-9544 Replace Intel's SSE i

[Impala-ASF-CR] IMPALA-10092: Do not skip test vectors of Kudu tests in a custom cluster

2020-08-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16348 ) Change subject: IMPALA-10092: Do not skip test vectors of Kudu tests in a custom cluster .. Patch Set 1: (1 comment) http:/

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 ) Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16280 ) Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. .. IMPALA-10034: Add remaining TPC-DS queries to worklo

[Impala-ASF-CR] IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator .. Patch Set 10: Bu

[Impala-ASF-CR] IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator

2020-08-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator .. Patch Set 10: Code-Review

[Impala-ASF-CR] IMPALA-10092: Do not skip test vectors of Kudu tests in a custom cluster

2020-08-24 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16348 ) Change subject: IMPALA-10092: Do not skip test vectors of Kudu tests in a custom cluster .. Patch Set 1: Hi Tim and Thomas, please revi

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 4: Build Successful https://jenkins.imp

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 4: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16345 to look at the new patch set (#4). Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS ...

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16336 ) Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function .. Patch Set 2: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-24 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16336 to look at the new patch set (#2). Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function

[Impala-ASF-CR] IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator .. Patch Set 10: Bu

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 ) Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile .. Patch Set 5: Build Successful https://jenki

[Impala-ASF-CR] IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator

2020-08-24 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator .. Patch Set 9: (3 comment

[Impala-ASF-CR] IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator

2020-08-24 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16240 to look at the new patch set (#10). Change subject: IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator .

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

2020-08-24 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/16331 ) Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile .. IMPALA-7779 Parquet Scanner can write binary data into pro

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles as string() function

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16324 ) Change subject: IMPALA-9962: Implement ds_kll_quantiles_as_string() function .. Patch Set 7: Build Successful https://jenkins

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles as string() function

2020-08-24 Thread Gabor Kaszab (Code Review)
Hello Adam Tamas, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16324 to look at the new patch set (#7). Change subject: IMPALA-9962: Implement ds_kll_quantiles_as_string() function ...

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 3: Verified-1 Build failed: https://jenk

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client .. Pat

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-24 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client .. Patch Set

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-24 Thread Quanlong Huang (Code Review)
Hello Thomas Tauber-Marshall, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16323 to look at the new patch set (#7). Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning