[Impala-ASF-CR] IMPALA-10046: Support constant propagation for eligible range predicates

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16346 ) Change subject: IMPALA-10046: Support constant propagation for eligible range predicates .. Patch Set 4: Build started: https

[Impala-ASF-CR] IMPALA-10046: Support constant propagation for eligible range predicates

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16346 ) Change subject: IMPALA-10046: Support constant propagation for eligible range predicates .. Patch Set 3: (1 comment) http://

[Impala-ASF-CR] IMPALA-10046: Support constant propagation for eligible range predicates

2020-08-25 Thread Aman Sinha (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16346 to look at the new patch set (#3). Change subject: IMPALA-10046: Support constant propagation for eligible range predicates ..

[Impala-ASF-CR] IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16363 ) Change subject: IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor .. Patch Set 2: Build Successful https:

[Impala-ASF-CR] IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16363 ) Change subject: IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor .. Patch Set 2: Build started: https://j

[Impala-ASF-CR] IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor

2020-08-25 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16363 ) Change subject: IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor .. IMPALA-4364: [Addendum] Compare specific f

[Impala-ASF-CR] IMPALA-10020: Implement ds kll cdf as string() function

2020-08-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16359 ) Change subject: IMPALA-10020: Implement ds_kll_cdf_as_string() function .. Patch Set 3: Code-Review+2 Carry +2 from Csaba -- To view,

[Impala-ASF-CR] IMPALA-10020: Implement ds kll cdf as string() function

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16359 ) Change subject: IMPALA-10020: Implement ds_kll_cdf_as_string() function .. Patch Set 3: Build started: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 6: Verified-1 Build failed: https://jenk

[Impala-ASF-CR] IMPALA-10080: Skip loading HDFS cache pools for non-HDFS file systems

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16335 ) Change subject: IMPALA-10080: Skip loading HDFS cache pools for non-HDFS file systems .. Patch Set 2: Verified-1 Build failed

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 7: Build Successful https://jenkins.imp

[native-toolchain-CR] IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform

2020-08-25 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16357 ) Change subject: IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform .. IMPALA-10088 Fix DeadLock while run u

[native-toolchain-CR] IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform

2020-08-25 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16357 ) Change subject: IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform .. Patch Set 2: (1 comment) http://g

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 7: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16345 to look at the new patch set (#7). Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS ...

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client .. Pat

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16336 ) Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function .. IMPALA-10019: Implement ds_kll_pmf_as_string

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16336 ) Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function .. Patch Set 4: Verified+1 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-10060: Upgrade Postgres JDBC driver to 42.2.14

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16362 ) Change subject: IMPALA-10060: Upgrade Postgres JDBC driver to 42.2.14 .. Patch Set 1: Verified+1 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 6: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-9989 Improve admission control pool stats logging

2020-08-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16220 ) Change subject: IMPALA-9989 Improve admission control pool stats logging .. Patch Set 38: Code-Review+1 (8 comments) I didn't look thr

[Impala-ASF-CR] IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor

2020-08-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16363 ) Change subject: IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor .. Patch Set 1: Code-Review+2 (2 comments) LGT

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 6: Build Successful https://jenkins.imp

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 6: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 6: Too many parallel CR had some things sneak

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16345 to look at the new patch set (#6). Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS ...

[Impala-ASF-CR] IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16338 ) Change subject: IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows .. Patch Set 3: Verified+1 -- To view, vi

[Impala-ASF-CR] IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16338 ) Change subject: IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows .. IMPALA-7782: fix constant NOT IN

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client .. Pat

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client .. Pat

[Impala-ASF-CR] IMPALA-10080: Skip loading HDFS cache pools for non-HDFS file systems

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16335 ) Change subject: IMPALA-10080: Skip loading HDFS cache pools for non-HDFS file systems .. Patch Set 2: Code-Review+2 -- To vi

[Impala-ASF-CR] IMPALA-10080: Skip loading HDFS cache pools for non-HDFS file systems

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16335 ) Change subject: IMPALA-10080: Skip loading HDFS cache pools for non-HDFS file systems .. Patch Set 2: Build started: https://

[Impala-ASF-CR] IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16363 ) Change subject: IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor .. Patch Set 1: Build Successful https:

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key .. IMPALA-8547: get_json_object fails t

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor

2020-08-25 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16363 Change subject: IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor .. IMPALA-4364: [Addendum] Compare specific

[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16355 ) Change subject: IMPALA-10103: upgrade jquery to 3.5.1 .. IMPALA-10103: upgrade jquery to 3.5.1 Testing: Manually click

[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 ) Change subject: IMPALA-10103: upgrade jquery to 3.5.1 .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16336 ) Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function .. Patch Set 4: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16336 ) Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function .. Patch Set 4: Code-Review+2 PS4 is a rebase with master. Carr

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16336 ) Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function .. Patch Set 4: Build started: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-25 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16336 to look at the new patch set (#4). Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function ...

[Impala-ASF-CR] IMPALA-10060: Upgrade Postgres JDBC driver to 42.2.14

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16362 ) Change subject: IMPALA-10060: Upgrade Postgres JDBC driver to 42.2.14 .. Patch Set 1: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-10080: Skip loading HDFS cache pools for non-HDFS file systems

2020-08-25 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16335 ) Change subject: IMPALA-10080: Skip loading HDFS cache pools for non-HDFS file systems .. Patch Set 1: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-9990: Support SET OWNER for Kudu tables

2020-08-25 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16273 ) Change subject: IMPALA-9990: Support SET OWNER for Kudu tables .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-10060: Upgrade Postgres JDBC driver to 42.2.14

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16362 Change subject: IMPALA-10060: Upgrade Postgres JDBC driver to 42.2.14 .. IMPALA-10060: Upgrade Postgres JDBC driver to 42.2.14 Change-I

[Impala-ASF-CR] IMPALA-10060: Upgrade Postgres JDBC driver to 42.2.14

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16362 ) Change subject: IMPALA-10060: Upgrade Postgres JDBC driver to 42.2.14 .. Patch Set 1: Build started: https://jenkins.impala.io

[native-toolchain-CR] IMPALA-10089 Fix large code model issue of llvm on aarch64

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16356 ) Change subject: IMPALA-10089 Fix large code model issue of llvm on aarch64 .. IMPALA-10089 Fix large code model issue of llvm o

[native-toolchain-CR] IMPALA-10089 Fix large code model issue of llvm on aarch64

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16356 ) Change subject: IMPALA-10089 Fix large code model issue of llvm on aarch64 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles as string() function

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16324 ) Change subject: IMPALA-9962: Implement ds_kll_quantiles_as_string() function .. Patch Set 8: Verified+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles as string() function

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16324 ) Change subject: IMPALA-9962: Implement ds_kll_quantiles_as_string() function .. IMPALA-9962: Implement ds_kll_quantiles

[Impala-ASF-CR] IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16338 ) Change subject: IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows .. Patch Set 3: This was the hive data loading iss

[Impala-ASF-CR] IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16338 ) Change subject: IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows .. Patch Set 3: Build started: https://jen

[Impala-ASF-CR] IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16338 ) Change subject: IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16338 ) Change subject: IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows .. Patch Set 2: Verified-1 Build failed: h

[Impala-ASF-CR] IMPALA-7658: Proper codegen for HiveUdfCall

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 ) Change subject: IMPALA-7658: Proper codegen for HiveUdfCall .. Patch Set 10: Code-Review+2 (2 comments) I'm happy with this modulo co

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key .. Patch Set 4: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key .. Patch Set 4: Build started: https://jenkins

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key .. Patch Set 3: Code-Review+2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client .. Patch Set 8:

[Impala-ASF-CR] IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16338 ) Change subject: IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows .. Patch Set 2: Thanks for the review! -- To vie

[Impala-ASF-CR] IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator .. IMPALA-9955,IMPAL

[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 ) Change subject: IMPALA-10103: upgrade jquery to 3.5.1 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 ) Change subject: IMPALA-10103: upgrade jquery to 3.5.1 .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-veri

[Impala-ASF-CR] IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator .. Patch Set 12: Code-Review

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 5: Looks like some discrepancies in the planner

[native-toolchain-CR] IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16357 ) Change subject: IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform .. Patch Set 1: (2 comments) Thanks for the c

[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1

2020-08-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 ) Change subject: IMPALA-10103: upgrade jquery to 3.5.1 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 ) Change subject: IMPALA-10103: upgrade jquery to 3.5.1 .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-c

[Impala-ASF-CR] WIP - IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 ) Change subject: WIP - IMPALA-9382: part 2/3: aggregate profiles sent to coordinator .. Patch Set 10: Build Failed https://je

[Impala-ASF-CR] IMPALA-10050: Fixed DCHECK error for backend in terminal state.

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16303 ) Change subject: IMPALA-10050: Fixed DCHECK error for backend in terminal state. .. Patch Set 6: Build Successful https://jenk

[native-toolchain-CR] IMPALA-10089 Fix large code model issue of llvm on aarch64

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16356 ) Change subject: IMPALA-10089 Fix large code model issue of llvm on aarch64 .. Patch Set 1: Code-Review+2 Will do a test build along wi

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

2020-08-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16331 ) Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile .. IMPALA-7779 Parquet Scanner can write binary d

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

2020-08-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 ) Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile .. Patch Set 6: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1

2020-08-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 ) Change subject: IMPALA-10103: upgrade jquery to 3.5.1 .. Patch Set 1: Oops, thanks for pointing that out. -- To view, visit http://g

[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1

2020-08-25 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16355 to look at the new patch set (#2). Change subject: IMPALA-10103: upgrade jquery to 3.5.1 ..

[Impala-ASF-CR] WIP - IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-08-25 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16057 to look at the new patch set (#10). Change subject: WIP - IMPALA-9382: part 2/3: aggregate profiles sent to coordinator ..

[Impala-ASF-CR] WIP - IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 ) Change subject: WIP - IMPALA-9382: part 2/3: aggregate profiles sent to coordinator .. Patch Set 10: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-10050: Fixed DCHECK error for backend in terminal state.

2020-08-25 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/16303 ) Change subject: IMPALA-10050: Fixed DCHECK error for backend in terminal state. .. IMPALA-10050: Fixed DCHECK error for backend in terminal

[Impala-ASF-CR] IMPALA-9482 Support for BINARY columns

2020-08-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16066 ) Change subject: IMPALA-9482 Support for BINARY columns .. Patch Set 7: (1 comment) I only checked the FE part of the patch. Will conti

[Impala-ASF-CR] IMPALA-5022: Outer join simplification

2020-08-25 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022: Outer join simplification .. Patch Set 12: (10 comments) Looks good! Thanks a lot to convince me on null-r

[Impala-ASF-CR] IMPALA-10106: Upgrade DataSketches in be/src/thirdparty

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16360 ) Change subject: IMPALA-10106: Upgrade DataSketches in be/src/thirdparty .. Patch Set 3: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-10106: Upgrade DataSketches in be/src/thirdparty

2020-08-25 Thread Adam Tamas (Code Review)
Adam Tamas has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16360 ) Change subject: IMPALA-10106: Upgrade DataSketches in be/src/thirdparty .. IMPALA-10106: Upgrade DataSketches in be/src/thirdparty Upgrade

[Impala-ASF-CR] IMPALA-10106: Upgrade DataSketches in be/src/thirdparty

2020-08-25 Thread Adam Tamas (Code Review)
Adam Tamas has posted comments on this change. ( http://gerrit.cloudera.org:8080/16360 ) Change subject: IMPALA-10106: Upgrade DataSketches in be/src/thirdparty .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: IMPALA-9955,IMPALA-9957: Fix not enough reservation for large pages in GroupingAggregator .. Patch Set 12: Ver

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-25 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-10020: Implement ds kll cdf as string() function

2020-08-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16359 ) Change subject: IMPALA-10020: Implement ds_kll_cdf_as_string() function .. Patch Set 2: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16336 ) Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function .. Patch Set 3: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16338 ) Change subject: IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows

2020-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16338 ) Change subject: IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows .. Patch Set 1: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16338 ) Change subject: IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows .. Patch Set 2: Build started: https://jen

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles as string() function

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16324 ) Change subject: IMPALA-9962: Implement ds_kll_quantiles_as_string() function .. Patch Set 8: Build started: https://jenkins.im

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles as string() function

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16324 ) Change subject: IMPALA-9962: Implement ds_kll_quantiles_as_string() function .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles as string() function

2020-08-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16324 ) Change subject: IMPALA-9962: Implement ds_kll_quantiles_as_string() function .. Patch Set 7: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-10106: Update DataSketches

2020-08-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16360 ) Change subject: IMPALA-10106: Update DataSketches .. Patch Set 2: (2 comments) I did some research and it seems that the 2.1.0 release

[Impala-ASF-CR] IMPALA-10106: Update DataSketches

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16360 ) Change subject: IMPALA-10106: Update DataSketches .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-

[Impala-ASF-CR] IMPALA-10106: Update DataSketches

2020-08-25 Thread Adam Tamas (Code Review)
Adam Tamas has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16360 Change subject: IMPALA-10106: Update DataSketches .. IMPALA-10106: Update DataSketches Update the external DataSketches files for HLL/KLL

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client .. Pat

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16323 ) Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client .. Patch Set

[Impala-ASF-CR] IMPALA-9225: Query option for retryable queries to spool all results before returning any to the client

2020-08-25 Thread Quanlong Huang (Code Review)
Hello Thomas Tauber-Marshall, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16323 to look at the new patch set (#8). Change subject: IMPALA-9225: Query option for retryable queries to spool all results before returning

  1   2   >