[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 6

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch S

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch S

[Impala-ASF-CR] IMPALA-10463: Implement ds theta sketch() and ds theta estimate() functions

2021-02-17 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17008 ) Change subject: IMPALA-10463: Implement ds_theta_sketch() and ds_theta_estimate() functions .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10463: Implement ds theta sketch() and ds theta estimate() functions

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17008 ) Change subject: IMPALA-10463: Implement ds_theta_sketch() and ds_theta_estimate() functions .. Patch Set 5: Code-Review+2 --

[Impala-ASF-CR] IMPALA-10463: Implement ds theta sketch() and ds theta estimate() functions

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17008 ) Change subject: IMPALA-10463: Implement ds_theta_sketch() and ds_theta_estimate() functions .. Patch Set 5: Build started: ht

[Impala-ASF-CR] IMPALA-8680: Docker-based tests fail to archive the minicluster component logs

2021-02-17 Thread Zoltan Garaguly (Code Review)
Hello Laszlo Gaal, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15898 to look at the new patch set (#5). Change subject: IMPALA-8680: Docker-based tests fail to archive the minicluster component logs ...

[Impala-ASF-CR] IMPALA-8680: Docker-based tests fail to archive the minicluster component logs

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15898 ) Change subject: IMPALA-8680: Docker-based tests fail to archive the minicluster component logs .. Patch Set 5: Build Successf

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch S

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17071 to look at the new patch set (#2). Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ .. Pat

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ ..

[Impala-ASF-CR] IMPALA-10503: testdata load hits hive memory limit errors during hive inserts

2021-02-17 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17061 ) Change subject: IMPALA-10503: testdata load hits hive memory limit errors during hive inserts .. Patch Set 3: recheck -- To view, v

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 6

[Impala-ASF-CR] IMPALA-10161: User LDAP Search bind support

2021-02-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17047 ) Change subject: IMPALA-10161: User LDAP Search bind support .. Patch Set 2: Code-Review+1 Leaving at a +1 for now in case Csa

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Csaba Ringhofer (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16833 to look at the new patch set (#25). Change subject: IMPALA-10496: SAML implementation in Impala ..

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 25: (16 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 25: (11 comments) http://gerrit.cloudera.org:8080/#/c/1683

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 26: Build started: https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-10503: testdata load hits hive memory limit errors during hive inserts

2021-02-17 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17061 ) Change subject: IMPALA-10503: testdata load hits hive memory limit errors during hive inserts .. Patch Set 3: > Patch Set 3: > > Verify

[Impala-ASF-CR] IMPALA-10503: testdata load hits hive memory limit errors during hive inserts

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17061 ) Change subject: IMPALA-10503: testdata load hits hive memory limit errors during hive inserts .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-10503: testdata load hits hive memory limit errors during hive inserts

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17061 ) Change subject: IMPALA-10503: testdata load hits hive memory limit errors during hive inserts .. Patch Set 4: Code-Review+2

[Impala-ASF-CR] IMPALA-10463: Implement ds theta sketch() and ds theta estimate() functions

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17008 ) Change subject: IMPALA-10463: Implement ds_theta_sketch() and ds_theta_estimate() functions .. Patch Set 5: Verified+1 -- To

[Impala-ASF-CR] IMPALA-10463: Implement ds theta sketch() and ds theta estimate() functions

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17008 ) Change subject: IMPALA-10463: Implement ds_theta_sketch() and ds_theta_estimate() functions .. IMPALA-10463: Implement

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 25: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-10504: Add tracing for remote block reads

2021-02-17 Thread Kurt Deschler (Code Review)
Hello Aman Sinha, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17062 to look at the new patch set (#4). Change subject: IMPALA-10504: Add tracing for remote block reads

[Impala-ASF-CR] IMPALA-10504: Add tracing for remote block reads

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17062 ) Change subject: IMPALA-10504: Add tracing for remote block reads .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-10507: Workaround for sporadic TPC-DS testdata insert error

2021-02-17 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17065 ) Change subject: IMPALA-10507: Workaround for sporadic TPC-DS testdata insert error .. Patch Set 1: The error doesn't repro in my bran

[Impala-ASF-CR] IMPALA-10507: Workaround for sporadic TPC-DS testdata insert error

2021-02-17 Thread Kurt Deschler (Code Review)
Kurt Deschler has abandoned this change. ( http://gerrit.cloudera.org:8080/17065 ) Change subject: IMPALA-10507: Workaround for sporadic TPC-DS testdata insert error .. Abandoned Fixed by IMPALA-9777 -- To view, visit http://

[Impala-ASF-CR] IMPALA-10504: Add tracing for remote block reads

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17062 ) Change subject: IMPALA-10504: Add tracing for remote block reads .. Patch Set 4: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17077 Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. IMPALA-10509: Add tool to visualize Impala query p

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 ) Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. Patch Set 1: (2 comments) http://gerri

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17077 to look at the new patch set (#2). Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 ) Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. Patch Set 2: (2 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 ) Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. Patch Set 1: Build Successful https://

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 ) Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. Patch Set 2: Build Successful https://

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 ) Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. Patch Set 2: Code-Review+1 (13 comments) Thanks f

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 26: Code-Review+2 (1 comment) Looks good, just one

[Impala-ASF-CR] IMPALA-10503: testdata load hits hive memory limit errors during hive inserts

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17061 ) Change subject: IMPALA-10503: testdata load hits hive memory limit errors during hive inserts .. Patch Set 4: Verified-1 Buil

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 26: Verified+1 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. IMPALA-10496: SAML implementation in Impala The bulk of

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 27: Oh, looks like you ran the verify job without 'd

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17077 to look at the new patch set (#3). Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 ) Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. Patch Set 3: (13 comments) Thank you for the fe

[Impala-ASF-CR] IMPALA-10504: Add tracing for remote block reads

2021-02-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17062 ) Change subject: IMPALA-10504: Add tracing for remote block reads .. Patch Set 4: (2 comments) Thanks for fixing the last round of com

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 ) Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. Patch Set 3: Build Successful https://

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-17 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#70). ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. IMPALA-10325: Parqu

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch S

[Impala-ASF-CR] IMPALA-10505: Avoid creating misleading audit logs

2021-02-17 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17078 Change subject: IMPALA-10505: Avoid creating misleading audit logs .. IMPALA-10505: Avoid creating misleading audit logs Before this patc

[Impala-ASF-CR] IMPALA-10505: Avoid creating misleading audit logs

2021-02-17 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17078 ) Change subject: IMPALA-10505: Avoid creating misleading audit logs .. Patch Set 2: Sorry that I forgot to mention how to reproduce the i

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 ) Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. Patch Set 3: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 ) Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 ) Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. Patch Set 4: Build started: https://jen

[Impala-ASF-CR] IMPALA-10505: Avoid creating misleading audit logs

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17078 ) Change subject: IMPALA-10505: Avoid creating misleading audit logs .. Patch Set 2: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions

2021-02-17 Thread Anonymous Coward (Code Review)
scar...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17079 Change subject: IMPALA-10510: Change code to help with third party extensions .. IMPALA-10510: Change code to help with third par

[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 1: Build Successful https://jenkin

[Impala-ASF-CR] IMPALA-xxxxx: [WIP] Refactoring to support external frontend.

2021-02-17 Thread Aman Sinha (Code Review)
Aman Sinha has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17080 Change subject: IMPALA-x: [WIP] Refactoring to support external frontend. .. IMPALA-x: [WIP] Refactoring to support external fronte

[Impala-ASF-CR] IMPALA-xxxxx: [WIP] Refactoring to support external frontend.

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17080 ) Change subject: IMPALA-x: [WIP] Refactoring to support external frontend. .. Patch Set 1: (1 comment) http://gerrit.cloud