[Impala-ASF-CR] IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap

2021-04-09 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17292 ) Change subject: IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap .. Patch Set 1: Tested with successful builds on t

[Impala-ASF-CR] IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap

2021-04-09 Thread Laszlo Gaal (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17292 to look at the new patch set (#3). Change subject: IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap ...

[Impala-ASF-CR] Try out larger yarn containers

2021-04-09 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 ) Change subject: Try out larger yarn containers .. Patch Set 1: Code-Review+1 It helped my builds and did not break the FE tests. -- To

[Impala-ASF-CR] IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17292 ) Change subject: IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap .. Patch Set 3: Build Successful https:

[Impala-ASF-CR] IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap

2021-04-09 Thread Laszlo Gaal (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17292 to look at the new patch set (#4). Change subject: IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap ...

[Impala-ASF-CR] IMPALA-10643: Allow the inclusion of jetty-client

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17287 ) Change subject: IMPALA-10643: Allow the inclusion of jetty-client .. Patch Set 2: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-10643: Allow the inclusion of jetty-client

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17287 ) Change subject: IMPALA-10643: Allow the inclusion of jetty-client .. Patch Set 2: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-10583: Fix bug on unbounded result spooling memory config.

2021-04-09 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17187 ) Change subject: IMPALA-10583: Fix bug on unbounded result spooling memory config. .. Patch Set 1: Code-Review+1 (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap

2021-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17292 ) Change subject: IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [WIP] IMPALA-10650: Bailout minm/ax filters in hash join builder early

2021-04-09 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17295 ) Change subject: [WIP] IMPALA-10650: Bailout minm/ax filters in hash join builder early .. [WIP] IMPALA-10650: Bailout minm/ax filters in ha

[Impala-ASF-CR] [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early

2021-04-09 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17295 ) Change subject: [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early .. [WIP] IMPALA-10650: Bailout min/max filters in ha

[Impala-ASF-CR] [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17295 ) Change subject: [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early .. Patch Set 3: Build Successful http

[Impala-ASF-CR] [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17295 ) Change subject: [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early .. Patch Set 5: Build Successful http

[Impala-ASF-CR] IMPALA-10583: Fix bug on unbounded result spooling memory config.

2021-04-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17187 ) Change subject: IMPALA-10583: Fix bug on unbounded result spooling memory config. .. Patch Set 1: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-10596: De-flake TestAdmissionControllerStress

2021-04-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17272 ) Change subject: IMPALA-10596: De-flake TestAdmissionControllerStress .. Patch Set 1: Code-Review+1 Looks good to me, thanks Bikram for

[Impala-ASF-CR] IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17292 ) Change subject: IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap .. Patch Set 4: Build started: https://j

[Impala-ASF-CR] IMPALA-10596: De-flake TestAdmissionControllerStress

2021-04-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17272 ) Change subject: IMPALA-10596: De-flake TestAdmissionControllerStress .. Patch Set 1: Code-Review+2 LGTM -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-10596: De-flake TestAdmissionControllerStress

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17272 ) Change subject: IMPALA-10596: De-flake TestAdmissionControllerStress .. Patch Set 2: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-10596: De-flake TestAdmissionControllerStress

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17272 ) Change subject: IMPALA-10596: De-flake TestAdmissionControllerStress .. Patch Set 2: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-09 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. IMPALA-10647 Improve always-true min/max filter

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 11: (1 comment) http://

[Impala-ASF-CR] IMPALA-10583: Fix bug on unbounded result spooling memory config.

2021-04-09 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17187 ) Change subject: IMPALA-10583: Fix bug on unbounded result spooling memory config. .. Patch Set 1: Code-Review+2 (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-10583: Fix bug on unbounded result spooling memory config.

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17187 ) Change subject: IMPALA-10583: Fix bug on unbounded result spooling memory config. .. Patch Set 2: Build started: https://jenk

[Impala-ASF-CR] IMPALA-10583: Fix bug on unbounded result spooling memory config.

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17187 ) Change subject: IMPALA-10583: Fix bug on unbounded result spooling memory config. .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 11: Build Successful ht

[Impala-ASF-CR] Try out larger yarn containers

2021-04-09 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 ) Change subject: Try out larger yarn containers .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17201 To

[Impala-ASF-CR] Try out larger yarn containers

2021-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 ) Change subject: Try out larger yarn containers .. Patch Set 1: Code-Review-2 Now that we know it helps, we can move forward with this.

[Impala-ASF-CR] IMPALA-10643: Allow the inclusion of jetty-client

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17287 ) Change subject: IMPALA-10643: Allow the inclusion of jetty-client .. IMPALA-10643: Allow the inclusion of jetty-client

[Impala-ASF-CR] IMPALA-10643: Allow the inclusion of jetty-client

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17287 ) Change subject: IMPALA-10643: Allow the inclusion of jetty-client .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-09 Thread Sourabh Goyal (Code Review)
Sourabh Goyal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17298 Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. .. IMPALA-10648: Inv

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. .. Patch Se

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-09 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 11: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-09 Thread Sourabh Goyal (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17298 to look at the new patch set (#2). Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. .. Patch Se

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. .. Patch Se

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. .. Patch Se

[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload

2021-04-09 Thread Joe McDonnell (Code Review)
Hello Laszlo Gaal, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17201 to look at the new patch set (#2). Change subject: IMPALA-10503: Use larger yarn containers for dataload .

[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload

2021-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed a vote on this change. Change subject: IMPALA-10503: Use larger yarn containers for dataload .. Removed Code-Review-2 by Joe McDonnell -- To view, visit http://gerrit.cloudera.org:8080/17201 To unsubsc

[Impala-ASF-CR] [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early

2021-04-09 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17295 ) Change subject: [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early .. Patch Set 5: Do you have performance test res

[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 ) Change subject: IMPALA-10503: Use larger yarn containers for dataload .. Patch Set 2: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 ) Change subject: IMPALA-10503: Use larger yarn containers for dataload .. Patch Set 2: Build started: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17292 ) Change subject: IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17292 ) Change subject: IMPALA-10646: Add non-server RHEL 8 signature to toolchain bootstrap .. IMPALA-10646: Add non-server R

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-09 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. IMPALA-10647 Improve always-true min/max filter

[Impala-ASF-CR] IMPALA-10596: De-flake TestAdmissionControllerStress

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17272 ) Change subject: IMPALA-10596: De-flake TestAdmissionControllerStress .. IMPALA-10596: De-flake TestAdmissionControllerS

[Impala-ASF-CR] IMPALA-10596: De-flake TestAdmissionControllerStress

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17272 ) Change subject: IMPALA-10596: De-flake TestAdmissionControllerStress .. Patch Set 2: Verified+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-09 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17289 Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. IMPALA-10532: TestOverlapMinMaxFilters.

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 15: Build Successful ht

[Impala-ASF-CR] IMPALA-10583: Fix bug on unbounded result spooling memory config.

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17187 ) Change subject: IMPALA-10583: Fix bug on unbounded result spooling memory config. .. IMPALA-10583: Fix bug on unbounde

[Impala-ASF-CR] IMPALA-10583: Fix bug on unbounded result spooling memory config.

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17187 ) Change subject: IMPALA-10583: Fix bug on unbounded result spooling memory config. .. Patch Set 2: Verified+1 -- To view, vis

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-09 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17289 ) Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. Patch Set 2: Code-Review+1 -- To vi

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-09 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 15: Code-Review+1 -- To view, vis

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17289 ) Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. Patch Set 2: Build Success

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 15: (2 comments) Thanks Qifan fo

[Impala-ASF-CR] [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early

2021-04-09 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17295 ) Change subject: [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early .. Patch Set 5: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-10503: Use larger yarn containers for dataload

2021-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17201 ) Change subject: IMPALA-10503: Use larger yarn containers for dataload .. Patch Set 2: Verified-1 Build failed: https://jenkins