[Impala-ASF-CR] IMPALA-10701: Switch to use TByteBuffer from thrift

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17428 ) Change subject: IMPALA-10701: Switch to use TByteBuffer from thrift .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-10701: Switch to use TByteBuffer from thrift

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17428 ) Change subject: IMPALA-10701: Switch to use TByteBuffer from thrift .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9155: Add recovery mechanism to admission service

2021-05-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17332 ) Change subject: IMPALA-9155: Add recovery mechanism to admission service .. Patch Set 1: (3 comments) I read through the code once,

[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option

2021-05-19 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 2: (2 comments) Thanks Wenzhe for the reply.

[Impala-ASF-CR] IMPALA-8769: [DOCS] Change the shell default

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17349 ) Change subject: IMPALA-8769: [DOCS] Change the shell default .. IMPALA-8769: [DOCS] Change the shell default Changed

[Impala-ASF-CR] IMPALA-8769: [DOCS] Change the shell default

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17349 ) Change subject: IMPALA-8769: [DOCS] Change the shell default .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option

2021-05-19 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 2: (2 comments) Thanks Qifan for your comments.

[Impala-ASF-CR] IMPALA-8769: [DOCS] Change the shell default

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17349 ) Change subject: IMPALA-8769: [DOCS] Change the shell default .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8769: [DOCS] Change the shell default

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17349 ) Change subject: IMPALA-8769: [DOCS] Change the shell default .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-8769: [DOCS] Change the shell default

2021-05-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17349 ) Change subject: IMPALA-8769: [DOCS] Change the shell default .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10681: Improve inner join cardinality estimates

2021-05-19 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17387 ) Change subject: IMPALA-10681: Improve inner join cardinality estimates .. Patch Set 5: (9 comments) Thanks Zoltan and Qifan for the

[Impala-ASF-CR] IMPALA-10681: Improve inner join cardinality estimates

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17387 ) Change subject: IMPALA-10681: Improve inner join cardinality estimates .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr

2021-05-19 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17413 ) Change subject: IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr .. Patch Set 4: (18 comments) Looks good and I may

[Impala-ASF-CR] IMPALA-10681: Improve inner join cardinality estimates

2021-05-19 Thread Aman Sinha (Code Review)
Hello Qifan Chen, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17387 to look at the new patch set (#5). Change subject: IMPALA-10681: Improve inner join cardinality estimates

[Impala-ASF-CR] IMPALA-10681: Improve inner join cardinality estimates

2021-05-19 Thread Aman Sinha (Code Review)
Hello Qifan Chen, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17387 to look at the new patch set (#4). Change subject: IMPALA-10681: Improve inner join cardinality estimates

[Impala-ASF-CR] IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr

2021-05-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17413 ) Change subject: IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-10485: Support Iceberg field-id based column resolution in the ORC scanner

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17398 ) Change subject: IMPALA-10485: Support Iceberg field-id based column resolution in the ORC scanner .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr

2021-05-19 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17413 ) Change subject: IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-05-19 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 5: (3 comments) Looks great!

[Impala-ASF-CR] IMPALA-10485: Support Iceberg field-id based column resolution in the ORC scanner

2021-05-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17398 ) Change subject: IMPALA-10485: Support Iceberg field-id based column resolution in the ORC scanner .. Patch Set 3: PS3 was a

[Impala-ASF-CR] IMPALA-10485: Support Iceberg field-id based column resolution in the ORC scanner

2021-05-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17398 to look at the new patch set (#3). Change subject: IMPALA-10485: Support Iceberg field-id based column resolution in

[Impala-ASF-CR] IMPALA-10681: Improve join cardinality estimates

2021-05-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17387 ) Change subject: IMPALA-10681: Improve join cardinality estimates .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option

2021-05-19 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 2: (2 comments) Looks good!

[Impala-ASF-CR] IMPALA-10681: Improve join cardinality estimates

2021-05-19 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17387 ) Change subject: IMPALA-10681: Improve join cardinality estimates .. Patch Set 3: (9 comments) Hi Aman, Thanks a lot for the work. I

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-05-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 5: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-10702: Add warning logs for slow or large catalogd response

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17427 ) Change subject: IMPALA-10702: Add warning logs for slow or large catalogd response .. IMPALA-10702: Add warning logs

[Impala-ASF-CR] IMPALA-10702: Add warning logs for slow or large catalogd response

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17427 ) Change subject: IMPALA-10702: Add warning logs for slow or large catalogd response .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-10688: Implement ds cpc stringify() function

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17373 ) Change subject: IMPALA-10688: Implement ds_cpc_stringify() function .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10695: add dedicated thread pool for OSS/JindoFS.

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 ) Change subject: IMPALA-10695: add dedicated thread pool for OSS/JindoFS. .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10695: add dedicated thread pool for OSS/JindoFS.

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17455 ) Change subject: IMPALA-10695: add dedicated thread pool for OSS/JindoFS. .. IMPALA-10695: add dedicated thread pool

[Impala-ASF-CR] IMPALA-10695: add dedicated thread pool for OSS/JindoFS.

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 ) Change subject: IMPALA-10695: add dedicated thread pool for OSS/JindoFS. .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-10702: Add warning logs for slow or large catalogd response

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17427 ) Change subject: IMPALA-10702: Add warning logs for slow or large catalogd response .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-10702: Add warning logs for slow or large catalogd response

2021-05-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17427 ) Change subject: IMPALA-10702: Add warning logs for slow or large catalogd response .. Patch Set 5: Code-Review+2 Resolved conflicts

[Impala-ASF-CR] IMPALA-10702: Add warning logs for slow or large catalogd response

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17427 ) Change subject: IMPALA-10702: Add warning logs for slow or large catalogd response .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-10197: Add KUDU REPLICA SELECTION query option

2021-05-19 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17396 ) Change subject: IMPALA-10197: Add KUDU_REPLICA_SELECTION query option .. IMPALA-10197: Add KUDU_REPLICA_SELECTION query option Sometimes

[Impala-ASF-CR] IMPALA-10688: Implement ds cpc stringify() function

2021-05-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17373 ) Change subject: IMPALA-10688: Implement ds_cpc_stringify() function .. Patch Set 4: Code-Review+2 Sure, I re-launched the verify job.

[Impala-ASF-CR] IMPALA-10688: Implement ds cpc stringify() function

2021-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17373 ) Change subject: IMPALA-10688: Implement ds_cpc_stringify() function .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-10681: Improve join cardinality estimates

2021-05-19 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17387 ) Change subject: IMPALA-10681: Improve join cardinality estimates .. Patch Set 3: > Patch Set 1: > > Thanks for the reply Aman. I wonder

[Impala-ASF-CR] IMPALA-10702: Add warning logs for slow or large catalogd response

2021-05-19 Thread Quanlong Huang (Code Review)
Hello Aman Sinha, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17427 to look at the new patch set (#5). Change subject: IMPALA-10702: Add warning logs for slow or large catalogd response