[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

2022-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 ) Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events" .. Patch Set 1: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-7864: (Addendum) Deflake test replan limit by postponing catalog fetches

2022-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18537 ) Change subject: IMPALA-7864: (Addendum) Deflake test_replan_limit by postponing catalog fetches .. Patch Set 2: (2 comments) http:

[Impala-ASF-CR] IMPALA-11295: Deflake TestParquet.test multiple blocks mt dop

2022-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18533 ) Change subject: IMPALA-11295: Deflake TestParquet.test_multiple_blocks_mt_dop .. Patch Set 3: Code-Review+2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18514 ) Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name .. Patch Set 4: Build started: ht

[Impala-ASF-CR] IMPALA-7864: (Addendum) Deflake test replan limit by postponing catalog fetches

2022-05-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18537 ) Change subject: IMPALA-7864: (Addendum) Deflake test_replan_limit by postponing catalog fetches .. Patch Set 2: (2 comments) http:/

[Impala-ASF-CR] IMPALA-10851: Codegen for structs

2022-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18526 ) Change subject: IMPALA-10851: Codegen for structs .. Patch Set 2: (6 comments) Went through the non-struct related refactors, but s

[Impala-ASF-CR] IMPALA-7864: (Addendum) Deflake test replan limit by postponing catalog fetches

2022-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18537 ) Change subject: IMPALA-7864: (Addendum) Deflake test_replan_limit by postponing catalog fetches .. Patch Set 2: Code-Review+2 Thank

[Impala-ASF-CR] IMPALA-11289: Push-down compound predicates to iceberg

2022-05-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18535 ) Change subject: IMPALA-11289: Push-down compound predicates to iceberg .. Patch Set 4: Code-Review+1 (3 comments) Great work! Onl

[Impala-ASF-CR] IMPALA-7864: (Addendum) Deflake test replan limit by postponing catalog fetches

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18537 ) Change subject: IMPALA-7864: (Addendum) Deflake test_replan_limit by postponing catalog fetches .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-7864: (Addendum) Deflake test replan limit by postponing catalog fetches

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18537 ) Change subject: IMPALA-7864: (Addendum) Deflake test_replan_limit by postponing catalog fetches .. Patch Set 3: Build started

[Impala-ASF-CR] IMPALA-9410: Support resolving ORC file columns by names

2022-05-23 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18397 ) Change subject: IMPALA-9410: Support resolving ORC file columns by names .. IMPALA-9410: Support resolving ORC file columns by names

[Impala-ASF-CR] IMPALA-9410: Support resolving ORC file columns by names

2022-05-23 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18397 ) Change subject: IMPALA-9410: Support resolving ORC file columns by names .. Patch Set 6: (8 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-9410: Support resolving ORC file columns by names

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18397 ) Change subject: IMPALA-9410: Support resolving ORC file columns by names .. Patch Set 6: Build Successful https://jenkins.imp

[Impala-ASF-CR] IMPALA-9410: Support resolving ORC file columns by names

2022-05-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18397 ) Change subject: IMPALA-9410: Support resolving ORC file columns by names .. Patch Set 6: Code-Review+1 (2 comments) Looks great!

[Impala-ASF-CR] IMPALA-10851: Codegen for structs

2022-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18526 ) Change subject: IMPALA-10851: Codegen for structs .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/18526/2//COMMIT_

[Impala-ASF-CR] IMPALA-1682: Support print the output of a query (rows) vertically.

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18549 ) Change subject: IMPALA-1682: Support print the output of a query (rows) vertically. .. Patch Set 5: Build started: https://je

[Impala-ASF-CR] IMPALA-11311: Fixed debug noopt build directory

2022-05-23 Thread Code Review
Gergely Fürnstáhl has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18555 Change subject: IMPALA-11311: Fixed debug_noopt build directory .. IMPALA-11311: Fixed debug_noopt build directory It used "release

[Impala-ASF-CR] IMPALA-11311: Fixed debug noopt build directory

2022-05-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18555 ) Change subject: IMPALA-11311: Fixed debug_noopt build directory .. Patch Set 1: Code-Review+1 Thanks for fixing it. -- To view, visi

[Impala-ASF-CR] IMPALA-11311: Fixed debug noopt build directory

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18555 ) Change subject: IMPALA-11311: Fixed debug_noopt build directory .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-11311: Fixed debug noopt build directory

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18555 ) Change subject: IMPALA-11311: Fixed debug_noopt build directory .. Patch Set 2: Build started: https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-11311: Fixed debug noopt build directory

2022-05-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18555 ) Change subject: IMPALA-11311: Fixed debug_noopt build directory .. Patch Set 1: Code-Review+2 Thanks for fixing this! -- To view

[Impala-ASF-CR] IMPALA-11311: Fixed debug noopt build directory

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18555 ) Change subject: IMPALA-11311: Fixed debug_noopt build directory .. Patch Set 1: Build Successful https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-11274: CNF Rewrite causes a regress in join node performance

2022-05-23 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18458 ) Change subject: IMPALA-11274: CNF Rewrite causes a regress in join node performance .. Patch Set 14: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10453: Support file pruning via runtime filters on Iceberg

2022-05-23 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 ) Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg .. Patch Set 1: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18514 ) Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name .. Patch Set 4: Verified-1 Build

[Impala-ASF-CR] IMPALA-10453: Support file pruning via runtime filters on Iceberg

2022-05-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 ) Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg .. Patch Set 1: Also, could you please run the

[Impala-ASF-CR] IMPALA-11305: Fix TypeError in impala-shell summary progress

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18546 ) Change subject: IMPALA-11305: Fix TypeError in impala-shell summary progress .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11305: Fix TypeError in impala-shell summary progress

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18546 ) Change subject: IMPALA-11305: Fix TypeError in impala-shell summary progress .. Patch Set 3: Build started: https://jenkins.im

[Impala-ASF-CR] IMPALA-7864: (Addendum) Deflake test replan limit by postponing catalog fetches

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18537 ) Change subject: IMPALA-7864: (Addendum) Deflake test_replan_limit by postponing catalog fetches .. Patch Set 3: Verified-1 Bu

[Impala-ASF-CR] IMPALA-11129: Support running KRPC over Unix Domain Socket

2022-05-23 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/18369 ) Change subject: IMPALA-11129: Support running KRPC over Unix Domain Socket .. IMPALA-11129: Support running KRPC over Unix Domain Socket T

[Impala-ASF-CR] IMPALA-7864: (Addendum) Deflake test replan limit by postponing catalog fetches

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18537 ) Change subject: IMPALA-7864: (Addendum) Deflake test_replan_limit by postponing catalog fetches .. Patch Set 3: Build started

[Impala-ASF-CR] IMPALA-11129: Support running KRPC over Unix Domain Socket

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18369 ) Change subject: IMPALA-11129: Support running KRPC over Unix Domain Socket .. Patch Set 9: Build Successful https://jenkins.i

[Impala-ASF-CR] IMPALA-1682: Support print the output of a query (rows) vertically.

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18549 ) Change subject: IMPALA-1682: Support print the output of a query (rows) vertically. .. Patch Set 5: Build failed: https://jen

[Impala-ASF-CR] IMPALA-11305: Fix TypeError in impala-shell summary progress

2022-05-23 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18546 ) Change subject: IMPALA-11305: Fix TypeError in impala-shell summary progress .. Patch Set 3: Code-Review+1 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-11311: Fixed debug noopt build directory

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18555 ) Change subject: IMPALA-11311: Fixed debug_noopt build directory .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-11311: Fixed debug noopt build directory

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18555 ) Change subject: IMPALA-11311: Fixed debug_noopt build directory .. IMPALA-11311: Fixed debug_noopt build directory It

[Impala-ASF-CR] IMPALA-11305: Fix TypeError in impala-shell summary progress

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18546 ) Change subject: IMPALA-11305: Fix TypeError in impala-shell summary progress .. Patch Set 3: Verified+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-11305: Fix TypeError in impala-shell summary progress

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18546 ) Change subject: IMPALA-11305: Fix TypeError in impala-shell summary progress .. IMPALA-11305: Fix TypeError in impala-s

[Impala-ASF-CR] IMPALA-7864: (Addendum) Deflake test replan limit by postponing catalog fetches

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18537 ) Change subject: IMPALA-7864: (Addendum) Deflake test_replan_limit by postponing catalog fetches .. Patch Set 3: Verified+1 -

[Impala-ASF-CR] IMPALA-7864: (Addendum) Deflake test replan limit by postponing catalog fetches

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18537 ) Change subject: IMPALA-7864: (Addendum) Deflake test_replan_limit by postponing catalog fetches .. IMPALA-7864: (Adden

[Impala-ASF-CR] IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18556 Change subject: IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes .. IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-s

[Impala-ASF-CR] IMPALA-11249: Fix add test dimensions() locations to call super()

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18557 Change subject: IMPALA-11249: Fix add_test_dimensions() locations to call super() .. IMPALA-11249: Fix add_test_dimensions() locations

[Impala-ASF-CR] IMPALA-11251: Fix TestImpalaShellInteractive.test unicode input on Ubuntu 20

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18558 Change subject: IMPALA-11251: Fix TestImpalaShellInteractive.test_unicode_input on Ubuntu 20 .. IMPALA-11251: Fix TestImpalaShellIntera

[Impala-ASF-CR] IMPALA-10199: Add Ubuntu 20 toolchain configuration

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18559 Change subject: IMPALA-10199: Add Ubuntu 20 toolchain configuration .. IMPALA-10199: Add Ubuntu 20 toolchain configuration Ubuntu 20 ha

[Impala-ASF-CR] IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes

2022-05-23 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18556 ) Change subject: IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10199: Add Ubuntu 20 toolchain configuration

2022-05-23 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18559 ) Change subject: IMPALA-10199: Add Ubuntu 20 toolchain configuration .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18556 ) Change subject: IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes .. Patch Set 1: Build Successful https:/

[Impala-ASF-CR] IMPALA-11249: Fix add test dimensions() locations to call super()

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18557 ) Change subject: IMPALA-11249: Fix add_test_dimensions() locations to call super() .. Patch Set 1: Build Successful https://j

[Impala-ASF-CR] IMPALA-11251: Fix TestImpalaShellInteractive.test unicode input on Ubuntu 20

2022-05-23 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18558 ) Change subject: IMPALA-11251: Fix TestImpalaShellInteractive.test_unicode_input on Ubuntu 20 .. Patch Set 1: Code-Review+1 Works for

[Impala-ASF-CR] IMPALA-11251: Fix TestImpalaShellInteractive.test unicode input on Ubuntu 20

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18558 ) Change subject: IMPALA-11251: Fix TestImpalaShellInteractive.test_unicode_input on Ubuntu 20 .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10199: Add Ubuntu 20 toolchain configuration

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18559 ) Change subject: IMPALA-10199: Add Ubuntu 20 toolchain configuration .. Patch Set 1: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10199: Add Ubuntu 20 toolchain configuration

2022-05-23 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18559 ) Change subject: IMPALA-10199: Add Ubuntu 20 toolchain configuration .. Patch Set 1: Code-Review+2 carry +1 from Michael. -- To view, v

[Impala-ASF-CR] IMPALA-11249: Fix add test dimensions() locations to call super()

2022-05-23 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18557 ) Change subject: IMPALA-11249: Fix add_test_dimensions() locations to call super() .. Patch Set 1: Was https://github.com/apache/impa

[Impala-ASF-CR] IMPALA-11305: Fix TypeError in impala-shell summary progress

2022-05-23 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18546 ) Change subject: IMPALA-11305: Fix TypeError in impala-shell summary progress .. Patch Set 4: Just realized I'm not sure there's a test

[Impala-ASF-CR] IMPALA-11249: Fix add test dimensions() locations to call super()

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18557 ) Change subject: IMPALA-11249: Fix add_test_dimensions() locations to call super() .. Patch Set 1: (4 comments) http://gerrit

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-05-23 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. Abandoned minor change --

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-05-23 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has restored this change. ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. Restored -- To view, visit

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-05-23 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. IMPALA-11205: Impl

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-05-23 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. IMPALA-11205: Impl

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. Patch Set 17: Build

[Impala-ASF-CR] IMPALA-11249: Fix add test dimensions() locations to call super()

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18557 ) Change subject: IMPALA-11249: Fix add_test_dimensions() locations to call super() .. Patch Set 1: > Was > https://github.com/apache/

[Impala-ASF-CR] IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes

2022-05-23 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18556 to look at the new patch set (#2). Change subject: IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. Patch Set 16: Build

[Impala-ASF-CR] IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes

2022-05-23 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18556 ) Change subject: IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. Patch Set 17: Build

[Impala-ASF-CR] IMPALA-10199: Add Ubuntu 20 toolchain configuration

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18559 ) Change subject: IMPALA-10199: Add Ubuntu 20 toolchain configuration .. Patch Set 2: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-10199: Add Ubuntu 20 toolchain configuration

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18559 ) Change subject: IMPALA-10199: Add Ubuntu 20 toolchain configuration .. Patch Set 2: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18556 ) Change subject: IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes .. Patch Set 2: Build Successful https:/

[Impala-ASF-CR] IMPALA-11295: Deflake TestParquet.test multiple blocks mt dop

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18533 ) Change subject: IMPALA-11295: Deflake TestParquet.test_multiple_blocks_mt_dop .. Patch Set 4: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-11295: Deflake TestParquet.test multiple blocks mt dop

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18533 ) Change subject: IMPALA-11295: Deflake TestParquet.test_multiple_blocks_mt_dop .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 ) Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events" .. Patch Set 2: Code-Review+2 -- To view, visi

[Impala-ASF-CR] Revert "IMPALA-9057: Disable test transactional insert events"

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18524 ) Change subject: Revert "IMPALA-9057: Disable test_transactional_insert_events" .. Patch Set 2: Build started: https://jenkins.

[Impala-ASF-CR] IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18560 Change subject: IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package .. IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi p

[Impala-ASF-CR] IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package

2022-05-23 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18560 ) Change subject: IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package .. Patch Set 1: Code-Review+1 This looks like it does wh

[native-toolchain-CR] IMPALA-10199: Add a toolchain build for Ubuntu 20

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18505 ) Change subject: IMPALA-10199: Add a toolchain build for Ubuntu 20 .. Patch Set 2: Verified+1 Code-Review+2 Carry +2. This builds and I

[native-toolchain-CR] IMPALA-10199: Add a toolchain build for Ubuntu 20

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18505 ) Change subject: IMPALA-10199: Add a toolchain build for Ubuntu 20 .. IMPALA-10199: Add a toolchain build for Ubuntu 20 This ad

[Impala-ASF-CR] IMPALA-11305: Fix TypeError in impala-shell summary progress

2022-05-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18546 ) Change subject: IMPALA-11305: Fix TypeError in impala-shell summary progress .. Patch Set 4: > Patch Set 4: > > Just realized I'm not s

[Impala-ASF-CR] IMPALA-11305: Fix TypeError in impala-shell summary progress

2022-05-23 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18546 ) Change subject: IMPALA-11305: Fix TypeError in impala-shell summary progress .. Patch Set 4: > Patch Set 4: > > > Patch Set 4: > > > >

[Impala-ASF-CR] IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18560 ) Change subject: IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package .. Patch Set 1: Build Successful https://jenkin

[Impala-ASF-CR] IMPALA-11281: Load table metadata for ResetMetadataStmt

2022-05-23 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18561 Change subject: IMPALA-11281: Load table metadata for ResetMetadataStmt .. IMPALA-11281: Load table metadata for ResetMetadataStmt This p

[Impala-ASF-CR] IMPALA-11281: Load table metadata for ResetMetadataStmt

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18561 ) Change subject: IMPALA-11281: Load table metadata for ResetMetadataStmt .. Patch Set 1: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed Steve Carlin from this change. ( http://gerrit.cloudera.org:8080/18556 ) Change subject: IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes .. Removed reviewer Steve Carlin. -- To vi

[Impala-ASF-CR] IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package

2022-05-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18560 ) Change subject: IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package .. Patch Set 1: Code-Review+2 (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-11129: Support running KRPC over Unix Domain Socket

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18369 ) Change subject: IMPALA-11129: Support running KRPC over Unix Domain Socket .. Patch Set 9: (2 comments) This is looking good to me. I

[Impala-ASF-CR] IMPALA-10199: Add Ubuntu 20 toolchain configuration

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18559 ) Change subject: IMPALA-10199: Add Ubuntu 20 toolchain configuration .. Patch Set 3: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18560 ) Change subject: IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-10199: Add Ubuntu 20 toolchain configuration

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18559 ) Change subject: IMPALA-10199: Add Ubuntu 20 toolchain configuration .. Patch Set 2: Code-Review-2 I forgot to fix my commit message to

[Impala-ASF-CR] IMPALA-10199: Add Ubuntu 20 toolchain configuration

2022-05-23 Thread Joe McDonnell (Code Review)
Hello Wenzhe Zhou, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18559 to look at the new patch set (#3). Change subject: IMPALA-10199: Add Ubuntu 20 toolchain configuration

[Impala-ASF-CR] IMPALA-10199: Add Ubuntu 20 toolchain configuration

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed a vote on this change. Change subject: IMPALA-10199: Add Ubuntu 20 toolchain configuration .. Removed Code-Review-2 by Joe McDonnell -- To view, visit http://gerrit.cloudera.org:8080/18559 To unsubscri

[Impala-ASF-CR] IMPALA-10199: Add Ubuntu 20 toolchain configuration

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18559 ) Change subject: IMPALA-10199: Add Ubuntu 20 toolchain configuration .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package

2022-05-23 Thread Joe McDonnell (Code Review)
Hello Quanlong Huang, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18560 to look at the new patch set (#2). Change subject: IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package ...

[Impala-ASF-CR] IMPALA-11251: Fix TestImpalaShellInteractive.test unicode input on Ubuntu 20

2022-05-23 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18558 to look at the new patch set (#2). Change subject: IMPALA-11251: Fix TestImpalaShellInteractive.test_unicode_input on Ubuntu 20 ...

[Impala-ASF-CR] IMPALA-11251: Fix TestImpalaShellInteractive.test unicode input on Ubuntu 20

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18558 ) Change subject: IMPALA-11251: Fix TestImpalaShellInteractive.test_unicode_input on Ubuntu 20 .. Patch Set 2: Code-Review+1 Carry +1

[Impala-ASF-CR] IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package

2022-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18560 ) Change subject: IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package .. Patch Set 2: Code-Review+2 Carry +2 -- To view, vis

[Impala-ASF-CR] IMPALA-11251: Fix TestImpalaShellInteractive.test unicode input on Ubuntu 20

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18558 ) Change subject: IMPALA-11251: Fix TestImpalaShellInteractive.test_unicode_input on Ubuntu 20 .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-11289: Push-down compound predicates to iceberg

2022-05-23 Thread Anonymous Coward (Code Review)
lipeng...@sensorsdata.cn has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18535 ) Change subject: IMPALA-11289: Push-down compound predicates to iceberg .. IMPALA-11289: Push-down compound predicates to icebe

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. Patch Set 17: Verifie

[Impala-ASF-CR] IMPALA-11289: Push-down compound predicates to iceberg

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18535 ) Change subject: IMPALA-11289: Push-down compound predicates to iceberg .. Patch Set 5: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-11295: Deflake TestParquet.test multiple blocks mt dop

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18533 ) Change subject: IMPALA-11295: Deflake TestParquet.test_multiple_blocks_mt_dop .. IMPALA-11295: Deflake TestParquet.test

[Impala-ASF-CR] IMPALA-11295: Deflake TestParquet.test multiple blocks mt dop

2022-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18533 ) Change subject: IMPALA-11295: Deflake TestParquet.test_multiple_blocks_mt_dop .. Patch Set 4: Verified+1 -- To view, visit ht

  1   2   >