[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Patch Set 3:

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Patch Set

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Patch Set

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-21 Thread ttttttz (Code Review)
ttz has restored this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Restored -- To view, visit

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-21 Thread ttttttz (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18652 to look at the new patch set (#3). Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-21 Thread ttttttz (Code Review)
ttz has abandoned this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Abandoned -- To view, visit

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-21 Thread ttttttz (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18652 to look at the new patch set (#2). Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-21 Thread ttttttz (Code Review)
ttz has restored this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Restored -- To view, visit

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-21 Thread ttttttz (Code Review)
ttz has abandoned this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Abandoned -- To view, visit

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-21 Thread ttttttz (Code Review)
ttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Patch Set 1: Quanlong,

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Patch Set

[Impala-ASF-CR] IMPALA-886: Support displaying HBase cols in the order from HMS

2022-06-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18635 ) Change subject: IMPALA-886: Support displaying HBase cols in the order from HMS .. Patch Set 4: Code-Review+1 (4 comments) Thanks

[Impala-ASF-CR] IMPALA-11379: Remove kerberos.egg-info directory

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18650 ) Change subject: IMPALA-11379: Remove kerberos.egg-info directory .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-11379: Remove kerberos.egg-info directory

2022-06-21 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18650 to look at the new patch set (#2). Change subject: IMPALA-11379: Remove kerberos.egg-info directory ..

[Impala-ASF-CR] PROTOTYPE: Verify that tests can catch modifications to sources

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18651 ) Change subject: PROTOTYPE: Verify that tests can catch modifications to sources .. Patch Set 1: Build Failed

[Impala-ASF-CR] PROTOTYPE: Verify that tests can catch modifications to sources

2022-06-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18651 Change subject: PROTOTYPE: Verify that tests can catch modifications to sources .. PROTOTYPE: Verify that tests can catch modifications

[Impala-ASF-CR] IMPALA-10545: Higher data cache write concurrency for SSDs

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18616 ) Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-10545: Higher data cache write concurrency for SSDs

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18616 ) Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-10545: Higher data cache write concurrency for SSDs

2022-06-21 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18616 ) Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs .. Patch Set 4: I've added an option to mock DiskInfo, and

[Impala-ASF-CR] IMPALA-10545: Higher data cache write concurrency for SSDs

2022-06-21 Thread Michael Smith (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18616 to look at the new patch set (#4). Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs

[Impala-ASF-CR] IMPALA-10545: Higher data cache write concurrency for SSDs

2022-06-21 Thread Michael Smith (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18616 to look at the new patch set (#3). Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs

[Impala-ASF-CR] IMPALA-10545: Higher data cache write concurrency for SSDs

2022-06-21 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18616 ) Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs .. Patch Set 2: Tested with #!/usr/bin/env bash

[Impala-ASF-CR] IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18649 ) Change subject: IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases

2022-06-21 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18649 Change subject: IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases .. IMPALA-11378: Allow INSERT OVERWRITE for

[Impala-ASF-CR] IMPALA-10545: Higher data cache write concurrency for SSDs

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18616 ) Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-11377: Handle concurrent Iceberg INSERT OVERWRITEs

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18648 ) Change subject: IMPALA-11377: Handle concurrent Iceberg INSERT OVERWRITEs .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10545: Higher data cache write concurrency for SSDs

2022-06-21 Thread Michael Smith (Code Review)
Hello Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18616 to look at the new patch set (#2). Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs ..

[Impala-ASF-CR] IMPALA-11377: Handle concurrent Iceberg INSERT OVERWRITEs

2022-06-21 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18648 Change subject: IMPALA-11377: Handle concurrent Iceberg INSERT OVERWRITEs .. IMPALA-11377: Handle concurrent Iceberg INSERT OVERWRITEs

[Impala-ASF-CR] IMPALA-11365: Dereferencing null pointer in TopNNode

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18629 ) Change subject: IMPALA-11365: Dereferencing null pointer in TopNNode .. IMPALA-11365: Dereferencing null pointer in

[Impala-ASF-CR] IMPALA-11365: Dereferencing null pointer in TopNNode

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18629 ) Change subject: IMPALA-11365: Dereferencing null pointer in TopNNode .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 ) Change subject: IMPALA-9718: Delete pkg_resources from impala-shell .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

2022-06-21 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 ) Change subject: IMPALA-9718: Delete pkg_resources from impala-shell .. Patch Set 6:

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

2022-06-21 Thread Michael Smith (Code Review)
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18585 to look at the new patch set (#6). Change subject: IMPALA-9718: Delete pkg_resources from impala-shell

[Impala-ASF-CR] IMPALA-11365: Dereferencing null pointer in TopNNode

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18629 ) Change subject: IMPALA-11365: Dereferencing null pointer in TopNNode .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions

2022-06-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 ) Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions .. Patch Set 4: (5 comments) Thanks

[Impala-ASF-CR] IMPALA-11365: Dereferencing null pointer in TopNNode

2022-06-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18629 ) Change subject: IMPALA-11365: Dereferencing null pointer in TopNNode .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11365: Dereferencing null pointer in TopNNode

2022-06-21 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18629 ) Change subject: IMPALA-11365: Dereferencing null pointer in TopNNode .. IMPALA-11365: Dereferencing null pointer in TopNNode In the

[Impala-ASF-CR] IMPALA-11365: Dereferencing null pointer in TopNNode

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18629 ) Change subject: IMPALA-11365: Dereferencing null pointer in TopNNode .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-11279: Optimize plain count(*) queries for Iceberg tables

2022-06-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18574 ) Change subject: IMPALA-11279: Optimize plain count(*) queries for Iceberg tables .. Patch Set 14: Code-Review+1 LGTM! -- To

[Impala-ASF-CR] IMPALA-11365: Dereferencing null pointer in TopNNode

2022-06-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18629 ) Change subject: IMPALA-11365: Dereferencing null pointer in TopNNode .. Patch Set 3: Code-Review+2 (1 comment) One small nit,

[Impala-ASF-CR] IMPALA-11365: Dereferencing null pointer in TopNNode

2022-06-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18629 ) Change subject: IMPALA-11365: Dereferencing null pointer in TopNNode .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18597 ) Change subject: IMPALA-11341: Print error log files when data-loading fails .. IMPALA-11341: Print error log files

[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails

2022-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18597 ) Change subject: IMPALA-11341: Print error log files when data-loading fails .. Patch Set 2: Verified+1 -- To view, visit