[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 ) Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

2022-10-06 Thread Peter Rozsa (Code Review)
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19099 Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT .. IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT This change

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

2022-10-06 Thread Peter Rozsa (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19099 to look at the new patch set (#2). Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 ) Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT .. Patch Set 1: Build Failed https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 ) Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT .. Patch Set 2: Build Failed https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-10-06 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 8: Code-Review+1 Thanks for working on

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

2022-10-06 Thread Peter Rozsa (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19099 to look at the new patch set (#3). Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

[Impala-ASF-CR] IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 ) Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT .. Patch Set 3: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-11504: Specializing DecimalUtil::GetScaleMultiplier().

2022-10-06 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18861 ) Change subject: IMPALA-11504: Specializing DecimalUtil::GetScaleMultiplier(). .. Patch Set 8: (3 comments) Thanks, only a few minor

[Impala-ASF-CR] IMPALA-9823: Make use local catalog and related flags visible

2022-10-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18660 ) Change subject: IMPALA-9823: Make use_local_catalog and related flags visible .. Patch Set 1: Code-Review+2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19088 ) Change subject: IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh .. Patch Set 4: Code-Review+2 Rebased, c

[Impala-ASF-CR] IMPALA-8770: Support building Docker images on Redhat-based distributions

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19006 ) Change subject: IMPALA-8770: Support building Docker images on Redhat-based distributions .. Patch Set 15: Code-Review+2 Carry Laszlo

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19080 ) Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Patch Set 6: Code-Review+2 Rebased, carrying +2 -- To

[Impala-ASF-CR] IMPALA-11634: Provide an option to use Java 11 for docker images

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19031 ) Change subject: IMPALA-11634: Provide an option to use Java 11 for docker images .. Patch Set 15: Code-Review+1 Rebased, carrying Wenz

[Impala-ASF-CR] IMPALA-10436: Support storage handler privileges for external Kudu table creation

2022-10-06 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17640 ) Change subject: IMPALA-10436: Support storage handler privileges for external Kudu table creation .. Patch Set 8: (1 comment) http://g

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-06 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. Patch Set 15: (7 comments) Should we clean up Thrift RPC related code, whi

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2022-10-06 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#26). ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner changes for CPU usage This patch augments IMPALA-10992

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2022-10-06 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 26: Adjust the minimal processing cost to be the largest sum of t

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 26: Build Successful https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19080 ) Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Patch Set 6: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2022-10-06 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 26: (1 comment) http://gerrit.cloudera.org:8080/#/c/19033/26/fe

[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 ) Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket .. Patch Set 4: Build started: https://jenkins

[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 ) Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket .. Patch Set 4: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-06 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/18798/15//C

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed a vote on this change. Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Removed Code-Review+2 by Joe McDonnell -- To view, visit http://gerrit.cloudera.org:8080/19080 To u

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19080 ) Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Patch Set 6: Something went wrong on rocky-8.5-dockeris

[Impala-ASF-CR] IMPALA-10148: Cleanup cores in TestHooksStartupFail

2022-10-06 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19103 Change subject: IMPALA-10148: Cleanup cores in TestHooksStartupFail .. IMPALA-10148: Cleanup cores in TestHooksStartupFail Generalizes

[Impala-ASF-CR] IMPALA-10148: Cleanup cores in TestHooksStartupFail

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19103 ) Change subject: IMPALA-10148: Cleanup cores in TestHooksStartupFail .. Patch Set 1: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-06 Thread Joe McDonnell (Code Review)
Hello Laszlo Gaal, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19080 to look at the new patch set (#7). Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images ..

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19080 ) Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Patch Set 7: Build Successful https://jenkins.

[Impala-ASF-CR] IMPALA-10148: Cleanup cores in TestHooksStartupFail

2022-10-06 Thread Michael Smith (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19103 to look at the new patch set (#2). Change subject: IMPALA-10148: Cleanup cores in TestHooksStartupFail .

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19080 ) Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Patch Set 7: I figured it out, but I'm going to add som

[Impala-ASF-CR] IMPALA-11640/IMPALA-11641: Workaround errors in shared library build on Ubuntu 18+

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19104 Change subject: IMPALA-11640/IMPALA-11641: Workaround errors in shared library build on Ubuntu 18+ .. IMPALA-11640/IMPALA-11641: Workar

[Impala-ASF-CR] IMPALA-11640/IMPALA-11641: Workaround errors in shared library build on Ubuntu 18+

2022-10-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19104 ) Change subject: IMPALA-11640/IMPALA-11641: Workaround errors in shared library build on Ubuntu 18+ .. Patch Set 1: Code-Review+1 --

[Impala-ASF-CR] IMPALA-11640/IMPALA-11641: Workaround errors in shared library build on Ubuntu 18+

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19104 ) Change subject: IMPALA-11640/IMPALA-11641: Workaround errors in shared library build on Ubuntu 18+ .. Patch Set 1: Build Succ

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19080 ) Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Patch Set 6: Verified+1 -- To view, visit http

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19102 Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. IMPALA-11628: Switch to reload4j, update slf4j Switch from log4j 1.x

[Impala-ASF-CR] IMPALA-9823: Make use local catalog and related flags visible

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18660 ) Change subject: IMPALA-9823: Make use_local_catalog and related flags visible .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9823: Make use local catalog and related flags visible

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18660 ) Change subject: IMPALA-9823: Make use_local_catalog and related flags visible .. Patch Set 2: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: Code-Review+1 LGTM! Just curious about the version, saw 1.7.3

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: > Patch Set 1: Code-Review+1 > > LGTM! > Just curious a

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. Patch Set 15: (5 comments) Agree that we should clean up Thrift RPC relat

[Impala-ASF-CR] IMPALA-11064 Optimizing Temporary File Structure for Batch Reading

2022-10-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18219 ) Change subject: IMPALA-11064 Optimizing Temporary File Structure for Batch Reading .. Patch Set 8: (18 comments) Did another pass th

[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19082 ) Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket .. IMPALA-9448: (Addendum) Avoid generi

[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 ) Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: Code-Review+2 Looks good. Thank you for taking care of t

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: Code-Review-2 When I build locally, log4j is still pres

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: (I'm only -2ing so no one gets tempted to click submit.

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: I think we would end up wanting to add log4j to banned

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: -Code-Review Removing my vote following Joe's comment.

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-06 Thread Joe McDonnell (Code Review)
Hello Laszlo Gaal, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19080 to look at the new patch set (#8). Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images ..

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19080 ) Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Patch Set 8: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-11526: Install en US.UTF-8 locale into docker images

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19080 ) Change subject: IMPALA-11526: Install en_US.UTF-8 locale into docker images .. Patch Set 8: Build Failed https://jenkins.impa

[Impala-ASF-CR] IMPALA-9823: Make use local catalog and related flags visible

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18660 ) Change subject: IMPALA-9823: Make use_local_catalog and related flags visible .. IMPALA-9823: Make use_local_catalog an

[Impala-ASF-CR] IMPALA-9823: Make use local catalog and related flags visible

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18660 ) Change subject: IMPALA-9823: Make use_local_catalog and related flags visible .. Patch Set 2: Verified+1 -- To view, visit ht