[Impala-ASF-CR] PROTOTYPE: Put all thrift-generated python code into the impala thrift gen package

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20169 ) Change subject: PROTOTYPE: Put all thrift-generated python code into the impala_thrift_gen package .. Patch Set 3: Build Succ

[Impala-ASF-CR] PROTOTYPE: Rearrange shell directory structure to match the pypi package

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20172 ) Change subject: PROTOTYPE: Rearrange shell directory structure to match the pypi package .. Patch Set 4: Build Successful ht

[Impala-ASF-CR] PROTOTYPE: Change the shell tarball to be a pip install of impala-shell package

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20171 ) Change subject: PROTOTYPE: Change the shell tarball to be a pip install of impala-shell package .. Patch Set 4: Build Success

[Impala-ASF-CR] IMPALA-11980: Move impala shell code to impala shell subdirectory and use absolute import

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20170 ) Change subject: IMPALA-11980: Move impala shell code to impala_shell subdirectory and use absolute_import .. Patch Set 4: Bui

[Impala-ASF-CR] PROTOTYPE: Rearrange shell directory structure to match the pypi package

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20172 ) Change subject: PROTOTYPE: Rearrange shell directory structure to match the pypi package .. Patch Set 4: (6 comments) http:/

[Impala-ASF-CR] PROTOTYPE: Change the shell tarball to be a pip install of impala-shell package

2023-09-08 Thread Joe McDonnell (Code Review)
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20171 to look at the new patch set (#4). Change subject: PROTOTYPE: Change the shell tarball to be a pip install of impala-shell package ..

[Impala-ASF-CR] PROTOTYPE: Rearrange shell directory structure to match the pypi package

2023-09-08 Thread Joe McDonnell (Code Review)
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20172 to look at the new patch set (#4). Change subject: PROTOTYPE: Rearrange shell directory structure to match the pypi package .

[Impala-ASF-CR] IMPALA-11980: Move impala shell code to impala shell subdirectory and use absolute import

2023-09-08 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20170 to look at the new patch set (#4). Change subject: IMPALA-11980: Move impala shell code to impala_shell subdirectory and use absolute_import .

[Impala-ASF-CR] PROTOTYPE: Put all thrift-generated python code into the impala thrift gen package

2023-09-08 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20169 to look at the new patch set (#3). Change subject: PROTOTYPE: Put all thrift-generated python code into the impala_thrift_gen package

[Impala-ASF-CR] PROTOTYPE: Change the shell tarball to be a pip install of impala-shell package

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20171 ) Change subject: PROTOTYPE: Change the shell tarball to be a pip install of impala-shell package .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-11980: Move impala shell code to impala shell subdirectory and use absolute import

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20170 ) Change subject: IMPALA-11980: Move impala shell code to impala_shell subdirectory and use absolute_import .. Patch Set 4: (47

[Impala-ASF-CR] PROTOTYPE: Put all thrift-generated python code into the impala thrift gen package

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20169 ) Change subject: PROTOTYPE: Put all thrift-generated python code into the impala_thrift_gen package .. Patch Set 3: (3 comment

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 17: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-08 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#17). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .

[Impala-ASF-CR] IMPALA-12425: Upgrade json-smart to fix CVE

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20461 ) Change subject: IMPALA-12425: Upgrade json-smart to fix CVE .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20471 ) Change subject: IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28 .. Patch Set 1: Build Successful https://

[Impala-ASF-CR] IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28

2023-09-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20471 Change subject: IMPALA-12432: Make LdapKerberosImpalaShellTest* work with Guava 28 .. IMPALA-12432: Make LdapKerberosImpalaShellTest* w

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-08 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 9: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12425: Upgrade json-smart to fix CVE

2023-09-08 Thread Michael Smith (Code Review)
Michael Smith has removed a vote on this change. Change subject: IMPALA-12425: Upgrade json-smart to fix CVE .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/20461 To unsubscribe,

[native-toolchain-CR] IMPALA-12435: Install pinned pip

2023-09-08 Thread Michael Smith (Code Review)
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: IMPALA-12435: Install pinned pip .. IMPALA-12435: Install pinned pip Fixes installing the desired version of p

[native-toolchain-CR] IMPALA-12435: Install pinned pip

2023-09-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: IMPALA-12435: Install pinned pip .. Patch Set 3: Verified+1 All images but SLES 12 built successfully. Ran into an unr

[Impala-ASF-CR] IMPALA-12425: Upgrade json-smart to fix CVE

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20461 ) Change subject: IMPALA-12425: Upgrade json-smart to fix CVE .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerri

[native-toolchain-CR] IMPALA-12436: Build multi-platform builder images

2023-09-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20469 ) Change subject: IMPALA-12436: Build multi-platform builder images .. Patch Set 1: This is the direction I'm thinking for creating mult

[native-toolchain-CR] IMPALA-12436: Build multi-platform builder images

2023-09-08 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20469 Change subject: IMPALA-12436: Build multi-platform builder images .. IMPALA-12436: Build multi-platform builder images Updates the tool

[native-toolchain-CR] IMPALA-12435: Install pinned pip

2023-09-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: IMPALA-12435: Install pinned pip .. Patch Set 3: > > Patch Set 3: Code-Review+2 > > > > Thanks for fixing this > >

[native-toolchain-CR] IMPALA-12435: Install pinned pip

2023-09-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: IMPALA-12435: Install pinned pip .. Patch Set 3: > Patch Set 3: Code-Review+2 > > Thanks for fixing this > > Does this

[native-toolchain-CR] IMPALA-12435: Install pinned pip

2023-09-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: IMPALA-12435: Install pinned pip .. Patch Set 3: Code-Review+2 Thanks for fixing this Does this help with the ARM con

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 4: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-09-08 Thread Michael Smith (Code Review)
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. IMPALA-12390 (part 1): Enable some

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-09-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-08 Thread Michael Smith (Code Review)
Hello Quanlong Huang, Daniel Becker, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20425 to look at the new patch set (#4). Change subject: IMPALA-10086: Implicit cast comparing char and varchar .

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 9: Build Successful https:/

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 9: (5 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-08 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#9) to the change originally created by Abhishek Rawat. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate ..

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. IMPALA-12424: Allow third party JniFrontend i

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 6: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 16: Build Successful https://jen

[native-toolchain-CR] IMPALA-12435: Install pinned pip

2023-09-08 Thread Michael Smith (Code Review)
Hello Laszlo Gaal, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20465 to look at the new patch set (#3). Change subject: IMPALA-12435: Install pinned pip .. IMPALA-12435:

[native-toolchain-CR] IMPALA-12435: Install pinned pip

2023-09-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: IMPALA-12435: Install pinned pip .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20465/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 8: Patch set 8 is a rebase. I will ad

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 16: (2 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-08 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#16). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .

[native-toolchain-CR] IMPALA-12435: Install pinned pip, use pip3 when available

2023-09-08 Thread Michael Smith (Code Review)
Hello Laszlo Gaal, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20465 to look at the new patch set (#2). Change subject: IMPALA-12435: Install pinned pip, use pip3 when available .

[Impala-ASF-CR] IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles

2023-09-08 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20439 ) Change subject: IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles .. Patch Set 4: Code-Review+1 Thanks for addre

[Impala-ASF-CR] IMPALA-12402: v1 change the term from consistency to concurrency and fix nits

2023-09-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20467 ) Change subject: IMPALA-12402: v1 change the term from consistency to concurrency and fix nits .. Patch Set 1: Please add this to the

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 6: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 6: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 5: The test failure on the last precommit run does

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-08 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 7: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 ) Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes .. Patch Set 10: Verified-1 Build failed: https://jenkins

[Impala-ASF-CR] IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes

2023-09-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20460 ) Change subject: IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 5: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-12417: Fix query timeline issue during asynchronous codegen

2023-09-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20458 ) Change subject: IMPALA-12417: Fix query timeline issue during asynchronous codegen .. Patch Set 2: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-08 Thread Steve Carlin (Code Review)
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-08 Thread Steve Carlin (Code Review)
Hello Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20459 to look at the new patch set (#5). Change subject: IMPALA-12424: Allow third party JniFrontend interface. ...

[Impala-ASF-CR] [arm64] remove dependence on sse2neon

2023-09-08 Thread Anonymous Coward (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19954 to look at the new patch set (#6). Change subject: [arm64] remove dependence on sse2neon ..

[Impala-ASF-CR] [arm64] remove dependence on sse2neon

2023-09-08 Thread Anonymous Coward (Code Review)
s...@amazon.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/19954 ) Change subject: [arm64] remove dependence on sse2neon .. Patch Set 5: Hi, could we merge this patch? The Impala patch has been merg

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-08 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 ) Change subject: IMPALA-12430: Skip compression when sending row batches within same process .. Patch Set 6: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 7: (4 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20355 ) Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline .. Patch Set 8: Build Failed

[Impala-ASF-CR] IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20355 ) Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 ) Change subject: IMPALA-12430: Skip compression when sending row batches within same process .. Patch Set 6: Code-Review+1 -- To view

[Impala-ASF-CR] IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline

2023-09-08 Thread Surya Hebbar (Code Review)
Surya Hebbar has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/20355 ) Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline .. IMPALA-12364: Display memory, disk an

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 ) Change subject: IMPALA-12430: Skip compression when sending row batches within same process .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 ) Change subject: IMPALA-12430: Skip compression when sending row batches within same process .. Patch Set 6: (4 comments) http://ge

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-08 Thread Csaba Ringhofer (Code Review)
Hello Kurt Deschler, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20462 to look at the new patch set (#6). Change subject: IMPALA-12430: Skip compression when sending row batches within same process .

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-08 Thread Csaba Ringhofer (Code Review)
Hello Kurt Deschler, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20462 to look at the new patch set (#5). Change subject: IMPALA-12430: Skip compression when sending row batches within same process .

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-08 Thread Csaba Ringhofer (Code Review)
Hello Kurt Deschler, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20462 to look at the new patch set (#4). Change subject: IMPALA-12430: Skip compression when sending row batches within same process .

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 ) Change subject: IMPALA-12430: Skip compression when sending row batches within same process .. Patch Set 3: (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 ) Change subject: IMPALA-12430: Skip compression when sending row batches within same process .. Patch Set 3: (3 comments) http://gerr

[Impala-ASF-CR] IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20439 ) Change subject: IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles .. Patch Set 4: Verified+1 -- To vi

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 ) Change subject: IMPALA-12430: Skip compression when sending row batches within same process .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 ) Change subject: IMPALA-12430: Skip compression when sending row batches within same process .. Patch Set 3: (3 comments) http://ge

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-08 Thread Csaba Ringhofer (Code Review)
Hello Kurt Deschler, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20462 to look at the new patch set (#3). Change subject: IMPALA-12430: Skip compression when sending row batches within same process

[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes

2023-09-08 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 ) Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes .. Patch Set 9: Code-Review+2 LGTM. Carrying Michael's +1. --

[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 ) Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes .. Patch Set 10: Build started: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 ) Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes .. Patch Set 10: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 4: Verified+1 -- To vi

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 4: Verified-1 Build failed: https://jenkin

[Impala-ASF-CR] IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20439 ) Change subject: IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles .. Patch Set 4: Build started: https

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 3: Verified-1 Build fai

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 15: Code-Review+1 (1 comment) http://g