[Impala-ASF-CR] IMPALA-12398: Ranger role not exists when altering db/table/view owner to a role

2023-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20503 ) Change subject: IMPALA-12398: Ranger role not exists when altering db/table/view owner to a role .. Patch Set 1: Verified-1 B

[Impala-ASF-CR] IMPALA-12449: remove dependence on sse2neon

2023-09-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19954 ) Change subject: IMPALA-12449: remove dependence on sse2neon .. Patch Set 10: (2 comments) I think my preferred approach would be to d

[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore

2023-09-22 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. Patch Set 11: (8 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-12398: Ranger role not exists when altering db/table/view owner to a role

2023-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20503 ) Change subject: IMPALA-12398: Ranger role not exists when altering db/table/view owner to a role .. Patch Set 1: Build Succes

[Impala-ASF-CR] IMPALA-12398: Ranger role not exists when altering db/table/view owner to a role

2023-09-22 Thread ji chen (Code Review)
ji chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20503 Change subject: IMPALA-12398: Ranger role not exists when altering db/table/view owner to a role .. IMPALA-12398: Ranger role not exists when

[Impala-ASF-CR] IMPALA-12398: Ranger role not exists when altering db/table/view owner to a role

2023-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20503 ) Change subject: IMPALA-12398: Ranger role not exists when altering db/table/view owner to a role .. Patch Set 1: Build starte

[Impala-ASF-CR] IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete file dir

2023-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20386 ) Change subject: IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete_file_dir .. Patch Set 6: Verified-1 Build

[Impala-ASF-CR] IMPALA-12390 (part 4): Enable unnecessary-value-param

2023-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 ) Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param .. Patch Set 5: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete file dir

2023-09-22 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20386 ) Change subject: IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete_file_dir .. Patch Set 6: Code-Review+1 -- To view

[Impala-ASF-CR](branch-4.3.0) Update version to 4.3.0-RELEASE

2023-09-22 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20488 ) Change subject: Update version to 4.3.0-RELEASE .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR](branch-4.3.0) Update version to 4.3.0-RELEASE

2023-09-22 Thread Michael Smith (Code Review)
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20488 ) Change subject: Update version to 4.3.0-RELEASE .. Update version to 4.3.0-RELEASE Change-Id: I8fa652d6d8c2dccae2366dafd7269b7

[Impala-ASF-CR] IMPALA-12390 (part 4): Enable unnecessary-value-param

2023-09-22 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 ) Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param .. Patch Set 4: (12 comments) > Also, running an ASAN test job

[Impala-ASF-CR] IMPALA-12390 (part 4): Enable unnecessary-value-param

2023-09-22 Thread Michael Smith (Code Review)
Hello Daniel Becker, gsi...@cloudera.com, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20494 to look at the new patch set (#5). Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param ...

[Impala-ASF-CR] IMPALA-12453: Increase yarn high disk threshold

2023-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20501 ) Change subject: IMPALA-12453: Increase yarn high disk threshold .. Patch Set 1: Build Successful https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-12453: Increase yarn high disk threshold

2023-09-22 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20501 ) Change subject: IMPALA-12453: Increase yarn high disk threshold .. Patch Set 1: One option for trying to be more efficient with disk s

[Impala-ASF-CR] IMPALA-12453: Increase yarn high disk threshold

2023-09-22 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20501 Change subject: IMPALA-12453: Increase yarn high disk threshold .. IMPALA-12453: Increase yarn high disk threshold Yarn will mark a nod

[Impala-ASF-CR] IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete file dir

2023-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20386 ) Change subject: IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete_file_dir .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete file dir

2023-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20386 ) Change subject: IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete_file_dir .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-12390 (part 4): Enable unnecessary-value-param

2023-09-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 ) Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete file dir

2023-09-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20386 ) Change subject: IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete_file_dir .. Patch Set 6: Still tuning the timing f

[Impala-ASF-CR] IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete file dir

2023-09-22 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20386 to look at the new patch set (#6). Change subject: IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete_file_dir

[Impala-ASF-CR] IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete file dir

2023-09-22 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20386 to look at the new patch set (#5). Change subject: IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete_file_dir

[Impala-ASF-CR] IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete file dir

2023-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20386 ) Change subject: IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete_file_dir .. Patch Set 6: Build started: ht

[Impala-ASF-CR] IMPALA-12390 (part 4): Enable unnecessary-value-param

2023-09-22 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 ) Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-12390 (part 4): Enable unnecessary-value-param

2023-09-22 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 ) Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param .. Patch Set 4: (10 comments) I went through the rest. http://

[Impala-ASF-CR] IMPALA-12373: Small String Optimization for StringValue

2023-09-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20496 ) Change subject: IMPALA-12373: Small String Optimization for StringValue .. Patch Set 4: (9 comments) great work! I couldn't proces

[Impala-ASF-CR] IMPALA-12312: Using correct executor group set info for planning

2023-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20273 ) Change subject: IMPALA-12312: Using correct executor group set info for planning .. Patch Set 7: Build Successful https://jen

[Impala-ASF-CR] IMPALA-12312: Using correct executor group set info for planning

2023-09-22 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20273 ) Change subject: IMPALA-12312: Using correct executor group set info for planning .. Patch Set 7: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-12312: Using correct executor group set info for planning

2023-09-22 Thread Yifan Zhang (Code Review)
Hello Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20273 to look at the new patch set (#7). Change subject: IMPALA-12312: Using correct executor group set info for planning .

[Impala-ASF-CR] IMPALA-12089: Be able to skip pushing down a subset of the predicates in Iceberg

2023-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20133 ) Change subject: IMPALA-12089: Be able to skip pushing down a subset of the predicates in Iceberg .. Patch Set 10: Verified-1

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-22 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 2: Code-Review+1 LGTM -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-12089: Be able to skip pushing down a subset of the predicates in Iceberg

2023-09-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20133 ) Change subject: IMPALA-12089: Be able to skip pushing down a subset of the predicates in Iceberg .. Patch Set 10: Build start

[Impala-ASF-CR] IMPALA-12399: (addendum) Fixed possible deadloop and also do not set the event skip list in notification request to update latestEventId

2023-09-22 Thread Anonymous Coward (Code Review)
k.venureddy2...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20487 ) Change subject: IMPALA-12399: (addendum) Fixed possible deadloop and also do not set the event skip list in notification request to update latestEventId_ ..