[Impala-ASF-CR] IMPALA-12431: Support reading compressed JSON file

2024-01-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20482 ) Change subject: IMPALA-12431: Support reading compressed JSON file .. Patch Set 11: Code-Review+1 This looks good to me -- To view,

[Impala-ASF-CR] IMPALA-12631: Improve count star performance for parquet scans

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20804 ) Change subject: IMPALA-12631: Improve count star performance for parquet scans .. Patch Set 11: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-12054: Lazily check Kudu flags in tests

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20904 ) Change subject: IMPALA-12054: Lazily check Kudu flags in tests .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-12054: Lazily check Kudu flags in tests

2024-01-15 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20904 ) Change subject: IMPALA-12054: Lazily check Kudu flags in tests .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12054: Lazily check Kudu flags in tests

2024-01-15 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20904 ) Change subject: IMPALA-12054: Lazily check Kudu flags in tests .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12631: Improve count star performance for parquet scans

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20804 ) Change subject: IMPALA-12631: Improve count star performance for parquet scans .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-12054: Lazily check Kudu flags in tests

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20904 ) Change subject: IMPALA-12054: Lazily check Kudu flags in tests .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12362: Improve Linux packaging support.

2024-01-15 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20263 ) Change subject: IMPALA-12362: Improve Linux packaging support. .. Patch Set 6: (8 comments) Thanks for improving the packaging

[Impala-ASF-CR] IMPALA-12054: Lazily check Kudu flags in tests

2024-01-15 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20904 Change subject: IMPALA-12054: Lazily check Kudu flags in tests .. IMPALA-12054: Lazily check Kudu flags in tests I usually shutdown

[Impala-ASF-CR] IMPALA-12714: Fix test reduced cardinality by filter for non-HDFS

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20902 ) Change subject: IMPALA-12714: Fix test_reduced_cardinality_by_filter for non-HDFS .. IMPALA-12714: Fix

[Impala-ASF-CR] IMPALA-12714: Fix test reduced cardinality by filter for non-HDFS

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20902 ) Change subject: IMPALA-12714: Fix test_reduced_cardinality_by_filter for non-HDFS .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-12642: Support query options for Impala external JDBC table

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20837 ) Change subject: IMPALA-12642: Support query options for Impala external JDBC table .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20903 ) Change subject: IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12642: Support query options for Impala external JDBC table

2024-01-15 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/20837 ) Change subject: IMPALA-12642: Support query options for Impala external JDBC table .. IMPALA-12642: Support query options for Impala

[Impala-ASF-CR] IMPALA-12714: Fix test reduced cardinality by filter for non-HDFS

2024-01-15 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20902 ) Change subject: IMPALA-12714: Fix test_reduced_cardinality_by_filter for non-HDFS .. Patch Set 1: > Patch Set 1: > > I'm double

[Impala-ASF-CR] IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

2024-01-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20903 Change subject: IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables .. IMPALA-12708: An UPDATE creates 2 new

[Impala-ASF-CR] IMPALA-12714: Fix test reduced cardinality by filter for non-HDFS

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20902 ) Change subject: IMPALA-12714: Fix test_reduced_cardinality_by_filter for non-HDFS .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12714: Fix test reduced cardinality by filter for non-HDFS

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20902 ) Change subject: IMPALA-12714: Fix test_reduced_cardinality_by_filter for non-HDFS .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20890 ) Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's metadata .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-12714: Fix test reduced cardinality by filter for non-HDFS

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20902 ) Change subject: IMPALA-12714: Fix test_reduced_cardinality_by_filter for non-HDFS .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12714: Fix test reduced cardinality by filter for non-HDFS

2024-01-15 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20902 ) Change subject: IMPALA-12714: Fix test_reduced_cardinality_by_filter for non-HDFS .. Patch Set 1: I'm double checking if the

[Impala-ASF-CR] IMPALA-12714: Fix test reduced cardinality by filter for non-HDFS

2024-01-15 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20902 ) Change subject: IMPALA-12714: Fix test_reduced_cardinality_by_filter for non-HDFS .. Patch Set 1: Code-Review+2 Thanks for the quick

[Impala-ASF-CR] IMPALA-12714: Fix test reduced cardinality by filter for non-HDFS

2024-01-15 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20902 Change subject: IMPALA-12714: Fix test_reduced_cardinality_by_filter for non-HDFS .. IMPALA-12714: Fix

[Impala-ASF-CR] IMPALA-12698: Restrict check deleted file fd() for fixing flaky tests

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20898 ) Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests .. Patch Set 3: Verified+1 -- To

[Impala-ASF-CR] IMPALA-12698: Restrict check deleted file fd() for fixing flaky tests

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20898 ) Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests .. IMPALA-12698: Restrict

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20890 ) Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's metadata .. Patch Set 4: Code-Review+2 Thanks Zihao Ye! LGTM!

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20890 ) Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's metadata .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20890 ) Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's metadata .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-12582: Fix crash when enabling MIN MAX RuntimeFilter in Nested Loop Join

2024-01-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20891 ) Change subject: IMPALA-12582: Fix crash when enabling MIN_MAX RuntimeFilter in Nested Loop Join .. Patch Set 2: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-12631: Improve count star performance for parquet scans

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20804 ) Change subject: IMPALA-12631: Improve count star performance for parquet scans .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-12642: Support query options for Impala external JDBC table

2024-01-15 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20837 ) Change subject: IMPALA-12642: Support query options for Impala external JDBC table .. Patch Set 7: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12631: Improve count star performance for parquet scans

2024-01-15 Thread Yifan Zhang (Code Review)
Hello Riza Suminto, Zoltan Borok-Nagy, Zihao Ye, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20804 to look at the new patch set (#11). Change subject: IMPALA-12631: Improve count star performance for parquet

[Impala-ASF-CR] IMPALA-12636: Reload filemetadata for AlterTable event of type truncate

2024-01-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20887 ) Change subject: IMPALA-12636: Reload filemetadata for AlterTable event of type truncate .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-12698: Restrict check deleted file fd() for fixing flaky tests

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20898 ) Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-12698: Restrict check deleted file fd() for fixing flaky tests

2024-01-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20898 ) Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Zihao Ye (Code Review)
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20890 ) Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's metadata .. Patch Set 3: (1 comment) Hi Tamas, thank you for

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Zihao Ye (Code Review)
Hello Tamas Mate, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20890 to look at the new patch set (#4). Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

[Impala-ASF-CR] IMPALA-12698: Restrict check deleted file fd() for fixing flaky tests

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20898 ) Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-12698: Restrict check deleted file fd() for fixing flaky tests

2024-01-15 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20898 ) Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12698: Restrict check deleted file fd() for fixing flaky tests

2024-01-15 Thread Yida Wu (Code Review)
Yida Wu has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20898 ) Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests .. IMPALA-12698: Restrict check_deleted_file_fd() for

[Impala-ASF-CR] IMPALA-12698: Restrict check deleted file fd() for fixing flaky tests

2024-01-15 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20898 ) Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20890 ) Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's metadata .. Patch Set 3: (1 comment) Hi Zihao Ye, thank you

[Impala-ASF-CR] IMPALA-12698: Restrict check deleted file fd() for fixing flaky tests

2024-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20898 ) Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-12698: Restrict check deleted file fd() for fixing flaky tests

2024-01-15 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20898 ) Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests .. Patch Set 2: (1 comment) Thanks Csaba for the

[Impala-ASF-CR] IMPALA-12698: Restrict check deleted file fd() for fixing flaky tests

2024-01-15 Thread Yida Wu (Code Review)
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20898 ) Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests .. IMPALA-12698: Restrict check_deleted_file_fd() for

[Impala-ASF-CR] IMPALA-12698: Restrict check deleted file fd() for fixing flaky tests

2024-01-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20898 ) Change subject: IMPALA-12698: Restrict check_deleted_file_fd() for fixing flaky tests .. Patch Set 1: Code-Review+1 (1 comment)