[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. IMPALA-12559: Support x5c Parameter for

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 27: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 27: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 27: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 27: Build started:

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 27: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread gaurav singh (Code Review)
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 27: (2 comments)

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread gaurav singh (Code Review)
Hello Abhishek Rawat, Jason Fehr, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21382 to look at the new patch set (#27). Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 26: (2 comments)

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 26: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread gaurav singh (Code Review)
Hello Abhishek Rawat, Jason Fehr, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21382 to look at the new patch set (#26). Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

[Impala-ASF-CR] IMPALA-12637: Processing CREATE TABLE event for an unloaded db shouldn't put EP into error state

2024-05-14 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21428 Change subject: IMPALA-12637: Processing CREATE_TABLE event for an unloaded db shouldn't put EP into error state ..

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 23: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-12935: First pass on Calcite planner functions

2024-05-14 Thread Steve Carlin (Code Review)
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21357 ) Change subject: IMPALA-12935: First pass on Calcite planner functions .. Patch Set 8: Cleaned the code up in the most recent commit to

[Impala-ASF-CR] IMPALA-13057: Incorporate tuple/slot information into tuple cache key

2024-05-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21398 ) Change subject: IMPALA-13057: Incorporate tuple/slot information into tuple cache key .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-12935: First pass on Calcite planner functions

2024-05-14 Thread Steve Carlin (Code Review)
Hello Aman Sinha, Joe McDonnell, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21357 to look at the new patch set (#10). Change subject: IMPALA-12935: First pass on Calcite planner functions

[Impala-ASF-CR] IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches

2024-05-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21412 ) Change subject: IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches .. Patch Set 2: (2 comments)

[Impala-ASF-CR](branch-3.4.2) IMPALA-9577: [test] Use `system unsync` time for Kudu test clusters

2024-05-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21422 ) Change subject: IMPALA-9577: [test] Use `system_unsync` time for Kudu test clusters .. IMPALA-9577: [test] Use

[Impala-ASF-CR](branch-3.4.2) IMPALA-9577: [test] Use `system unsync` time for Kudu test clusters

2024-05-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21422 ) Change subject: IMPALA-9577: [test] Use `system_unsync` time for Kudu test clusters .. Patch Set 1: Verified+1 -- To view, visit

[native-toolchain-CR] IMPALA-13072: Add retries for s3 uploads to combat flakiness

2024-05-14 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21421 ) Change subject: IMPALA-13072: Add retries for s3 uploads to combat flakiness .. Patch Set 1: Code-Review+2 Thanks for the patch, Joe!

[native-toolchain-CR] IMPALA-13072: Add retries for s3 uploads to combat flakiness

2024-05-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21421 ) Change subject: IMPALA-13072: Add retries for s3 uploads to combat flakiness .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: (1 comment)

[native-toolchain-CR] IMPALA-13072: Add retries for s3 uploads to combat flakiness

2024-05-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21421 ) Change subject: IMPALA-13072: Add retries for s3 uploads to combat flakiness .. Patch Set 1: > https://gerrit.cloudera.org/c/21341/

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 25: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread gaurav singh (Code Review)
Hello Abhishek Rawat, Jason Fehr, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21382 to look at the new patch set (#25). Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

[Impala-ASF-CR] CDPD-68003: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has restored this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: CDPD-68003: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Restored Restore to patch 23 which was approved. --

[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors

2024-05-14 Thread Saurabh Katiyal (Code Review)
Saurabh Katiyal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21426 Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. IMPALA-12216: Print timestamp for impala-shell errors This

[Impala-ASF-CR] CDPD-68003: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has abandoned this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: CDPD-68003: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Abandoned Duplicate -- To view, visit

[Impala-ASF-CR] CDPD-68003: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: CDPD-68003: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 24: (1 comment)

[Impala-ASF-CR] CDPD-68003: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread gaurav singh (Code Review)
Hello Abhishek Rawat, Jason Fehr, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21382 to look at the new patch set (#24). Change subject: CDPD-68003: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 23: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 23: Build started:

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 23: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread gaurav singh (Code Review)
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 23: (2 comments)

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread gaurav singh (Code Review)
Hello Abhishek Rawat, Jason Fehr, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21382 to look at the new patch set (#23). Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

[native-toolchain-CR] IMPALA-13072: Add retries for s3 uploads to combat flakiness

2024-05-14 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21421 ) Change subject: IMPALA-13072: Add retries for s3 uploads to combat flakiness .. Patch Set 1: https://gerrit.cloudera.org/c/21341/ was

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 22: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 22: Code-Review+1 (4 comments) Overall looks

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread gaurav singh (Code Review)
gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 ) Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys .. Patch Set 20: (3 comments)

[Impala-ASF-CR] IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

2024-05-14 Thread gaurav singh (Code Review)
Hello Abhishek Rawat, Jason Fehr, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21382 to look at the new patch set (#22). Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys

[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables

2024-05-14 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21425 Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables .. IMPALA-13079: Add support for FLOAT/DOUBLE in

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-05-14 Thread Peter Rozsa (Code Review)
Peter Rozsa has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/21423 ) Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. IMPALA-12732: Add support for MERGE statements for

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-05-14 Thread Peter Rozsa (Code Review)
Peter Rozsa has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/21423 ) Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. IMPALA-12732: Add support for MERGE statements for

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-05-14 Thread Peter Rozsa (Code Review)
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21423 Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. IMPALA-12732: Add support for MERGE statements for

[Impala-ASF-CR](branch-3.4.2) IMPALA-9577: [test] Use `system unsync` time for Kudu test clusters

2024-05-14 Thread Zihao Ye (Code Review)
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21422 ) Change subject: IMPALA-9577: [test] Use `system_unsync` time for Kudu test clusters .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12786: Optimize count(*) for JSON scans

2024-05-14 Thread Zihao Ye (Code Review)
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21039 ) Change subject: IMPALA-12786: Optimize count(*) for JSON scans .. Patch Set 10: (5 comments) Thanks for the review!

[Impala-ASF-CR] IMPALA-12786: Optimize count(*) for JSON scans

2024-05-14 Thread Zihao Ye (Code Review)
Hello Quanlong Huang, Riza Suminto, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21039 to look at the new patch set (#11). Change subject: IMPALA-12786: Optimize count(*) for JSON scans