[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 ) Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. Patch Set 13: Build S

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-06-12 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 ) Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. Patch Set 13: (5 comm

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-06-12 Thread Sai Hemanth Gantasala (Code Review)
Hello Quanlong Huang, Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21437 to look at the new patch set (#13). Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off ...

[Impala-ASF-CR] [tools] Add .gitignore for new files

2024-06-12 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21503 ) Change subject: [tools] Add .gitignore for new files .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21493 ) Change subject: IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header .. I

[Impala-ASF-CR] IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21493 ) Change subject: IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header .. Patch Set

[Impala-ASF-CR] IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy

2024-06-12 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21502 ) Change subject: IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy .. Patch Set 3: Code-Review+1

[Impala-ASF-CR] IMPALA-13156: Investigation: Set explicit credential provider for S3 builds

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21510 ) Change subject: IMPALA-13156: Investigation: Set explicit credential provider for S3 builds .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-13076 Add pstack and jstack to Impala Redhat docker images

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21433 ) Change subject: IMPALA-13076 Add pstack and jstack to Impala Redhat docker images .. Patch Set 3: Build Successful https://j

[Impala-ASF-CR] IMPALA-13156: Investigation: Set explicit credential provider for S3 builds

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21510 ) Change subject: IMPALA-13156: Investigation: Set explicit credential provider for S3 builds .. Patch Set 1: (1 comment) http

[Impala-ASF-CR] IMPALA-13156: Investigation: Set explicit credential provider for S3 builds

2024-06-12 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21510 Change subject: IMPALA-13156: Investigation: Set explicit credential provider for S3 builds .. IMPALA-13156: Investigation: Set explicit

[Impala-ASF-CR] IMPALA-13076 Add pstack and jstack to Impala Redhat docker images

2024-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21433 ) Change subject: IMPALA-13076 Add pstack and jstack to Impala Redhat docker images .. IMPALA-13076 Add pstack and jstack to Impala Redha

[Impala-ASF-CR] IMPALA-13076 Add pstack and jstack to Impala Redhat docker images

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21433 ) Change subject: IMPALA-13076 Add pstack and jstack to Impala Redhat docker images .. Patch Set 3: (2 comments) http://gerrit

[Impala-ASF-CR] IMPALA-13152: Avoid NaN cost at SortNode.java

2024-06-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21504 ) Change subject: IMPALA-13152: Avoid NaN cost at SortNode.java .. Patch Set 1: Code-Review-1 After IMPALA-12657, cost calculation can be

[Impala-ASF-CR] IMPALA-13152: Avoid NaN cost at SortNode.java

2024-06-12 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21504 ) Change subject: IMPALA-13152: Avoid NaN cost at SortNode.java .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-12871: Added filtering capability for Calcite planner

2024-06-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21498 ) Change subject: IMPALA-12871: Added filtering capability for Calcite planner .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-12871: Added filtering capability for Calcite planner

2024-06-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21498 ) Change subject: IMPALA-12871: Added filtering capability for Calcite planner .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-13137: Add additional client fetch metrics columns to the queries page

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21482 ) Change subject: IMPALA-13137: Add additional client fetch metrics columns to the queries page .. Patch Set 4: Build Successfu

[Impala-ASF-CR] IMPALA-13137: Add additional client fetch metrics columns to the queries page

2024-06-12 Thread Surya Hebbar (Code Review)
Surya Hebbar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21482 ) Change subject: IMPALA-13137: Add additional client fetch metrics columns to the queries page .. IMPALA-13137: Add additional client fetc

[Impala-ASF-CR] IMPALA-13137: Add additional client fetch metrics columns to the queries page

2024-06-12 Thread Surya Hebbar (Code Review)
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21482 ) Change subject: IMPALA-13137: Add additional client fetch metrics columns to the queries page .. Patch Set 4: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header

2024-06-12 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21493 ) Change subject: IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header .. Patch Set 7: Code-Revie

[Impala-ASF-CR] IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21493 ) Change subject: IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header .. Patch Set

[Impala-ASF-CR] IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21493 ) Change subject: IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header .. Patch Set

[Impala-ASF-CR] IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header

2024-06-12 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21493 ) Change subject: IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header .. Patch Set 7: Code-R

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. IMPALA-12562: Cast double and fl

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 6: Verified+1 -- To view, vi

[Impala-ASF-CR] IMPALA-13137: Add additional client fetch metrics columns to the queries page

2024-06-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21482 ) Change subject: IMPALA-13137: Add additional client fetch metrics columns to the queries page .. Patch Set 3: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21502 ) Change subject: IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy .. Patch Set 3: Buil

[Impala-ASF-CR] IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy

2024-06-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21502 ) Change subject: IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy .. Patch Set 3: (3 comme

[Impala-ASF-CR] WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21508 ) Change subject: WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy() .. Patch Set 3: Build Successful https:/

[Impala-ASF-CR] WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21508 ) Change subject: WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy() .. Patch Set 2: Build Successful https:/

[Impala-ASF-CR] WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()

2024-06-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21508 to look at the new patch set (#3). Change subject: WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy() ...

[Impala-ASF-CR] WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21508 ) Change subject: WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy() .. Patch Set 1: Build Successful https:/

[Impala-ASF-CR] IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()

2024-06-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21508 to look at the new patch set (#2). Change subject: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy() .

[Impala-ASF-CR] IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()

2024-06-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21508 Change subject: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy() .. IMPALA-13155: Smallify strings values in all Tuple

[Impala-ASF-CR] IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy

2024-06-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21502 ) Change subject: IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy .. Patch Set 2: Code-Review

[Impala-ASF-CR] IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy

2024-06-12 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21502 ) Change subject: IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header

2024-06-12 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21493 ) Change subject: IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header .. Patch Set 7: Code-Revie

[Impala-ASF-CR] IMPALA-13137: Add additional client fetch metrics columns to the queries page

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21482 ) Change subject: IMPALA-13137: Add additional client fetch metrics columns to the queries page .. Patch Set 3: Build Successfu

[Impala-ASF-CR] IMPALA-13137: Add additional client fetch metrics columns to the queries page

2024-06-12 Thread Surya Hebbar (Code Review)
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21482 ) Change subject: IMPALA-13137: Add additional client fetch metrics columns to the queries page .. Patch Set 3: > Please add tests to te

[Impala-ASF-CR] IMPALA-13137: Add additional client fetch metrics columns to the queries page

2024-06-12 Thread Surya Hebbar (Code Review)
Surya Hebbar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21482 ) Change subject: IMPALA-13137: Add additional client fetch metrics columns to the queries page .. IMPALA-13137: Add additional client fetc

[Impala-ASF-CR] IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21502 ) Change subject: IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy .. Patch Set 2: Buil

[Impala-ASF-CR] IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy

2024-06-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21502 ) Change subject: IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy .. Patch Set 1: (4 comme

[Impala-ASF-CR] IMPALA-12800: Add cache for isTrueWithNullSlots() evaluation

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21484 ) Change subject: IMPALA-12800: Add cache for isTrueWithNullSlots() evaluation .. IMPALA-12800: Add cache for isTrueWithN

[Impala-ASF-CR] IMPALA-12800: Add cache for isTrueWithNullSlots() evaluation

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21484 ) Change subject: IMPALA-12800: Add cache for isTrueWithNullSlots() evaluation .. Patch Set 12: Verified+1 -- To view, visit ht

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 6: Build started: https://jen

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 6: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-13039: AES Encryption/ Decryption Support in Impala

2024-06-12 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 ) Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala .. Patch Set 9: (89 comments) Thanks Pranav for the new pa

[Impala-ASF-CR] IMPALA-13001: Support graceful and force shutdown for impala.sh.

2024-06-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21297 ) Change subject: IMPALA-13001: Support graceful and force shutdown for impala.sh. .. Patch Set 4: (4 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-12921, IMPALA-12985: Support running Impala with locally built Ranger

2024-06-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21160 ) Change subject: IMPALA-12921, IMPALA-12985: Support running Impala with locally built Ranger .. Patch Set 16: Code-Review+1 Reviewed

[Impala-ASF-CR] IMPALA-12800: Add cache for isTrueWithNullSlots() evaluation

2024-06-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21484 ) Change subject: IMPALA-12800: Add cache for isTrueWithNullSlots() evaluation .. Patch Set 12: Code-Review+2 LGTM. Carry +1 from Riza.

[Impala-ASF-CR] IMPALA-12800: Add cache for isTrueWithNullSlots() evaluation

2024-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21484 ) Change subject: IMPALA-12800: Add cache for isTrueWithNullSlots() evaluation .. Patch Set 12: Build started: https://jenkins.i