[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12052 ) Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. IMPALA-7939: Fix issue where CTE is categorized as DML

[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12052 ) Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. IMPALA-7939: Fix issue where CTE is categorized as DML

[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12052 Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. IMPALA-7939: Fix issue where CTE is categorized as DM

[Impala-ASF-CR] IMPALA-6591: Fix test ssl flaky test

2018-12-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12047 ) Change subject: IMPALA-6591: Fix test_ssl flaky test .. IMPALA-6591: Fix test_ssl flaky test test_ssl has a logic that waits for the numb

[Impala-ASF-CR] IMPALA-6591: Fix test ssl flaky test

2018-12-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12047 Change subject: IMPALA-6591: Fix test_ssl flaky test .. IMPALA-6591: Fix test_ssl flaky test test_ssl has a logic that waits for the num

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 11: (9 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This pa

[Impala-ASF-CR] IMPALA-7917 (Part 1): Decouple Sentry from Impala

2018-12-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12020 ) Change subject: IMPALA-7917 (Part 1): Decouple Sentry from Impala .. IMPALA-7917 (Part 1): Decouple Sentry from Impala The first part of

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This pat

[Impala-ASF-CR](2.x) IMPALA-7922: Fix 2.x broken build due to Jackson dependency update

2018-12-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12027 ) Change subject: IMPALA-7922: Fix 2.x broken build due to Jackson dependency update .. Patch Set 3: Verified+1 -- To view, visit http:

[Impala-ASF-CR](2.x) IMPALA-7922: Fix 2.x broken build due to Jackson dependency update

2018-12-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12027 ) Change subject: IMPALA-7922: Fix 2.x broken build due to Jackson dependency update .. Patch Set 3: I'm going to merge this since the 2

[Impala-ASF-CR](2.x) IMPALA-7922: Fix 2.x broken build due to Jackson dependency update

2018-12-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12027 ) Change subject: IMPALA-7922: Fix 2.x broken build due to Jackson dependency update .. IMPALA-7922: Fix 2.x broken build due to

[Impala-ASF-CR](2.x) IMPALA-7922: Fix 2.x broken build due to Jackson dependency update

2018-12-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12027 ) Change subject: IMPALA-7922: Fix 2.x broken build due to Jackson dependency update .. Patch Set 3: > Patch Set 3: > > Thank you, Fredy

[Impala-ASF-CR](2.x) IMPALA-7922: Fix 2.x broken build due to Jackson dependency update

2018-12-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12027 ) Change subject: IMPALA-7922: Fix 2.x broken build due to Jackson dependency update .. IMPALA-7922: Fix 2.x broken build due to Jackson de

[Impala-ASF-CR](2.x) IMPALA-7922: Fix 2.x broken build due to Jackson dependency update

2018-12-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12027 ) Change subject: IMPALA-7922: Fix 2.x broken build due to Jackson dependency update .. Patch Set 3: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR](2.x) IMPALA-7922: Fix 2.x broken build due to Jackson dependency update

2018-12-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12027 ) Change subject: IMPALA-7922: Fix 2.x broken build due to Jackson dependency update .. Patch Set 2: The patch is able to build and run

[Impala-ASF-CR](2.x) IMPALA-7922: Fix 2.x broken build due to Jackson dependency update

2018-12-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12027 Change subject: IMPALA-7922: Fix 2.x broken build due to Jackson dependency update .. IMPALA-7922: Fix 2.x broken build due to update to

[Impala-ASF-CR](2.x) IMPALA-7922: Fix 2.x broken build due to Jackson dependency update

2018-12-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12027 ) Change subject: IMPALA-7922: Fix 2.x broken build due to Jackson dependency update .. IMPALA-7922: Fix 2.x broken build due to Jackson de

[Impala-ASF-CR] IMPALA-7917 (Part 1): Initial work to decouple Sentry from Impala

2018-11-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12020 ) Change subject: IMPALA-7917 (Part 1): Initial work to decouple Sentry from Impala .. Patch Set 3: (2 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-7917 (Part 1): Decouple Sentry from Impala

2018-11-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12020 ) Change subject: IMPALA-7917 (Part 1): Decouple Sentry from Impala .. IMPALA-7917 (Part 1): Decouple Sentry from Impala The first part of

[Impala-ASF-CR] IMPALA-7917 (Part 1): Initial work to decouple Sentry from Impala

2018-11-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12020 ) Change subject: IMPALA-7917 (Part 1): Initial work to decouple Sentry from Impala .. IMPALA-7917 (Part 1): Initial work to decouple Sentr

[Impala-ASF-CR] IMPALA-7917 (Part 1): Initial work to decouple Sentry from Impala

2018-11-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12020 Change subject: IMPALA-7917 (Part 1): Initial work to decouple Sentry from Impala .. IMPALA-7917 (Part 1): Initial work to decouple Sent

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12005 ) Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. Patch Set 5: (2 comments) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12005 ) Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from s

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12005 ) Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. Patch Set 4: Code-Review+1 (1 comment) Carry Phi

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12005 ) Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from s

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12005 ) Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. Patch Set 3: > Patch Set 1: > > I'm vaguely uncom

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12005 ) Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from s

[Impala-ASF-CR] IMPALA-6293: Unset JAVA TOOL OPTIONS variable from shell commands

2018-11-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12005 Change subject: IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from shell commands .. IMPALA-6293: Unset JAVA_TOOL_OPTIONS variable from

[Impala-ASF-CR] IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

2018-11-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11995 ) Change subject: IMPALA-7867 (Part 2): ArrayList cleanup in analyzer .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7865: Repeated type widening of arithmetic expressions

2018-11-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11952 ) Change subject: IMPALA-7865: Repeated type widening of arithmetic expressions .. Patch Set 2: (10 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query

2018-11-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11990 ) Change subject: IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query .. Patch Set 4: Code-Review+2 Trivial test fix

[Impala-ASF-CR] IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query

2018-11-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11990 ) Change subject: IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query .. IMPALA-7893: Correctly handle Ctrl+C for cance

[Impala-ASF-CR] IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query

2018-11-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11990 ) Change subject: IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query .. Patch Set 3: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7823: Clean up unused Java imports

2018-11-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11987 ) Change subject: IMPALA-7823: Clean up unused Java imports .. Patch Set 2: Code-Review+1 This LGTM, but I'll let Phil give a +2. -- To

[Impala-ASF-CR] IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query

2018-11-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11990 ) Change subject: IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query .. IMPALA-7893: Correctly handle Ctrl+C for cance

[Impala-ASF-CR] IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query

2018-11-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11990 Change subject: IMPALA-7893: Correctly handle Ctrl+C for cancelling a non-running query .. IMPALA-7893: Correctly handle Ctrl+C for canc

[Impala-ASF-CR] IMPALA-7867 (Part 1): Expose List in TreeNode, parser

2018-11-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11954 ) Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-11-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/118

[Impala-ASF-CR] IMPALA-7867 (Part 1): Expose List in TreeNode, parser

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11954 ) Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 4: Code-Review+2 (1 comment

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. IMPALA-7839: Remove code duplication for

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 8: Code-Review+1 (1 comment) Carry Csaba's +1. ht

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This pat

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 3: (2 comments) http://ger

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. IMPALA-7839: Remove code duplication for

[Impala-ASF-CR] IMPALA-7867 (Part 1): Expose List in TreeNode, parser

2018-11-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11954 ) Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 2: (2 comments) http://ger

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 5: (28 comments) My general comments: - We should a

[Impala-ASF-CR] IMPALA-7867, part 1: Expose List in TreeNode, parser

2018-11-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11954 ) Change subject: IMPALA-7867, part 1: Expose List in TreeNode, parser .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This pat

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 2: Code-Review+1 Carry Csab

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 2: (2 comments) http://ger

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. IMPALA-7839: Remove code duplication for

[Impala-ASF-CR] IMPALA-941: [DOCS] Update Impala identifier doc

2018-11-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11930 Change subject: IMPALA-941: [DOCS] Update Impala identifier doc .. IMPALA-941: [DOCS] Update Impala identifier doc Change-Id: I481e4c9be

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Patch Set 4: Code-Review+2 (2 comments) Carry

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. IMPALA-941: Fix support for an identifier that sta

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Patch Set 3: (5 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. IMPALA-941: Fix support for an identifier that sta

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11928 Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. IMPALA-7839: Remove code duplication fo

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. IMPALA-7764: Improve SentryProxy test coverage This patch refactors the

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 7: Code-Review+2 (1 comment) Carry Vuk's +2. http://gerri

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has removed Vuk Ercegovac from this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Removed reviewer Vuk Ercegovac. -- To view, visit htt

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has removed Vuk Ercegovac from this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Removed reviewer Vuk Ercegovac. -- To v

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11927 Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. IMPALA-941: Fix support for an identifier that st

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11922/3/doc

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 2: > Patch Set 2: > > > Patch Set 2: > > > > Build

[Impala-ASF-CR] IMPALA-7848: Enable ParserTest.TestAdminFns

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11925 Change subject: IMPALA-7848: Enable ParserTest.TestAdminFns .. IMPALA-7848: Enable ParserTest.TestAdminFns This patch enables ParserTest

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 6: Rebased. -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This pat

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. IMPALA-7764: Improve SentryProxy test coverage This patch refactors the

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 6: Rebased. -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/11880/

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. IMPALA-7764: Improve SentryProxy test coverage This patch refactors the

[Impala-ASF-CR] IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang

2018-11-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11910 ) Change subject: IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang .. Patch Set 7: (4

[Impala-ASF-CR] IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang

2018-11-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11910 ) Change subject: IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang .. IMPALA-7835: Role

[Impala-ASF-CR] IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang

2018-11-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11910 ) Change subject: IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang .. IMPALA-7835: Role

[Impala-ASF-CR] IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang

2018-11-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11910 ) Change subject: IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang .. Patch Set 6: (4

[Impala-ASF-CR] IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang

2018-11-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11910 Change subject: IMPALA-7835: Role and user catalog objects with the same name can cause INVALIDATE METADATA to hang .. IMPALA-7835: Role

[Impala-ASF-CR] IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable

2018-11-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/11897 ) Change subject: IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable .. IMPALA-7824: INVALIDATE METADATA should n

[Impala-ASF-CR] IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable

2018-11-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11897 ) Change subject: IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable .. Patch Set 11: Code-Review+2 So apparent

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11880/2

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. IMPALA-7764: Improve SentryProxy test coverage This patch refactors the

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. IMPALA-7764: Improve SentryProxy test coverage This patch refactors the

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11880/1

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This pat

[Impala-ASF-CR] IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable

2018-11-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/11897 ) Change subject: IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable .. IMPALA-7824: INVALIDATE METADATA should no

[Impala-ASF-CR] IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable

2018-11-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11897 ) Change subject: IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable .. Patch Set 9: (10 comments) http://gerr

[Impala-ASF-CR] IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable

2018-11-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11897 ) Change subject: IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable .. IMPALA-7824: INVALIDATE METADATA should no

[Impala-ASF-CR] IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable

2018-11-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11897 ) Change subject: IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable .. Patch Set 5: (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable

2018-11-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11897 Change subject: IMPALA-7824: INVALIDATE METADATA should not hang when Sentry is unavailable .. IMPALA-7824: INVALIDATE METADATA should n

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This pat

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11888 Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This pa

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11880 Change subject: IMPALA-7764: Improve SentryProxy test coverage .. IMPALA-7764: Improve SentryProxy test coverage This patch refactors th

[Impala-ASF-CR] IMPALA-7794: Rewrite flaky ownership authorization tests

2018-10-31 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11837 ) Change subject: IMPALA-7794: Rewrite flaky ownership authorization tests .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-7794: Rewrite flaky ownership authorization tests

2018-10-31 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11837 ) Change subject: IMPALA-7794: Rewrite flaky ownership authorization tests .. IMPALA-7794: Rewrite flaky ownership authorization tests This

<    3   4   5   6   7   8   9   10   11   12   >