[Impala-ASF-CR] IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder

2024-06-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21452 ) Change subject: IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-06-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21435 ) Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-06-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21423 ) Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. Patch Set 7: (18 comments) I managed to finish

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-06-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21423 ) Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. Patch Set 7: (25 comments) I managed to finish

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-06-17 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21423 ) Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. Patch Set 7: (16 comments) Another batch. I'm

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-06-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21423 ) Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. Patch Set 7: (22 comments) doing another dump.

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-06-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21423 ) Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. Patch Set 7: (25 comments) Let me flush another

[Impala-ASF-CR] IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy

2024-06-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21502 ) Change subject: IMPALA-13138: Never smallify existing StringValue objects, only new ones during DeepCopy .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-05-31 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21423 ) Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-05-31 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21423 ) Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. Patch Set 6: (7 comments) Thanks for this huge

[Impala-ASF-CR] IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder

2024-05-31 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21452 ) Change subject: IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-05-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21435 ) Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21394 ) Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-09 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21394 to look at the new patch set (#2). Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-05-09 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21348 to look at the new patch set (#4). Change subject: IMPALA-13029: Tests for multi format equality deletes

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21394 Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert .. IMPALA-13055: Some Iceberg metadata table tests don't

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-05-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21348 ) Change subject: IMPALA-13029: Tests for multi format equality deletes .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-05-02 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21348 to look at the new patch set (#3). Change subject: IMPALA-13029: Tests for multi format equality deletes

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-04-24 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21348 ) Change subject: IMPALA-13029: Tests for multi format equality deletes .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-04-24 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21348 to look at the new patch set (#2). Change subject: IMPALA-13029: Tests for multi format equality deletes

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-04-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21348 Change subject: IMPALA-13029: Tests for multi format equality deletes .. IMPALA-13029: Tests for multi format equality deletes So far

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list .. Patch Set 8:

[Impala-ASF-CR] IMPALA-13002: Iceberg V2 tables with Avro delete files aren't read properly

2024-04-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21301 ) Change subject: IMPALA-13002: Iceberg V2 tables with Avro delete files aren't read properly .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-13002: Iceberg V2 tables with Avro delete files aren't read properly

2024-04-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21301 ) Change subject: IMPALA-13002: Iceberg V2 tables with Avro delete files aren't read properly .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list .. Patch Set 7: (2

[Impala-ASF-CR] IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder

2024-04-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 ) Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder

2024-04-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 ) Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-12991: Eliminate unnecessary SORT for Iceberg DELETEs

2024-04-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21285 ) Change subject: IMPALA-12991: Eliminate unnecessary SORT for Iceberg DELETEs .. Patch Set 1: Code-Review+2 (1 comment) Thanks! +2

[Impala-ASF-CR] IMPALA-12970: Fix ConcurrentModificationException for Iceberg table scans

2024-04-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21267 ) Change subject: IMPALA-12970: Fix ConcurrentModificationException for Iceberg table scans .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder

2024-04-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 ) Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder .. Patch Set 7: (3 comments)

[Impala-ASF-CR] IMPALA-12970: Fix ConcurrentModificationException for Iceberg table scans

2024-04-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21267 ) Change subject: IMPALA-12970: Fix ConcurrentModificationException for Iceberg table scans .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-12970: Fix ConcurrentModificationException for Iceberg table scans

2024-04-09 Thread Gabor Kaszab (Code Review)
Hello Peter Rozsa, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21267 to look at the new patch set (#2). Change subject: IMPALA-12970: Fix ConcurrentModificationException for Iceberg table scans

[Impala-ASF-CR] IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder

2024-04-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 ) Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-12970: Fix ConcurrentModificationException for Iceberg table scans

2024-04-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21267 Change subject: IMPALA-12970: Fix ConcurrentModificationException for Iceberg table scans .. IMPALA-12970: Fix

[Impala-ASF-CR] IMPALA-12894: Addendum: Re-enable test plain count star optimization

2024-04-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21249 ) Change subject: IMPALA-12894: Addendum: Re-enable test_plain_count_star_optimization .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

2024-04-04 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21236 to look at the new patch set (#4). Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

[Impala-ASF-CR] IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

2024-04-03 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21236 to look at the new patch set (#2). Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

[Impala-ASF-CR] IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

2024-04-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21236 ) Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-12612: Expand complex type columns from Iceberg metadata tables

2024-04-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21236 Change subject: IMPALA-12612: Expand complex type columns from Iceberg metadata tables .. IMPALA-12612: Expand complex type columns

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-04-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. Patch Set 10: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-04-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. Patch Set 4: (3 comments) Thanks for the patch! I

[Impala-ASF-CR] IMPALA-12600: Schema evolution with equality delete files

2024-04-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21210 ) Change subject: IMPALA-12600: Schema evolution with equality delete files .. Patch Set 5: Code-Review+2 Did a rebase to resolve git

[Impala-ASF-CR] IMPALA-12600: Schema evolution with equality delete files

2024-04-02 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21210 to look at the new patch set (#5). Change subject: IMPALA-12600: Schema evolution with equality delete files

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-03-28 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. Patch Set 5: (8 comments)

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-28 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21149 to look at the new patch set (#10). Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-28 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21149 ) Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables .. Patch Set 9: After a rebase with master some Iceberg

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-28 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21149 to look at the new patch set (#9). Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-03-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. Patch Set 3: (4 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12600: Schema evolution with equality delete files

2024-03-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21210 ) Change subject: IMPALA-12600: Schema evolution with equality delete files .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12600: Schema evolution with equality delete files

2024-03-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21210 ) Change subject: IMPALA-12600: Schema evolution with equality delete files .. Patch Set 3: Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-12600: Schema evolution with equality delete files

2024-03-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21210 ) Change subject: IMPALA-12600: Schema evolution with equality delete files .. Patch Set 3: PS3 is rebase with master + conflict

[Impala-ASF-CR] IMPALA-12600: Schema evolution with equality delete files

2024-03-27 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21210 to look at the new patch set (#3). Change subject: IMPALA-12600: Schema evolution with equality delete files

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-27 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21149 to look at the new patch set (#8). Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables

[Impala-ASF-CR] IMPALA-12600: Schema evolution with equality delete files

2024-03-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21210 ) Change subject: IMPALA-12600: Schema evolution with equality delete files .. Patch Set 2: Thanks for taking a look, Zoli! Added a

[Impala-ASF-CR] IMPALA-12600: Schema evolution with equality delete files

2024-03-27 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21210 to look at the new patch set (#2). Change subject: IMPALA-12600: Schema evolution with equality delete files

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21149 ) Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-27 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21149 to look at the new patch set (#6). Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables

[Impala-ASF-CR] IMPALA-12600: Schema evolution with equality delete files

2024-03-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21210 Change subject: IMPALA-12600: Schema evolution with equality delete files .. IMPALA-12600: Schema evolution with equality delete files

[Impala-ASF-CR] IMPALA-12879: Conjunct not referring to table field causes ERROR for Iceberg table

2024-03-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21179 ) Change subject: IMPALA-12879: Conjunct not referring to table field causes ERROR for Iceberg table .. Patch Set 5: Code-Review+2 --

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21149 ) Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables .. Patch Set 5: (15 comments)

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-25 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21149 to look at the new patch set (#5). Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-25 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21149 to look at the new patch set (#4). Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables

[Impala-ASF-CR] IMPALA-12809: Iceberg metadata table scanner should always be scheduled to the coordinator

2024-03-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21138 ) Change subject: IMPALA-12809: Iceberg metadata table scanner should always be scheduled to the coordinator .. Patch Set 4:

[Impala-ASF-CR] IMPALA-12903: Querying virtual column FILE POSITION for TEXT and JSON tables crashes Impala

2024-03-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21148 ) Change subject: IMPALA-12903: Querying virtual column FILE__POSITION for TEXT and JSON tables crashes Impala .. Patch Set 4:

[Impala-ASF-CR] IMPALA-12879: Conjunct not referring to table field causes ERROR for Iceberg table

2024-03-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21179 ) Change subject: IMPALA-12879: Conjunct not referring to table field causes ERROR for Iceberg table .. Patch Set 2: Code-Review+2 --

[Impala-ASF-CR] IMPALA-12903: Querying virtual column FILE POSITION for TEXT and JSON tables crashes Impala

2024-03-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21148 ) Change subject: IMPALA-12903: Querying virtual column FILE__POSITION for TEXT and JSON tables crashes Impala .. Patch Set 3:

[Impala-ASF-CR] IMPALA-12879: Conjunct not referring to table field causes ERROR for Iceberg table

2024-03-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21179 ) Change subject: IMPALA-12879: Conjunct not referring to table field causes ERROR for Iceberg table .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-12809: Iceberg metadata table scanner should always be scheduled to the coordinator

2024-03-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21138 ) Change subject: IMPALA-12809: Iceberg metadata table scanner should always be scheduled to the coordinator .. Patch Set 2: (4

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-21 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21149 to look at the new patch set (#3). Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-19 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21149 to look at the new patch set (#2). Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables

[Impala-ASF-CR] IMPALA-12903: Querying virtual column FILE POSITION for TEXT and JSON tables crashes Impala

2024-03-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21148 ) Change subject: IMPALA-12903: Querying virtual column FILE__POSITION for TEXT and JSON tables crashes Impala .. Patch Set 1: (2

[Impala-ASF-CR] IMPALA-12729: Allow creating primary keys for Iceberg tables

2024-03-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21149 Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables .. IMPALA-12729: Allow creating primary keys for Iceberg

[Impala-ASF-CR] IMPALA-12894: (part 1) Turn off the count(*) optimisation for V2 Iceberg tables

2024-03-13 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21139 to look at the new patch set (#4). Change subject: IMPALA-12894: (part 1) Turn off the count(*) optimisation for V2 Iceberg tables

[Impala-ASF-CR] IMPALA-12894: Turn off the count(*) optimisation for V2 Iceberg tables

2024-03-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21139 ) Change subject: IMPALA-12894: Turn off the count(*) optimisation for V2 Iceberg tables .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-12894: Turn off the count(*) optimisation for V2 Iceberg tables

2024-03-13 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21139 to look at the new patch set (#3). Change subject: IMPALA-12894: Turn off the count(*) optimisation for V2 Iceberg tables

[Impala-ASF-CR] IMPALA-12894: Turn off the count(*) optimisation for V2 Iceberg tables

2024-03-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21139 ) Change subject: IMPALA-12894: Turn off the count(*) optimisation for V2 Iceberg tables .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-12894: Turn off the count(*) optimisation for V2 Iceberg tables

2024-03-13 Thread Gabor Kaszab (Code Review)
Hello Daniel Becker, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21139 to look at the new patch set (#2). Change subject: IMPALA-12894: Turn off the count(*) optimisation for V2 Iceberg tables

[Impala-ASF-CR] IMPALA-12894: Turn off the count(*) optimisation for V2 Iceberg tables

2024-03-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21139 Change subject: IMPALA-12894: Turn off the count(*) optimisation for V2 Iceberg tables .. IMPALA-12894: Turn off the count(*)

[Impala-ASF-CR] IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables

2024-03-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21061 ) Change subject: IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables .. IMPALA-12610: Support reading ARRAY

[Impala-ASF-CR] IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables

2024-03-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21061 ) Change subject: IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables .. Patch Set 12: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12860: Invoke validateDataFilesExist for RowDelta operations

2024-03-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21099 ) Change subject: IMPALA-12860: Invoke validateDataFilesExist for RowDelta operations .. Patch Set 2: Code-Review+2 Thanks for the

[Impala-ASF-CR] IMPALA-12860: Invoke validateDataFilesExist for RowDelta operations

2024-03-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21099 ) Change subject: IMPALA-12860: Invoke validateDataFilesExist for RowDelta operations .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-12860: Invoke validateDataFilesExist for RowDelta operations

2024-03-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21099 ) Change subject: IMPALA-12860: Invoke validateDataFilesExist for RowDelta operations .. Patch Set 1: (7 comments) great job with this

[Impala-ASF-CR] IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables

2024-02-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21061 ) Change subject: IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables .. Patch Set 8: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12598: Allow multiple equality field id lists for Iceberg tables

2024-02-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20951 ) Change subject: IMPALA-12598: Allow multiple equality field id lists for Iceberg tables .. Patch Set 11: Code-Review+2 carry +2 from

[Impala-ASF-CR] IMPALA-12598: Allow multiple equality field id lists for Iceberg tables

2024-02-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20951 ) Change subject: IMPALA-12598: Allow multiple equality field id lists for Iceberg tables .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-12598: Allow multiple equality field id lists for Iceberg tables

2024-02-29 Thread Gabor Kaszab (Code Review)
Hello Andrew Sherman, Tamas Mate, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20951 to look at the new patch set (#10). Change subject: IMPALA-12598: Allow multiple equality field id lists for Iceberg tables

[Impala-ASF-CR] IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables

2024-02-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21061 ) Change subject: IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables

2024-02-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21061 ) Change subject: IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables .. Patch Set 6: (8 comments)

[Impala-ASF-CR] IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables

2024-02-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21061 ) Change subject: IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables .. Patch Set 3: (14 comments) I managed to

[Impala-ASF-CR] IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables

2024-02-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21061 ) Change subject: IMPALA-12610: Support reading ARRAY columns for Iceberg Metadata tables .. Patch Set 3: (9 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables

2024-02-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21026 ) Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables .. Patch Set 7: (3

[Impala-ASF-CR] IMPALA-12598: Allow multiple equality field id lists for Iceberg tables

2024-02-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20951 ) Change subject: IMPALA-12598: Allow multiple equality field id lists for Iceberg tables .. Patch Set 7: (3 comments)

[Impala-ASF-CR] IMPALA-12598: Allow multiple equality field id lists for Iceberg tables

2024-02-22 Thread Gabor Kaszab (Code Review)
Hello Andrew Sherman, Tamas Mate, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20951 to look at the new patch set (#7). Change subject: IMPALA-12598: Allow multiple equality field id lists for Iceberg tables

  1   2   3   4   5   6   7   8   9   10   >