[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj

2019-02-08 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12412 Change subject: IMPALA-8175: improve tests_minicluster_obj .. IMPALA-8175: improve tests_minicluster_obj Adjust minicluster impalad pgr

[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj

2019-02-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12412 ) Change subject: IMPALA-8175: improve tests_minicluster_obj .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12412/1/te

[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj

2019-02-08 Thread Michael Brown (Code Review)
Hello Andrew Sherman, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12412 to look at the new patch set (#2). Change subject: IMPALA-8175: improve tests_minicluster_obj

[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj

2019-02-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12412 ) Change subject: IMPALA-8175: improve tests_minicluster_obj .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12412/1/te

[Impala-ASF-CR] IMPALA-8171: minicluster: use exec builtin to start Impala daemons

2019-02-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12391 ) Change subject: IMPALA-8171: minicluster: use exec builtin to start Impala daemons .. Patch Set 1: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8171: minicluster: use exec builtin to start Impala daemons

2019-02-06 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12391 Change subject: IMPALA-8171: minicluster: use exec builtin to start Impala daemons .. IMPALA-8171: minicluster: use exec builtin to sta

[Impala-ASF-CR] IMPALA-8169: small changes to Leopard

2019-02-06 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12386 Change subject: IMPALA-8169: small changes to Leopard .. IMPALA-8169: small changes to Leopard - Fix a bug in which rsync --chown doesn

[Impala-ASF-CR] IMPALA-8091 addendum: use absolute path for ntp-wait

2019-02-05 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12369 Change subject: IMPALA-8091 addendum: use absolute path for ntp-wait .. IMPALA-8091 addendum: use absolute path for ntp-wait While ntp-

[Impala-ASF-CR] IMPALA-8113: skip test aggregation and test avro primitive in list in S3

2019-01-24 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12272 Change subject: IMPALA-8113: skip test_aggregation and test_avro_primitive_in_list in S3 .. IMPALA-8113: skip test_aggregation and test

[Impala-ASF-CR] IMPALA-8091: incremental improvements to NTP sync

2019-01-22 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12253 Change subject: IMPALA-8091: incremental improvements to NTP sync .. IMPALA-8091: incremental improvements to NTP sync - Warn when ntp-

[Impala-ASF-CR] IMPALA-5847: Fix incorrect use of SET in .test files

2019-01-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12220 ) Change subject: IMPALA-5847: Fix incorrect use of SET in .test files .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-8089: Fixing run-all-tests timeout raciness.

2019-01-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12230 ) Change subject: IMPALA-8089: Fixing run-all-tests timeout raciness. .. Patch Set 1: Code-Review+1 Seems a fine place to start. Bikram,

[Impala-ASF-CR] IMPALA-5847: Fix incorrect use of SET in .test files

2019-01-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12220 ) Change subject: IMPALA-5847: Fix incorrect use of SET in .test files .. Patch Set 2: (6 comments) No issues with implementation. I lo

[Impala-ASF-CR] Added timeout to run-all-tests

2018-12-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/12086

[Impala-ASF-CR] Added timeout to run-all-tests

2018-12-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-t

[Impala-ASF-CR] IMPALA-7926: Fix flakiness in test reconnect

2018-12-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12045 ) Change subject: IMPALA-7926: Fix flakiness in test_reconnect .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR](asf-site) [DOCS] The wrong version number was fixed for Impala 3.0 Changelog

2018-12-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12056 ) Change subject: [DOCS] The wrong version number was fixed for Impala 3.0 Changelog .. Patch Set 1: Code-Review+2 -- To view, visit h

[Impala-ASF-CR](asf-site) [DOCS] Impala 3.1 Docs to be published

2018-12-06 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12046 ) Change subject: [DOCS] Impala 3.1 Docs to be published .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR](asf-site) [DOCS] Impala 3.1 Docs to be published

2018-12-06 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12046 ) Change subject: [DOCS] Impala 3.1 Docs to be published .. Patch Set 1: I think as part of this patch you also need to "git rm impala_

[Impala-ASF-CR](asf-site) [DOCS] Impala 3.1 Docs to be published

2018-12-06 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12046 ) Change subject: [DOCS] Impala 3.1 Docs to be published .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12046/1//COMMI

[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function

2018-11-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 ) Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function .. Patch Set 3: Code-Review+1 (1 comment) Soft +2 for th

[Impala-ASF-CR] IMPALA-7761: Add multiple DISTINCT to targeted perf and stress test

2018-11-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 ) Change subject: IMPALA-7761: Add multiple DISTINCT to targeted perf and stress test .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7761: Add multiple DISTINCT to targeted perf and stress test

2018-11-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 ) Change subject: IMPALA-7761: Add multiple DISTINCT to targeted perf and stress test .. Patch Set 3: This seems fine now. I'm checking

[Impala-ASF-CR] IMPALA-7809: support Kudu 1.9 in test concurrent schema change

2018-11-05 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11882 Change subject: IMPALA-7809: support Kudu 1.9 in test_concurrent_schema_change .. IMPALA-7809: support Kudu 1.9 in test_concurrent_schem

[Impala-ASF-CR] IMPALA-7761: Add multiple DISTINCT to targeted stress and perf

2018-11-05 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 ) Change subject: IMPALA-7761: Add multiple DISTINCT to targeted stress and perf .. Patch Set 1: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7761: Add multiple DISTINCT to targeted stress and perf

2018-10-31 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 ) Change subject: IMPALA-7761: Add multiple DISTINCT to targeted stress and perf .. Patch Set 1: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7783: Skip test default timezone when testing a real cluster.

2018-10-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11820 ) Change subject: IMPALA-7783: Skip test_default_timezone when testing a real cluster. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6374: fix handling of commas in .test files

2018-10-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11800 ) Change subject: IMPALA-6374: fix handling of commas in .test files .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-6374: fix handling of commas in .test files

2018-10-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11800 ) Change subject: IMPALA-6374: fix handling of commas in .test files .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11

[Impala-ASF-CR] CDH-73537: Skip test default timezone when testing a real cluster.

2018-10-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11820 ) Change subject: CDH-73537: Skip test_default_timezone when testing a real cluster. .. Patch Set 2: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-7761: Add multiple DISTINCT to targeted stress and perf

2018-10-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 ) Change subject: IMPALA-7761: Add multiple DISTINCT to targeted stress and perf .. Patch Set 1: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7673: Support values from other variables in Impala shell --var

2018-10-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11623 ) Change subject: IMPALA-7673: Support values from other variables in Impala shell --var .. Patch Set 9: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-7690: Make test pool config change while queued compatible with python 2.6

2018-10-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11660 ) Change subject: IMPALA-7690: Make test_pool_config_change_while_queued compatible with python 2.6 .. Patch Set 1: Code-Review+2 -- T

[Impala-ASF-CR] IMPALA-7693: stress test: fix Query().name

2018-10-11 Thread Michael Brown (Code Review)
Michael Brown has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11651 ) Change subject: IMPALA-7693: stress test: fix Query().name .. IMPALA-7693: stress test: fix Query().name In the refactor as pa

[Impala-ASF-CR] IMPALA-7693: stress test: fix Query().name

2018-10-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11651 ) Change subject: IMPALA-7693: stress test: fix Query().name .. Patch Set 2: Verified+1 > Build failed: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-7693: stress test: fix Query().name

2018-10-11 Thread Michael Brown (Code Review)
Michael Brown has removed a vote on this change. Change subject: IMPALA-7693: stress test: fix Query().name .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/11651 To unsubscribe,

[Impala-ASF-CR] IMPALA-7693: stress test: fix Query().name

2018-10-10 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11651 Change subject: IMPALA-7693: stress test: fix Query().name .. IMPALA-7693: stress test: fix Query().name In the refactor as part of IMP

[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes

2018-10-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11619 ) Change subject: [DOCS] Built-in Functions doc format Changes .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes

2018-10-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11619 ) Change subject: [DOCS] Built-in Functions doc format Changes .. Patch Set 2: I don't think you used "git add" or something else went w

[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes

2018-10-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11619 ) Change subject: [DOCS] Built-in Functions doc format Changes .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11619/2/

[Impala-ASF-CR] IMPALA-7647: Add HS2/Impyla dimension to TestQueries

2018-10-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11546 ) Change subject: IMPALA-7647: Add HS2/Impyla dimension to TestQueries .. Patch Set 7: Code-Review+1 This looks good, and because some d

[Impala-ASF-CR] IMPALA-7643: report # queries actually executing in stress test

2018-10-05 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11587 ) Change subject: IMPALA-7643: report # queries actually executing in stress test .. Patch Set 3: Code-Review+2 (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-7643: report # queries actually executing in stress test

2018-10-05 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11587 ) Change subject: IMPALA-7643: report # queries actually executing in stress test .. Patch Set 2: (4 comments) Can you also do a quick

[Impala-ASF-CR] IMPALA-6249: Expose several build flags via web UI

2018-10-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11410 ) Change subject: IMPALA-6249: Expose several build flags via web UI .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11

[Impala-ASF-CR] IMPALA-7589: default query options for custom cluster

2018-09-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11463 ) Change subject: IMPALA-7589: default query options for custom cluster .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-6442: Misleading file offset reporting in error messages.

2018-08-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11336 ) Change subject: IMPALA-6442: Misleading file offset reporting in error messages. .. Patch Set 1: Hello, This is the Apache Impala pro

[Impala-ASF-CR] update Flask to latest (1.0.2)

2018-08-27 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11335 Change subject: update Flask to latest (1.0.2) .. update Flask to latest (1.0.2) Similar to Fabric and Paramiko, make Flask part of ext

[Impala-ASF-CR] IMPALA-7356 (part 2 of ?): restrict number of coordinators

2018-08-24 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11316 ) Change subject: IMPALA-7356 (part 2 of ?): restrict number of coordinators .. Patch Set 1: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-7460 part 2: upgrade Paramiko and Fabric in extended test env

2018-08-23 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11308 Change subject: IMPALA-7460 part 2: upgrade Paramiko and Fabric in extended test env .. IMPALA-7460 part 2: upgrade Paramiko and Fabric

[Impala-ASF-CR] IMPALA-7479: Harmonize parquet versions.

2018-08-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11299 ) Change subject: IMPALA-7479: Harmonize parquet versions. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors

2018-08-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 9: Code-Review+1 (2 comments) Phil had good co

[Impala-ASF-CR] IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 5: Code-Review+2 rebase/commit message fi

[Impala-ASF-CR] IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Michael Brown (Code Review)
Hello Lars Volker, Philip Zeyliger, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11264 to look at the new patch set (#5). Change subject: IMPALA-7460 part 1: require user to install Paramiko and Fabric .

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 4: > Expect another non-trivial upd

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-22 Thread Michael Brown (Code Review)
Hello Lars Volker, Philip Zeyliger, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11264 to look at the new patch set (#4). Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric ...

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 3: > Thanks. I'm considering this s

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 3: > Patch Set 3: Code-Review+2 Th

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11264 ) Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. Patch Set 2: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-21 Thread Michael Brown (Code Review)
Hello Lars Volker, Philip Zeyliger, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11264 to look at the new patch set (#3). Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric ..

[Impala-ASF-CR] WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric

2018-08-21 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11264 Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric .. WIP: IMPALA-7460 part 1: require user to instal

[Impala-ASF-CR] tests: remove unused failure injector test library

2018-08-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11226 ) Change subject: tests: remove unused failure_injector test library .. Patch Set 1: Code-Review+2 We know where we can find it, so sure

[Impala-ASF-CR] tests: ensure consistent logging format across tests

2018-08-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11225 ) Change subject: tests: ensure consistent logging format across tests .. Patch Set 1: Code-Review+2 (1 comment) Than you for doing thi

[Impala-ASF-CR] IMPALA-7445: separate skippable tables from test resource limits

2018-08-14 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11221 Change subject: IMPALA-7445: separate skippable tables from test_resource_limits .. IMPALA-7445: separate skippable tables from test_res

[Impala-ASF-CR] IMPALA-7356 (part 1 of ?): admission control stress

2018-08-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11205 ) Change subject: IMPALA-7356 (part 1 of ?): admission control stress .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7440: remove --nlj-filter from stress test

2018-08-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11212 ) Change subject: IMPALA-7440: remove --nlj-filter from stress test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-7356 (part 1 of ?): admission control stress

2018-08-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11205 ) Change subject: IMPALA-7356 (part 1 of ?): admission control stress .. Patch Set 5: (1 comment) Seems fine and straightforward, just

[Impala-ASF-CR] IMPALA-7428: Fix flaky test shell command line::test large sql

2018-08-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11201 ) Change subject: IMPALA-7428: Fix flaky test_shell_command_line::test_large_sql .. Patch Set 3: Code-Review+2 (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-7428: Fix flaky test shell command line::test large sql

2018-08-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11201 ) Change subject: IMPALA-7428: Fix flaky test_shell_command_line::test_large_sql .. Patch Set 2: (3 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] Ignore flake8 W503 about breaking before operators

2018-08-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11196 ) Change subject: Ignore flake8 W503 about breaking before operators .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-7317: loosen flake8 rules

2018-08-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11102 ) Change subject: IMPALA-7317: loosen flake8 rules .. Patch Set 2: Code-Review+2 (1 comment) Feel free to carry +2 after addressing the

[Impala-ASF-CR] IMPALA-7317: loosen flake8 rules

2018-08-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11102 ) Change subject: IMPALA-7317: loosen flake8 rules .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg Fi

[Impala-ASF-CR] IMPALA-7317: loosen flake8 rules

2018-08-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11102 ) Change subject: IMPALA-7317: loosen flake8 rules .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg Fi

[Impala-ASF-CR] IMPALA-7317: loosen flake8 rules

2018-08-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11102 ) Change subject: IMPALA-7317: loosen flake8 rules .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg F

[Impala-ASF-CR] IMPALA-7317: loosen flake8 rules

2018-08-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11102 ) Change subject: IMPALA-7317: loosen flake8 rules .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg Fi

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-7317: add scripts to post flake8 comments

2018-07-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11054 ) Change subject: IMPALA-7317: add scripts to post flake8 comments .. Patch Set 14: Seems fine. Have you yet tested reviews with non-Pyt

[Impala-ASF-CR] IMPALA-110 (part 3): Add multiple DISTINCT support to query generator

2018-07-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11073 ) Change subject: IMPALA-110 (part 3): Add multiple DISTINCT support to query generator .. Patch Set 1: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-7173: [DOCS] Added check options in the load balancer examples

2018-07-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11006 ) Change subject: IMPALA-7173: [DOCS] Added check options in the load balancer examples .. Patch Set 1: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates

2018-07-18 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10100 ) Change subject: IMPALA-6923: Update scripts in benchmark folder to store workload and few minor updates .. Patch Set 12: (5 comments)

[Impala-ASF-CR] IMPALA-7314: Doc generation should fail on error

2018-07-18 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10976 ) Change subject: IMPALA-7314: Doc generation should fail on error .. Patch Set 2: Code-Review+2 I'm happy to promote my +1. For docs, u

[Impala-ASF-CR] IMPALA-7314: Doc generation should fail on error

2018-07-18 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10976 ) Change subject: IMPALA-7314: Doc generation should fail on error .. Patch Set 2: Code-Review+1 Please make sure Alex understands and a

[Impala-ASF-CR] IMPALA-6810: runtime row filters.test: omit pool name in pattern

2018-07-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10942 ) Change subject: IMPALA-6810: runtime_row_filters.test: omit pool name in pattern .. Patch Set 2: Code-Review+2 rebase -- To view, vi

[Impala-ASF-CR] IMPALA-6810: runtime row filters.test: omit pool name in pattern

2018-07-13 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10942 Change subject: IMPALA-6810: runtime_row_filters.test: omit pool name in pattern .. IMPALA-6810: runtime_row_filters.test: omit pool nam

[Impala-ASF-CR] IMPALA-7259: Improve Impala shell performance

2018-07-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10939 ) Change subject: IMPALA-7259: Improve Impala shell performance .. Patch Set 7: Code-Review+1 (1 comment) for the test http://gerrit.c

[Impala-ASF-CR] IMPALA-7259: Improve Impala shell performance

2018-07-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10939 ) Change subject: IMPALA-7259: Improve Impala shell performance .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/10939/

[Impala-ASF-CR] IMPALA-7238: Use custom timeout for create unique database

2018-07-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10862 ) Change subject: IMPALA-7238: Use custom timeout for create unique database .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 20: (1 comment) +2 for test_parti

[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option

2018-06-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10795 ) Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option .. Patch Set 2: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option

2018-06-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10795 ) Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 18: (9 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 14: Code-Review+2 Seems like we're loosening things

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 6: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 14: +1 since we are trying to ease changes in gently

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 14: Code-Review+1 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 13: (8 comments) I checked out your patch and ran t

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR](2.x) IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-05 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10603 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 4: Code-Review+1 Looks fine from my end. The python look

  1   2   3   >