[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#3). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 3: (4 comments) http://gerri

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 3: (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#4). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#5). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 5: (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#6). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9383 to look at the new patch set (#2). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .

[Impala-ASF-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9383 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 2: Code-Review+1 > Looks good to me, ma

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#7). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 6: (4 comments) http://gerri

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#8). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 7: (2 comments) http://gerri

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#9). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 9: (2 comments) http://gerri

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#10). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 10: (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation

2018-02-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 ) Change subject: IMPALA-2990: Add a warning message during cancellation .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters

2018-02-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9434 Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters .. IMPALA-6432: Default rpc_

[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters

2018-02-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9434 ) Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters .. IMPALA-6432: Default rpc_n

[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters

2018-02-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 ) Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters .. Patch Set 2: (1 comment

[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters

2018-02-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 ) Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters .. Patch Set 3: Code-Review

[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters

2018-02-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 ) Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters .. Patch Set 3: Just saw t

[Impala-ASF-CR] IMPALA-6565: Fix dropped status in DequeueDeferredRpc()

2018-02-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9439 ) Change subject: IMPALA-6565: Fix dropped status in DequeueDeferredRpc() .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6565: Fix dropped status in DequeueDeferredRpc()

2018-02-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9439 ) Change subject: IMPALA-6565: Fix dropped status in DequeueDeferredRpc() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-6577: avoid slow Status constructor on expiration thread

2018-02-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9443 ) Change subject: IMPALA-6577: avoid slow Status constructor on expiration thread .. Patch Set 3: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-02-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/94

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-02-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/9446/

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-03-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option

2018-03-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option .. Patch Set 4: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

2018-03-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 ) Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters .. Patch Set 6: Code-Review+1 I'm good with this change. D

[Impala-ASF-CR] IMPALA-6338: xfail test profile fragment instances

2018-03-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9467 ) Change subject: IMPALA-6338: xfail test_profile_fragment_instances .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-02 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#11). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-05 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#12). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 12: (2 comments) http://gerr

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/9300/

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 8: (2 comments) Once you address my comments below, pleas

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#13). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 13: (2 comments) http://gerr

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9519 Change subject: IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 .. IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 On

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9384 to look at the new patch set (#14). Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ..

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 14: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4

2018-03-06 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9519 to look at the new patch set (#2). Change subject: IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 .. IMPALA-

[Impala-ASF-CR] IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9519 ) Change subject: IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 .. Patch Set 1: (2 comments) > (2 comments) > > So, thrift-

[Impala-ASF-CR] IMPALA-6614: ClientRequestState should use HS2 TOperationState

2018-03-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9501 ) Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState .. Patch Set 2: (8 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4

2018-03-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9519 ) Change subject: IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 .. Patch Set 3: Code-Review+2 Confirmed that all BE tests pass

[Impala-ASF-CR] IMPALA-6614: ClientRequestState should use HS2 TOperationState

2018-03-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9501 ) Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 1: (6 comments) http://gerrit.clouder

[Impala-ASF-CR] Add fragment instance id/query id to important log messages and make them grep friendly

2018-03-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9535 Change subject: Add fragment_instance_id/query_id to important log messages and make them grep friendly .. Add fragment_instance_id/quer

[Impala-ASF-CR] Add fragment instance id/query id to important log messages and make them grep friendly

2018-03-07 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9535 to look at the new patch set (#2). Change subject: Add fragment_instance_id/query_id to important log messages and make them grep friendly ...

[Impala-ASF-CR] Add fragment instance id/query id to important log messages and make them grep friendly

2018-03-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9535 ) Change subject: Add fragment_instance_id/query_id to important log messages and make them grep friendly .. Patch Set 2: Code-Review+2

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 4: (4 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 3: Code-Review+1 (1 comment) Feel free to u

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 5: Code-Review+1 -- To view, visit ht

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL write()

2018-03-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9606 ) Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL_write() .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 8: (2 comments) Apologies for the slow review. http://ge

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9635 Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. IMPALA-6662: Make stress test resilient to han

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-14 Thread Sailesh Mukil (Code Review)
Hello Michael Brown, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9635 to look at the new patch set (#2). Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Sailesh Mukil (Code Review)
Hello Michael Brown, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9635 to look at the new patch set (#3). Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 2: (14 comments) Thanks for the r

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Sailesh Mukil (Code Review)
Hello Michael Brown, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9635 to look at the new patch set (#4). Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 3: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 4: (6 comments) > Patch Set 4: >

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Michael Brown, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9635 to look at the new patch set (#5). Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes ...

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 5: Code-Review+1 (1 comment) Than

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-16 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Michael Brown, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9635 to look at the new patch set (#6). Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes ...

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9696 Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. IMPALA-6691: KRPC w/ kerberos fails on SLES11 The Kerberos version used

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9696/1/b

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Patch Set 1: > Patch Set 1: > > (1 comment) I spent about 2 days tryi

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 10: > Patch Set 10: > > Hello,Bharath

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 10: > Patch Set 10: > > Only the echo

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 11: Code-Review+2 Thanks for your con

[Impala-ASF-CR] IMPALA-6610: Improve LDAP auth fail warning message in impala-shell

2018-03-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell .. Patch Set 12: Code-Review+2 Rebase, carry +2.

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-20 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Philip Zeyliger, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9696 to look at the new patch set (#2). Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Patch Set 2: > Patch Set 1: > > (1 comment) Thanks Todd and Phil! I'v

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/9696/2/

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-21 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Philip Zeyliger, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9696 to look at the new patch set (#3). Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-21 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Philip Zeyliger, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9696 to look at the new patch set (#4). Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Patch Set 4: Code-Review+2 (1 comment) Thanks for the review! Rebase

[Impala-ASF-CR] IMPALA-6713: Fix format string error in Sorter

2018-03-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9740 ) Change subject: IMPALA-6713: Fix format string error in Sorter .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-6716: Store LDAP options as shell member variables

2018-03-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9744 ) Change subject: IMPALA-6716: Store LDAP options as shell member variables .. Patch Set 1: > Patch Set 1: > > > Patch Set 1: Verified-1

[Impala-ASF-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Sailesh Mukil (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9842 to review the following change. Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. KUDU-2385: Fix typ

[Impala-ASF-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/9842 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Removed reviewer Todd Lipcon. -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-6771: Fix in-predicate set up bug

2018-04-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9891 ) Change subject: IMPALA-6771: Fix in-predicate set up bug .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9891/1/be/src

[Impala-ASF-CR] IMPALA-6771: Fix in-predicate set up bug

2018-04-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9891 ) Change subject: IMPALA-6771: Fix in-predicate set up bug .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9891/1/be/src

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

2018-04-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9916 Change subject: IMPALA-6792: Fail status reporting if coordinator refuses connections .. IMPALA-6792: Fail status reporting if coordinat

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

2018-04-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9916 ) Change subject: IMPALA-6792: Fail status reporting if coordinator refuses connections .. Patch Set 1: Something to add. This patch mea

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

2018-04-03 Thread Sailesh Mukil (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9916 to look at the new patch set (#2). Change subject: IMPALA-6792: Fail status reporting if coordinator refuses connections ...

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

2018-04-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9916 ) Change subject: IMPALA-6792: Fail status reporting if coordinator refuses connections .. Patch Set 2: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6771: Fix in-predicate set up bug

2018-04-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9891 ) Change subject: IMPALA-6771: Fix in-predicate set up bug .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9891/2/be/src

[Impala-ASF-CR] IMPALA-6771: Fix in-predicate set up bug

2018-04-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9891 ) Change subject: IMPALA-6771: Fix in-predicate set up bug .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

2018-04-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9913 ) Change subject: IMPALA-6785: reset failed heartbeat count when re-registering .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-6785: reset failed heartbeat count when re-registering

2018-04-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9913 ) Change subject: IMPALA-6785: reset failed heartbeat count when re-registering .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

2018-04-04 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Tim Armstrong, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9916 to look at the new patch set (#3). Change subject: IMPALA-6792: Fail status reporting if coordinator refuses connections .

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

2018-04-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9916 ) Change subject: IMPALA-6792: Fail status reporting if coordinator refuses connections .. Patch Set 2: (2 comments) > Patch Set 2: Cod

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

2018-04-04 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Tim Armstrong, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9916 to look at the new patch set (#4). Change subject: IMPALA-6792: Fail status reporting if coordinator refuses connections .

<    1   2   3   4   5   6   >